Message ID | 42bf6244582d6208f51db1a9299fe1c8afab4e14.1683630932.git.quic_varada@quicinc.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp2838015vqo; Tue, 9 May 2023 05:24:16 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6qhBmqgfCllwX7oYabqqZTaI7+R0l2iY12LFovEXic5nbBJoHl8G4b4ZMgIEh7loCvPUVw X-Received: by 2002:a05:6a20:244d:b0:f3:5cf7:581b with SMTP id t13-20020a056a20244d00b000f35cf7581bmr17884630pzc.28.1683635056135; Tue, 09 May 2023 05:24:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683635056; cv=none; d=google.com; s=arc-20160816; b=PMW0EPXhypsoNR4xbIhp3AQEfYSuykWOtTt4mswDyOK/VIt5g/MTXNa9ngJscwtuah 1kUQQZoN6WKbGNN5fR7A2jDbJHaPIwGmep8z6NKSm8i1gjDDVIcBRSe7RjY18p7Fz/Oy n+kqjFP8k6lptBrf7xYYCtqsMU+QgVxAmNMBeLtn4TwqyiIAQaCKOWimPbl8KoFwceDh /EwvHCKxNs8ExLO6dS6cCyXuQGsLRiPjY3oBm/qxyP4thoY2T3qOrxpvFVD6UqzLRyAZ t1I8k/8GHxvR9sxfEZBZuYgO5qL9R1XALBuYHxKS9huuKcn/cLaQM++uvrGj/xsmk45G HqOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=WZtO0HqANQYzG7rjKke7I95LJ7e1euJQtwGimPfnjXM=; b=nK9FalvYXZblTIOvzuMn4AkDddaQBAFbVFvLwrJUWfpW+GCcHfOvjfnBD8090gDN8w e0SvRkpLKQb6h4FT1uE4iQ/ITB4HrmROB4PoOwZ17n3+P+6mWJY4wT51vZz2oUBQDTs5 NiGNtiY5xH7w5Xv1CylLXGNbpblx+mApMeqpRbziBrmt6hxxMPEdKitpaijXSCAlHpra bT1+xoaU0IqFqPWrrtGjSLocCYczY1M7XS+Tr61js/pNLSVbQgkh3nVLe9kYBZb718vW y1/pxZHYo2eLE7Lx25zjMg5wCKVpC7+fatZfCbpPCyK6+MRZog3RFE0JvlvWUGMhrL0D X7Kg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=WEP1zYFk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f25-20020aa79699000000b00643b1616d7csi2285835pfk.77.2023.05.09.05.24.02; Tue, 09 May 2023 05:24:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=WEP1zYFk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233852AbjEIL4B (ORCPT <rfc822;baris.duru.linux@gmail.com> + 99 others); Tue, 9 May 2023 07:56:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41634 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235691AbjEILzn (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 9 May 2023 07:55:43 -0400 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 28CBE1713; Tue, 9 May 2023 04:55:17 -0700 (PDT) Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 34997NCr026683; Tue, 9 May 2023 11:55:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type; s=qcppdkim1; bh=WZtO0HqANQYzG7rjKke7I95LJ7e1euJQtwGimPfnjXM=; b=WEP1zYFkISriUQXgMytNxemdcbnOOYkkRFqlNQfRFL4iHOzQP+4gjc91OWC6zrckEjkx u9nixfK3c0ihOnmJASdGxr9R+3FAHF7ubpyhbiCZ0pk+ke5/iHE/MTATe9jGKY021UOQ Qll0HTsmqM3hNB2GL7iDgosiTGeMfqEsoXe+RZFa7m5Mvjw+mNiaT8D9C3TEZ4VHfZBm +UwFF6J5o3KwH8nyo/yS1b7qle+zztm1eb7zdTz6Crv3RtThTkOzCl2p0OfplcMxMSMt ruZhvLgnUfITjWwejO5KrLVeJK2JBGNj2MVl9gZ2ax1mZb9qL4f9EsScPveHoK2lN1iR eA== Received: from nasanppmta03.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3qf77g1nqd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 09 May 2023 11:55:05 +0000 Received: from nasanex01a.na.qualcomm.com (nasanex01a.na.qualcomm.com [10.52.223.231]) by NASANPPMTA03.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 349Bt4Fi022772 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 9 May 2023 11:55:04 GMT Received: from varda-linux.qualcomm.com (10.80.80.8) by nasanex01a.na.qualcomm.com (10.52.223.231) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.42; Tue, 9 May 2023 04:54:59 -0700 From: Varadarajan Narayanan <quic_varada@quicinc.com> To: <agross@kernel.org>, <andersson@kernel.org>, <konrad.dybcio@linaro.org>, <vkoul@kernel.org>, <kishon@kernel.org>, <robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>, <gregkh@linuxfoundation.org>, <mturquette@baylibre.com>, <sboyd@kernel.org>, <quic_wcheng@quicinc.com>, <linux-arm-msm@vger.kernel.org>, <linux-phy@lists.infradead.org>, <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linux-usb@vger.kernel.org>, <linux-clk@vger.kernel.org> CC: Varadarajan Narayanan <quic_varada@quicinc.com> Subject: [PATCH v11 8/9] arm64: dts: qcom: ipq9574: Add LDO regulator node Date: Tue, 9 May 2023 17:24:08 +0530 Message-ID: <42bf6244582d6208f51db1a9299fe1c8afab4e14.1683630932.git.quic_varada@quicinc.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <cover.1683630932.git.quic_varada@quicinc.com> References: <cover.1683630932.git.quic_varada@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01a.na.qualcomm.com (10.52.223.231) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: ygB8CtVpKMHGGTQTMQKY8Wb0M57SIa87 X-Proofpoint-ORIG-GUID: ygB8CtVpKMHGGTQTMQKY8Wb0M57SIa87 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-05-09_08,2023-05-05_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 phishscore=0 mlxlogscore=776 malwarescore=0 clxscore=1015 mlxscore=0 suspectscore=0 priorityscore=1501 bulkscore=0 lowpriorityscore=0 spamscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2304280000 definitions=main-2305090095 X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1765419312328698323?= X-GMAIL-MSGID: =?utf-8?q?1765419312328698323?= |
Series |
Enable IPQ9754 USB
|
|
Commit Message
Varadarajan Narayanan
May 9, 2023, 11:54 a.m. UTC
Add LDO regulator node
Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com>
---
Changes in v10:
- Add LDO regulator node
---
arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts | 7 +++++++
1 file changed, 7 insertions(+)
Comments
On Tue, 9 May 2023 at 14:56, Varadarajan Narayanan <quic_varada@quicinc.com> wrote: > > Add LDO regulator node > > Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> > --- > Changes in v10: > - Add LDO regulator node > --- > arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts | 7 +++++++ > 1 file changed, 7 insertions(+) Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Minor question below: > > diff --git a/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts b/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts > index bdc1434..1f5d14f 100644 > --- a/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts > +++ b/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts > @@ -60,6 +60,13 @@ > regulator-min-microvolt = <725000>; > regulator-max-microvolt = <1075000>; > }; > + > + mp5496_l2: l2 { > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + regulator-boot-on; > + regulator-always-on; This usually points out that there are other users which are not yet enabled/properly specified. What users are there for this supply which demand it to be always on? > + }; > }; > }; > > -- > 2.7.4 >
On Tue, May 09, 2023 at 04:08:59PM +0300, Dmitry Baryshkov wrote: > On Tue, 9 May 2023 at 14:56, Varadarajan Narayanan > <quic_varada@quicinc.com> wrote: > > > > Add LDO regulator node > > > > Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> > > --- > > Changes in v10: > > - Add LDO regulator node > > --- > > arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts | 7 +++++++ > > 1 file changed, 7 insertions(+) > > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > Minor question below: > > > > > diff --git a/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts b/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts > > index bdc1434..1f5d14f 100644 > > --- a/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts > > +++ b/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts > > @@ -60,6 +60,13 @@ > > regulator-min-microvolt = <725000>; > > regulator-max-microvolt = <1075000>; > > }; > > + > > + mp5496_l2: l2 { > > + regulator-min-microvolt = <1800000>; > > + regulator-max-microvolt = <1800000>; > > + regulator-boot-on; > > + regulator-always-on; > > This usually points out that there are other users which are not yet > enabled/properly specified. What users are there for this supply which > demand it to be always on? The 1.8v rail is used by PCIe PHY, PLL for Ethernet SerDes interface and PLLs that generate SoC clocks. The voting for this rail is managed by the RPM f/w. Thanks Varada > > + }; > > }; > > }; > > > > -- > > 2.7.4 > > > > > -- > With best wishes > Dmitry
On Wed, 10 May 2023 at 13:23, Varadarajan Narayanan <quic_varada@quicinc.com> wrote: > > On Tue, May 09, 2023 at 04:08:59PM +0300, Dmitry Baryshkov wrote: > > On Tue, 9 May 2023 at 14:56, Varadarajan Narayanan > > <quic_varada@quicinc.com> wrote: > > > > > > Add LDO regulator node > > > > > > Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> > > > --- > > > Changes in v10: > > > - Add LDO regulator node > > > --- > > > arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts | 7 +++++++ > > > 1 file changed, 7 insertions(+) > > > > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > > > Minor question below: > > > > > > > > diff --git a/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts b/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts > > > index bdc1434..1f5d14f 100644 > > > --- a/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts > > > +++ b/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts > > > @@ -60,6 +60,13 @@ > > > regulator-min-microvolt = <725000>; > > > regulator-max-microvolt = <1075000>; > > > }; > > > + > > > + mp5496_l2: l2 { > > > + regulator-min-microvolt = <1800000>; > > > + regulator-max-microvolt = <1800000>; > > > + regulator-boot-on; > > > + regulator-always-on; > > > > This usually points out that there are other users which are not yet > > enabled/properly specified. What users are there for this supply which > > demand it to be always on? > > The 1.8v rail is used by PCIe PHY, PLL for Ethernet SerDes > interface and PLLs that generate SoC clocks. The voting for this > rail is managed by the RPM f/w. Then I'm looking forward to seeing the patch which declares all the actual users of the lane. Please do not declare power lanes as boot-on/always-on unless there is a strong reason for doing it. > > Thanks > Varada > > > > + }; > > > }; > > > }; > > > > > > -- > > > 2.7.4 > > > > > > > > > -- > > With best wishes > > Dmitry
diff --git a/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts b/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts index bdc1434..1f5d14f 100644 --- a/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts +++ b/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts @@ -60,6 +60,13 @@ regulator-min-microvolt = <725000>; regulator-max-microvolt = <1075000>; }; + + mp5496_l2: l2 { + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + regulator-boot-on; + regulator-always-on; + }; }; };