[-next,v4,1/5] block, bfq: remove set but not used variable in __bfq_entity_update_weight_prio
Message ID | 20221102022542.3621219-2-yukuai1@huaweicloud.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp3337298wru; Tue, 1 Nov 2022 19:05:43 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5yJrIZg7HMoyg2Lkr7gLvit4Ily4V4qiey8Ro8eLSpZ7g0N2upsvuIakaLQCU6WBIJ/rSB X-Received: by 2002:a17:90b:3901:b0:213:dfd5:a75f with SMTP id ob1-20020a17090b390100b00213dfd5a75fmr14167090pjb.233.1667354742792; Tue, 01 Nov 2022 19:05:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667354742; cv=none; d=google.com; s=arc-20160816; b=JI60EcV+MeDHYETt89MG6b49AIT2HaOQ/sF1SFymZF583pulCFUvKJGDY+D3L+Ke2u UIViztkG7s8V74oYUkRDFAzt6teLEJMNN69aBt5wSlob/PTpHJaXdROM/9crbzLS1nIn 3luUdbjtGl5Qv6KM90kyXKmxR9l+jQIvG7K7VME32yp7OAAXhXGcqYQ9tGq/0pRl3J+F 7wshgb7/5m1a40bEunwZCIyPLQupXeROpPNJzYk/RIA6rqe5USRr2fDhpZWHxeDPyXeA dSECDeKs0fFGvQskONZZaz0fNeimjqa2anHfmcnLY/VzcwVMH+5CKbXJ07jfw2YE6xpD OQfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=MFncMCCokAmu+KRHAMeazFOoTbXO+qyPcxDCvK8OrXo=; b=a/gij78ile10eWSs4TIhRD5AIvjwVz5U1PNSFL4HfOIr8priCvsz1wdy8uYJ80VOfW HIicGxSnICD9CVV4DVj/PdWAqdkAZmvNxVxkyF7/YLf+206P4wWsNW3I96r8R6nBhfnS bp75EoeDXZ34+T5qed0k3LloZ2SqSglERQP81MZ7nDmtBomZoG6qhrc9A/LzNJnY+RDJ sHFD1VF+FPFP5mDgWhvKWXD+k1VkY3NX9dX2b1ddhX/+/AYPZoVcfr/8M8MefhgKJXH2 pf52wvYrlgHMTF74ml8xFijG9niX4fuf1vOilQMlEHj8tUCV7RDBTArAdqUB2E3LGvvS BlVw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id mm24-20020a17090b359800b0020da8f11bb3si608347pjb.14.2022.11.01.19.05.29; Tue, 01 Nov 2022 19:05:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230073AbiKBCEF (ORCPT <rfc822;rua109.linux@gmail.com> + 99 others); Tue, 1 Nov 2022 22:04:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34692 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229817AbiKBCED (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 1 Nov 2022 22:04:03 -0400 Received: from dggsgout11.his.huawei.com (dggsgout11.his.huawei.com [45.249.212.51]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2D4C618B0C; Tue, 1 Nov 2022 19:04:01 -0700 (PDT) Received: from mail02.huawei.com (unknown [172.30.67.143]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4N299K2sS2zKFQh; Wed, 2 Nov 2022 10:01:25 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.127.227]) by APP2 (Coremail) with SMTP id Syh0CgCnP9QN0GFjGqzfBA--.48110S5; Wed, 02 Nov 2022 10:03:59 +0800 (CST) From: Yu Kuai <yukuai1@huaweicloud.com> To: jack@suse.cz, axboe@kernel.dk, paolo.valente@linaro.org Cc: cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, yukuai3@huawei.com, yukuai1@huaweicloud.com, yi.zhang@huawei.com Subject: [PATCH -next v4 1/5] block, bfq: remove set but not used variable in __bfq_entity_update_weight_prio Date: Wed, 2 Nov 2022 10:25:38 +0800 Message-Id: <20221102022542.3621219-2-yukuai1@huaweicloud.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20221102022542.3621219-1-yukuai1@huaweicloud.com> References: <20221102022542.3621219-1-yukuai1@huaweicloud.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID: Syh0CgCnP9QN0GFjGqzfBA--.48110S5 X-Coremail-Antispam: 1UD129KBjvdXoW7XF18Kw48JrWDJr1DAr4fXwb_yoWkGwcEya 4Dt3WrGr1kJ3yrCF1jyr13Xayqq3yjq34DZa4ftrW8JF17Jas2k39FyrZxZws5WFWrGFyf Zwn5Xw43AF1jvjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUb-kFF20E14v26ryj6rWUM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M28IrcIa0xkI8VA2jI8067AKxVWUGwA2048vs2IY02 0Ec7CjxVAFwI0_JFI_Gr1l8cAvFVAK0II2c7xJM28CjxkF64kEwVA0rcxSw2x7M28EF7xv wVC0I7IYx2IY67AKxVWDJVCq3wA2z4x0Y4vE2Ix0cI8IcVCY1x0267AKxVW8Jr0_Cr1UM2 8EF7xvwVC2z280aVAFwI0_GcCE3s1l84ACjcxK6I8E87Iv6xkF7I0E14v26rxl6s0DM2AI xVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj6xIIjxv20x vE14v26r1j6r18McIj6I8E87Iv67AKxVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xv r2IYc2Ij64vIr41lF7I21c0EjII2zVCS5cI20VAGYxC7MxAIw28IcxkI7VAKI48JMxC20s 026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_ JrI_JrWlx4CE17CEb7AF67AKxVWUtVW8ZwCIc40Y0x0EwIxGrwCI42IY6xIIjxv20xvE14 v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxVW8JVWxJwCI42IY6xAIw20EY4v20xva j40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Jr0_Gr1lIxAIcVC2z280aVCY1x0267AKxVW8JV W8JrUvcSsGvfC2KfnxnUUI43ZEXa7VUbec_DUUUUU== X-CM-SenderInfo: 51xn3trlr6x35dzhxuhorxvhhfrp/ X-CFilter-Loop: Reflected X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1748348166510847568?= X-GMAIL-MSGID: =?utf-8?q?1748348166510847568?= |
Series |
multiple cleanup patches for bfqd
|
|
Commit Message
Yu Kuai
Nov. 2, 2022, 2:25 a.m. UTC
From: Yu Kuai <yukuai3@huawei.com> After the patch "block, bfq: cleanup bfq_weights_tree add/remove apis"), the local variable 'bfqd' is not used anymore, thus remove it. Signed-off-by: Yu Kuai <yukuai3@huawei.com> --- block/bfq-wf2q.c | 15 --------------- 1 file changed, 15 deletions(-)
Comments
On 11/1/22 8:25 PM, Yu Kuai wrote: > From: Yu Kuai <yukuai3@huawei.com> > > After the patch "block, bfq: cleanup bfq_weights_tree add/remove apis"), > the local variable 'bfqd' is not used anymore, thus remove it. Please add a Fixes tag.
On 11/1/22 8:09 PM, Jens Axboe wrote: > On 11/1/22 8:25 PM, Yu Kuai wrote: >> From: Yu Kuai <yukuai3@huawei.com> >> >> After the patch "block, bfq: cleanup bfq_weights_tree add/remove apis"), >> the local variable 'bfqd' is not used anymore, thus remove it. > > Please add a Fixes tag. Looks like the rest were good to go, so I added it myself.
Hi, 在 2022/11/02 10:11, Jens Axboe 写道: > On 11/1/22 8:09 PM, Jens Axboe wrote: >> On 11/1/22 8:25 PM, Yu Kuai wrote: >>> From: Yu Kuai <yukuai3@huawei.com> >>> >>> After the patch "block, bfq: cleanup bfq_weights_tree add/remove apis"), >>> the local variable 'bfqd' is not used anymore, thus remove it. >> >> Please add a Fixes tag. > > Looks like the rest were good to go, so I added it myself. Thanks for helping out. I'm not sure which commit id to use since the fixed patch is not in linux-next yet, does the commit id stay the same when the patch applied from for-6.2 to next ? Thanks, Kuai >
On 11/1/22 8:18 PM, Yu Kuai wrote: > Hi, > > 在 2022/11/02 10:11, Jens Axboe 写道: >> On 11/1/22 8:09 PM, Jens Axboe wrote: >>> On 11/1/22 8:25 PM, Yu Kuai wrote: >>>> From: Yu Kuai <yukuai3@huawei.com> >>>> >>>> After the patch "block, bfq: cleanup bfq_weights_tree add/remove apis"), >>>> the local variable 'bfqd' is not used anymore, thus remove it. >>> >>> Please add a Fixes tag. >> >> Looks like the rest were good to go, so I added it myself. > > Thanks for helping out. I'm not sure which commit id to use since the > fixed patch is not in linux-next yet, does the commit id stay the same > when the patch applied from for-6.2 to next ? linux-next shas are not stable, but since you're sending this to the linux-block list and against the block tree, that's obviously where you'd find that commit.
diff --git a/block/bfq-wf2q.c b/block/bfq-wf2q.c index 5a02cb94d86e..2faa29fcb1e9 100644 --- a/block/bfq-wf2q.c +++ b/block/bfq-wf2q.c @@ -706,21 +706,6 @@ __bfq_entity_update_weight_prio(struct bfq_service_tree *old_st, if (entity->prio_changed) { struct bfq_queue *bfqq = bfq_entity_to_bfqq(entity); unsigned int prev_weight, new_weight; - struct bfq_data *bfqd = NULL; -#ifdef CONFIG_BFQ_GROUP_IOSCHED - struct bfq_sched_data *sd; - struct bfq_group *bfqg; -#endif - - if (bfqq) - bfqd = bfqq->bfqd; -#ifdef CONFIG_BFQ_GROUP_IOSCHED - else { - sd = entity->my_sched_data; - bfqg = container_of(sd, struct bfq_group, sched_data); - bfqd = (struct bfq_data *)bfqg->bfqd; - } -#endif /* Matches the smp_wmb() in bfq_group_set_weight. */ smp_rmb();