| Message ID | 20230504131654.24922-1-oleksandr@natalenko.name |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp334713vqo;
Thu, 4 May 2023 06:55:38 -0700 (PDT)
X-Google-Smtp-Source:
ACHHUZ6gbqQnqOS1KJ3sJRf1tjz9qjo4guKA1pu3ozmyTgIEHMIr4ItsTGxLSLtWfXbxk4M9ata6
X-Received: by 2002:a17:902:d88c:b0:19e:6e00:4676 with SMTP id
b12-20020a170902d88c00b0019e6e004676mr3618732plz.61.1683208537982;
Thu, 04 May 2023 06:55:37 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1683208537; cv=none;
d=google.com; s=arc-20160816;
b=cxvFgM9HgsA0opDPESXufg5xDcMExJv47XulXkaZhR+o/oGVElE2epNdVucWpTudRm
2M3mwL8CqIfBiN/9J9jNaJ6x5w48OToZc0JZUau06Nptb/ZoCj9BPyqnOO6YGwJ4r/dG
BcMitzvbZLdNoACNZQTwt9JkVlDnMj5yUQkOD7//NvUrdczRLrJJIzwoh6YrFxD8KMMH
wQ4zK3PTrg2VXPkp9lrRJMhk+6XHHZAtU+ZAfr7kF1gJovMpJqw+JuztEqdRC2pVfGm9
dEX6AAKPo4dL75jL2apGhGvmma8jXKQ81BeIbN7ZDcRmvDoIW7XCn2vsanWifXbF42y0
erSw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:message-id:date:subject:cc:to:from:dkim-signature;
bh=1GoSmlsswYCSSMaB76ExjC77jP1QgiBUF/bzBvuBTsg=;
b=eE8Pu0gpse8WBQI9Ch/qxQRI5Vm4aS9x80QcY3ncMYDoMTVc5hQsBkPyYEdANTQjIb
IDiJU9quVe2X6cVVn84AkS888/dLspsZ1fiueCJ6UHvtFtVMM2tWKYKlZH0b/E59P/Ra
oGy/2I8aaJ4rR1tj/APNGa9ZaWk5FB5kmyjyUCxgaQKiG8xwLbNbjmGNbsOdvfAGhTTg
LLQ3zUu+WfKhccjDgQQe6Whj17M6yPk9nnWz3BmxmZdoNCeyOv8qCitVmYsQYi0cGiwL
evpQCaG79RsCk5S+nUsQFYOB4/KfjEXvEjrHEtJrp0maA/uk6gc8KjNe19kZR0BXhB2s
EM7g==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@natalenko.name header.s=dkim-20170712
header.b=Td2N0gBj;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=natalenko.name
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
n2-20020a170902f60200b001a96124e47fsi30600151plg.348.2023.05.04.06.55.22;
Thu, 04 May 2023 06:55:37 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=pass header.i=@natalenko.name header.s=dkim-20170712
header.b=Td2N0gBj;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=natalenko.name
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S231168AbjEDN0G (ORCPT <rfc822;b08248@gmail.com> + 99 others);
Thu, 4 May 2023 09:26:06 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55750 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S229606AbjEDNZ6 (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Thu, 4 May 2023 09:25:58 -0400
X-Greylist: delayed 535 seconds by postgrey-1.37 at lindbergh.monkeyblade.net;
Thu, 04 May 2023 06:25:56 PDT
Received: from vulcan.natalenko.name (vulcan.natalenko.name [104.207.131.136])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9BC48273B;
Thu, 4 May 2023 06:25:56 -0700 (PDT)
Received: from localhost (unknown [83.148.33.151])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange ECDHE (prime256v1) server-signature RSA-PSS (2048 bits)
server-digest SHA256)
(No client certificate requested)
by vulcan.natalenko.name (Postfix) with ESMTPSA id 8DE4A12F8768;
Thu, 4 May 2023 15:16:56 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=natalenko.name;
s=dkim-20170712; t=1683206216;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:cc:mime-version:mime-version:
content-transfer-encoding:content-transfer-encoding;
bh=1GoSmlsswYCSSMaB76ExjC77jP1QgiBUF/bzBvuBTsg=;
b=Td2N0gBjPvlTlyWzvZHpJqFSgse2/YThNRfD6cCkdFEtPcZvagxfK2z2uJ/6ZK4CiNuRGx
/cPifY7XykPQVQctaZOZrKE92Cm2Akzh3uCoKNdldBM1lfHT9NFCLB9hcsb77/uhp5Nc0S
Tj87eGjKwHqbtCXeQG/t0nqYKwS9kDo=
From: Oleksandr Natalenko <oleksandr@natalenko.name>
To: linux-kernel@vger.kernel.org
Cc: Alex Williamson <alex.williamson@redhat.com>,
Eric Auger <eric.auger@redhat.com>,
=?utf-8?q?C=C3=A9dric_Le_Goater?= <clg@redhat.com>,
Jason Gunthorpe <jgg@ziepe.ca>, Abhishek Sahu <abhsahu@nvidia.com>,
Kevin Tian <kevin.tian@intel.com>, Cornelia Huck <cohuck@redhat.com>,
Bo Liu <liubo03@inspur.com>, "K V P,
Satyanarayana" <satyanarayana.k.v.p@intel.com>, kvm@vger.kernel.org
Subject: [PATCH] vfio/pci: demote hiding ecap messages to debug level
Date: Thu, 4 May 2023 15:16:54 +0200
Message-Id: <20230504131654.24922-1-oleksandr@natalenko.name>
X-Mailer: git-send-email 2.40.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,
SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham
autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1764972075826745829?=
X-GMAIL-MSGID: =?utf-8?q?1764972075826745829?=
|
| Series |
vfio/pci: demote hiding ecap messages to debug level
|
|
Commit Message
Oleksandr Natalenko
May 4, 2023, 1:16 p.m. UTC
Seeing a burst of messages like this:
vfio-pci 0000:98:00.0: vfio_ecap_init: hiding ecap 0x19@0x1d0
vfio-pci 0000:98:00.0: vfio_ecap_init: hiding ecap 0x25@0x200
vfio-pci 0000:98:00.0: vfio_ecap_init: hiding ecap 0x26@0x210
vfio-pci 0000:98:00.0: vfio_ecap_init: hiding ecap 0x27@0x250
vfio-pci 0000:98:00.1: vfio_ecap_init: hiding ecap 0x25@0x200
vfio-pci 0000:b1:00.0: vfio_ecap_init: hiding ecap 0x19@0x1d0
vfio-pci 0000:b1:00.0: vfio_ecap_init: hiding ecap 0x25@0x200
vfio-pci 0000:b1:00.0: vfio_ecap_init: hiding ecap 0x26@0x210
vfio-pci 0000:b1:00.0: vfio_ecap_init: hiding ecap 0x27@0x250
vfio-pci 0000:b1:00.1: vfio_ecap_init: hiding ecap 0x25@0x200
is of little to no value for an ordinary user.
Hence, use pci_dbg() instead of pci_info().
Signed-off-by: Oleksandr Natalenko <oleksandr@natalenko.name>
---
drivers/vfio/pci/vfio_pci_config.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On 5/4/23 15:16, Oleksandr Natalenko wrote: > Seeing a burst of messages like this: > > vfio-pci 0000:98:00.0: vfio_ecap_init: hiding ecap 0x19@0x1d0 > vfio-pci 0000:98:00.0: vfio_ecap_init: hiding ecap 0x25@0x200 > vfio-pci 0000:98:00.0: vfio_ecap_init: hiding ecap 0x26@0x210 > vfio-pci 0000:98:00.0: vfio_ecap_init: hiding ecap 0x27@0x250 > vfio-pci 0000:98:00.1: vfio_ecap_init: hiding ecap 0x25@0x200 > vfio-pci 0000:b1:00.0: vfio_ecap_init: hiding ecap 0x19@0x1d0 > vfio-pci 0000:b1:00.0: vfio_ecap_init: hiding ecap 0x25@0x200 > vfio-pci 0000:b1:00.0: vfio_ecap_init: hiding ecap 0x26@0x210 > vfio-pci 0000:b1:00.0: vfio_ecap_init: hiding ecap 0x27@0x250 > vfio-pci 0000:b1:00.1: vfio_ecap_init: hiding ecap 0x25@0x200 > > is of little to no value for an ordinary user. > > Hence, use pci_dbg() instead of pci_info(). > > Signed-off-by: Oleksandr Natalenko <oleksandr@natalenko.name> Acked-by: Cédric Le Goater <clg@redhat.com> Thanks, C. > --- > drivers/vfio/pci/vfio_pci_config.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/vfio/pci/vfio_pci_config.c b/drivers/vfio/pci/vfio_pci_config.c > index 948cdd464f4e..dd8dda14e701 100644 > --- a/drivers/vfio/pci/vfio_pci_config.c > +++ b/drivers/vfio/pci/vfio_pci_config.c > @@ -1643,7 +1643,7 @@ static int vfio_ecap_init(struct vfio_pci_core_device *vdev) > } > > if (!len) { > - pci_info(pdev, "%s: hiding ecap %#x@%#x\n", > + pci_dbg(pdev, "%s: hiding ecap %#x@%#x\n", > __func__, ecap, epos); > > /* If not the first in the chain, we can skip over it */
On Thu, 4 May 2023 15:16:54 +0200 Oleksandr Natalenko <oleksandr@natalenko.name> wrote: > Seeing a burst of messages like this: > > vfio-pci 0000:98:00.0: vfio_ecap_init: hiding ecap 0x19@0x1d0 > vfio-pci 0000:98:00.0: vfio_ecap_init: hiding ecap 0x25@0x200 > vfio-pci 0000:98:00.0: vfio_ecap_init: hiding ecap 0x26@0x210 > vfio-pci 0000:98:00.0: vfio_ecap_init: hiding ecap 0x27@0x250 > vfio-pci 0000:98:00.1: vfio_ecap_init: hiding ecap 0x25@0x200 > vfio-pci 0000:b1:00.0: vfio_ecap_init: hiding ecap 0x19@0x1d0 > vfio-pci 0000:b1:00.0: vfio_ecap_init: hiding ecap 0x25@0x200 > vfio-pci 0000:b1:00.0: vfio_ecap_init: hiding ecap 0x26@0x210 > vfio-pci 0000:b1:00.0: vfio_ecap_init: hiding ecap 0x27@0x250 > vfio-pci 0000:b1:00.1: vfio_ecap_init: hiding ecap 0x25@0x200 > > is of little to no value for an ordinary user. > > Hence, use pci_dbg() instead of pci_info(). > > Signed-off-by: Oleksandr Natalenko <oleksandr@natalenko.name> > --- > drivers/vfio/pci/vfio_pci_config.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/vfio/pci/vfio_pci_config.c b/drivers/vfio/pci/vfio_pci_config.c > index 948cdd464f4e..dd8dda14e701 100644 > --- a/drivers/vfio/pci/vfio_pci_config.c > +++ b/drivers/vfio/pci/vfio_pci_config.c > @@ -1643,7 +1643,7 @@ static int vfio_ecap_init(struct vfio_pci_core_device *vdev) > } > > if (!len) { > - pci_info(pdev, "%s: hiding ecap %#x@%#x\n", > + pci_dbg(pdev, "%s: hiding ecap %#x@%#x\n", > __func__, ecap, epos); > > /* If not the first in the chain, we can skip over it */ Looks fine to me, though I might adjust that next line to keep the previous alignment. In general this has certainly caused more confusion than insightful information, so demoting it to debug is a good idea. Thanks, Alex
Hello. On pátek 5. května 2023 1:01:11 CEST Alex Williamson wrote: > On Thu, 4 May 2023 15:16:54 +0200 > Oleksandr Natalenko <oleksandr@natalenko.name> wrote: > > > Seeing a burst of messages like this: > > > > vfio-pci 0000:98:00.0: vfio_ecap_init: hiding ecap 0x19@0x1d0 > > vfio-pci 0000:98:00.0: vfio_ecap_init: hiding ecap 0x25@0x200 > > vfio-pci 0000:98:00.0: vfio_ecap_init: hiding ecap 0x26@0x210 > > vfio-pci 0000:98:00.0: vfio_ecap_init: hiding ecap 0x27@0x250 > > vfio-pci 0000:98:00.1: vfio_ecap_init: hiding ecap 0x25@0x200 > > vfio-pci 0000:b1:00.0: vfio_ecap_init: hiding ecap 0x19@0x1d0 > > vfio-pci 0000:b1:00.0: vfio_ecap_init: hiding ecap 0x25@0x200 > > vfio-pci 0000:b1:00.0: vfio_ecap_init: hiding ecap 0x26@0x210 > > vfio-pci 0000:b1:00.0: vfio_ecap_init: hiding ecap 0x27@0x250 > > vfio-pci 0000:b1:00.1: vfio_ecap_init: hiding ecap 0x25@0x200 > > > > is of little to no value for an ordinary user. > > > > Hence, use pci_dbg() instead of pci_info(). > > > > Signed-off-by: Oleksandr Natalenko <oleksandr@natalenko.name> > > --- > > drivers/vfio/pci/vfio_pci_config.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/vfio/pci/vfio_pci_config.c b/drivers/vfio/pci/vfio_pci_config.c > > index 948cdd464f4e..dd8dda14e701 100644 > > --- a/drivers/vfio/pci/vfio_pci_config.c > > +++ b/drivers/vfio/pci/vfio_pci_config.c > > @@ -1643,7 +1643,7 @@ static int vfio_ecap_init(struct vfio_pci_core_device *vdev) > > } > > > > if (!len) { > > - pci_info(pdev, "%s: hiding ecap %#x@%#x\n", > > + pci_dbg(pdev, "%s: hiding ecap %#x@%#x\n", > > __func__, ecap, epos); > > > > /* If not the first in the chain, we can skip over it */ > > Looks fine to me, though I might adjust that next line to keep the > previous alignment. Sure, but if you want me to send v2 with this, please let me know. Thanks. > In general this has certainly caused more > confusion than insightful information, so demoting it to debug is a > good idea. Thanks, > > Alex > >
Tested-by: YangHang Liu <yanghliu@redhat.com> On 5/4/2023 9:16 PM, Oleksandr Natalenko wrote: > Seeing a burst of messages like this: > > vfio-pci 0000:98:00.0: vfio_ecap_init: hiding ecap 0x19@0x1d0 > vfio-pci 0000:98:00.0: vfio_ecap_init: hiding ecap 0x25@0x200 > vfio-pci 0000:98:00.0: vfio_ecap_init: hiding ecap 0x26@0x210 > vfio-pci 0000:98:00.0: vfio_ecap_init: hiding ecap 0x27@0x250 > vfio-pci 0000:98:00.1: vfio_ecap_init: hiding ecap 0x25@0x200 > vfio-pci 0000:b1:00.0: vfio_ecap_init: hiding ecap 0x19@0x1d0 > vfio-pci 0000:b1:00.0: vfio_ecap_init: hiding ecap 0x25@0x200 > vfio-pci 0000:b1:00.0: vfio_ecap_init: hiding ecap 0x26@0x210 > vfio-pci 0000:b1:00.0: vfio_ecap_init: hiding ecap 0x27@0x250 > vfio-pci 0000:b1:00.1: vfio_ecap_init: hiding ecap 0x25@0x200 > > is of little to no value for an ordinary user. > > Hence, use pci_dbg() instead of pci_info(). > > Signed-off-by: Oleksandr Natalenko <oleksandr@natalenko.name> > --- > drivers/vfio/pci/vfio_pci_config.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/vfio/pci/vfio_pci_config.c b/drivers/vfio/pci/vfio_pci_config.c > index 948cdd464f4e..dd8dda14e701 100644 > --- a/drivers/vfio/pci/vfio_pci_config.c > +++ b/drivers/vfio/pci/vfio_pci_config.c > @@ -1643,7 +1643,7 @@ static int vfio_ecap_init(struct vfio_pci_core_device *vdev) > } > > if (!len) { > - pci_info(pdev, "%s: hiding ecap %#x@%#x\n", > + pci_dbg(pdev, "%s: hiding ecap %#x@%#x\n", > __func__, ecap, epos); > > /* If not the first in the chain, we can skip over it */
On Thu, 4 May 2023 15:16:54 +0200 Oleksandr Natalenko <oleksandr@natalenko.name> wrote: > Seeing a burst of messages like this: > > vfio-pci 0000:98:00.0: vfio_ecap_init: hiding ecap 0x19@0x1d0 > vfio-pci 0000:98:00.0: vfio_ecap_init: hiding ecap 0x25@0x200 > vfio-pci 0000:98:00.0: vfio_ecap_init: hiding ecap 0x26@0x210 > vfio-pci 0000:98:00.0: vfio_ecap_init: hiding ecap 0x27@0x250 > vfio-pci 0000:98:00.1: vfio_ecap_init: hiding ecap 0x25@0x200 > vfio-pci 0000:b1:00.0: vfio_ecap_init: hiding ecap 0x19@0x1d0 > vfio-pci 0000:b1:00.0: vfio_ecap_init: hiding ecap 0x25@0x200 > vfio-pci 0000:b1:00.0: vfio_ecap_init: hiding ecap 0x26@0x210 > vfio-pci 0000:b1:00.0: vfio_ecap_init: hiding ecap 0x27@0x250 > vfio-pci 0000:b1:00.1: vfio_ecap_init: hiding ecap 0x25@0x200 > > is of little to no value for an ordinary user. > > Hence, use pci_dbg() instead of pci_info(). > > Signed-off-by: Oleksandr Natalenko <oleksandr@natalenko.name> > --- > drivers/vfio/pci/vfio_pci_config.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/vfio/pci/vfio_pci_config.c b/drivers/vfio/pci/vfio_pci_config.c > index 948cdd464f4e..dd8dda14e701 100644 > --- a/drivers/vfio/pci/vfio_pci_config.c > +++ b/drivers/vfio/pci/vfio_pci_config.c > @@ -1643,7 +1643,7 @@ static int vfio_ecap_init(struct vfio_pci_core_device *vdev) > } > > if (!len) { > - pci_info(pdev, "%s: hiding ecap %#x@%#x\n", > + pci_dbg(pdev, "%s: hiding ecap %#x@%#x\n", > __func__, ecap, epos); > > /* If not the first in the chain, we can skip over it */ Applied to vfio next branch for v6.5. Thanks! Alex
diff --git a/drivers/vfio/pci/vfio_pci_config.c b/drivers/vfio/pci/vfio_pci_config.c index 948cdd464f4e..dd8dda14e701 100644 --- a/drivers/vfio/pci/vfio_pci_config.c +++ b/drivers/vfio/pci/vfio_pci_config.c @@ -1643,7 +1643,7 @@ static int vfio_ecap_init(struct vfio_pci_core_device *vdev) } if (!len) { - pci_info(pdev, "%s: hiding ecap %#x@%#x\n", + pci_dbg(pdev, "%s: hiding ecap %#x@%#x\n", __func__, ecap, epos); /* If not the first in the chain, we can skip over it */