diff mbox series

[20/30] mm/damon: Use kstrtobool() instead of strtobool()

Message ID	ed2b46489a513988688decb53850339cc228940c.1667336095.git.christophe.jaillet@wanadoo.fr
State	New
Headers	Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; From: Christophe JAILLET <christophe.jaillet@wanadoo.fr> To: SeongJae Park <sj@kernel.org>, Andrew Morton <akpm@linux-foundation.org> Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET <christophe.jaillet@wanadoo.fr>, damon@lists.linux.dev, linux-mm@kvack.org Subject: [PATCH 20/30] mm/damon: Use kstrtobool() instead of strtobool() Date: Tue, 1 Nov 2022 22:14:08 +0100 Message-Id: <ed2b46489a513988688decb53850339cc228940c.1667336095.git.christophe.jaillet@wanadoo.fr> In-Reply-To: <cover.1667336095.git.christophe.jaillet@wanadoo.fr> References: <cover.1667336095.git.christophe.jaillet@wanadoo.fr> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk
Series	Remove strtobool() \| [00/30] Remove strtobool() [01/30] net: usb: Use kstrtobool() instead of strtobool() [02/30] wifi: Use kstrtobool() instead of strtobool() [03/30] irqchip: Use kstrtobool() instead of strtobool() [04/30] scsi: target: Use kstrtobool() instead of strtobool() [05/30] nvdimm: Use kstrtobool() instead of strtobool() [06/30] nvme: Use kstrtobool() instead of strtobool() [07/30] usb: core: Use kstrtobool() instead of strtobool() [08/30] usb: gadget: Use kstrtobool() instead of strtobool() [09/30] ACPI: sysfs: Use kstrtobool() instead of strtobool() [10/30] clocksource/drivers/arm_arch_timer: Use kstrtobool() instead of strtobool() [11/30] greybus: svc: Use kstrtobool() instead of strtobool() [12/30] input: Use kstrtobool() instead of strtobool() [13/30] platform/chrome: Use kstrtobool() instead of strtobool() [14/30] powercap: Use kstrtobool() instead of strtobool() [15/30] video: fbdev: omapfb: Use kstrtobool() instead of strtobool() [16/30] cifs: Use kstrtobool() instead of strtobool() [17/30] initramfs: Use kstrtobool() instead of strtobool() [18/30] module: Use kstrtobool() instead of strtobool() [19/30] kernel/params.c: Use kstrtobool() instead of strtobool() [20/30] mm/damon: Use kstrtobool() instead of strtobool() [21/30] mm: Use kstrtobool() instead of strtobool() [22/30] Bluetooth: hci_debugfs: Use kstrtobool() instead of strtobool() [23/30] test_firmware: Use kstrtobool() instead of strtobool() [24/30] arm64: cpufeature: Use kstrtobool() instead of strtobool() [25/30] KVM: arm64: vgic-v3: Use kstrtobool() instead of strtobool() [26/30] s390/ipl: Use kstrtobool() instead of strtobool() [27/30] KVM: x86/mmu: Use kstrtobool() instead of strtobool() [28/30] x86/xen: Use kstrtobool() instead of strtobool() [29/30] driver core: Use kstrtobool() instead of strtobool() [30/30] kstrtox: Remove strtobool()

Commit Message

Christophe JAILLET Nov. 1, 2022, 9:14 p.m. UTC

  strtobool() is the same as kstrtobool().
However, the latter is more used within the kernel.

In order to remove strtobool() and slightly simplify kstrtox.h, switch to
the other function name.

While at it, include the corresponding header file (<linux/kstrtox.h>)

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
This patch is part of a serie that axes all usages of strtobool().
Each patch can be applied independently from the other ones.

The last patch of the serie removes the definition of strtobool().

You may not be in copy of the cover letter. So, if needed, it is available
at [1].

[1]: https://lore.kernel.org/all/cover.1667336095.git.christophe.jaillet@wanadoo.fr/
---
 mm/damon/lru_sort.c | 3 ++-
 mm/damon/reclaim.c  | 3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)

Comments

SeongJae Park Nov. 1, 2022, 10 p.m. UTC | #1

On Tue, 1 Nov 2022 22:14:08 +0100 Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote:

> strtobool() is the same as kstrtobool().
> However, the latter is more used within the kernel.
> 
> In order to remove strtobool() and slightly simplify kstrtox.h, switch to
> the other function name.
> 
> While at it, include the corresponding header file (<linux/kstrtox.h>)
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

Reviewed-by: SeongJae Park <sj@kernel.org>


Thanks,
SJ

[...]

diff mbox series

Patch

diff --git a/mm/damon/lru_sort.c b/mm/damon/lru_sort.c
index 2a532e3983df..7b8fce2f67a8 100644
--- a/mm/damon/lru_sort.c
+++ b/mm/damon/lru_sort.c
@@ -8,6 +8,7 @@ 
 #define pr_fmt(fmt) "damon-lru-sort: " fmt
 
 #include <linux/damon.h>
+#include <linux/kstrtox.h>
 #include <linux/module.h>
 
 #include "modules-common.h"
@@ -241,7 +242,7 @@  static int damon_lru_sort_enabled_store(const char *val,
 	bool enable;
 	int err;
 
-	err = strtobool(val, &enable);
+	err = kstrtobool(val, &enable);
 	if (err)
 		return err;
 
diff --git a/mm/damon/reclaim.c b/mm/damon/reclaim.c
index e57604bec06d..e82631f39481 100644
--- a/mm/damon/reclaim.c
+++ b/mm/damon/reclaim.c
@@ -8,6 +8,7 @@ 
 #define pr_fmt(fmt) "damon-reclaim: " fmt
 
 #include <linux/damon.h>
+#include <linux/kstrtox.h>
 #include <linux/module.h>
 
 #include "modules-common.h"
@@ -187,7 +188,7 @@  static int damon_reclaim_enabled_store(const char *val,
 	bool enable;
 	int err;
 
-	err = strtobool(val, &enable);
+	err = kstrtobool(val, &enable);
 	if (err)
 		return err;