[v3,10/18] dt-bindings: reserved-memory: Add qcom,ramoops-minidump binding

Message ID 1683133352-10046-11-git-send-email-quic_mojha@quicinc.com
State New
Headers
Series [v3,01/18] remoteproc: qcom: Expand MD_* as MINIDUMP_* |

Commit Message

Mukesh Ojha May 3, 2023, 5:02 p.m. UTC
  Qualcomm ramoops minidump logger provide a means of storing the ramoops data
to some dynamically reserved memory instead of traditionally implemented
ramoops where the region should be statically fixed ram region.

Add qcom,ramoops-minidump binding under "/reserved-memory", and is named
"qcom,ramoops-minidump" and the reason of naming like this is because
as it is going to contain ramoops frontend data and this content will
be collected via Qualcomm minidump infrastructure provided from the
boot firmware.

Signed-off-by: Mukesh Ojha <quic_mojha@quicinc.com>
---
 .../reserved-memory/qcom,ramoops-minidump.yaml     | 69 ++++++++++++++++++++++
 1 file changed, 69 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/reserved-memory/qcom,ramoops-minidump.yaml
  

Comments

Krzysztof Kozlowski May 4, 2023, 11:22 a.m. UTC | #1
On 03/05/2023 19:02, Mukesh Ojha wrote:
> Qualcomm ramoops minidump logger provide a means of storing the ramoops data
> to some dynamically reserved memory instead of traditionally implemented
> ramoops where the region should be statically fixed ram region.
> 
> Add qcom,ramoops-minidump binding under "/reserved-memory", and is named
> "qcom,ramoops-minidump" and the reason of naming like this is because
> as it is going to contain ramoops frontend data and this content will
> be collected via Qualcomm minidump infrastructure provided from the
> boot firmware.
> 
> Signed-off-by: Mukesh Ojha <quic_mojha@quicinc.com>
> ---

Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC.  It might happen, that command when run on an older
kernel, gives you outdated entries.  Therefore please be sure you base
your patches on recent Linux kernel.

You missed at least DT list (maybe more), so this won't be tested.
Please resend and include all necessary entries.

Without testing that's a NAK. :(

Best regards,
Krzysztof
  

Patch

diff --git a/Documentation/devicetree/bindings/reserved-memory/qcom,ramoops-minidump.yaml b/Documentation/devicetree/bindings/reserved-memory/qcom,ramoops-minidump.yaml
new file mode 100644
index 0000000..a308db0
--- /dev/null
+++ b/Documentation/devicetree/bindings/reserved-memory/qcom,ramoops-minidump.yaml
@@ -0,0 +1,69 @@ 
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: "http://devicetree.org/schemas/reserved-memory/qcom,ramoops-minidump.yaml#"
+$schema: "http://devicetree.org/meta-schemas/core.yaml#"
+
+title: Qualcomm Ramoops minidump logger
+
+description: |
+  Qualcomm ramoops minidump logger provide a means of storing the ramoops data
+  to some dynamically reserved memory instead of traditionally implemented
+  ramoops where the region should be statically fixed ram region.
+
+  This is a child-node of "/reserved-memory", and is named "qcom_ramoops_md_region"
+  and the reason of naming like this is because as it is going to contain ramoops
+  frontend data and this content will be collected via Qualcomm minidump
+  infrastructure provided from the boot firmware.
+
+maintainers:
+  - Mukesh Ojha <quic_mojha@quicinc.com>
+
+allOf:
+  - $ref: "reserved-memory.yaml"
+
+properties:
+  compatible:
+    items:
+      - enum:
+          - qcom,sm8450-ramoops-minidump
+      - const: qcom,ramoops-minidump
+
+  memory-region:
+    maxItems: 1
+    items:
+      - description: handle to memory reservation for qcom,ramoops-minidump region.
+
+  no-map: true
+
+unevaluatedProperties: false
+
+required:
+  - compatible
+  - memory-region
+
+examples:
+  - |
+    / {
+        compatible = "foo";
+        model = "foo";
+        #address-cells = <2>;
+        #size-cells = <2>;
+
+        reserved-memory {
+            #address-cells = <2>;
+            #size-cells = <2>;
+            ranges;
+
+            qcom_ramoops_md_region@qcom_ramoops_md {
+                alloc-ranges = <0x0 0x00000000 0xffffffff 0xffffffff>;
+                size = <0x0 0x200000>;
+                no-map
+            };
+        };
+
+	qcom_ramoops_md {
+            compatible = "qcom,sm8450-ramoops-minidump", "qcom,ramoops-minidump";
+            memory-region = <&qcom_ramoops_md_region>;
+        };
+    };