Message ID | 3c6f7510d175ba5a3c81730b010f6c421b2fbf2d.1682682753.git.quic_varada@quicinc.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp992855vqo; Fri, 28 Apr 2023 08:03:39 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4EmN9gTnX/777CRYYfqwhNlWtDuJUVf/AhcVjBe8ZGzTtCr48Ux1++8NfURViYsviNEqC4 X-Received: by 2002:a6b:5c19:0:b0:763:570c:3a97 with SMTP id z25-20020a6b5c19000000b00763570c3a97mr3535275ioh.15.1682694219043; Fri, 28 Apr 2023 08:03:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682694219; cv=none; d=google.com; s=arc-20160816; b=V8guOI8ell6OZeY8B/PV2xF5+q4sWZnvu8re65XlQChJB0viR/ryWXltMF16k+JmiS BHlPRvWRsczKnyHl0LgMOcch4bYCaDGBIfLDyXln1IcR+AdIo1Ebc3fk96t4cqBN6XzY 5CNPgia35b19Ac8WTm3xbw+VXXaK6tXvTduQ0OK3oJUvaJpuT2bs6EkfvvlI6irxdnOQ kSyYTPaoeua7iz6EniWOITNc0Q35Q4OV8x4Zf+RGtNuboPCZNc/cUgfBuqN9t1SUtKZ6 t+/sGlMTQD2GroNxZ8OoigL1XhN+aaCFfRsUF44FbIgYSLKMIygJ1Zlhi7esmwHaozV4 mRsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=YT6sin7qrQa3ZRjEgGewAlX1Cnjc9ZhEG9Kem6mKXIQ=; b=y9WI6KNNhfs+FrqYbosqGQ/8Nhdf8PIPy63lYo1p0L1TMB0V+Nb6Dr1J/JlkLe6stb qYkSxBMshbiHek451syqabOVKXrueUE8qPT20cbZ/zEBE/jTB4+E1Cr949NSZivH659a El8Vljln92NDUe+kWeNe8KqdNFxZ4hWv9/RcIRm0xnoeMjU+nHqanUmPujPIqrPJvi8X vH5mPN4RFlUGDOGW0MR5tjT3pSikiqSB1zYSjoLQPOI76HwTe6/3JNQnslDdWCJxCj5R AP+N6MF07Si3G7Kl6KWB4y+onSGdSMRvVwf+5RyaHEtFa8fI5kcVuy5tYqMPxRR4D22/ ZRLQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b="L/kMKjLu"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u21-20020a6be315000000b00760c1c32920si15775584ioc.121.2023.04.28.08.03.18; Fri, 28 Apr 2023 08:03:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b="L/kMKjLu"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230502AbjD1OxY (ORCPT <rfc822;chrisjones.unixmen@gmail.com> + 99 others); Fri, 28 Apr 2023 10:53:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49146 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345821AbjD1OxS (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 28 Apr 2023 10:53:18 -0400 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E87B7526F; Fri, 28 Apr 2023 07:53:17 -0700 (PDT) Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 33SDwjMI020795; Fri, 28 Apr 2023 14:53:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type; s=qcppdkim1; bh=YT6sin7qrQa3ZRjEgGewAlX1Cnjc9ZhEG9Kem6mKXIQ=; b=L/kMKjLu8B96FnI2QrDW4EGqN3H1nhbrptJBk61+aB7amOV1RHBZnyCvVWroDIWFJ5N5 3AzHmfDxDnzDvIS4gDT989MfNprSc0Ck33hUpXVoNivz66HsJZY0F+CJWNFD1rQ38a5d HJYZfnFUBIC1ywYYDXnQBAliJGspjJdj3Z7h11XghT22pi/ITJKDRsqZw2cx6XM9vHMA vOchM8PJaQGZdSGKzGwwMNAsE06gTwuoODX2MIZThwmwxoR+lKPGe5LmKvsFrNjRFlN2 E0/EITz1NFO09AqZBXl0G/R2yx5mG5O7fYGhNfxn96Mt46pO5uh8VhDjNlwJZhoAqzS8 Iw== Received: from nasanppmta04.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3q7wq8ar9r-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 28 Apr 2023 14:53:07 +0000 Received: from nasanex01a.na.qualcomm.com (nasanex01a.na.qualcomm.com [10.52.223.231]) by NASANPPMTA04.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 33SEr6h2023689 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 28 Apr 2023 14:53:06 GMT Received: from varda-linux.qualcomm.com (10.80.80.8) by nasanex01a.na.qualcomm.com (10.52.223.231) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.42; Fri, 28 Apr 2023 07:53:00 -0700 From: Varadarajan Narayanan <quic_varada@quicinc.com> To: <agross@kernel.org>, <andersson@kernel.org>, <konrad.dybcio@linaro.org>, <amitk@kernel.org>, <thara.gopinath@gmail.com>, <rafael@kernel.org>, <daniel.lezcano@linaro.org>, <rui.zhang@intel.com>, <robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>, <linux-arm-msm@vger.kernel.org>, <linux-pm@vger.kernel.org>, <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org> CC: Praveenkumar I <quic_ipkumar@quicinc.com>, Varadarajan Narayanan <quic_varada@quicinc.com> Subject: [PATCH 1/4] dt-bindings: thermal: tsens: Add ipq9574 compatible Date: Fri, 28 Apr 2023 20:22:31 +0530 Message-ID: <3c6f7510d175ba5a3c81730b010f6c421b2fbf2d.1682682753.git.quic_varada@quicinc.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <cover.1682682753.git.quic_varada@quicinc.com> References: <cover.1682682753.git.quic_varada@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01a.na.qualcomm.com (10.52.223.231) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: u19mM4K03FclkrL0CAp6FaLnV1KquR3l X-Proofpoint-ORIG-GUID: u19mM4K03FclkrL0CAp6FaLnV1KquR3l X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-04-28_04,2023-04-27_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 mlxlogscore=946 bulkscore=0 suspectscore=0 phishscore=0 adultscore=0 impostorscore=0 lowpriorityscore=0 malwarescore=0 mlxscore=0 priorityscore=1501 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000 definitions=main-2304280119 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1764432773473762716?= X-GMAIL-MSGID: =?utf-8?q?1764432773473762716?= |
Series |
Enable IPQ9574 TSENS support
|
|
Commit Message
Varadarajan Narayanan
April 28, 2023, 2:52 p.m. UTC
From: Praveenkumar I <quic_ipkumar@quicinc.com> Qualcomm IPQ9574 has tsens v2.3.1 block, which is similar to IPQ8074 tsens. Signed-off-by: Praveenkumar I <quic_ipkumar@quicinc.com> Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> --- Documentation/devicetree/bindings/thermal/qcom-tsens.yaml | 3 +++ 1 file changed, 3 insertions(+)
Comments
On 28/04/2023 16:52, Varadarajan Narayanan wrote: > From: Praveenkumar I <quic_ipkumar@quicinc.com> > > Qualcomm IPQ9574 has tsens v2.3.1 block, which is similar to IPQ8074 tsens. > > Signed-off-by: Praveenkumar I <quic_ipkumar@quicinc.com> > Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> > --- > Documentation/devicetree/bindings/thermal/qcom-tsens.yaml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml > index d1ec963..8e2208c 100644 > --- a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml > +++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml > @@ -66,6 +66,7 @@ properties: > - description: v2 of TSENS with combined interrupt > enum: > - qcom,ipq8074-tsens > + - qcom,ipq9574-tsens Your drive change indicates they are compatible, so make them compatible. 9574 followed by 8074. Best regards, Krzysztof
On Mon, May 01, 2023 at 09:08:49AM +0200, Krzysztof Kozlowski wrote: > On 28/04/2023 16:52, Varadarajan Narayanan wrote: > > From: Praveenkumar I <quic_ipkumar@quicinc.com> > > > > Qualcomm IPQ9574 has tsens v2.3.1 block, which is similar to IPQ8074 tsens. > > > > Signed-off-by: Praveenkumar I <quic_ipkumar@quicinc.com> > > Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> > > --- > > Documentation/devicetree/bindings/thermal/qcom-tsens.yaml | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml > > index d1ec963..8e2208c 100644 > > --- a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml > > +++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml > > @@ -66,6 +66,7 @@ properties: > > - description: v2 of TSENS with combined interrupt > > enum: > > - qcom,ipq8074-tsens > > + - qcom,ipq9574-tsens > > Your drive change indicates they are compatible, so make them > compatible. 9574 followed by 8074. Not able to understand. You want IPQ9574 to use "qcom,ipq8074-tsens" instead of adding a "qcom,ipq9574-tsens" and no need to add an extra entry to the driver like }, { .compatible = "qcom,ipq9574-tsens", .data = &data_ipq8074, }, { Thanks Varada > Best regards, > Krzysztof >
On 03/05/2023 09:10, Varadarajan Narayanan wrote: > On Mon, May 01, 2023 at 09:08:49AM +0200, Krzysztof Kozlowski wrote: >> On 28/04/2023 16:52, Varadarajan Narayanan wrote: >>> From: Praveenkumar I <quic_ipkumar@quicinc.com> >>> >>> Qualcomm IPQ9574 has tsens v2.3.1 block, which is similar to IPQ8074 tsens. >>> >>> Signed-off-by: Praveenkumar I <quic_ipkumar@quicinc.com> >>> Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> >>> --- >>> Documentation/devicetree/bindings/thermal/qcom-tsens.yaml | 3 +++ >>> 1 file changed, 3 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml >>> index d1ec963..8e2208c 100644 >>> --- a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml >>> +++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml >>> @@ -66,6 +66,7 @@ properties: >>> - description: v2 of TSENS with combined interrupt >>> enum: >>> - qcom,ipq8074-tsens >>> + - qcom,ipq9574-tsens >> >> Your drive change indicates they are compatible, so make them >> compatible. 9574 followed by 8074. > > Not able to understand. You want IPQ9574 to use "qcom,ipq8074-tsens" > instead of adding a "qcom,ipq9574-tsens" and no need to add an extra > entry to the driver like Assuming the devices are really compatible, which your driver change suggests, I want to use two compatibles. 9574 followed by 8074 fallback, just like we do for all Qualcomm IP blocks. Then as you said - no need for driver change. Best regards, Krzysztof
On Wed, May 03, 2023 at 09:42:28AM +0200, Krzysztof Kozlowski wrote: > On 03/05/2023 09:10, Varadarajan Narayanan wrote: > > On Mon, May 01, 2023 at 09:08:49AM +0200, Krzysztof Kozlowski wrote: > >> On 28/04/2023 16:52, Varadarajan Narayanan wrote: > >>> From: Praveenkumar I <quic_ipkumar@quicinc.com> > >>> > >>> Qualcomm IPQ9574 has tsens v2.3.1 block, which is similar to IPQ8074 tsens. > >>> > >>> Signed-off-by: Praveenkumar I <quic_ipkumar@quicinc.com> > >>> Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> > >>> --- > >>> Documentation/devicetree/bindings/thermal/qcom-tsens.yaml | 3 +++ > >>> 1 file changed, 3 insertions(+) > >>> > >>> diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml > >>> index d1ec963..8e2208c 100644 > >>> --- a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml > >>> +++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml > >>> @@ -66,6 +66,7 @@ properties: > >>> - description: v2 of TSENS with combined interrupt > >>> enum: > >>> - qcom,ipq8074-tsens > >>> + - qcom,ipq9574-tsens > >> > >> Your drive change indicates they are compatible, so make them > >> compatible. 9574 followed by 8074. > > > > Not able to understand. You want IPQ9574 to use "qcom,ipq8074-tsens" > > instead of adding a "qcom,ipq9574-tsens" and no need to add an extra > > entry to the driver like > > Assuming the devices are really compatible, which your driver change > suggests, I want to use two compatibles. 9574 followed by 8074 fallback, > just like we do for all Qualcomm IP blocks. Then as you said - no need > for driver change. With schema like this items: - enum: - qcom,ipq8074-tsens - qcom,ipq9574-tsens and DTS as compatible = "qcom,ipq9574-tsens", "qcom,ipq8074-tsens"; 'make dtbs_check' gives the following error arch/arm64/boot/dts/qcom/ipq9574-rdp433.dtb: thermal-sensor@4a9000: compatible: 'oneOf' conditional failed, one must be fixed: ['qcom,ipq9574-tsens', 'qcom,ipq8074-tsens'] is too long To fix the above error, I have to change the schema as items: - enum: - qcom,ipq8074-tsens - qcom,ipq9574-tsens - const: qcom,tsens-v2-combined-int and change ipq8074 & ipq9754 DTS as compatible = "qcom,ipq8074-tsens", "qcom,tsens-v2-combined-int"; compatible = "qcom,ipq9574-tsens", "qcom,tsens-v2-combined-int"; For this to work, have to introduce qcom,tsens-v2-combined-int in the driver with }, { .compatible = "qcom,tsens-v2-combined-int", .data = &data_ipq8074, }, This i guess will defeat the purpose. So shall we leave it as it is now, or shall I change driver, schema and ipq8074 + ip9574 DTS with qcom,tsens-v2-combined-int? Let me know. Thanks Varada > Best regards, > Krzysztof
On 04/05/2023 06:57, Varadarajan Narayanan wrote: > On Wed, May 03, 2023 at 09:42:28AM +0200, Krzysztof Kozlowski wrote: >> On 03/05/2023 09:10, Varadarajan Narayanan wrote: >>> On Mon, May 01, 2023 at 09:08:49AM +0200, Krzysztof Kozlowski wrote: >>>> On 28/04/2023 16:52, Varadarajan Narayanan wrote: >>>>> From: Praveenkumar I <quic_ipkumar@quicinc.com> >>>>> >>>>> Qualcomm IPQ9574 has tsens v2.3.1 block, which is similar to IPQ8074 tsens. >>>>> >>>>> Signed-off-by: Praveenkumar I <quic_ipkumar@quicinc.com> >>>>> Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> >>>>> --- >>>>> Documentation/devicetree/bindings/thermal/qcom-tsens.yaml | 3 +++ >>>>> 1 file changed, 3 insertions(+) >>>>> >>>>> diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml >>>>> index d1ec963..8e2208c 100644 >>>>> --- a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml >>>>> +++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml >>>>> @@ -66,6 +66,7 @@ properties: >>>>> - description: v2 of TSENS with combined interrupt >>>>> enum: >>>>> - qcom,ipq8074-tsens >>>>> + - qcom,ipq9574-tsens >>>> >>>> Your drive change indicates they are compatible, so make them >>>> compatible. 9574 followed by 8074. >>> >>> Not able to understand. You want IPQ9574 to use "qcom,ipq8074-tsens" >>> instead of adding a "qcom,ipq9574-tsens" and no need to add an extra >>> entry to the driver like >> >> Assuming the devices are really compatible, which your driver change >> suggests, I want to use two compatibles. 9574 followed by 8074 fallback, >> just like we do for all Qualcomm IP blocks. Then as you said - no need >> for driver change. > > With schema like this > items: > - enum: > - qcom,ipq8074-tsens > - qcom,ipq9574-tsens > and DTS as > compatible = "qcom,ipq9574-tsens", "qcom,ipq8074-tsens"; This file (and many others) shows you how to encode it in the DT schema https://elixir.bootlin.com/linux/v6.3-rc6/source/Documentation/devicetree/bindings/sound/nvidia,tegra210-ope.yaml#L31 > > 'make dtbs_check' gives the following error > > arch/arm64/boot/dts/qcom/ipq9574-rdp433.dtb: thermal-sensor@4a9000: compatible: 'oneOf' conditional failed, one must be fixed: > ['qcom,ipq9574-tsens', 'qcom,ipq8074-tsens'] is too long > > To fix the above error, I have to change the schema as > > items: > - enum: > - qcom,ipq8074-tsens > - qcom,ipq9574-tsens > - const: qcom,tsens-v2-combined-int This is not what we talked about. Best regards, Krzysztof
On Thu, May 04, 2023 at 08:22:44AM +0200, Krzysztof Kozlowski wrote: > On 04/05/2023 06:57, Varadarajan Narayanan wrote: > > On Wed, May 03, 2023 at 09:42:28AM +0200, Krzysztof Kozlowski wrote: > >> On 03/05/2023 09:10, Varadarajan Narayanan wrote: > >>> On Mon, May 01, 2023 at 09:08:49AM +0200, Krzysztof Kozlowski wrote: > >>>> On 28/04/2023 16:52, Varadarajan Narayanan wrote: > >>>>> From: Praveenkumar I <quic_ipkumar@quicinc.com> > >>>>> > >>>>> Qualcomm IPQ9574 has tsens v2.3.1 block, which is similar to IPQ8074 tsens. > >>>>> > >>>>> Signed-off-by: Praveenkumar I <quic_ipkumar@quicinc.com> > >>>>> Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> > >>>>> --- > >>>>> Documentation/devicetree/bindings/thermal/qcom-tsens.yaml | 3 +++ > >>>>> 1 file changed, 3 insertions(+) > >>>>> > >>>>> diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml > >>>>> index d1ec963..8e2208c 100644 > >>>>> --- a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml > >>>>> +++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml > >>>>> @@ -66,6 +66,7 @@ properties: > >>>>> - description: v2 of TSENS with combined interrupt > >>>>> enum: > >>>>> - qcom,ipq8074-tsens > >>>>> + - qcom,ipq9574-tsens > >>>> > >>>> Your drive change indicates they are compatible, so make them > >>>> compatible. 9574 followed by 8074. > >>> > >>> Not able to understand. You want IPQ9574 to use "qcom,ipq8074-tsens" > >>> instead of adding a "qcom,ipq9574-tsens" and no need to add an extra > >>> entry to the driver like > >> > >> Assuming the devices are really compatible, which your driver change > >> suggests, I want to use two compatibles. 9574 followed by 8074 fallback, > >> just like we do for all Qualcomm IP blocks. Then as you said - no need > >> for driver change. > > > > With schema like this > > items: > > - enum: > > - qcom,ipq8074-tsens > > - qcom,ipq9574-tsens > > and DTS as > > compatible = "qcom,ipq9574-tsens", "qcom,ipq8074-tsens"; > > This file (and many others) shows you how to encode it in the DT schema > > https://elixir.bootlin.com/linux/v6.3-rc6/source/Documentation/devicetree/bindings/sound/nvidia,tegra210-ope.yaml#L31 Thanks for the pointer. Will rework and post. -Varada > > 'make dtbs_check' gives the following error > > > > arch/arm64/boot/dts/qcom/ipq9574-rdp433.dtb: thermal-sensor@4a9000: compatible: 'oneOf' conditional failed, one must be fixed: > > ['qcom,ipq9574-tsens', 'qcom,ipq8074-tsens'] is too long > > > > To fix the above error, I have to change the schema as > > > > items: > > - enum: > > - qcom,ipq8074-tsens > > - qcom,ipq9574-tsens > > - const: qcom,tsens-v2-combined-int > > This is not what we talked about. > > Best regards, > Krzysztof >
diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml index d1ec963..8e2208c 100644 --- a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml +++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml @@ -66,6 +66,7 @@ properties: - description: v2 of TSENS with combined interrupt enum: - qcom,ipq8074-tsens + - qcom,ipq9574-tsens reg: items: @@ -277,6 +278,7 @@ allOf: contains: enum: - qcom,ipq8074-tsens + - qcom,ipq9574-tsens then: properties: interrupts: @@ -292,6 +294,7 @@ allOf: contains: enum: - qcom,ipq8074-tsens + - qcom,ipq9574-tsens - qcom,tsens-v0_1 - qcom,tsens-v1 - qcom,tsens-v2