Message ID | cbf916e31b00e0e0599a3012a84a4740df89f4e0.1683027347.git.quic_varada@quicinc.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1076335vqo; Tue, 2 May 2023 21:50:15 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7fQoVXreW6jCTdTZep4kHul9B0kGWLAojuq+UZSS69pMHDixKI6IC2ToH0Pfx7wVm2+yAO X-Received: by 2002:a17:902:d314:b0:1a6:db0a:8003 with SMTP id b20-20020a170902d31400b001a6db0a8003mr993942plc.23.1683089415480; Tue, 02 May 2023 21:50:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683089415; cv=none; d=google.com; s=arc-20160816; b=mky3sdGCnITov+AJaBj8MwaHLGvOpGPjgoZklO+q00lLwE0WsuklvSxLxSQVqdlrw+ RQeBTiwzsA5mP/LJ/ERabQ4SX4dN3ScP8Y2Td7/W7ajJeLedMgB4DZC5eodgeNCOIRTT OyH4WBuVorBfjXAqyCBvYWyNylyV/3tE0DR7maiG347zIB+O3DNF2KP8MWO2FPyndK7K ozaw/+JD0IYwYnrXN92BbVPHQ1TYPHza3+dk+H+77gbiPy6ab771zHMKwgbgbuFO2lON zQg/sReGh5n55XEthyOJEO6eaQqCcgwxihNzuZ1ygjvr2unaEyk4MN0PiitmBnt0VBj9 tk+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=YT6sin7qrQa3ZRjEgGewAlX1Cnjc9ZhEG9Kem6mKXIQ=; b=AHmDGVXlzI2oEGYG5tqVlp1HS0zradC0zXKEtgP8mhCniQYTEbLQm/57lv4t/Wn2rZ YZ+tHNDlJHGECCy3SC6YUSMEPJ+rcahz/vnqDvrnk1MeKdRuXrWpVuclhURFLPGeTXjL FKzR/bRcmXZDYkJcK8pZKjodFK/khPbcH5pRnz3QGOP3tqRR15mJHVoW++7JiRnb9SC6 qD1jv5zX9BQjOo0km2o8x+4faTneeDMk/KU5FQZWtl7uyB9bIgbp4S+pF0usVZwSW8D/ s3qNP6wxxZgYY/ziJMdTECL9CjLanWcQIz8WOaDth9JTGYkm+zDZPLqB0yVcBaftMgrP Zyqg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=oEtY36Kq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h6-20020a170902f54600b001a9baadecc0si14818427plf.160.2023.05.02.21.50.03; Tue, 02 May 2023 21:50:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=oEtY36Kq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229650AbjECEqq (ORCPT <rfc822;heyuhang3455@gmail.com> + 99 others); Wed, 3 May 2023 00:46:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47052 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229639AbjECEqo (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Wed, 3 May 2023 00:46:44 -0400 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3C30B30E8; Tue, 2 May 2023 21:46:40 -0700 (PDT) Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 34347i6N021640; Wed, 3 May 2023 04:46:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type; s=qcppdkim1; bh=YT6sin7qrQa3ZRjEgGewAlX1Cnjc9ZhEG9Kem6mKXIQ=; b=oEtY36KqAb9dVr+a8sw8fRt7VnykIYUtogT5CXqOAHEyAWsyyHwDHv79xkVAyeHFBVGF NvgCwhMZ/4+bXsDxQ6fmBTjaDJg6PGVeo/+xGKZt2V1oYPQlgYITGjJc3He2jBPlYAAQ r+UyiVIFBfLv9D1nVyjWJ63uqIP/qus2psO60unvKaBluqd4Rob/PbAIp7hVbDxFBZdG bz2j1YGnqnGWKhA+WONDOAf93TWv8wki8flZ79jzdoJtqkdQU4YxrTNSWl6xX/SDBjB9 5F1xh9t9o+DZwsQS02hdfpvbJtuzUUdq2pIw/FcMFcEfwmEfzsj1ee6BIm591et3JQ1H eg== Received: from nasanppmta02.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3qb9fagpqp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 03 May 2023 04:46:34 +0000 Received: from nasanex01a.na.qualcomm.com (nasanex01a.na.qualcomm.com [10.52.223.231]) by NASANPPMTA02.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 3434kXNp007593 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 3 May 2023 04:46:33 GMT Received: from varda-linux.qualcomm.com (10.80.80.8) by nasanex01a.na.qualcomm.com (10.52.223.231) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.42; Tue, 2 May 2023 21:46:28 -0700 From: Varadarajan Narayanan <quic_varada@quicinc.com> To: <amitk@kernel.org>, <thara.gopinath@gmail.com>, <agross@kernel.org>, <andersson@kernel.org>, <konrad.dybcio@linaro.org>, <rafael@kernel.org>, <daniel.lezcano@linaro.org>, <rui.zhang@intel.com>, <robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>, <linux-pm@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org> CC: Praveenkumar I <quic_ipkumar@quicinc.com>, Varadarajan Narayanan <quic_varada@quicinc.com> Subject: [PATCH v1 1/4] dt-bindings: thermal: tsens: Add ipq9574 compatible Date: Wed, 3 May 2023 10:15:59 +0530 Message-ID: <cbf916e31b00e0e0599a3012a84a4740df89f4e0.1683027347.git.quic_varada@quicinc.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <cover.1683027347.git.quic_varada@quicinc.com> References: <cover.1683027347.git.quic_varada@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01a.na.qualcomm.com (10.52.223.231) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: abKG5y0x4kdpOBjOosVhfK-fEkRVz7xH X-Proofpoint-GUID: abKG5y0x4kdpOBjOosVhfK-fEkRVz7xH X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-05-03_01,2023-04-27_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 priorityscore=1501 suspectscore=0 spamscore=0 clxscore=1015 adultscore=0 lowpriorityscore=0 mlxlogscore=946 malwarescore=0 impostorscore=0 mlxscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000 definitions=main-2305030037 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1764847166670571876?= X-GMAIL-MSGID: =?utf-8?q?1764847166670571876?= |
Series |
Enable IPQ9574 TSENS support
|
|
Commit Message
Varadarajan Narayanan
May 3, 2023, 4:45 a.m. UTC
From: Praveenkumar I <quic_ipkumar@quicinc.com> Qualcomm IPQ9574 has tsens v2.3.1 block, which is similar to IPQ8074 tsens. Signed-off-by: Praveenkumar I <quic_ipkumar@quicinc.com> Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> --- Documentation/devicetree/bindings/thermal/qcom-tsens.yaml | 3 +++ 1 file changed, 3 insertions(+)
Comments
On 03/05/2023 06:45, Varadarajan Narayanan wrote: > From: Praveenkumar I <quic_ipkumar@quicinc.com> > > Qualcomm IPQ9574 has tsens v2.3.1 block, which is similar to IPQ8074 tsens. > > Signed-off-by: Praveenkumar I <quic_ipkumar@quicinc.com> > Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> > --- > Documentation/devicetree/bindings/thermal/qcom-tsens.yaml | 3 +++ > 1 file changed, 3 insertions(+) > I saw already v1, so this looks like v2, not v1. Please add changelog describing what you changed here. > diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml > index d1ec963..8e2208c 100644 > --- a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml > +++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml > @@ -66,6 +66,7 @@ properties: > - description: v2 of TSENS with combined interrupt > enum: > - qcom,ipq8074-tsens > + - qcom,ipq9574-tsens This is a friendly reminder during the review process. It seems my previous comments were not fully addressed. Maybe my feedback got lost between the quotes, maybe you just forgot to apply it. Please go back to the previous discussion and either implement all requested changes or keep discussing them. Thank you. Best regards, Krzysztof
On Wed, May 03, 2023 at 08:34:45AM +0200, Krzysztof Kozlowski wrote: > On 03/05/2023 06:45, Varadarajan Narayanan wrote: > > From: Praveenkumar I <quic_ipkumar@quicinc.com> > > > > Qualcomm IPQ9574 has tsens v2.3.1 block, which is similar to IPQ8074 tsens. > > > > Signed-off-by: Praveenkumar I <quic_ipkumar@quicinc.com> > > Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> > > --- > > Documentation/devicetree/bindings/thermal/qcom-tsens.yaml | 3 +++ > > 1 file changed, 3 insertions(+) > > > > I saw already v1, so this looks like v2, not v1. Please add changelog > describing what you changed here. No code change between v1 and v2 w.r.t this patch. The 4th patch alone in this series has code changes between v1 and v2. > > diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml > > index d1ec963..8e2208c 100644 > > --- a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml > > +++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml > > @@ -66,6 +66,7 @@ properties: > > - description: v2 of TSENS with combined interrupt > > enum: > > - qcom,ipq8074-tsens > > + - qcom,ipq9574-tsens > > This is a friendly reminder during the review process. > > It seems my previous comments were not fully addressed. Maybe my > feedback got lost between the quotes, maybe you just forgot to apply it. > Please go back to the previous discussion and either implement all > requested changes or keep discussing them. > > Thank you. Sorry. Looks like I missed https://lore.kernel.org/lkml/20230502080611.GB26126@varda-linux.qualcomm.com/T/#m42a9b77be2ceddf1adc90c07f487929fcf2dbc0f Will take that input and post a new version. Thanks Varada > Best regards, > Krzysztof >
On Wed, 03 May 2023 10:15:59 +0530, Varadarajan Narayanan wrote: > From: Praveenkumar I <quic_ipkumar@quicinc.com> > > Qualcomm IPQ9574 has tsens v2.3.1 block, which is similar to IPQ8074 tsens. > > Signed-off-by: Praveenkumar I <quic_ipkumar@quicinc.com> > Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> > --- > Documentation/devicetree/bindings/thermal/qcom-tsens.yaml | 3 +++ > 1 file changed, 3 insertions(+) > Acked-by: Rob Herring <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml index d1ec963..8e2208c 100644 --- a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml +++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml @@ -66,6 +66,7 @@ properties: - description: v2 of TSENS with combined interrupt enum: - qcom,ipq8074-tsens + - qcom,ipq9574-tsens reg: items: @@ -277,6 +278,7 @@ allOf: contains: enum: - qcom,ipq8074-tsens + - qcom,ipq9574-tsens then: properties: interrupts: @@ -292,6 +294,7 @@ allOf: contains: enum: - qcom,ipq8074-tsens + - qcom,ipq9574-tsens - qcom,tsens-v0_1 - qcom,tsens-v1 - qcom,tsens-v2