diff mbox series

ALSA: hda/realtek: Add quirk for 2nd ASUS GU603

Message ID 20230503035035.254346-1-luke@ljones.dev
State New
Headers
Series ALSA: hda/realtek: Add quirk for 2nd ASUS GU603 |

Commit Message

Luke Jones May 3, 2023, 3:50 a.m. UTC 
  Add quirk for GU603 with 0x1c62 variant of codec.

Signed-off-by: Luke D. Jones <luke@ljones.dev>
---
 sound/pci/hda/patch_realtek.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Takashi Iwai May 3, 2023, 6:08 a.m. UTC | #1 
On Wed, 03 May 2023 05:50:35 +0200,
Luke D. Jones wrote:
> 
> Add quirk for GU603 with 0x1c62 variant of codec.
> 
> Signed-off-by: Luke D. Jones <luke@ljones.dev>
> ---
>  sound/pci/hda/patch_realtek.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 3b9f077a227f..4a585050edc3 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -9501,6 +9501,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
>  	SND_PCI_QUIRK(0x1043, 0x1517, "Asus Zenbook UX31A", ALC269VB_FIXUP_ASUS_ZENBOOK_UX31A),
>  	SND_PCI_QUIRK(0x1043, 0x1662, "ASUS GV301QH", ALC294_FIXUP_ASUS_DUAL_SPK),
>  	SND_PCI_QUIRK(0x1043, 0x16b2, "ASUS GU603", ALC289_FIXUP_ASUS_GA401),
> +	SND_PCI_QUIRK(0x1043, 0x1c62, "ASUS GU603", ALC289_FIXUP_ASUS_GA401),
>  	SND_PCI_QUIRK(0x1043, 0x16e3, "ASUS UX50", ALC269_FIXUP_STEREO_DMIC),
>  	SND_PCI_QUIRK(0x1043, 0x1740, "ASUS UX430UA", ALC295_FIXUP_ASUS_DACS),
>  	SND_PCI_QUIRK(0x1043, 0x17d1, "ASUS UX431FL", ALC294_FIXUP_ASUS_DUAL_SPK),

Could you try to put the new entry at the right place?
The table is sorted in the PCI SSID order.


thanks,

Takashi
Luke Jones May 4, 2023, 12:41 a.m. UTC | #2 
On Wed, May 3 2023 at 08:08:13 +0200, Takashi Iwai <tiwai@suse.de> 
wrote:
> On Wed, 03 May 2023 05:50:35 +0200,
> Luke D. Jones wrote:
>> 
>>  Add quirk for GU603 with 0x1c62 variant of codec.
>> 
>>  Signed-off-by: Luke D. Jones <luke@ljones.dev>
>>  ---
>>   sound/pci/hda/patch_realtek.c | 1 +
>>   1 file changed, 1 insertion(+)
>> 
>>  diff --git a/sound/pci/hda/patch_realtek.c 
>> b/sound/pci/hda/patch_realtek.c
>>  index 3b9f077a227f..4a585050edc3 100644
>>  --- a/sound/pci/hda/patch_realtek.c
>>  +++ b/sound/pci/hda/patch_realtek.c
>>  @@ -9501,6 +9501,7 @@ static const struct snd_pci_quirk 
>> alc269_fixup_tbl[] = {
>>   	SND_PCI_QUIRK(0x1043, 0x1517, "Asus Zenbook UX31A", 
>> ALC269VB_FIXUP_ASUS_ZENBOOK_UX31A),
>>   	SND_PCI_QUIRK(0x1043, 0x1662, "ASUS GV301QH", 
>> ALC294_FIXUP_ASUS_DUAL_SPK),
>>   	SND_PCI_QUIRK(0x1043, 0x16b2, "ASUS GU603", 
>> ALC289_FIXUP_ASUS_GA401),
>>  +	SND_PCI_QUIRK(0x1043, 0x1c62, "ASUS GU603", 
>> ALC289_FIXUP_ASUS_GA401),
>>   	SND_PCI_QUIRK(0x1043, 0x16e3, "ASUS UX50", 
>> ALC269_FIXUP_STEREO_DMIC),
>>   	SND_PCI_QUIRK(0x1043, 0x1740, "ASUS UX430UA", 
>> ALC295_FIXUP_ASUS_DACS),
>>   	SND_PCI_QUIRK(0x1043, 0x17d1, "ASUS UX431FL", 
>> ALC294_FIXUP_ASUS_DUAL_SPK),
> 
> Could you try to put the new entry at the right place?
> The table is sorted in the PCI SSID order.
> 
> 
> thanks,
> 
> Takashi

Sure no problem. Sorry, seems I read `0x1c62` and `0x16c2` :(
Takashi Iwai May 5, 2023, 3:15 p.m. UTC | #3 
On Thu, 04 May 2023 02:41:09 +0200,
Luke Jones wrote:
> 
> On Wed, May 3 2023 at 08:08:13 +0200, Takashi Iwai <tiwai@suse.de>
> wrote:
> > On Wed, 03 May 2023 05:50:35 +0200,
> > Luke D. Jones wrote:
> >> 
> >>  Add quirk for GU603 with 0x1c62 variant of codec.
> >> 
> >>  Signed-off-by: Luke D. Jones <luke@ljones.dev>
> >>  ---
> >>   sound/pci/hda/patch_realtek.c | 1 +
> >>   1 file changed, 1 insertion(+)
> >> 
> >>  diff --git a/sound/pci/hda/patch_realtek.c
> >> b/sound/pci/hda/patch_realtek.c
> >>  index 3b9f077a227f..4a585050edc3 100644
> >>  --- a/sound/pci/hda/patch_realtek.c
> >>  +++ b/sound/pci/hda/patch_realtek.c
> >>  @@ -9501,6 +9501,7 @@ static const struct snd_pci_quirk
> >> alc269_fixup_tbl[] = {
> >>   	SND_PCI_QUIRK(0x1043, 0x1517, "Asus Zenbook UX31A",
> >> ALC269VB_FIXUP_ASUS_ZENBOOK_UX31A),
> >>   	SND_PCI_QUIRK(0x1043, 0x1662, "ASUS GV301QH",
> >> ALC294_FIXUP_ASUS_DUAL_SPK),
> >>   	SND_PCI_QUIRK(0x1043, 0x16b2, "ASUS GU603",
> >> ALC289_FIXUP_ASUS_GA401),
> >>  +	SND_PCI_QUIRK(0x1043, 0x1c62, "ASUS GU603",
> >> ALC289_FIXUP_ASUS_GA401),
> >>   	SND_PCI_QUIRK(0x1043, 0x16e3, "ASUS UX50",
> >> ALC269_FIXUP_STEREO_DMIC),
> >>   	SND_PCI_QUIRK(0x1043, 0x1740, "ASUS UX430UA",
> >> ALC295_FIXUP_ASUS_DACS),
> >>   	SND_PCI_QUIRK(0x1043, 0x17d1, "ASUS UX431FL",
> >> ALC294_FIXUP_ASUS_DUAL_SPK),
> > 
> > Could you try to put the new entry at the right place?
> > The table is sorted in the PCI SSID order.
> > 
> > 
> > thanks,
> > 
> > Takashi
> 
> Sure no problem. Sorry, seems I read `0x1c62` and `0x16c2` :(

So, which number is correct?  Isn't it 0x16c2?  This sounds more
reasonable.

In anyway, please resubmit a proper patch after confirming that it's
really working.


thanks,

Takashi
Luke Jones May 5, 2023, 11:59 p.m. UTC | #4 
On Fri, May 5 2023 at 17:15:24 +0200, Takashi Iwai <tiwai@suse.de> 
wrote:
> On Thu, 04 May 2023 02:41:09 +0200,
> Luke Jones wrote:
>> 
>>  On Wed, May 3 2023 at 08:08:13 +0200, Takashi Iwai <tiwai@suse.de>
>>  wrote:
>>  > On Wed, 03 May 2023 05:50:35 +0200,
>>  > Luke D. Jones wrote:
>>  >>
>>  >>  Add quirk for GU603 with 0x1c62 variant of codec.
>>  >>
>>  >>  Signed-off-by: Luke D. Jones <luke@ljones.dev>
>>  >>  ---
>>  >>   sound/pci/hda/patch_realtek.c | 1 +
>>  >>   1 file changed, 1 insertion(+)
>>  >>
>>  >>  diff --git a/sound/pci/hda/patch_realtek.c
>>  >> b/sound/pci/hda/patch_realtek.c
>>  >>  index 3b9f077a227f..4a585050edc3 100644
>>  >>  --- a/sound/pci/hda/patch_realtek.c
>>  >>  +++ b/sound/pci/hda/patch_realtek.c
>>  >>  @@ -9501,6 +9501,7 @@ static const struct snd_pci_quirk
>>  >> alc269_fixup_tbl[] = {
>>  >>   	SND_PCI_QUIRK(0x1043, 0x1517, "Asus Zenbook UX31A",
>>  >> ALC269VB_FIXUP_ASUS_ZENBOOK_UX31A),
>>  >>   	SND_PCI_QUIRK(0x1043, 0x1662, "ASUS GV301QH",
>>  >> ALC294_FIXUP_ASUS_DUAL_SPK),
>>  >>   	SND_PCI_QUIRK(0x1043, 0x16b2, "ASUS GU603",
>>  >> ALC289_FIXUP_ASUS_GA401),
>>  >>  +	SND_PCI_QUIRK(0x1043, 0x1c62, "ASUS GU603",
>>  >> ALC289_FIXUP_ASUS_GA401),
>>  >>   	SND_PCI_QUIRK(0x1043, 0x16e3, "ASUS UX50",
>>  >> ALC269_FIXUP_STEREO_DMIC),
>>  >>   	SND_PCI_QUIRK(0x1043, 0x1740, "ASUS UX430UA",
>>  >> ALC295_FIXUP_ASUS_DACS),
>>  >>   	SND_PCI_QUIRK(0x1043, 0x17d1, "ASUS UX431FL",
>>  >> ALC294_FIXUP_ASUS_DUAL_SPK),
>>  >
>>  > Could you try to put the new entry at the right place?
>>  > The table is sorted in the PCI SSID order.
>>  >
>>  >
>>  > thanks,
>>  >
>>  > Takashi
>> 
>>  Sure no problem. Sorry, seems I read `0x1c62` and `0x16c2` :(
> 
> So, which number is correct?  Isn't it 0x16c2?  This sounds more
> reasonable.
> 
> In anyway, please resubmit a proper patch after confirming that it's
> really working.
> 
> 
> thanks,
> 
> Takashi

0x1c62 is the correct hex, I've submitted V2 with the line in the right 
order.
diff mbox series

Patch

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 3b9f077a227f..4a585050edc3 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -9501,6 +9501,7 @@  static const struct snd_pci_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x1043, 0x1517, "Asus Zenbook UX31A", ALC269VB_FIXUP_ASUS_ZENBOOK_UX31A),
 	SND_PCI_QUIRK(0x1043, 0x1662, "ASUS GV301QH", ALC294_FIXUP_ASUS_DUAL_SPK),
 	SND_PCI_QUIRK(0x1043, 0x16b2, "ASUS GU603", ALC289_FIXUP_ASUS_GA401),
+	SND_PCI_QUIRK(0x1043, 0x1c62, "ASUS GU603", ALC289_FIXUP_ASUS_GA401),
 	SND_PCI_QUIRK(0x1043, 0x16e3, "ASUS UX50", ALC269_FIXUP_STEREO_DMIC),
 	SND_PCI_QUIRK(0x1043, 0x1740, "ASUS UX430UA", ALC295_FIXUP_ASUS_DACS),
 	SND_PCI_QUIRK(0x1043, 0x17d1, "ASUS UX431FL", ALC294_FIXUP_ASUS_DUAL_SPK),