RISC-V: Name newly added flags in changelog

Message ID 20230501161037.614414-1-patrick@rivosinc.com
State Accepted
Headers
Series RISC-V: Name newly added flags in changelog |

Checks

Context Check Description
snail/gcc-patch-check success Github commit url

Commit Message

Patrick O'Neill May 1, 2023, 4:10 p.m. UTC
  This patch fixes the changelog to explicitly name the added command line
flags introduced in this patch:
https://gcc.gnu.org/pipermail/gcc-patches/2023-April/616807.html

2023-05-01 Patrick O'Neill <patrick@rivosinc.com>

gcc/ChangeLog:

	* ChangeLog: Name the flags added by the patch in the changelog.

Signed-off-by: Patrick O'Neill <patrick@rivosinc.com>
---
 gcc/ChangeLog | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
  

Comments

Jeff Law May 2, 2023, 3:50 p.m. UTC | #1
On 5/1/23 10:10, Patrick O'Neill wrote:
> This patch fixes the changelog to explicitly name the added command line
> flags introduced in this patch:
> https://gcc.gnu.org/pipermail/gcc-patches/2023-April/616807.html
> 
> 2023-05-01 Patrick O'Neill <patrick@rivosinc.com>
> 
> gcc/ChangeLog:
> 
> 	* ChangeLog: Name the flags added by the patch in the changelog.
OK.  You *might* not actually need a ChangeLog entry for this.  The 
hooks *might* have a special case for fixing up the ChangeLog entries.

jeff
  
Patrick O'Neill May 2, 2023, 4:24 p.m. UTC | #2
On 5/2/23 08:50, Jeff Law wrote:
> On 5/1/23 10:10, Patrick O'Neill wrote:
>> This patch fixes the changelog to explicitly name the added command line
>> flags introduced in this patch:
>> https://gcc.gnu.org/pipermail/gcc-patches/2023-April/616807.html
>>
>> 2023-05-01 Patrick O'Neill <patrick@rivosinc.com>
>>
>> gcc/ChangeLog:
>>
>>     * ChangeLog: Name the flags added by the patch in the changelog.
> OK.  You *might* not actually need a ChangeLog entry for this. The 
> hooks *might* have a special case for fixing up the ChangeLog entries.
>
> jeff
Committed.

I tried without a ChangeLog and it worked. Thanks!

Patrick
  

Patch

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index fe8f624343c..7eb2b43c98c 100644
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -109,10 +109,12 @@ 
 	PR target/104338
 	* config/riscv/riscv-protos.h: Add helper function stubs.
 	* config/riscv/riscv.cc: Add helper functions for subword masking.
-	* config/riscv/riscv.opt: Add command-line flag.
+	* config/riscv/riscv.opt: Add command-line flags -minline-atomics and
+	-mno-inline-atomics.
 	* config/riscv/sync.md: Add masking logic and inline asm for fetch_and_op,
 	fetch_and_nand, CAS, and exchange ops.
-	* doc/invoke.texi: Add blurb regarding command-line flag.
+	* doc/invoke.texi: Add blurb regarding new command-line flags
+	-minline-atomics and -mno-inline-atomics.
 
 2023-04-26  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>