| Message ID | 20221101081458.8119-1-liubo03@inspur.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp2816117wru;
Tue, 1 Nov 2022 01:23:48 -0700 (PDT)
X-Google-Smtp-Source:
AMsMyM61D08oQUBGnpVokPyc8OltS2gDcmAGkyyHxaxPhka0k5QM4TAoFLYtXrrVrvk7WAmXsLMX
X-Received: by 2002:a17:906:30c8:b0:73c:81a9:f8e1 with SMTP id
b8-20020a17090630c800b0073c81a9f8e1mr17063730ejb.649.1667291027858;
Tue, 01 Nov 2022 01:23:47 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1667291027; cv=none;
d=google.com; s=arc-20160816;
b=ES9442lhLnVbhUpWaPBw9Co7Svz4wgSNrj+m43gnOmX84SyKkKHh08GEyadeJEquZA
T6p22cq52gWtKMzsKpZYWOeKszx0cs0AXwyFSRJJRBcEOt/SLv6WRe06dSvEJFZ7K71v
pddBqmgttMraMl4OAilKWqbPGIZDGTME4oU/ieTsQlbsI7MrXBmXkGhb5PMrNcChn0Tr
eka6SAaV3IZ2Un1yqy3Iwr2J4y0VWpNEUpGmXQFMB3/Sx7BKz92S0hwyii5uWELMDUfT
AMWJAZMetxik0nHy3ghGAl1b5eZfnItFquwk/GNl+rWEcSuBJHbh1SEoXMIFwul5uMqw
PgqQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:abuse-reports-to:tuid:mime-version:message-id
:date:subject:cc:to:from;
bh=eaocrJQuTSj7xehLO8WAc3O8/X7VnvExe3mcwyGrtWc=;
b=jrAXTXNJIo1OGFGlD+5b6TiTKwGdG544bAri/WSCteyYUC5GOrr4lM4X91dq2xTDxE
BVu/bJD5m1KjMWfzEzs/xC91WBL7zw9+inqCbQMHzy9NPnjcG2iz3fSnluffgt00iRM4
Sdl83oTkgj8zQvh4RNAEKBBBEWnkdUkwGHHetsW71Ph2TT1Q6uhmclsYN0eh0N+EwYVK
RDspdocEXcHngiqmLk0UJjT7ApE7XErNbIIGBIs/Os4k2X3m1mdAlOcqAOVabuX9WkFb
sOFD8b3dn8hnNSHwsHkQ8koY7zl1zyPOql39/hjROCOzQZBdB0/8HpRagjKXr2QSIo7A
ARDw==
ARC-Authentication-Results: i=1; mx.google.com;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
g16-20020a1709065d1000b00791bcf8aa5esi7780935ejt.739.2022.11.01.01.23.23;
Tue, 01 Nov 2022 01:23:47 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S229739AbiKAIPN (ORCPT <rfc822;kartikey406@gmail.com>
+ 99 others); Tue, 1 Nov 2022 04:15:13 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49842 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S229556AbiKAIPM (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Tue, 1 Nov 2022 04:15:12 -0400
Received: from ssh248.corpemail.net (ssh248.corpemail.net [210.51.61.248])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3A7011260E;
Tue, 1 Nov 2022 01:15:07 -0700 (PDT)
Received: from ([60.208.111.195])
by ssh248.corpemail.net ((D)) with ASMTP (SSL) id WLR00100;
Tue, 01 Nov 2022 16:15:00 +0800
Received: from localhost.localdomain (10.200.104.97) by
jtjnmail201603.home.langchao.com (10.100.2.3) with Microsoft SMTP Server id
15.1.2507.12; Tue, 1 Nov 2022 16:15:01 +0800
From: Bo Liu <liubo03@inspur.com>
To: <dmitry.torokhov@gmail.com>
CC: <michael@amarulasolutions.com>,
<dario.binacchi@amarulasolutions.com>,
<wsa+renesas@sang-engineering.com>,
<oliver.graute@kococonnector.com>, <linux-input@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, Bo Liu <liubo03@inspur.com>
Subject: [PATCH] Input: edt-ft5x06 - replace DEFINE_SIMPLE_ATTRIBUTE with
DEFINE_DEBUGFS_ATTRIBUTE
Date: Tue, 1 Nov 2022 04:14:58 -0400
Message-ID: <20221101081458.8119-1-liubo03@inspur.com>
X-Mailer: git-send-email 2.18.2
MIME-Version: 1.0
Content-Type: text/plain
X-Originating-IP: [10.200.104.97]
tUid: 20221101161500c5e451d4bbc87ab63752f659c0e9ec61
X-Abuse-Reports-To: service@corp-email.com
Abuse-Reports-To: service@corp-email.com
X-Complaints-To: service@corp-email.com
X-Report-Abuse-To: service@corp-email.com
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE,
SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1748281356745976723?=
X-GMAIL-MSGID: =?utf-8?q?1748281356745976723?=
|
| Series |
Input: edt-ft5x06 - replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE
|
|
Commit Message
Bo Liu
Nov. 1, 2022, 8:14 a.m. UTC
Fix the following coccicheck warning:
drivers/input/touchscreen/edt-ft5x06.c:756:0-23: WARNING:
debugfs_mode_fops should be defined with DEFINE_DEBUGFS_ATTRIBUTE
Signed-off-by: Bo Liu <liubo03@inspur.com>
---
drivers/input/touchscreen/edt-ft5x06.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
> Am 01.11.2022 um 09:14 schrieb Bo Liu <liubo03@inspur.com>: > > Fix the following coccicheck warning: > drivers/input/touchscreen/edt-ft5x06.c:756:0-23: WARNING: > debugfs_mode_fops should be defined with DEFINE_DEBUGFS_ATTRIBUTE > > Signed-off-by: Bo Liu <liubo03@inspur.com> Reviewed-by: Oliver Graute <oliver.graute@kococonnector.com> > --- > drivers/input/touchscreen/edt-ft5x06.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/touchscreen/edt-ft5x06.c b/drivers/input/touchscreen/edt-ft5x06.c > index 9ac1378610bc..a184425b6985 100644 > --- a/drivers/input/touchscreen/edt-ft5x06.c > +++ b/drivers/input/touchscreen/edt-ft5x06.c > @@ -753,7 +753,7 @@ static int edt_ft5x06_debugfs_mode_set(void *data, u64 mode) > return retval; > }; > > -DEFINE_SIMPLE_ATTRIBUTE(debugfs_mode_fops, edt_ft5x06_debugfs_mode_get, > +DEFINE_DEBUGFS_ATTRIBUTE(debugfs_mode_fops, edt_ft5x06_debugfs_mode_get, > edt_ft5x06_debugfs_mode_set, "%llu\n"); > > static ssize_t edt_ft5x06_debugfs_raw_data_read(struct file *file, > -- > 2.27.0 >
Hi Bo, On Tue, Nov 01, 2022 at 04:14:58AM -0400, Bo Liu wrote: > Fix the following coccicheck warning: > drivers/input/touchscreen/edt-ft5x06.c:756:0-23: WARNING: > debugfs_mode_fops should be defined with DEFINE_DEBUGFS_ATTRIBUTE This is not a great justification for a change. Could you please update the patch description to document why DEFINE_DEBUGFS_ATTRIBUTE is preferred over DEFINE_SIMPLE_ATTRIBUTE? > > Signed-off-by: Bo Liu <liubo03@inspur.com> > --- > drivers/input/touchscreen/edt-ft5x06.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/touchscreen/edt-ft5x06.c b/drivers/input/touchscreen/edt-ft5x06.c > index 9ac1378610bc..a184425b6985 100644 > --- a/drivers/input/touchscreen/edt-ft5x06.c > +++ b/drivers/input/touchscreen/edt-ft5x06.c > @@ -753,7 +753,7 @@ static int edt_ft5x06_debugfs_mode_set(void *data, u64 mode) > return retval; > }; > > -DEFINE_SIMPLE_ATTRIBUTE(debugfs_mode_fops, edt_ft5x06_debugfs_mode_get, > +DEFINE_DEBUGFS_ATTRIBUTE(debugfs_mode_fops, edt_ft5x06_debugfs_mode_get, > edt_ft5x06_debugfs_mode_set, "%llu\n"); > > static ssize_t edt_ft5x06_debugfs_raw_data_read(struct file *file, > -- > 2.27.0 > Thanks.
diff --git a/drivers/input/touchscreen/edt-ft5x06.c b/drivers/input/touchscreen/edt-ft5x06.c index 9ac1378610bc..a184425b6985 100644 --- a/drivers/input/touchscreen/edt-ft5x06.c +++ b/drivers/input/touchscreen/edt-ft5x06.c @@ -753,7 +753,7 @@ static int edt_ft5x06_debugfs_mode_set(void *data, u64 mode) return retval; }; -DEFINE_SIMPLE_ATTRIBUTE(debugfs_mode_fops, edt_ft5x06_debugfs_mode_get, +DEFINE_DEBUGFS_ATTRIBUTE(debugfs_mode_fops, edt_ft5x06_debugfs_mode_get, edt_ft5x06_debugfs_mode_set, "%llu\n"); static ssize_t edt_ft5x06_debugfs_raw_data_read(struct file *file,