Message ID | 20230427195639.2718734-1-hugo@hugovil.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp518276vqo; Thu, 27 Apr 2023 13:38:50 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7AWWNJiUofjeJW7vQTu8cM/5iSvN2fPCHqdBnEYS1pD2cCgLr4Ht0UpnuwbarzJx4+LwAb X-Received: by 2002:a05:6a20:9150:b0:f5:d6cc:e3f1 with SMTP id x16-20020a056a20915000b000f5d6cce3f1mr3567948pzc.20.1682627929856; Thu, 27 Apr 2023 13:38:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682627929; cv=none; d=google.com; s=arc-20160816; b=ist7XVyPK8ZxLJqXJ8xVPTYBrN1QZS2FfFufzDBxG7MWWvkDy9M/fDXE2gC+Sia0DA 6xE9vYL3iIfdsrR+v2r0JFIcNGYJc2mVLd3vM8mzkwQfalhUoVdttA3S+fMFPQtlJnPh CYNl3tytfSa9hHXGqp12gK/KzTvEPXFVHAdpIpQknxoONsDa7/neUHMbWG1zLrggtfyf mDBcDIqjje/FdkAbNGsDu6lEjTxuCsDHJw+CfCQ26aVlI1oDwSxllHScUccQPy8W4Xeo CEoY8JjjUdWR4VKdmLuS0lP0cqfhou8/kpWXV5HfD5S1pGZJP5sHiOSnrwV4hzyS/r2G oCDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:subject:content-transfer-encoding:mime-version :message-id:date:cc:to:from:dkim-signature; bh=wor8RugYSIQvGy88vbz6N5i586hb3K3HJiPcgNEMEes=; b=JVbLAMyA6Cbwvec5+eSeHQc7D3cHlThxKb5OIKLz7KVJf4NiXvHhHCwX2KjlOOEmco HXqvOG3YP8Qv/n0BiSAfhPvCTzIazNxuJ7G0Bi0LZlvKodlvCAx1BR1egnXwNThQPImJ xegh/0NYpnJ//PkBGHDWItxx+E0vSTmvG72eAFXDuq6b3IBV0eli5R+ySxy/VON3JphS ldGni3ny/pAxPFFA8PJkV3T+NBfKm6L7oU4VbwODzbVRAsD2VJuhIlqPEr/m5BvrECB2 qrHV7qzH+niZ6paJgu2HCOmetIFvbt79kYymuwqFMrJ8dHfyqNUy0JYdhhad2IoEKQAK W6rg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@hugovil.com header.s=x header.b=MT72ECsm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 197-20020a6300ce000000b0051b5ceff4b1si19391133pga.404.2023.04.27.13.38.35; Thu, 27 Apr 2023 13:38:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@hugovil.com header.s=x header.b=MT72ECsm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344137AbjD0UVG (ORCPT <rfc822;zxc52fgh@gmail.com> + 99 others); Thu, 27 Apr 2023 16:21:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53340 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344077AbjD0UVD (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Thu, 27 Apr 2023 16:21:03 -0400 Received: from mail.hugovil.com (mail.hugovil.com [162.243.120.170]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 850213C07; Thu, 27 Apr 2023 13:21:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=hugovil.com ; s=x; h=Subject:Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Cc:To :From:Sender:Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=wor8RugYSIQvGy88vbz6N5i586hb3K3HJiPcgNEMEes=; b=M T72ECsm2RFlWogw8EGn4a6KtLO6uq8u4tXRGYJ3oB3sNTWn7ijn914Mmh0PFdbowJAHeFBixoIGtA TeqH8bccQtKJFwcmjJ+8bMAvtj5VRNHd1dWGo36V6uLtWpOHZwY5rx0OW3F4P9lTGdVvp+z92pf52 h67p0yjgxKu/1f0I=; Received: from modemcable168.174-80-70.mc.videotron.ca ([70.80.174.168]:57646 helo=pettiford.lan) by mail.hugovil.com with esmtpa (Exim 4.92) (envelope-from <hugo@hugovil.com>) id 1ps7jV-0002hU-Am; Thu, 27 Apr 2023 15:56:49 -0400 From: Hugo Villeneuve <hugo@hugovil.com> To: Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Shawn Guo <shawnguo@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>, Pengutronix Kernel Team <kernel@pengutronix.de>, Fabio Estevam <festevam@gmail.com>, NXP Linux Team <linux-imx@nxp.com> Cc: Hugo Villeneuve <hvilleneuve@dimonoff.com>, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Date: Thu, 27 Apr 2023 15:56:38 -0400 Message-Id: <20230427195639.2718734-1-hugo@hugovil.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 70.80.174.168 X-SA-Exim-Mail-From: hugo@hugovil.com X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 Subject: [PATCH] imx8mn-var-som: dts: add SOM EEPROM X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.hugovil.com) Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1764363264160648093?= X-GMAIL-MSGID: =?utf-8?q?1764363264160648093?= |
Series |
imx8mn-var-som: dts: add SOM EEPROM
|
|
Commit Message
Hugo Villeneuve
April 27, 2023, 7:56 p.m. UTC
From: Hugo Villeneuve <hvilleneuve@dimonoff.com> The 4Kbit EEPROM located on the SOM contains hardware configuration options, manufacturing infos and ethernet MAC address. Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com> --- arch/arm64/boot/dts/freescale/imx8mn-var-som.dtsi | 10 ++++++++++ 1 file changed, 10 insertions(+)
Comments
On 27/04/2023 21:56, Hugo Villeneuve wrote: > From: Hugo Villeneuve <hvilleneuve@dimonoff.com> Thank you for your patch. There is something to discuss/improve. > > The 4Kbit EEPROM located on the SOM contains hardware configuration > options, manufacturing infos and ethernet MAC address. Use subject prefixes matching the subsystem (which you can get for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is touching). > > Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com> > --- > arch/arm64/boot/dts/freescale/imx8mn-var-som.dtsi | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mn-var-som.dtsi b/arch/arm64/boot/dts/freescale/imx8mn-var-som.dtsi > index 9052b0d4b5b4..3ed396f41e46 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mn-var-som.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mn-var-som.dtsi > @@ -30,6 +30,10 @@ reg_eth_phy: regulator-eth-phy { > gpio = <&gpio2 9 GPIO_ACTIVE_HIGH>; > enable-active-high; > }; > + > + aliases { Keep nodes ordered. > + eeprom_som = &eeprom_som; That's no valid alias. Which upstream kernel driver makes use of this? > + }; > }; > Best regards, Krzysztof
On Fri, 28 Apr 2023 15:06:22 +0200 Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > On 27/04/2023 21:56, Hugo Villeneuve wrote: > > From: Hugo Villeneuve <hvilleneuve@dimonoff.com> > > Thank you for your patch. There is something to discuss/improve. > > > > > The 4Kbit EEPROM located on the SOM contains hardware configuration > > options, manufacturing infos and ethernet MAC address. > > Use subject prefixes matching the subsystem (which you can get for > example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory > your patch is touching). > > > > > Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com> > > --- > > arch/arm64/boot/dts/freescale/imx8mn-var-som.dtsi | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mn-var-som.dtsi b/arch/arm64/boot/dts/freescale/imx8mn-var-som.dtsi > > index 9052b0d4b5b4..3ed396f41e46 100644 > > --- a/arch/arm64/boot/dts/freescale/imx8mn-var-som.dtsi > > +++ b/arch/arm64/boot/dts/freescale/imx8mn-var-som.dtsi > > @@ -30,6 +30,10 @@ reg_eth_phy: regulator-eth-phy { > > gpio = <&gpio2 9 GPIO_ACTIVE_HIGH>; > > enable-active-high; > > }; > > + > > + aliases { > > Keep nodes ordered. > > > + eeprom_som = &eeprom_som; > > That's no valid alias. Which upstream kernel driver makes use of this? Is "eeprom-som" ok? No driver uses it for now.. Hugo. > > > + }; > > }; > > > > Best regards, > Krzysztof > >
On 01/05/2023 15:45, Hugo Villeneuve wrote: > On Fri, 28 Apr 2023 15:06:22 +0200 > Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > >> On 27/04/2023 21:56, Hugo Villeneuve wrote: >>> From: Hugo Villeneuve <hvilleneuve@dimonoff.com> >> >> Thank you for your patch. There is something to discuss/improve. >> >>> >>> The 4Kbit EEPROM located on the SOM contains hardware configuration >>> options, manufacturing infos and ethernet MAC address. >> >> Use subject prefixes matching the subsystem (which you can get for >> example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory >> your patch is touching). >> >>> >>> Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com> >>> --- >>> arch/arm64/boot/dts/freescale/imx8mn-var-som.dtsi | 10 ++++++++++ >>> 1 file changed, 10 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/freescale/imx8mn-var-som.dtsi b/arch/arm64/boot/dts/freescale/imx8mn-var-som.dtsi >>> index 9052b0d4b5b4..3ed396f41e46 100644 >>> --- a/arch/arm64/boot/dts/freescale/imx8mn-var-som.dtsi >>> +++ b/arch/arm64/boot/dts/freescale/imx8mn-var-som.dtsi >>> @@ -30,6 +30,10 @@ reg_eth_phy: regulator-eth-phy { >>> gpio = <&gpio2 9 GPIO_ACTIVE_HIGH>; >>> enable-active-high; >>> }; >>> + >>> + aliases { >> >> Keep nodes ordered. >> >>> + eeprom_som = &eeprom_som; >> >> That's no valid alias. Which upstream kernel driver makes use of this? > > Is "eeprom-som" ok? > > No driver uses it for now.. None of them are valid if nothing uses them. There is also no clear meaning of this alias to me. Why "som" should denote any alias in upstream kernel? Anyway, drop it as there are no users. Best regards, Krzysztof
diff --git a/arch/arm64/boot/dts/freescale/imx8mn-var-som.dtsi b/arch/arm64/boot/dts/freescale/imx8mn-var-som.dtsi index 9052b0d4b5b4..3ed396f41e46 100644 --- a/arch/arm64/boot/dts/freescale/imx8mn-var-som.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8mn-var-som.dtsi @@ -30,6 +30,10 @@ reg_eth_phy: regulator-eth-phy { gpio = <&gpio2 9 GPIO_ACTIVE_HIGH>; enable-active-high; }; + + aliases { + eeprom_som = &eeprom_som; + }; }; &A53_0 { @@ -223,6 +227,12 @@ ldo6_reg: LDO6 { }; }; }; + + eeprom_som: eeprom@52 { + compatible = "atmel,24c04"; + reg = <0x52>; + pagesize = <16>; + }; }; &i2c3 {