Message ID | 20230501105832.1185477-2-bhupesh.sharma@linaro.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp2617166vqo; Mon, 1 May 2023 04:10:55 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5yCeBmbtBNCl7NIEmqfowQLketqbkQKgCnu8SW7WFt5rbsfseJwkKDIzbf8qEjr22Dm6gc X-Received: by 2002:a17:902:ed44:b0:1a8:1cbb:4f76 with SMTP id y4-20020a170902ed4400b001a81cbb4f76mr13678475plb.28.1682939454987; Mon, 01 May 2023 04:10:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682939454; cv=none; d=google.com; s=arc-20160816; b=LC4Zfs84mklVrnZSujteS3GboRqrXVL2wowxgoVPpWLAmFmkxZbiCvgv8d6VGmAHKC ZcpI+eH7ggbS/jJmKmifjAIiT67sjrlHAFCEKd5dnNOIBE3TMwqjtsoBePoMHu9j/n0O 0NTB4faIwG1noDitW3akIB5m80xiGU7yw6geI9+brHA+i6kSDKVBU3zOKJ0WRobGW7sW JUwGYSg6zaCUlJZeUYAdldhuoHL9rYkH61GOXtmyaPB4TCirN/+dHwK0vsrunHZDeX1r VX9bkhhSJknuEUDCcGGImHcxJxFX5i52IUUqgwMK2K7lcvvHGJXeJgk9r0hn8Jop316I qBRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=qZJiKllDLItsVzxcb83bHoOkbBzdRY7lgMq5/jA57JA=; b=OPkC5RBt5L5OIR0UrV2ySg6PMvzXKbeRD79GCNf/DkbCOVTG4A8cSkcqLsU+0BsHtD Wlwe6XZup6txnVsX6pS+8cd1eFFOHMPTdA4SR2aGvnuKf+ShqBmIft3S7JstNqpTZlPc xdjP79MfxPxEzuYbE2wLpnq6KPSQqEgMfzOTFRZMDwQGg0A+uZcTSuwnBEsxoryDH0Bi Lr5/yom9QC3/H6tLWh/5o2LYW2f9hDu8Q5iHfKULUaz4PfpZ/oANhG3fqLA1wDLWaRCT Kmx4UmIH83pebrPEAL4QgUuJPNULz29UXx+3ZZF70qLibva7hyAxmr29wezQIdd3xS1O hPIA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=DX4W5o6b; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u23-20020a1709026e1700b001a97daf438esi16455342plk.607.2023.05.01.04.10.35; Mon, 01 May 2023 04:10:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=DX4W5o6b; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232311AbjEAK6s (ORCPT <rfc822;rbbytesnap@gmail.com> + 99 others); Mon, 1 May 2023 06:58:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60768 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232301AbjEAK6q (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Mon, 1 May 2023 06:58:46 -0400 Received: from mail-pg1-x530.google.com (mail-pg1-x530.google.com [IPv6:2607:f8b0:4864:20::530]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3D5F81A1 for <linux-kernel@vger.kernel.org>; Mon, 1 May 2023 03:58:45 -0700 (PDT) Received: by mail-pg1-x530.google.com with SMTP id 41be03b00d2f7-52160f75920so1551282a12.2 for <linux-kernel@vger.kernel.org>; Mon, 01 May 2023 03:58:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1682938724; x=1685530724; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qZJiKllDLItsVzxcb83bHoOkbBzdRY7lgMq5/jA57JA=; b=DX4W5o6b4PrQ+p3HT7nrCoJI0e/LN+NRyrQ0OmB6UgMctDiA9oBPAB7lu0xkunK68m k6CnYzurg60J+iH61Va0au3DiQj5v4MT04jFWHbhDpk0n3yV/YJYm9zmw6My8r340Xav GXNILD+SvP0uqtuYhMmOCOk0CMmBoNzmoswauN/UTp2TrDxN1n1vlPxyo91z+wfIMRNY r6E4jaIQfWM6/B6/Sl7H8kmum4WkfuOuiRbbhOfzT1wWtFzhzwstMmQC+tr6CL0OvrQm xX7RQrkoVXubqXNGfZegVSOVxlbDAle0o/eiWbdu3+/QBQ8Cnu+ir2tKT97M+QglnX3J nfig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682938724; x=1685530724; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qZJiKllDLItsVzxcb83bHoOkbBzdRY7lgMq5/jA57JA=; b=ZHpbhU+h58qd9YDP2qkmmPYCl7ACtxNEeG4ESjwf8XcQeNpJXunFrSFmoPc5Qt2oYC /QpYA4c+39CQtBbO8wmeGSF6T6ICuunZ1Go0PPhG7euKGDoRfY7a2HQZqj28Ow63GVF5 nqdRsozjgl8Ms+U4lDWmqfGQ/lh93QBlIpce6Kv7WaS8XZJ5Yxf4Rz6tUEX+a2u3Ik0H ckMXkSlW5Wg7Zrt9f2XkRm2ttY/HHmvAaoxj5a/9TjhyRE0Gq5JPUo7J2TfJ/dVdMhQa gi1Lu/ogoNzl9XtJdeFzF2M4zjvJ+wQqXmwspHi8wZS88khg+r9qGLLKlhL42Pn36Swl yz9A== X-Gm-Message-State: AC+VfDxlgmoTun6BVRwckYGNWc5lFdncDkFpNfA83fbVDXZemrnqvCMB cQZRUCNHmeVgkQKHrXftKDCtQw== X-Received: by 2002:a17:903:1cb:b0:1a9:86ca:38cd with SMTP id e11-20020a17090301cb00b001a986ca38cdmr16722680plh.2.1682938724678; Mon, 01 May 2023 03:58:44 -0700 (PDT) Received: from localhost.localdomain ([2401:4900:1f3b:58fa:39f6:37e1:bb9a:a094]) by smtp.gmail.com with ESMTPSA id c24-20020a170902849800b001a50ae08284sm17569516plo.301.2023.05.01.03.58.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 May 2023 03:58:44 -0700 (PDT) From: Bhupesh Sharma <bhupesh.sharma@linaro.org> To: linux-arm-msm@vger.kernel.org Cc: agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, linux-kernel@vger.kernel.org, bhupesh.linux@gmail.com, bhupesh.sharma@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski@linaro.org, devicetree@vger.kernel.org Subject: [PATCH v2 1/3] arm64: dts: qcom: qrb4210-rb2: Add SD pinctrl states Date: Mon, 1 May 2023 16:28:30 +0530 Message-Id: <20230501105832.1185477-2-bhupesh.sharma@linaro.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20230501105832.1185477-1-bhupesh.sharma@linaro.org> References: <20230501105832.1185477-1-bhupesh.sharma@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1764689921886719329?= X-GMAIL-MSGID: =?utf-8?q?1764689921886719329?= |
Series |
arm64: dts: qcom: QRB4210-RB2 board: Enable more peripherals
|
|
Commit Message
Bhupesh Sharma
May 1, 2023, 10:58 a.m. UTC
Add the default and sleep pinctrl states for SDHC1 & 2 controllers
on QRB4210 RB2 board.
Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
---
arch/arm64/boot/dts/qcom/qrb4210-rb2.dts | 15 +++++++++++++++
1 file changed, 15 insertions(+)
Comments
On 01/05/2023 12:58, Bhupesh Sharma wrote: > Add the default and sleep pinctrl states for SDHC1 & 2 controllers > on QRB4210 RB2 board. > > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> > --- Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On 1.05.2023 12:58, Bhupesh Sharma wrote: > Add the default and sleep pinctrl states for SDHC1 & 2 controllers > on QRB4210 RB2 board. > > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> > --- > arch/arm64/boot/dts/qcom/qrb4210-rb2.dts | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts > index dc80f0bca767..5a5294cc6e45 100644 > --- a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts > +++ b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts > @@ -190,6 +190,10 @@ vreg_l24a_2p96: l24 { > }; > > &sdhc_1 { > + pinctrl-names = "default", "sleep"; > + pinctrl-0 = <&sdc1_state_on>; > + pinctrl-1 = <&sdc1_state_off>; property-n property-names Other than that: Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad > + > vmmc-supply = <&vreg_l24a_2p96>; > vqmmc-supply = <&vreg_l11a_1p8>; > no-sdio; > @@ -200,6 +204,10 @@ &sdhc_1 { > > &sdhc_2 { > cd-gpios = <&tlmm 88 GPIO_ACTIVE_HIGH>; /* card detect gpio */ > + pinctrl-names = "default", "sleep"; > + pinctrl-0 = <&sdc2_state_on &sdc2_card_det_n>; > + pinctrl-1 = <&sdc2_state_off &sdc2_card_det_n>; > + > vmmc-supply = <&vreg_l22a_2p96>; > vqmmc-supply = <&vreg_l5a_2p96>; > no-sdio; > @@ -216,6 +224,13 @@ &tlmm { > <49 1>, <52 1>, <54 1>, > <56 3>, <61 2>, <64 1>, > <68 1>, <72 8>, <96 1>; > + > + sdc2_card_det_n: sd-card-det-n-state { > + pins = "gpio88"; > + function = "gpio"; > + drive-strength = <2>; > + bias-pull-up; > + }; > }; > > &uart4 {
On Tue, 2 May 2023 at 17:27, Konrad Dybcio <konrad.dybcio@linaro.org> wrote: > > On 1.05.2023 12:58, Bhupesh Sharma wrote: > > Add the default and sleep pinctrl states for SDHC1 & 2 controllers > > on QRB4210 RB2 board. > > > > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> > > --- > > arch/arm64/boot/dts/qcom/qrb4210-rb2.dts | 15 +++++++++++++++ > > 1 file changed, 15 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts > > index dc80f0bca767..5a5294cc6e45 100644 > > --- a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts > > +++ b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts > > @@ -190,6 +190,10 @@ vreg_l24a_2p96: l24 { > > }; > > > > &sdhc_1 { > > + pinctrl-names = "default", "sleep"; > > + pinctrl-0 = <&sdc1_state_on>; > > + pinctrl-1 = <&sdc1_state_off>; > property-n > property-names > > Other than that: > Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Sure, let me fix this in v3. Thanks, Bhupesh
diff --git a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts index dc80f0bca767..5a5294cc6e45 100644 --- a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts +++ b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts @@ -190,6 +190,10 @@ vreg_l24a_2p96: l24 { }; &sdhc_1 { + pinctrl-names = "default", "sleep"; + pinctrl-0 = <&sdc1_state_on>; + pinctrl-1 = <&sdc1_state_off>; + vmmc-supply = <&vreg_l24a_2p96>; vqmmc-supply = <&vreg_l11a_1p8>; no-sdio; @@ -200,6 +204,10 @@ &sdhc_1 { &sdhc_2 { cd-gpios = <&tlmm 88 GPIO_ACTIVE_HIGH>; /* card detect gpio */ + pinctrl-names = "default", "sleep"; + pinctrl-0 = <&sdc2_state_on &sdc2_card_det_n>; + pinctrl-1 = <&sdc2_state_off &sdc2_card_det_n>; + vmmc-supply = <&vreg_l22a_2p96>; vqmmc-supply = <&vreg_l5a_2p96>; no-sdio; @@ -216,6 +224,13 @@ &tlmm { <49 1>, <52 1>, <54 1>, <56 3>, <61 2>, <64 1>, <68 1>, <72 8>, <96 1>; + + sdc2_card_det_n: sd-card-det-n-state { + pins = "gpio88"; + function = "gpio"; + drive-strength = <2>; + bias-pull-up; + }; }; &uart4 {