[-next] gpio: brcmstb: Use devm_platform_get_and_ioremap_resource()

Message ID 20230428061109.102343-1-yang.lee@linux.alibaba.com
State New
Headers
Series [-next] gpio: brcmstb: Use devm_platform_get_and_ioremap_resource() |

Commit Message

Yang Li April 28, 2023, 6:11 a.m. UTC
  Convert platform_get_resource(), devm_ioremap_resource() to a single
call to devm_platform_get_and_ioremap_resource(), as this is exactly
what this function does.

Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
 drivers/gpio/gpio-brcmstb.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
  

Comments

Florian Fainelli April 28, 2023, 5:42 p.m. UTC | #1
On 4/27/23 23:11, Yang Li wrote:
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
> 
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>

Acked-by: Florian Fainelli <f.fainelli@gmail.com>
  
Doug Berger April 28, 2023, 6:51 p.m. UTC | #2
On 4/27/2023 11:11 PM, Yang Li wrote:
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
> 
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
>   drivers/gpio/gpio-brcmstb.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/gpio/gpio-brcmstb.c b/drivers/gpio/gpio-brcmstb.c
> index c55b35da61a0..6566517fe0d8 100644
> --- a/drivers/gpio/gpio-brcmstb.c
> +++ b/drivers/gpio/gpio-brcmstb.c
> @@ -609,8 +609,7 @@ static int brcmstb_gpio_probe(struct platform_device *pdev)
>   	platform_set_drvdata(pdev, priv);
>   	INIT_LIST_HEAD(&priv->bank_list);
>   
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	reg_base = devm_ioremap_resource(dev, res);
> +	reg_base = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
>   	if (IS_ERR(reg_base))
>   		return PTR_ERR(reg_base);
>   
Acked-by: Doug Berger <opendmb@gmail.com>
  
Linus Walleij May 8, 2023, 1:31 p.m. UTC | #3
On Fri, Apr 28, 2023 at 8:11 AM Yang Li <yang.lee@linux.alibaba.com> wrote:

> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>

Looks good
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij
  
Bartosz Golaszewski May 23, 2023, 8:24 a.m. UTC | #4
On Fri, Apr 28, 2023 at 8:11 AM Yang Li <yang.lee@linux.alibaba.com> wrote:
>
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
>  drivers/gpio/gpio-brcmstb.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-brcmstb.c b/drivers/gpio/gpio-brcmstb.c
> index c55b35da61a0..6566517fe0d8 100644
> --- a/drivers/gpio/gpio-brcmstb.c
> +++ b/drivers/gpio/gpio-brcmstb.c
> @@ -609,8 +609,7 @@ static int brcmstb_gpio_probe(struct platform_device *pdev)
>         platform_set_drvdata(pdev, priv);
>         INIT_LIST_HEAD(&priv->bank_list);
>
> -       res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -       reg_base = devm_ioremap_resource(dev, res);
> +       reg_base = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
>         if (IS_ERR(reg_base))
>                 return PTR_ERR(reg_base);
>
> --
> 2.20.1.7.g153144c
>

Applied, thanks!

Bart
  

Patch

diff --git a/drivers/gpio/gpio-brcmstb.c b/drivers/gpio/gpio-brcmstb.c
index c55b35da61a0..6566517fe0d8 100644
--- a/drivers/gpio/gpio-brcmstb.c
+++ b/drivers/gpio/gpio-brcmstb.c
@@ -609,8 +609,7 @@  static int brcmstb_gpio_probe(struct platform_device *pdev)
 	platform_set_drvdata(pdev, priv);
 	INIT_LIST_HEAD(&priv->bank_list);
 
-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	reg_base = devm_ioremap_resource(dev, res);
+	reg_base = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
 	if (IS_ERR(reg_base))
 		return PTR_ERR(reg_base);