Message ID | 53930ee1-da0f-0c33-cd6d-1d936584ffdd@linux.ibm.com |
---|---|
State | New, archived |
Headers |
Return-Path: <gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:ecc5:0:0:0:0:0 with SMTP id s5csp142526wro; Wed, 31 Aug 2022 02:34:17 -0700 (PDT) X-Google-Smtp-Source: AA6agR7g/W3VL3NoUFGYgjUuJ/rllRF4sh4XNqW7Smzxd0B89nGasEwipoaRM/B2avQkGwukG2V7 X-Received: by 2002:a17:907:c05:b0:73d:6e0a:8d22 with SMTP id ga5-20020a1709070c0500b0073d6e0a8d22mr19524900ejc.646.1661938457458; Wed, 31 Aug 2022 02:34:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661938457; cv=none; d=google.com; s=arc-20160816; b=on/XXodUw1wetyxxXmyjoGn1i90oShOxUcYxWJL+KngWX11lrgH81eTbCXKKen+r85 FN8eLbfMY6VjjP7Rw2+c/f8OI9coaOTze+5Nlkz9A0UA0RqtucqInxAgWC8nSPRY7hCV ZPVDdVP/LSQaBE1m+P97s6/aU9ZOCZs/QqLHoDNgpJzYbu0Ln0LoPor29u0nwyXw64/L t5Cxapjb2nY0vW226Wn5vZ+D4lJysM3UxP2ElZl5/xd/ItsAShRBscSDBqjeDCbCAVdG wUeo2eHX+RUmJqQHYyfkDjNkZnf4H9xniEBihUs4hxpzngREhE5iWBfQub3BJ3b8yfs/ NLxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:reply-to:from:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence :content-transfer-encoding:subject:to:content-language:user-agent :mime-version:date:message-id:dmarc-filter:delivered-to :dkim-signature:dkim-filter; bh=AA35qAAqOTTkqFXhHturxM1qSl14PtS9HEZtmizBvbY=; b=jZHeR6AJmK8n31aWF57GwzpgkCKIQ8hTRB+M3Jpd7q04NousdyFqEncZ817/pKkrfY C5B+mPejHq3pRTnZhSw+nHdtSbv2wn5u1Ut7++/eQgZus6oPRv8bOdmXBJ+sUvhOwlAT ZnKSVoLiZX1VBLxm1PDcX8gqe6pp2Wtup8TQQy4PUopnEzikzhBFgCh95vKqoh18eFZj kb0nZyGUvD6lsyqnasrEeJ34pZOZdPGf9n4TZwuPIkmY5OHzR8uDi16RthgCvlJ8XUrb tIV8ZyAvEwSSl2dXTE+fpN/ZG0LwiOYIPUa4Rp2Z2JpYBuv6iULNqVWRD3AK8TW+Ug2B KuAg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=P2X7NajO; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id ji6-20020a170907980600b0072f2e1425a3si13288905ejc.774.2022.08.31.02.34.17 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 31 Aug 2022 02:34:17 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=P2X7NajO; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 28B89383CCFE for <ouuuleilei@gmail.com>; Wed, 31 Aug 2022 09:34:16 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 28B89383CCFE DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1661938456; bh=AA35qAAqOTTkqFXhHturxM1qSl14PtS9HEZtmizBvbY=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=P2X7NajOH/pnYQZBJkd9fbfUDaiaLILVVwNViMy7fLf2R76mhrT9FcCqDxWOzN4hM uze5fFFzgIPmALrfcUxav0Tmsdc+kZvWG970Fe5e03mMYlfdAvwC3bajDHUJEfe1pW obS1pM0ipVXgCMIvjuf7txPb98S+Lbsrub18VRaw= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 3D2963858C52 for <gcc-patches@gcc.gnu.org>; Wed, 31 Aug 2022 09:33:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3D2963858C52 Received: from pps.filterd (m0187473.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 27V8JQms025623; Wed, 31 Aug 2022 09:33:30 GMT Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3ja41jamwq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 31 Aug 2022 09:33:29 +0000 Received: from m0187473.ppops.net (m0187473.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 27V8mI9B010593; Wed, 31 Aug 2022 09:33:29 GMT Received: from ppma06ams.nl.ibm.com (66.31.33a9.ip4.static.sl-reverse.com [169.51.49.102]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3ja41jamvn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 31 Aug 2022 09:33:29 +0000 Received: from pps.filterd (ppma06ams.nl.ibm.com [127.0.0.1]) by ppma06ams.nl.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 27V9Losr017075; Wed, 31 Aug 2022 09:33:27 GMT Received: from b06avi18626390.portsmouth.uk.ibm.com (b06avi18626390.portsmouth.uk.ibm.com [9.149.26.192]) by ppma06ams.nl.ibm.com with ESMTP id 3j7ahj527a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 31 Aug 2022 09:33:26 +0000 Received: from d06av23.portsmouth.uk.ibm.com (d06av23.portsmouth.uk.ibm.com [9.149.105.59]) by b06avi18626390.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 27V9U9Wp14156130 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 31 Aug 2022 09:30:09 GMT Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 99853A4059; Wed, 31 Aug 2022 09:33:24 +0000 (GMT) Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 09EA9A4051; Wed, 31 Aug 2022 09:33:23 +0000 (GMT) Received: from [9.197.247.44] (unknown [9.197.247.44]) by d06av23.portsmouth.uk.ibm.com (Postfix) with ESMTP; Wed, 31 Aug 2022 09:33:22 +0000 (GMT) Message-ID: <53930ee1-da0f-0c33-cd6d-1d936584ffdd@linux.ibm.com> Date: Wed, 31 Aug 2022 17:33:21 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Content-Language: en-US To: GCC Patches <gcc-patches@gcc.gnu.org> Subject: [PATCH] rs6000/test: Fix typo in pr86731-fwrapv-longlong.c [PR106682] Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: 8H-b_cGp9By7dPGaWZ6hXzPI7Cr9S_2C X-Proofpoint-GUID: 5F-nSUE50E2D81iCNLBfhvnAKGyCuH6r X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-08-31_05,2022-08-31_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 priorityscore=1501 clxscore=1015 mlxlogscore=999 spamscore=0 bulkscore=0 malwarescore=0 phishscore=0 impostorscore=0 mlxscore=0 adultscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2207270000 definitions=main-2208310047 X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org> List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe> List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/> List-Post: <mailto:gcc-patches@gcc.gnu.org> List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help> List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe> From: "Kewen.Lin via Gcc-patches" <gcc-patches@gcc.gnu.org> Reply-To: "Kewen.Lin" <linkw@linux.ibm.com> Cc: Peter Bergner <bergner@linux.ibm.com>, David Edelsohn <dje.gcc@gmail.com>, Segher Boessenkool <segher@kernel.crashing.org> Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" <gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org> X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1742668779748945243?= X-GMAIL-MSGID: =?utf-8?q?1742668779748945243?= |
Series |
rs6000/test: Fix typo in pr86731-fwrapv-longlong.c [PR106682]
|
|
Commit Message
Kewen.Lin
Aug. 31, 2022, 9:33 a.m. UTC
Hi, Commit r12-2266 updated the scanned assembly content from "{\mlvx\M|\mlxv\M|\mlxvd2x\M}" to "{\mp?lxv\M|\mlxv\M|\mlxvd2x\M}" for the test case pr86731-fwrapv-longlong.c unexpectedly. It's meant to update "lxv" to "p?lxv" and should leave the "lvx" unchanged. So this is to fix the typo accordingly. Tested on powerpc64-linux-gnu P7 and P8, and powerpc64le-linux-gnu P9 and P10. I'll push this soon if no objections. BR, Kewen ----- PR testsuite/106682 gcc/testsuite/ChangeLog: * gcc.target/powerpc/pr86731-fwrapv-longlong.c: Fix typo. --- gcc/testsuite/gcc.target/powerpc/pr86731-fwrapv-longlong.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.25.1
Comments
On 8/31/22 4:33 AM, Kewen.Lin via Gcc-patches wrote: > Commit r12-2266 updated the scanned assembly content from > > "{\mlvx\M|\mlxv\M|\mlxvd2x\M}" > > to > > "{\mp?lxv\M|\mlxv\M|\mlxvd2x\M}" > > for the test case pr86731-fwrapv-longlong.c unexpectedly. > > It's meant to update "lxv" to "p?lxv" and should leave the > "lvx" unchanged. So this is to fix the typo accordingly. I agree. Thanks for catching this! Peter
On Wed, Aug 31, 2022 at 05:33:21PM +0800, Kewen.Lin wrote: > It's meant to update "lxv" to "p?lxv" and should leave the > "lvx" unchanged. So this is to fix the typo accordingly. > > I'll push this soon if no objections. Please go ahead. Out of interest, did you see failures from this, was it just by visual inspection, something else? Thanks, Segher
Hi Segher & Peter, Thanks for your reviews! on 2022/8/31 23:12, Segher Boessenkool wrote: > On Wed, Aug 31, 2022 at 05:33:21PM +0800, Kewen.Lin wrote: >> It's meant to update "lxv" to "p?lxv" and should leave the >> "lvx" unchanged. So this is to fix the typo accordingly. >> >> I'll push this soon if no objections. > > Please go ahead. Out of interest, did you see failures from this, was > it just by visual inspection, something else? > I did reproduce the failure for this test case on ppc64 P8 machine. :) For the other test cases updated by commit r12-2266, I did a quick visual inspection on them instead of actually testing them, there are some other typos but they have been fixed by r12-2889-g8464894c86b03e. To avoid some to escape, I just tested the other cases on ppc64 P8 and ppc64le P9 and P10, no failures were found. So committed as r13-2332-g023c5b36e47697. Thanks! BR, Kewen
diff --git a/gcc/testsuite/gcc.target/powerpc/pr86731-fwrapv-longlong.c b/gcc/testsuite/gcc.target/powerpc/pr86731-fwrapv-longlong.c index dcb30e1d886..018e1cf9749 100644 --- a/gcc/testsuite/gcc.target/powerpc/pr86731-fwrapv-longlong.c +++ b/gcc/testsuite/gcc.target/powerpc/pr86731-fwrapv-longlong.c @@ -31,5 +31,5 @@ vector signed long long splats4(void) /* { dg-final { scan-assembler-times {\mvspltis[bhw]\M} 0 } } */ /* { dg-final { scan-assembler-times {\mvsl[bhwd]\M} 0 } } */ -/* { dg-final { scan-assembler-times {\mp?lxv\M|\mlxv\M|\mlxvd2x\M|\mxxspltidp\M} 2 } } */ +/* { dg-final { scan-assembler-times {\mp?lxv\M|\mlvx\M|\mlxvd2x\M|\mxxspltidp\M} 2 } } */