Message ID | 20230421133922.8520-2-quic_shazhuss@quicinc.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1077686vqo; Fri, 21 Apr 2023 06:45:00 -0700 (PDT) X-Google-Smtp-Source: AKy350Zo688ZEBeMq80aK4UVE0fgG6gGshe7focuT5uYbxs7dTnUE351XDhONyLNQtizgNHPpa2A X-Received: by 2002:a05:6a00:2406:b0:63d:38aa:5617 with SMTP id z6-20020a056a00240600b0063d38aa5617mr4518590pfh.6.1682084700121; Fri, 21 Apr 2023 06:45:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682084700; cv=none; d=google.com; s=arc-20160816; b=0SPHNhHz00JbrIf51xpsOO+rEU3Ycf/GYWX8J4T9FAW6VmxLXRFxfGNS7mUrbvlS8P xRAsTV0fmFJb2qIth+qdE3TY/v/DBMWZ9lvMnVb0fIQ7bCoEhf9/3ljDPhedM/8wMOiF 6HfJFNtdeKbHQUvPdXlr/pmTBrSV+guU2Jq1MysJ7tqAXCSjRaSTA1UBFhwabxOlpyNy DCsQtoUYm27P9vsiNXz/Mm/OrKZn3y2gE1TSkcqpmEt/D5rzeyZU1d6AolaMo4A8zuUO QimpzMXyd1B7SM4U1C9iS1bB15BEHbHLeo/1UxUcJTWZaBigP1sdQKMguUXl9+qN6nq0 BDKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=cMWDrilQuXY13Cwc8mXfvSAytR6jNuLiIsH73U6fgio=; b=JG5FV1gcea/iKJ233U3qcW93eVlrlJrD+x0xeQYXEGzfVwmnEW8gabOe0RCIAuN/EJ 8o8ibg04pLUMSgF8RxB3L3qLuMslJlC5LM/PJuBtqixqM1tRtvEExpZeaQb5vHSqzKcr plnfFwNP2Tl1wMH3agu1sP4nUImwLgKWiU7JTzHiZm+sXfrArTPNUqumNDIe/wv/7P1T K3feU0ebW/jAGVL2zTdNVEy/Qrfffdov3nK0EBN8Hjxpn3y7mw+6eXpU7VwqsDlLbHvp jUTAvzDXssrRD6MAvXuFjsV6cqQFo3Cl/NHdnYUvbxrMf5SSOKbimr6VHiLhmbmf3UJI CvWw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=iQcoDNIQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v5-20020aa799c5000000b0063f1cb928bdsi1123428pfi.313.2023.04.21.06.44.47; Fri, 21 Apr 2023 06:45:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=iQcoDNIQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232508AbjDUNkU (ORCPT <rfc822;cjcooper78@gmail.com> + 99 others); Fri, 21 Apr 2023 09:40:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55666 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230205AbjDUNkP (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 21 Apr 2023 09:40:15 -0400 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8CBF4CC03; Fri, 21 Apr 2023 06:40:14 -0700 (PDT) Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 33LC7FBe010059; Fri, 21 Apr 2023 13:40:08 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type; s=qcppdkim1; bh=cMWDrilQuXY13Cwc8mXfvSAytR6jNuLiIsH73U6fgio=; b=iQcoDNIQuo4zNlVj8kJmA2/nIQc7rsj/3QPUzvZGugfMS4aXH4N9lolMQCQGMRZEhbpm +sHlhmfKrS33ET0tblO/FLiU8II2aZs3McHUg7fxwkqu77X+5R2uPvGRUYP6eAPCJ/4R pntsGTTq0CYwXsa+ZWl0UFemIV4FgG1wyehM1QZ4VgVqc8ptR7W4iwcM+w3zEHmDgSND AGzevgJ96TPdzlFT3dyLMX7Lx6tDITtElcDSxf1YtlujwpLAsq8pqWuBi3OsJEQZ5iUf 7I5eVSAYSADQzw39q65ZjF83lDInhBt0OW1OpiNNX3HtiJa0idU5ezy3NyjqunPnPRRG 6w== Received: from nalasppmta01.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3q3dcmhpy5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 21 Apr 2023 13:40:08 +0000 Received: from nalasex01b.na.qualcomm.com (nalasex01b.na.qualcomm.com [10.47.209.197]) by NALASPPMTA01.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 33LDe79C031978 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 21 Apr 2023 13:40:07 GMT Received: from hu-shazhuss-hyd.qualcomm.com (10.80.80.8) by nalasex01b.na.qualcomm.com (10.47.209.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.42; Fri, 21 Apr 2023 06:40:02 -0700 From: Shazad Hussain <quic_shazhuss@quicinc.com> To: <agross@kernel.org>, <andersson@kernel.org>, <robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org> CC: Shazad Hussain <quic_shazhuss@quicinc.com>, Konrad Dybcio <konrad.dybcio@linaro.org>, Vinod Koul <vkoul@kernel.org>, "Kishon Vijay Abraham I" <kishon@kernel.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Wesley Cheng <quic_wcheng@quicinc.com>, <linux-arm-msm@vger.kernel.org>, <linux-phy@lists.infradead.org>, <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linux-usb@vger.kernel.org> Subject: [PATCH v1 1/6] dt-bindings: usb: qcom,dwc3: Add bindings for SA8775P Date: Fri, 21 Apr 2023 19:09:16 +0530 Message-ID: <20230421133922.8520-2-quic_shazhuss@quicinc.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230421133922.8520-1-quic_shazhuss@quicinc.com> References: <20230421133922.8520-1-quic_shazhuss@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01b.na.qualcomm.com (10.47.209.197) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: Ros5LPtWPtWqGFJ62JxwrLRYnNOD09w- X-Proofpoint-GUID: Ros5LPtWPtWqGFJ62JxwrLRYnNOD09w- X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-04-21_06,2023-04-21_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 lowpriorityscore=0 adultscore=0 phishscore=0 spamscore=0 impostorscore=0 mlxlogscore=654 malwarescore=0 suspectscore=0 clxscore=1015 mlxscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000 definitions=main-2304210119 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1763793646062053908?= X-GMAIL-MSGID: =?utf-8?q?1763793646062053908?= |
Series |
arm64: qcom: sa8775p: add support for USB
|
|
Commit Message
Shazad Hussain
April 21, 2023, 1:39 p.m. UTC
Add the compatible string for SA8775P SoC from Qualcomm.
Set minItems to 3 for interrupts as usb2 i.e third usb port supports
only high speed mode and does not require ss_phy_irq.
Signed-off-by: Shazad Hussain <quic_shazhuss@quicinc.com>
---
Documentation/devicetree/bindings/usb/qcom,dwc3.yaml | 5 +++++
1 file changed, 5 insertions(+)
Comments
On Fri, Apr 21, 2023 at 07:09:16PM +0530, Shazad Hussain wrote: > Add the compatible string for SA8775P SoC from Qualcomm. > > Set minItems to 3 for interrupts as usb2 i.e third usb port supports > only high speed mode and does not require ss_phy_irq. > > Signed-off-by: Shazad Hussain <quic_shazhuss@quicinc.com> > --- > Documentation/devicetree/bindings/usb/qcom,dwc3.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml > index d84281926f10..3ae02cffae49 100644 > --- a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml > +++ b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml > @@ -23,6 +23,7 @@ properties: > - qcom,msm8998-dwc3 > - qcom,qcm2290-dwc3 > - qcom,qcs404-dwc3 > + - qcom,sa8775p-dwc3 > - qcom,sc7180-dwc3 > - qcom,sc7280-dwc3 > - qcom,sc8280xp-dwc3 > @@ -180,6 +181,7 @@ allOf: > - qcom,msm8953-dwc3 > - qcom,msm8996-dwc3 > - qcom,msm8998-dwc3 > + - qcom,sa8775p-dwc3 > - qcom,sc7180-dwc3 > - qcom,sc7280-dwc3 > - qcom,sdm670-dwc3 > @@ -443,12 +445,15 @@ allOf: > compatible: > contains: > enum: > + - qcom,sa8775p-dwc3 > - qcom,sc8280xp-dwc3 > then: > properties: > interrupts: > + minItems: 3 Now 3 interrupts is valid for qcom,sc8280xp-dwc3? > maxItems: 4 > interrupt-names: > + minItems: 3 > items: > - const: pwr_event > - const: dp_hs_phy_irq > -- > 2.17.1 >
On 4/27/2023 7:52 PM, Rob Herring wrote: > On Fri, Apr 21, 2023 at 07:09:16PM +0530, Shazad Hussain wrote: >> Add the compatible string for SA8775P SoC from Qualcomm. >> >> Set minItems to 3 for interrupts as usb2 i.e third usb port supports >> only high speed mode and does not require ss_phy_irq. >> >> Signed-off-by: Shazad Hussain <quic_shazhuss@quicinc.com> >> --- >> Documentation/devicetree/bindings/usb/qcom,dwc3.yaml | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml >> index d84281926f10..3ae02cffae49 100644 >> --- a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml >> +++ b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml >> @@ -23,6 +23,7 @@ properties: >> - qcom,msm8998-dwc3 >> - qcom,qcm2290-dwc3 >> - qcom,qcs404-dwc3 >> + - qcom,sa8775p-dwc3 >> - qcom,sc7180-dwc3 >> - qcom,sc7280-dwc3 >> - qcom,sc8280xp-dwc3 >> @@ -180,6 +181,7 @@ allOf: >> - qcom,msm8953-dwc3 >> - qcom,msm8996-dwc3 >> - qcom,msm8998-dwc3 >> + - qcom,sa8775p-dwc3 >> - qcom,sc7180-dwc3 >> - qcom,sc7280-dwc3 >> - qcom,sdm670-dwc3 >> @@ -443,12 +445,15 @@ allOf: >> compatible: >> contains: >> enum: >> + - qcom,sa8775p-dwc3 >> - qcom,sc8280xp-dwc3 >> then: >> properties: >> interrupts: >> + minItems: 3 > > Now 3 interrupts is valid for qcom,sc8280xp-dwc3? > Hi Rob, I was under the impression from [1] that usb_2 for sc8280xp has only 3 irq's, but it seems it does required all 4 irq's. I would take care of this in next version of the patch. Thanks for pointing it out. [1]: https://lore.kernel.org/lkml/20230405125759.4201-7-quic_kriskura@quicinc.com/ >> maxItems: 4 >> interrupt-names: >> + minItems: 3 >> items: >> - const: pwr_event >> - const: dp_hs_phy_irq >> -- >> 2.17.1 >> -Shazad
diff --git a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml index d84281926f10..3ae02cffae49 100644 --- a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml +++ b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml @@ -23,6 +23,7 @@ properties: - qcom,msm8998-dwc3 - qcom,qcm2290-dwc3 - qcom,qcs404-dwc3 + - qcom,sa8775p-dwc3 - qcom,sc7180-dwc3 - qcom,sc7280-dwc3 - qcom,sc8280xp-dwc3 @@ -180,6 +181,7 @@ allOf: - qcom,msm8953-dwc3 - qcom,msm8996-dwc3 - qcom,msm8998-dwc3 + - qcom,sa8775p-dwc3 - qcom,sc7180-dwc3 - qcom,sc7280-dwc3 - qcom,sdm670-dwc3 @@ -443,12 +445,15 @@ allOf: compatible: contains: enum: + - qcom,sa8775p-dwc3 - qcom,sc8280xp-dwc3 then: properties: interrupts: + minItems: 3 maxItems: 4 interrupt-names: + minItems: 3 items: - const: pwr_event - const: dp_hs_phy_irq