Message ID | 20230424144949.244135-4-nm@ti.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp2808944vqo; Mon, 24 Apr 2023 08:04:51 -0700 (PDT) X-Google-Smtp-Source: AKy350aNkeqvA0zwJ1B5wRLNArvFbRMKudKQ0Ba4vxgZkd+qzS7AWAWy0upJTNkdcnr1hOuXRIlb X-Received: by 2002:a05:6a00:2e06:b0:63a:33d5:9224 with SMTP id fc6-20020a056a002e0600b0063a33d59224mr19088117pfb.18.1682348691546; Mon, 24 Apr 2023 08:04:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682348691; cv=none; d=google.com; s=arc-20160816; b=N6jyMneLRGLOZiEPyXQYgS/jyukAu8mIVPcm/RHwfFDIHdKNBoZPHfztxzQ94/AUXi cAIvdcTX5MuRdAk0UqxaxPGVGuhe1Mx7gAhBjb3oMhZVdk/cfzqRz9wflhjx4CLKA7cR G6NPKEtT6RtkhzHCwauNwU9Bth4Fe5l4iP6NAksMoLRSLHDtVZoBEeP1tfOf5fMd1FLl x/YUg2C5qvuXooIWdv5jymBhCjgiP7o239rhGiptuZXvjid7xUrUfw41W1Ryn9WYyfQM ZBWxvyPmczkJMF0aJXhgxHi/PmFX6TAkQqYrHyRgIVnCiIH+WYQuaDUmmKB4pHH1xbno 0b6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=nUVFPlYCg/KaMwB8INGoLdagVjzw0UIPdMOQDZkIhgs=; b=tROIWNZDPiB5wMsOujlpSemJnuE0EST9vBDq8zz43MQOQyYhKK6afG4X8nP4XDKZKB 8vfe+aRQ43XjjeKV5y0Ste9HW039JbcJ744PLM5C+1bNG/iNnXJG6pn3/EhYxcAqTfPF WW8ziefBLXVv9Tb7Jw0XppEVVYc2s6zKJ1C0Z95ye42qf5IBE4q6UUeuytOyRA23wPcb grF5iG0cLmYj6jgCy+OIp2JZeOjbgpcNoH+8K9ViHVCoGQ8s/mqJLwaeshpKOfchZa57 0Ljxdqj7AL0A+9pV3Ycwa+fQRzyPN0H48NJH+ZEqGKJb6mDSmW5xvCmNi+HwwyrzH5Nz 1LcQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=gCDcOGMR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u62-20020a638541000000b00525048cb4dasi4857293pgd.555.2023.04.24.08.04.36; Mon, 24 Apr 2023 08:04:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=gCDcOGMR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231946AbjDXOum (ORCPT <rfc822;fengqi706@gmail.com> + 99 others); Mon, 24 Apr 2023 10:50:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39500 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231770AbjDXOuf (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Mon, 24 Apr 2023 10:50:35 -0400 Received: from fllv0015.ext.ti.com (fllv0015.ext.ti.com [198.47.19.141]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 83A0A6E94; Mon, 24 Apr 2023 07:50:21 -0700 (PDT) Received: from fllv0034.itg.ti.com ([10.64.40.246]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 33OEnqnF031813; Mon, 24 Apr 2023 09:49:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1682347792; bh=nUVFPlYCg/KaMwB8INGoLdagVjzw0UIPdMOQDZkIhgs=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=gCDcOGMR0mxTPUHJiLI5JQCUebhQPs1mkxeNIVrvk/0eG55UqpFgP1ukQdIZ8w7em 7PBEUV144kNlPOTknFC0VmCHIxXUlxDKkgtDNRit1M6ioQiaPe5wIr89lTW12QnKHz AxIX2ISkvjx0lxnIUP47tjs7i3/b0V82gBffCgOc= Received: from DLEE105.ent.ti.com (dlee105.ent.ti.com [157.170.170.35]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 33OEnqPs128767 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 24 Apr 2023 09:49:52 -0500 Received: from DLEE101.ent.ti.com (157.170.170.31) by DLEE105.ent.ti.com (157.170.170.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16; Mon, 24 Apr 2023 09:49:51 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DLEE101.ent.ti.com (157.170.170.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16 via Frontend Transport; Mon, 24 Apr 2023 09:49:52 -0500 Received: from localhost (ileaxei01-snat2.itg.ti.com [10.180.69.6]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 33OEnqlJ021005; Mon, 24 Apr 2023 09:49:52 -0500 From: Nishanth Menon <nm@ti.com> To: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Rob Herring <robh+dt@kernel.org>, Vignesh Raghavendra <vigneshr@ti.com> CC: <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, Tero Kristo <kristo@kernel.org>, Nishanth Menon <nm@ti.com>, Jan Kiszka <jan.kiszka@siemens.com> Subject: [PATCH 3/7] arm64: dts: ti: k3-am65: Switch to "ti,j721e-system-controller" compatible Date: Mon, 24 Apr 2023 09:49:45 -0500 Message-ID: <20230424144949.244135-4-nm@ti.com> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230424144949.244135-1-nm@ti.com> References: <20230424144949.244135-1-nm@ti.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1764070461834681672?= X-GMAIL-MSGID: =?utf-8?q?1764070461834681672?= |
Series |
arm64: dts: ti: k3-am65: dtbs_check warnings fixups
|
|
Commit Message
Nishanth Menon
April 24, 2023, 2:49 p.m. UTC
Switch scm-conf to "ti,j721e-system-controller" compatible to be more
specific.
Signed-off-by: Nishanth Menon <nm@ti.com>
---
arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 2 +-
arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
Comments
On 4/24/23 9:49 AM, Nishanth Menon wrote: > Switch scm-conf to "ti,j721e-system-controller" compatible to be more > specific. > > Signed-off-by: Nishanth Menon <nm@ti.com> > --- > arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 2 +- > arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi > index 227573773b26..40fa631f2f3d 100644 > --- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi > @@ -475,7 +475,7 @@ sdhci1: mmc@4fa0000 { > }; > > scm_conf: scm-conf@100000 { > - compatible = "syscon", "simple-mfd"; > + compatible = "ti,j721e-system-controller", "syscon", "simple-mfd"; > reg = <0 0x00100000 0 0x1c000>; > #address-cells = <1>; > #size-cells = <1>; > diff --git a/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi b/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi > index 5dfa31840e9c..566dc584d3f3 100644 > --- a/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi > @@ -7,7 +7,7 @@ > > &cbass_mcu { > mcu_conf: scm-conf@40f00000 { > - compatible = "syscon", "simple-mfd"; > + compatible = "ti,j721e-system-controller", "syscon", "simple-mfd"; This node is not a "j721e-system-controller". Only the one in main could be said to be one, but even it is different enough that this is not correct IMHO. It almost seems like you are using "ti,j721e-system-controller" as a workaround for the restriction on raw "syscon", "simple-mfd" nodes. And just replacing all instance of those with something that avoids the warning. What we should do here is turn both of these nodes into "simple-bus". The sub-nodes themselves would describe what they are. This is the normal DT way vs having all our device nodes pointing into one big "syscon" node with various offsets (which makes it hard to see all users of a node and near impossible to work out the real memory map in these "system-controller" nodes). Worse, if the parent is a "syscon" then the whole memory region gets one big regmap over it, and any child nodes that also build a regmap for their smaller sub-range leads to having two regmaps pointing to the same memory area. This breaks some assumptions around atomic access and reg caching. Taking a quick look I see some of our sub-node drivers expecting the parent to always be a syscon, others turn themselves into a syscon, and others still do the normal "reg" mapping. What a mess.. To unwind this I'd suggest we do this: * Add support for these sub-node drivers to use the normal "reg" property by default if available, falling back to expecting the parent to be a syscon only for backwards compatibility. * Add "reg" properties to the sub-nodes. * Remove "syscon" from our system-controller nodes and instead use "simple-bus". Which more accurately describes what these regions are, and prevents issues like having a regmap over gaps (as these system-controller have gaps in between the sub device memory regions) We would still have to add simple compatibles for the efuse and pcie mode/id regions, but that is much more correct than hiding them in the device's node like done in patch 1/7 of this series. Andrew > reg = <0x0 0x40f00000 0x0 0x20000>; > #address-cells = <1>; > #size-cells = <1>;
diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi index 227573773b26..40fa631f2f3d 100644 --- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi +++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi @@ -475,7 +475,7 @@ sdhci1: mmc@4fa0000 { }; scm_conf: scm-conf@100000 { - compatible = "syscon", "simple-mfd"; + compatible = "ti,j721e-system-controller", "syscon", "simple-mfd"; reg = <0 0x00100000 0 0x1c000>; #address-cells = <1>; #size-cells = <1>; diff --git a/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi b/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi index 5dfa31840e9c..566dc584d3f3 100644 --- a/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi +++ b/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi @@ -7,7 +7,7 @@ &cbass_mcu { mcu_conf: scm-conf@40f00000 { - compatible = "syscon", "simple-mfd"; + compatible = "ti,j721e-system-controller", "syscon", "simple-mfd"; reg = <0x0 0x40f00000 0x0 0x20000>; #address-cells = <1>; #size-cells = <1>;