[v4,3/4] staging: rtl8192e: Remove unused _rtl92e_wx_set_sens function
Commit Message
After removal of rf_set_sens variable, the _rtl92e_wx_set_sens function
always returns an error code.
This commit removes the unused function and the respective ioctl.
Suggested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Signed-off-by: Yogesh Hegde <yogi.kernel@gmail.com>
---
Changes in v4:
1. Split changes into patch series per feedback from
gregkh@linuxfoundation.org
Changes in v3:
-- None
Changes in v2:
-- None
Changes in v1:
-- None
---
drivers/staging/rtl8192e/rtl8192e/rtl_wx.c | 20 --------------------
1 file changed, 20 deletions(-)
Comments
On 4/23/23 16:22, Yogesh Hegde wrote:
> After removal of rf_set_sens variable, the _rtl92e_wx_set_sens function
> always returns an error code.
> This commit removes the unused function and the respective ioctl.
>
> Suggested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
> Signed-off-by: Yogesh Hegde <yogi.kernel@gmail.com>
> ---
>
> Changes in v4:
> 1. Split changes into patch series per feedback from
> gregkh@linuxfoundation.org
>
> Changes in v3:
> -- None
>
> Changes in v2:
> -- None
>
> Changes in v1:
> -- None
> ---
> drivers/staging/rtl8192e/rtl8192e/rtl_wx.c | 20 --------------------
> 1 file changed, 20 deletions(-)
>
> diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c b/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
> index e4a726cd0b31..0bb657fda06c 100644
> --- a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
> +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
> @@ -803,25 +803,6 @@ static int _rtl92e_wx_get_retry(struct net_device *dev,
> return 0;
> }
>
> -static int _rtl92e_wx_set_sens(struct net_device *dev,
> - struct iw_request_info *info,
> - union iwreq_data *wrqu, char *extra)
> -{
> - struct r8192_priv *priv = rtllib_priv(dev);
> -
> - short err = 0;
> -
> - if (priv->hw_radio_off)
> - return 0;
> -
> - mutex_lock(&priv->wx_mutex);
> - err = -1;
> -exit:
> - mutex_unlock(&priv->wx_mutex);
> -
> - return err;
> -}
> -
> static int _rtl92e_wx_set_encode_ext(struct net_device *dev,
> struct iw_request_info *info,
> union iwreq_data *wrqu, char *extra)
> @@ -1042,7 +1023,6 @@ static iw_handler r8192_wx_handlers[] = {
> [IW_IOCTL(SIOCGIWFREQ)] = _rtl92e_wx_get_freq,
> [IW_IOCTL(SIOCSIWMODE)] = _rtl92e_wx_set_mode,
> [IW_IOCTL(SIOCGIWMODE)] = _rtl92e_wx_get_mode,
> - [IW_IOCTL(SIOCSIWSENS)] = _rtl92e_wx_set_sens,
> [IW_IOCTL(SIOCGIWRANGE)] = _rtl92e_wx_get_range,
> [IW_IOCTL(SIOCSIWAP)] = _rtl92e_wx_set_wap,
> [IW_IOCTL(SIOCGIWAP)] = _rtl92e_wx_get_wap,
I can apply the first two patches but not this one.
Did you do a git pull before?
Thanks for your support.
Bye Philipp
@@ -803,25 +803,6 @@ static int _rtl92e_wx_get_retry(struct net_device *dev,
return 0;
}
-static int _rtl92e_wx_set_sens(struct net_device *dev,
- struct iw_request_info *info,
- union iwreq_data *wrqu, char *extra)
-{
- struct r8192_priv *priv = rtllib_priv(dev);
-
- short err = 0;
-
- if (priv->hw_radio_off)
- return 0;
-
- mutex_lock(&priv->wx_mutex);
- err = -1;
-exit:
- mutex_unlock(&priv->wx_mutex);
-
- return err;
-}
-
static int _rtl92e_wx_set_encode_ext(struct net_device *dev,
struct iw_request_info *info,
union iwreq_data *wrqu, char *extra)
@@ -1042,7 +1023,6 @@ static iw_handler r8192_wx_handlers[] = {
[IW_IOCTL(SIOCGIWFREQ)] = _rtl92e_wx_get_freq,
[IW_IOCTL(SIOCSIWMODE)] = _rtl92e_wx_set_mode,
[IW_IOCTL(SIOCGIWMODE)] = _rtl92e_wx_get_mode,
- [IW_IOCTL(SIOCSIWSENS)] = _rtl92e_wx_set_sens,
[IW_IOCTL(SIOCGIWRANGE)] = _rtl92e_wx_get_range,
[IW_IOCTL(SIOCSIWAP)] = _rtl92e_wx_set_wap,
[IW_IOCTL(SIOCGIWAP)] = _rtl92e_wx_get_wap,