[v2,11/24] selftests/resctrl: Remove start_buf local variable from buffer alloc func
Message ID | 20230418114506.46788-12-ilpo.jarvinen@linux.intel.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp2781019vqo; Tue, 18 Apr 2023 04:49:49 -0700 (PDT) X-Google-Smtp-Source: AKy350YWeTTFizIxIuaGMKvSgf1iT89p9ucKnsM+H4td/fu93xMJIvA5GbLRxNhordcwpmEpvvc+ X-Received: by 2002:a17:90a:9283:b0:247:1418:ad28 with SMTP id n3-20020a17090a928300b002471418ad28mr1762922pjo.22.1681818588801; Tue, 18 Apr 2023 04:49:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681818588; cv=none; d=google.com; s=arc-20160816; b=H2nub80JTDraBicdXmXSpxaTGAP3evPT6CHQou6e9ifsN/yElgynn8DQWS2X2tsShy t1SdrHUJxBoDbor1lgfwU/R0BQaS0PURH03TfCooJURvCaZIUWIkuhyIevPrMtkNGUhp yk32upiVG08k3vGhnSLjevgzKoON0ptDZSWXGZ9PLpTs0tn0A94XjeEe6o531MJ5oACU rAdT52PL89Cx2jzLiu5gfivmvMjr+WGPxCEHeaDvQkQKtOm6py5O/EEOYJ6RIt3UJW0P i+wsl7yufgHFKGwztgvqgz3yt+s2T7Q9fL9HkKA3Esxy078CdwZjsNW+aW3JytlU9osS Qq1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=RSLTsYdws30UteBbth/1B//xD1kTRcauB1Zky+pDJt4=; b=sULLHRxH7cOq8nVGnD7977Q7jDcKTBCMkK5d4/m88qjr2U60EwbkYxIHoxmYkyk/1G S4XNc4nGhD0YW7HdcrAgftrUrxuFylsqqgkAguY1/zXYprSoLTjRT6Fq3G+5F+L66lpU eCW24kMiBDI7mjOmSKPRBmrkKu6/GeMv8l8yrCz4k15t/HxgQxRSdh8mAYygFunRzdl9 F+M5hGrIj4BwL/tNrq5JIV88oSFU8vOn4f6J0gxJMZ+Z4LecO8nGz9P20Pah8JP5+hbq F9b4GC37T7J379DYo6cZ4dmy84bnmKIUWUV8UfBkPOOVYxCpcEuiKo3LarKbfa+AzWPf qQkg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="VxW/m9p+"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id mj12-20020a17090b368c00b00246799bf0c2si13457168pjb.187.2023.04.18.04.49.36; Tue, 18 Apr 2023 04:49:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="VxW/m9p+"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230428AbjDRLqx (ORCPT <rfc822;leviz.kernel.dev@gmail.com> + 99 others); Tue, 18 Apr 2023 07:46:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56046 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231593AbjDRLqq (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 18 Apr 2023 07:46:46 -0400 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 41D40468E; Tue, 18 Apr 2023 04:46:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1681818376; x=1713354376; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=DtsmLDO5mFl9wMfAHngLijzuH7IwO+uKW2gw4UdECuo=; b=VxW/m9p+NP/86N3pYXDv0OMFv4/twRcCufFUZo1VbRUU2+HnurFG7NrL Oqi2LEsIMvWJJFVZ1ZyG2ktW6at9KBzwoiDrEkcoQWE8qCAKUnlrws6LX 13KEAPwllDHYYykTe1YhY29YC28qsIU9GmJMsC5FkmmAYIRsuhA5yYXEQ ou6LDVzj+7KDiVxnCHRHGJx3tT14TQLb2X/afcGLfMOHmCiJ7n9Yr3P2W CaAOEZZEJZCTXoDHmt1TqPeMXyhYF5C25SRV3nr8AKevSxlcgiFGvlJcw fDIT4wz7TBu4QW4NbmJkAjnaXWtRoQw/kUUfm4pZi5k/7/PiYEp1NlEfC A==; X-IronPort-AV: E=McAfee;i="6600,9927,10683"; a="346994361" X-IronPort-AV: E=Sophos;i="5.99,207,1677571200"; d="scan'208";a="346994361" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Apr 2023 04:46:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10683"; a="723601661" X-IronPort-AV: E=Sophos;i="5.99,207,1677571200"; d="scan'208";a="723601661" Received: from yvolokit-mobl1.ger.corp.intel.com (HELO ijarvine-MOBL2.ger.corp.intel.com) ([10.251.213.103]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Apr 2023 04:45:58 -0700 From: =?utf-8?q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com> To: linux-kselftest@vger.kernel.org, Reinette Chatre <reinette.chatre@intel.com>, Fenghua Yu <fenghua.yu@intel.com>, Shuah Khan <shuah@kernel.org>, linux-kernel@vger.kernel.org Cc: Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>, =?utf-8?q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com> Subject: [PATCH v2 11/24] selftests/resctrl: Remove start_buf local variable from buffer alloc func Date: Tue, 18 Apr 2023 14:44:53 +0300 Message-Id: <20230418114506.46788-12-ilpo.jarvinen@linux.intel.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230418114506.46788-1-ilpo.jarvinen@linux.intel.com> References: <20230418114506.46788-1-ilpo.jarvinen@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1763514608666575512?= X-GMAIL-MSGID: =?utf-8?q?1763514608666575512?= |
Series |
selftests/resctrl: Fixes, cleanups, and rewritten CAT test
|
|
Commit Message
Ilpo Järvinen
April 18, 2023, 11:44 a.m. UTC
alloc_buffer() has local start_ptr variable which is unnecessary.
Assign the pointer of the allocated buffer directly to startptr that is
a global variable in fill_buf to simplify the code in alloc_buffer().
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
---
tools/testing/selftests/resctrl/fill_buf.c | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)
Comments
Hi Ilpo, On 4/18/2023 4:44 AM, Ilpo Järvinen wrote: > alloc_buffer() has local start_ptr variable which is unnecessary. > > Assign the pointer of the allocated buffer directly to startptr that is > a global variable in fill_buf to simplify the code in alloc_buffer(). I think the opposite (removing the global variable) would make the code more manageable. Tests manage their own buffer pointers, there is no need for a global buffer pointer (that I can see). Reinette
diff --git a/tools/testing/selftests/resctrl/fill_buf.c b/tools/testing/selftests/resctrl/fill_buf.c index 6f0438aa71a6..3a10b554d778 100644 --- a/tools/testing/selftests/resctrl/fill_buf.c +++ b/tools/testing/selftests/resctrl/fill_buf.c @@ -145,17 +145,13 @@ static int fill_cache_write(unsigned char *start_ptr, unsigned char *end_ptr, int alloc_buffer(unsigned long long buf_size, int memflush) { - unsigned char *start_ptr; - - start_ptr = malloc_and_init_memory(buf_size); - if (!start_ptr) + startptr = malloc_and_init_memory(buf_size); + if (!startptr) return -1; - startptr = start_ptr; - /* Flush the memory before using to avoid "cache hot pages" effect */ if (memflush) - mem_flush(start_ptr, buf_size); + mem_flush(startptr, buf_size); return 0; }