diff mbox series

[v2] configure: Only create serdep.tmp if needed

Message ID 20230117011203.3342271-1-pefoley2@pefoley.com
State Accepted
Headers
Series [v2] configure: Only create serdep.tmp if needed |

Checks

Context Check Description
snail/gcc-patch-check success Github commit url

Commit Message

Peter Foley Jan. 17, 2023, 1:12 a.m. UTC 
  There's no reason to create this file if none of the serial configure
options are passed.

v2: Use test instead of [ to avoid running afoul of autoconf quoting.

ChangeLog:

	* configure: Regenerate.
	* configure.ac: Only create serdep.tmp if needed

Signed-off-by: Peter Foley <pefoley2@pefoley.com>
---
 configure    | 2 ++
 configure.ac | 2 ++
 2 files changed, 4 insertions(+)

Comments

Jeff Law Jan. 17, 2023, 1:14 a.m. UTC | #1 
On 1/16/23 18:12, Peter Foley wrote:
> There's no reason to create this file if none of the serial configure
> options are passed.
> 
> v2: Use test instead of [ to avoid running afoul of autoconf quoting.
> 
> ChangeLog:
> 
> 	* configure: Regenerate.
> 	* configure.ac: Only create serdep.tmp if needed
Note I think this should be deferred to gcc-14 given that gcc-13 is in 
regression bugfixes only stage right now.

jeff
Jeff Law April 21, 2023, 7:16 p.m. UTC | #2 
On 1/16/23 18:12, Peter Foley wrote:
> There's no reason to create this file if none of the serial configure
> options are passed.
> 
> v2: Use test instead of [ to avoid running afoul of autoconf quoting.
> 
> ChangeLog:
> 
> 	* configure: Regenerate.
> 	* configure.ac: Only create serdep.tmp if needed
Thanks.  I bootstrapped and regression tested x86 without issues and 
pushed this patch to the trunk.

jeff
diff mbox series

Patch

diff --git a/configure b/configure
index 85883099410..0494e2fa2bf 100755
--- a/configure
+++ b/configure
@@ -9918,7 +9918,9 @@  esac
 # These force 'configure's to be done one at a time, to avoid problems
 # with contention over a shared config.cache.
 rm -f serdep.tmp
+if test "x${enable_serial_build_configure}" = xyes || test "x${enable_serial_host_configure}" = xyes || test "x${enable_serial_target_configure}" = xyes; then
 echo '# serdep.tmp' > serdep.tmp
+fi
 olditem=
 test "x${enable_serial_build_configure}" = xyes &&
 for item in ${build_configdirs} ; do
diff --git a/configure.ac b/configure.ac
index 2b612dce6e9..f5cce5830bc 100644
--- a/configure.ac
+++ b/configure.ac
@@ -3071,7 +3071,9 @@  esac
 # These force 'configure's to be done one at a time, to avoid problems
 # with contention over a shared config.cache.
 rm -f serdep.tmp
+if test "x${enable_serial_build_configure}" = xyes || test "x${enable_serial_host_configure}" = xyes || test "x${enable_serial_target_configure}" = xyes; then
 echo '# serdep.tmp' > serdep.tmp
+fi
 olditem=
 test "x${enable_serial_build_configure}" = xyes &&
 for item in ${build_configdirs} ; do