diff mbox series

media: v4l2-mc: Drop subdev check in v4l2_create_fwnode_links_to_pad()

Message ID 20230421100430.28962-1-vaishnav.a@ti.com
State New
Headers
Series media: v4l2-mc: Drop subdev check in v4l2_create_fwnode_links_to_pad() |

Commit Message

Vaishnav Achath April 21, 2023, 10:04 a.m. UTC 
  While updating v4l2_create_fwnode_links_to_pad() to accept non-subdev
sinks, the check is_media_entity_v4l2_subdev() was not removed which
prevented the function from being used with non-subdev sinks, Drop the
unnecessary check.

Fixes: bd5a03bc5be8 ("media: Accept non-subdev sinks in v4l2_create_fwnode_links_to_pad()")

Signed-off-by: Vaishnav Achath <vaishnav.a@ti.com>
---
 drivers/media/v4l2-core/v4l2-mc.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Laurent Pinchart April 21, 2023, 12:10 p.m. UTC | #1 
Hi Vaishnav,

Thank you for the patch.

On Fri, Apr 21, 2023 at 03:34:30PM +0530, Vaishnav Achath wrote:
> While updating v4l2_create_fwnode_links_to_pad() to accept non-subdev
> sinks, the check is_media_entity_v4l2_subdev() was not removed which
> prevented the function from being used with non-subdev sinks, Drop the
> unnecessary check.
> 
> Fixes: bd5a03bc5be8 ("media: Accept non-subdev sinks in v4l2_create_fwnode_links_to_pad()")
> 
> Signed-off-by: Vaishnav Achath <vaishnav.a@ti.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Sakari, the commit this patch fixes will land in v6.4, should this be
merged as a v6.4 fix ?

> ---
>  drivers/media/v4l2-core/v4l2-mc.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/media/v4l2-core/v4l2-mc.c b/drivers/media/v4l2-core/v4l2-mc.c
> index bf0c18100664..22fe08fce0a9 100644
> --- a/drivers/media/v4l2-core/v4l2-mc.c
> +++ b/drivers/media/v4l2-core/v4l2-mc.c
> @@ -314,8 +314,7 @@ int v4l2_create_fwnode_links_to_pad(struct v4l2_subdev *src_sd,
>  {
>  	struct fwnode_handle *endpoint;
>  
> -	if (!(sink->flags & MEDIA_PAD_FL_SINK) ||
> -	    !is_media_entity_v4l2_subdev(sink->entity))
> +	if (!(sink->flags & MEDIA_PAD_FL_SINK))
>  		return -EINVAL;
>  
>  	fwnode_graph_for_each_endpoint(dev_fwnode(src_sd->dev), endpoint) {
Sakari Ailus April 21, 2023, 12:17 p.m. UTC | #2 
On Fri, Apr 21, 2023 at 03:10:48PM +0300, Laurent Pinchart wrote:
> Hi Vaishnav,
> 
> Thank you for the patch.
> 
> On Fri, Apr 21, 2023 at 03:34:30PM +0530, Vaishnav Achath wrote:
> > While updating v4l2_create_fwnode_links_to_pad() to accept non-subdev
> > sinks, the check is_media_entity_v4l2_subdev() was not removed which
> > prevented the function from being used with non-subdev sinks, Drop the
> > unnecessary check.
> > 
> > Fixes: bd5a03bc5be8 ("media: Accept non-subdev sinks in v4l2_create_fwnode_links_to_pad()")
> > 
> > Signed-off-by: Vaishnav Achath <vaishnav.a@ti.com>
> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> 
> Sakari, the commit this patch fixes will land in v6.4, should this be
> merged as a v6.4 fix ?

I'd think so. I'll take this soonish.
diff mbox series

Patch

diff --git a/drivers/media/v4l2-core/v4l2-mc.c b/drivers/media/v4l2-core/v4l2-mc.c
index bf0c18100664..22fe08fce0a9 100644
--- a/drivers/media/v4l2-core/v4l2-mc.c
+++ b/drivers/media/v4l2-core/v4l2-mc.c
@@ -314,8 +314,7 @@  int v4l2_create_fwnode_links_to_pad(struct v4l2_subdev *src_sd,
 {
 	struct fwnode_handle *endpoint;
 
-	if (!(sink->flags & MEDIA_PAD_FL_SINK) ||
-	    !is_media_entity_v4l2_subdev(sink->entity))
+	if (!(sink->flags & MEDIA_PAD_FL_SINK))
 		return -EINVAL;
 
 	fwnode_graph_for_each_endpoint(dev_fwnode(src_sd->dev), endpoint) {