Message ID | ZEGTnajiQm7mkkZS@slm.duckdns.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp573175vqo; Thu, 20 Apr 2023 12:43:17 -0700 (PDT) X-Google-Smtp-Source: AKy350aqmdwgLzEDWK5q5aymgjdP/DXBx7kr/gKNZw9lPr7eUGtPP/SSudQqLpgc+voYukw5Bebs X-Received: by 2002:a17:903:2287:b0:1a3:cd4c:8d08 with SMTP id b7-20020a170903228700b001a3cd4c8d08mr3211465plh.38.1682019796980; Thu, 20 Apr 2023 12:43:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682019796; cv=none; d=google.com; s=arc-20160816; b=amb0kjLGTEkwrj51vzWjwBE6I1RQ8U7F7M5Wa5kerup6Nnow+TtuCFtlj5OiHxcB4F HeXp7A3S0F4dgXdqb+uGy2iVW9j5MlDsXBNN+tuPqxOj6jtmdDt5qb58kt8tvqAa39PJ yNAHV9xGjlX8MGx5lvWsUctNeoJcEqy/hM6I7RBWJM095XWIbVbYRZlQywDt08rj8ZJq PGzfqxxRgQkECwmVDaBbeTw1BYeTaAQp6ETeO0m1ed83FZBVTnSgLL1e1qah3Fbf6QQe eWui62W9bGE3N6H0nzCDsu3LMgSy2sBFUnqbQ767zxa+dwL9FZt/2pwzFp2JiBduM+fl 1/rQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-disposition:mime-version:message-id :subject:cc:to:from:date:sender:dkim-signature; bh=y74Qw0/8a5dMAsd+sLD5I7B7gKbGCOA24GXrDYc4XOg=; b=XICyXbVQ0ea/mjnRFqZ9fcEnUBNzHB5cVAl5IsdDeXRtTw+wRzlCNcopYPMTETQeDs +x7smPLDr0uAe2pkaiGlPK0Yt6v6rsZ9hdjo5oL8M1LEM83OnVpnIQfYAPQpGc0wxj1F HblCspWka87HRYFGEe5wQg2NNBrothYR4JluW4GrTw/1qwSPN3Ur0QzRa7IVZqows8BE +KOjw6YVKcvHU3UVYTN1jDO4TR2b0lrpGl/t26tWWrWsoriAkHUTZ960Bx1mQA6bOmCY yqb3XdOW+XpWSS8G64PYk8/r+BZj2PAiVyaSV9b6qqctA0KQ4I0Z0XktzStB8GWyZW8d 1AgA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=UPJJd3og; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l14-20020a170903244e00b001a6e87f4336si2900526pls.275.2023.04.20.12.43.04; Thu, 20 Apr 2023 12:43:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=UPJJd3og; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232027AbjDTTdz (ORCPT <rfc822;cjcooper78@gmail.com> + 99 others); Thu, 20 Apr 2023 15:33:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50776 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231206AbjDTTdx (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Thu, 20 Apr 2023 15:33:53 -0400 Received: from mail-pf1-x42a.google.com (mail-pf1-x42a.google.com [IPv6:2607:f8b0:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 652B019C for <linux-kernel@vger.kernel.org>; Thu, 20 Apr 2023 12:33:52 -0700 (PDT) Received: by mail-pf1-x42a.google.com with SMTP id d2e1a72fcca58-63b8b19901fso1819741b3a.3 for <linux-kernel@vger.kernel.org>; Thu, 20 Apr 2023 12:33:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682019232; x=1684611232; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :sender:from:to:cc:subject:date:message-id:reply-to; bh=y74Qw0/8a5dMAsd+sLD5I7B7gKbGCOA24GXrDYc4XOg=; b=UPJJd3ogPdBv/pVoXDdKlIHl0RL0ASvVb345pCL+hNq6LlD+Gn58+pJ5JsX/IL7Wfj rPWDH0P2HCl27BwG7gdXm913RJMv0yJ84nwS/xKcm0xNhvzbzzDCTZQ1sCj4IUasIxC7 7AJto8DyUTA2WSxI7CKsnFl0Qs7YNVw245vTHWQj3kZLsrbN5ZfYnene5gasq3GG3doN WU+yxe0TAAJ/2OgIHg2vuvYgdkWPLmhlx5QiPD2DSDweWJdXuddBhEfFO2eDdFhL+iNw TLH+MByh8hrdJLqc6BlJMBqf5lyX/eUQawH/PMRfdh7egDhMe/mIQUKNsZszoh+fybQB BAlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682019232; x=1684611232; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=y74Qw0/8a5dMAsd+sLD5I7B7gKbGCOA24GXrDYc4XOg=; b=fUwHzOf9h9o91r6LsRCh/pB542hDziM/kBrN6WkG7ZL2AM+bKnuGI+SsRMLAGA7dzx jOmnCky1r7gsPL/zFK0f0A8h3QLe7nLwEWsqAJEJn5O+yWthtrVaFuYkMEjBUBB9mgxM ej3I9/1mpclT3c1je0gWfXEq7toYkDSblftGSl5dvgE4Nq+qMYhyZTyfHl6RQjAYoFTQ 0oqpA9iGk8rPJJFGr65wdsEWGt/GJ8f1h+jC7Rga5ebKAr4kRrWA1J4WT57bmRzb3VUv sRsGFikHR5Qu24Fmfi9tXHMM2T2pcKm5KX7WYMUAvLcnSk/t8evaEOcAbd9XWYeNpvLh LU6Q== X-Gm-Message-State: AAQBX9dRt31sZy4BYufo8mKHMPqdKioKo4yUsp56W5G7BcqgrgzfXcQO Z4/gtCYyKqpC2Px1ewhrx+M= X-Received: by 2002:a05:6a20:4296:b0:ef:1457:6cdf with SMTP id o22-20020a056a20429600b000ef14576cdfmr3736647pzj.19.1682019231601; Thu, 20 Apr 2023 12:33:51 -0700 (PDT) Received: from localhost (2603-800c-1a02-1bae-a7fa-157f-969a-4cde.res6.spectrum.com. [2603:800c:1a02:1bae:a7fa:157f:969a:4cde]) by smtp.gmail.com with ESMTPSA id q5-20020a056a00084500b0062dae524006sm1599698pfk.157.2023.04.20.12.33.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Apr 2023 12:33:51 -0700 (PDT) Sender: Tejun Heo <htejun@gmail.com> Date: Thu, 20 Apr 2023 09:33:49 -1000 From: Tejun Heo <tj@kernel.org> To: Sudeep Holla <sudeep.holla@arm.com> Cc: Cristian Marussi <cristian.marussi@arm.com>, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: [PATCH] firmware: arm_scmi: Fix incorrect alloc_workqueue() invocation Message-ID: <ZEGTnajiQm7mkkZS@slm.duckdns.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1763725590563665052?= X-GMAIL-MSGID: =?utf-8?q?1763725590563665052?= |
Series |
firmware: arm_scmi: Fix incorrect alloc_workqueue() invocation
|
|
Commit Message
Tejun Heo
April 20, 2023, 7:33 p.m. UTC
scmi_xfer_raw_worker_init() is specifying a flag, WQ_SYSFS, as @max_active.
Fix it by or'ing WQ_SYSFS into @flags so that it actually enables sysfs
interface and using 0 for @max_active for the default setting.
Signed-off-by: Tejun Heo <tj@kernel.org>
---
drivers/firmware/arm_scmi/raw_mode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On Thu, Apr 20, 2023 at 09:33:49AM -1000, Tejun Heo wrote: > scmi_xfer_raw_worker_init() is specifying a flag, WQ_SYSFS, as @max_active. > Fix it by or'ing WQ_SYSFS into @flags so that it actually enables sysfs > interface and using 0 for @max_active for the default setting. > Hi Tejun, my bad I messed up the params in the call. LGTM. Thanks, Cristian > Signed-off-by: Tejun Heo <tj@kernel.org> > --- > drivers/firmware/arm_scmi/raw_mode.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- a/drivers/firmware/arm_scmi/raw_mode.c > +++ b/drivers/firmware/arm_scmi/raw_mode.c > @@ -1066,7 +1066,7 @@ static int scmi_xfer_raw_worker_init(str > > raw->wait_wq = alloc_workqueue("scmi-raw-wait-wq-%d", > WQ_UNBOUND | WQ_FREEZABLE | > - WQ_HIGHPRI, WQ_SYSFS, raw->id); > + WQ_HIGHPRI | WQ_SYSFS, 0, raw->id); > if (!raw->wait_wq) > return -ENOMEM; >
On Fri, Apr 21, 2023 at 09:46:11AM +0100, Cristian Marussi wrote: > On Thu, Apr 20, 2023 at 09:33:49AM -1000, Tejun Heo wrote: > > scmi_xfer_raw_worker_init() is specifying a flag, WQ_SYSFS, as @max_active. > > Fix it by or'ing WQ_SYSFS into @flags so that it actually enables sysfs > > interface and using 0 for @max_active for the default setting. > > Thanks, good catch, very hard to notice. > > Hi Tejun, > > my bad I messed up the params in the call. > Hi Cristian, I think it deserves the fixes tag, right ? Fixes: 3c3d818a9317 ("firmware: arm_scmi: Add core raw transmission support")
On Fri, Apr 21, 2023 at 10:27:42AM +0100, Sudeep Holla wrote: > On Fri, Apr 21, 2023 at 09:46:11AM +0100, Cristian Marussi wrote: > > On Thu, Apr 20, 2023 at 09:33:49AM -1000, Tejun Heo wrote: > > > scmi_xfer_raw_worker_init() is specifying a flag, WQ_SYSFS, as @max_active. > > > Fix it by or'ing WQ_SYSFS into @flags so that it actually enables sysfs > > > interface and using 0 for @max_active for the default setting. > > > > > Thanks, good catch, very hard to notice. Indeed :< > > > > > Hi Tejun, > > > > my bad I messed up the params in the call. > > > > Hi Cristian, > > I think it deserves the fixes tag, right ? > > Fixes: 3c3d818a9317 ("firmware: arm_scmi: Add core raw transmission support") > I though so, but as usual I am not sure what to do when we are fixing something in the middle of a cycle... Raw support went in v6.3-rc1 and we are now in v6.3-rc7, so if you want to pick this up now (as it seems the case) it will fix the above yes, but it is anyway still on an unreleased kernel...so nothing really to have to apply on any early stable kernels...buh..I dont know what is the rule, but the Fix tag seems harmless ... so why not :D Thanks, Cristian
On Fri, Apr 21, 2023 at 10:38:49AM +0100, Cristian Marussi wrote: > I though so, but as usual I am not sure what to do when we are fixing something > in the middle of a cycle... Raw support went in v6.3-rc1 and we are now in > v6.3-rc7, so if you want to pick this up now (as it seems the case) it will fix > the above yes, but it is anyway still on an unreleased kernel...so nothing really > to have to apply on any early stable kernels...buh..I dont know what is the rule, > but the Fix tag seems harmless ... so why not :D > Not that complicated TBH. If you know this fixes a particular commit in the tree, just add Fixes tag. The stable maintainers have made it easier in general by relying on the fixes tag and not needing explicit stable tag in most of the cases. I will add it.
On Thu, 20 Apr 2023 09:33:49 -1000, Tejun Heo wrote: > scmi_xfer_raw_worker_init() is specifying a flag, WQ_SYSFS, as @max_active. > Fix it by or'ing WQ_SYSFS into @flags so that it actually enables sysfs > interface and using 0 for @max_active for the default setting. > Applied to sudeep.holla/linux (for-next/scmi/fixes), thanks! [1/1] firmware: arm_scmi: Fix incorrect alloc_workqueue() invocation https://git.kernel.org/sudeep.holla/c/44e8d5ad2dc0 -- Regards, Sudeep
--- a/drivers/firmware/arm_scmi/raw_mode.c +++ b/drivers/firmware/arm_scmi/raw_mode.c @@ -1066,7 +1066,7 @@ static int scmi_xfer_raw_worker_init(str raw->wait_wq = alloc_workqueue("scmi-raw-wait-wq-%d", WQ_UNBOUND | WQ_FREEZABLE | - WQ_HIGHPRI, WQ_SYSFS, raw->id); + WQ_HIGHPRI | WQ_SYSFS, 0, raw->id); if (!raw->wait_wq) return -ENOMEM;