Message ID | 20230421060505.10132-10-dwagner@suse.de |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp852737vqo; Thu, 20 Apr 2023 23:18:08 -0700 (PDT) X-Google-Smtp-Source: AKy350aYucyDMUVUHDorgOFj6ems3YKJiLPY/CY5PXBziO2RxWdamiP9rwwWKSEAZAVruHjhE0u9 X-Received: by 2002:a17:90a:2c49:b0:247:2969:4f95 with SMTP id p9-20020a17090a2c4900b0024729694f95mr3995274pjm.26.1682057888262; Thu, 20 Apr 2023 23:18:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682057888; cv=none; d=google.com; s=arc-20160816; b=ZBjWJXmvQyTI0JEHsvEXCVOGN51chrKaNfrtaLvOR0S1Kk8xJIV52hiMBgBHtdhEjS Kyr8W9DWk/T3v6IoePMycTSrfMTejNGpMf/5z03Q3nNemvVF0IZp5/KOJD7EmCr01p18 uur++b7OLMddzddOiUGNPptJB8sAR94FfxLhGWAF4tleAEoEQp52l5atN39mGLsM0Sd3 gloCrrXy0G/J+ziNAyEVCQz5dULLkwPOq4GfwDNKzqeG67SpiqglMLKA6kwSkjwdAi28 F9oTuS5nps6MmxCGhFMZqfqZsiQEOJ6L4yvDthLgR+BHe1Zxz8OlZ+E5pgOiPSqB+jNx kC6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature:dkim-signature; bh=64UivdY+JtKHHGrkt+vaul9Etj91J7nvEO+ZQNudNu8=; b=c1dG04WEElisgh7o5CK4Ve5lIxpB7adHcHlJPsOGMeuHBrzAmU0wPp8n1Uw5NzHVT7 sHhrVMoYMYpWcWbUV444sjy/pwBhgnz6LkHqVciJQr4+WT4trSMfR1jzSix7E5l8m5w9 obJodmRq1WkFrPTnY4Dt0AjT9E853zl2bJsqfzxERUYKbgslLjXJobSPeiSWq6LzxsYK Xo4mzAnYRzL3QImH2ga5H/A2esqsTtvV506ZPAlkCnG5O7JWwb8b4Zutt+MTJQV3kc+Z WFDsmBNN9m9Z/d3YjYPuMK1SYF3Lz8uiH9xK+GuNDOQjumyt8Y52bnD3biLvmH4rEHbA od5A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=EoDlVx7F; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w11-20020a17090abc0b00b0024696759991si6447674pjr.47.2023.04.20.23.17.56; Thu, 20 Apr 2023 23:18:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=EoDlVx7F; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233800AbjDUGGR (ORCPT <rfc822;cjcooper78@gmail.com> + 99 others); Fri, 21 Apr 2023 02:06:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47314 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233769AbjDUGGG (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 21 Apr 2023 02:06:06 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5040F768E; Thu, 20 Apr 2023 23:05:56 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 9EEA81FDE2; Fri, 21 Apr 2023 06:05:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1682057121; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=64UivdY+JtKHHGrkt+vaul9Etj91J7nvEO+ZQNudNu8=; b=EoDlVx7FPNaOzfpIOSof4jUY/6TuLVkrAyfprfZJfhy51GvMUM+n3ATkasGkLnJs+C5dIO Fyq7gr10RKobM0kDmJs+7SnK1o4KX/w6yFyaD46VkRmYMlY7DT3oYzbLPb0sCTY5l72lbK 6SUu6B8aGNy+riILvgXic0sEaMv6Rpk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1682057121; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=64UivdY+JtKHHGrkt+vaul9Etj91J7nvEO+ZQNudNu8=; b=ZoTN2WdrMBxSwpS2IqkFOu5Yqa1VIXEp6PiWZwtMiPNUAwRRCg+aBF/tgnYjlop0XjvaQb GQcRmDXfFpwu00Cg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 914831390E; Fri, 21 Apr 2023 06:05:21 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 46mJI6EnQmSAZgAAMHmgww (envelope-from <dwagner@suse.de>); Fri, 21 Apr 2023 06:05:21 +0000 From: Daniel Wagner <dwagner@suse.de> To: linux-nvme@lists.infradead.org Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, Chaitanya Kulkarni <kch@nvidia.com>, Shin'ichiro Kawasaki <shinichiro@fastmail.com>, Daniel Wagner <dwagner@suse.de> Subject: [PATCH REPOST blktests v2 9/9] nvme: Make the number iterations configurable Date: Fri, 21 Apr 2023 08:05:05 +0200 Message-Id: <20230421060505.10132-10-dwagner@suse.de> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230421060505.10132-1-dwagner@suse.de> References: <20230421060505.10132-1-dwagner@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1763765531949064341?= X-GMAIL-MSGID: =?utf-8?q?1763765531949064341?= |
Series |
nvme testsuite runtime optimization
|
|
Commit Message
Daniel Wagner
April 21, 2023, 6:05 a.m. UTC
Some tests hard code high values of iterations. This makes them run
relatively long compared to the other tests. Introduce a new environment
variable nvme_num_iter to allow tune the runtime.
Signed-off-by: Daniel Wagner <dwagner@suse.de>
---
tests/nvme/002 | 2 +-
tests/nvme/016 | 2 +-
tests/nvme/017 | 2 +-
tests/nvme/rc | 1 +
4 files changed, 4 insertions(+), 3 deletions(-)
Comments
On 4/21/23 08:05, Daniel Wagner wrote: > Some tests hard code high values of iterations. This makes them run > relatively long compared to the other tests. Introduce a new environment > variable nvme_num_iter to allow tune the runtime. > > Signed-off-by: Daniel Wagner <dwagner@suse.de> > --- > tests/nvme/002 | 2 +- > tests/nvme/016 | 2 +- > tests/nvme/017 | 2 +- > tests/nvme/rc | 1 + > 4 files changed, 4 insertions(+), 3 deletions(-) > Reviewed-by: Hannes Reinecke <hare@suse.de> Cheers, Hannes
On Apr 21, 2023 / 08:05, Daniel Wagner wrote: > Some tests hard code high values of iterations. This makes them run > relatively long compared to the other tests. Introduce a new environment > variable nvme_num_iter to allow tune the runtime. > > Signed-off-by: Daniel Wagner <dwagner@suse.de> > --- > tests/nvme/002 | 2 +- > tests/nvme/016 | 2 +- > tests/nvme/017 | 2 +- > tests/nvme/rc | 1 + > 4 files changed, 4 insertions(+), 3 deletions(-) > > diff --git a/tests/nvme/002 b/tests/nvme/002 > index 6b8484844b4d..c28035483514 100755 > --- a/tests/nvme/002 > +++ b/tests/nvme/002 > @@ -20,7 +20,7 @@ test() { > > _setup_nvmet > > - local iterations=1000 > + local iterations="${nvme_num_iter}" > local port > port="$(_create_nvmet_port "${nvme_trtype}")" > > diff --git a/tests/nvme/016 b/tests/nvme/016 > index 4eba30223a08..c0c31a55b190 100755 > --- a/tests/nvme/016 > +++ b/tests/nvme/016 > @@ -17,7 +17,7 @@ test() { > echo "Running ${TEST_NAME}" > > local port > - local iterations=1000 > + local iterations="${nvme_num_iter}" > local loop_dev > local subsys_nqn="blktests-subsystem-1" > > diff --git a/tests/nvme/017 b/tests/nvme/017 > index 0248aee9bc41..e1674508f654 100755 > --- a/tests/nvme/017 > +++ b/tests/nvme/017 > @@ -18,7 +18,7 @@ test() { > > local port > local file_path > - local iterations=1000 > + local iterations="${nvme_num_iter}" > local subsys_name="blktests-subsystem-1" > > _setup_nvmet > diff --git a/tests/nvme/rc b/tests/nvme/rc > index 2aa34fb0c9b8..bb135502220a 100644 > --- a/tests/nvme/rc > +++ b/tests/nvme/rc > @@ -18,6 +18,7 @@ def_hostnqn="$(cat /etc/nvme/hostnqn 2> /dev/null)" > def_hostid="$(cat /etc/nvme/hostid 2> /dev/null)" > nvme_trtype=${nvme_trtype:-"loop"} > nvme_img_size=${nvme_img_size:-"350M"} > +nvme_num_iter=${nvme_num_iter:-"100"} The commit log of tests/nvme/002 says that "Test nvme discovery with many (1000) subsystems so the discovery log page exceeds 4k.". Can we fulfill this test purpose with the default value 100? Also, nvme_num_iter will need description in Documentation/running-tests.md. > > _nvme_requires() { > _have_program nvme > -- > 2.40.0 >
On Fri, Apr 28, 2023 at 04:12:06AM +0000, Shinichiro Kawasaki wrote: > > nvme_img_size=${nvme_img_size:-"350M"} > > +nvme_num_iter=${nvme_num_iter:-"100"} > > The commit log of tests/nvme/002 says that "Test nvme discovery with many (1000) > subsystems so the discovery log page exceeds 4k.". Can we fulfill this test > purpose with the default value 100? I am going to drop the nvme/002 change in this case and set the default of nvme_num_iter to 1000. > Also, nvme_num_iter will need description in Documentation/running-tests.md. Sure.
diff --git a/tests/nvme/002 b/tests/nvme/002 index 6b8484844b4d..c28035483514 100755 --- a/tests/nvme/002 +++ b/tests/nvme/002 @@ -20,7 +20,7 @@ test() { _setup_nvmet - local iterations=1000 + local iterations="${nvme_num_iter}" local port port="$(_create_nvmet_port "${nvme_trtype}")" diff --git a/tests/nvme/016 b/tests/nvme/016 index 4eba30223a08..c0c31a55b190 100755 --- a/tests/nvme/016 +++ b/tests/nvme/016 @@ -17,7 +17,7 @@ test() { echo "Running ${TEST_NAME}" local port - local iterations=1000 + local iterations="${nvme_num_iter}" local loop_dev local subsys_nqn="blktests-subsystem-1" diff --git a/tests/nvme/017 b/tests/nvme/017 index 0248aee9bc41..e1674508f654 100755 --- a/tests/nvme/017 +++ b/tests/nvme/017 @@ -18,7 +18,7 @@ test() { local port local file_path - local iterations=1000 + local iterations="${nvme_num_iter}" local subsys_name="blktests-subsystem-1" _setup_nvmet diff --git a/tests/nvme/rc b/tests/nvme/rc index 2aa34fb0c9b8..bb135502220a 100644 --- a/tests/nvme/rc +++ b/tests/nvme/rc @@ -18,6 +18,7 @@ def_hostnqn="$(cat /etc/nvme/hostnqn 2> /dev/null)" def_hostid="$(cat /etc/nvme/hostid 2> /dev/null)" nvme_trtype=${nvme_trtype:-"loop"} nvme_img_size=${nvme_img_size:-"350M"} +nvme_num_iter=${nvme_num_iter:-"100"} _nvme_requires() { _have_program nvme