diff mbox series

[1/2] dt-bindings: regulator: Add dt property

Message ID	20230418145051.4192963-1-Naresh.Solanki@9elements.com
State	New
Headers	Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; From: Naresh Solanki <naresh.solanki@9elements.com> To: Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Zev Weiss <zev@bewilderbeest.net> Cc: Naresh Solanki <Naresh.Solanki@9elements.com>, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: [PATCH 1/2] dt-bindings: regulator: Add dt property Date: Tue, 18 Apr 2023 16:50:50 +0200 Message-Id: <20230418145051.4192963-1-Naresh.Solanki@9elements.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk
Series	[1/2] dt-bindings: regulator: Add dt property \| [1/2] dt-bindings: regulator: Add dt property [2/2] regulator: userspace-consumer: Multiple regulators

Commit Message

Naresh Solanki April 18, 2023, 2:50 p.m. UTC

  Add DT property regulator-supplies.
This enables us to couple one or more regulator output to gether. This
is use in case of Single connector having 2 or more supplies.

Signed-off-by: Naresh Solanki <Naresh.Solanki@9elements.com>
---
 .../bindings/regulator/regulator-output.yaml         | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)


base-commit: c55470f8b0616b0adb758077dbae9b19c5aac005

Comments

Zev Weiss April 20, 2023, 12:01 a.m. UTC | #1

On Tue, Apr 18, 2023 at 07:50:50AM PDT, Naresh Solanki wrote:
>Add DT property regulator-supplies.
>This enables us to couple one or more regulator output to gether. This
>is use in case of Single connector having 2 or more supplies.
>
>Signed-off-by: Naresh Solanki <Naresh.Solanki@9elements.com>
>---
> .../bindings/regulator/regulator-output.yaml         | 12 +++++++++---
> 1 file changed, 9 insertions(+), 3 deletions(-)
>
>diff --git a/Documentation/devicetree/bindings/regulator/regulator-output.yaml b/Documentation/devicetree/bindings/regulator/regulator-output.yaml
>index 078b37a1a71a..17f683d3c1f3 100644
>--- a/Documentation/devicetree/bindings/regulator/regulator-output.yaml
>+++ b/Documentation/devicetree/bindings/regulator/regulator-output.yaml
>@@ -21,13 +21,19 @@ properties:
>   compatible:
>     const: regulator-output
>
>-  vout-supply:
>+  regulator-supplies:
>     description:
>-      Phandle of the regulator supplying the output.
>+      Specifies the name of the output supply provided by the regulator.
>+      Defaults to "vout".
>+    default: "vout"
>+

Was this meant to be specified as a string-array to allow providing 
multiple names?

>+patternProperties:
>+  ".*-supply":
>+    description:
>+      Specified the phandle for various supplies
>
> required:
>   - compatible
>-  - vout-supply
>
> additionalProperties: false
>
>

I think it would be nice to also update the examples to show what a 
multi-supply instance would look like.

A slightly more descriptive subject line would also be good -- "Add dt 
property" is a bit vague.

>base-commit: c55470f8b0616b0adb758077dbae9b19c5aac005
>-- 
>2.39.1
>

Naresh Solanki April 20, 2023, 8:22 a.m. UTC | #2

Hi Zev,

On 20-04-2023 05:31 am, Zev Weiss wrote:
> On Tue, Apr 18, 2023 at 07:50:50AM PDT, Naresh Solanki wrote:
>> Add DT property regulator-supplies.
>> This enables us to couple one or more regulator output to gether. This
>> is use in case of Single connector having 2 or more supplies.
>>
>> Signed-off-by: Naresh Solanki <Naresh.Solanki@9elements.com>
>> ---
>> .../bindings/regulator/regulator-output.yaml         | 12 +++++++++---
>> 1 file changed, 9 insertions(+), 3 deletions(-)
>>
>> diff --git 
>> a/Documentation/devicetree/bindings/regulator/regulator-output.yaml 
>> b/Documentation/devicetree/bindings/regulator/regulator-output.yaml
>> index 078b37a1a71a..17f683d3c1f3 100644
>> --- a/Documentation/devicetree/bindings/regulator/regulator-output.yaml
>> +++ b/Documentation/devicetree/bindings/regulator/regulator-output.yaml
>> @@ -21,13 +21,19 @@ properties:
>>   compatible:
>>     const: regulator-output
>>
>> -  vout-supply:
>> +  regulator-supplies:
>>     description:
>> -      Phandle of the regulator supplying the output.
>> +      Specifies the name of the output supply provided by the regulator.
>> +      Defaults to "vout".
>> +    default: "vout"
>> +
> 
> Was this meant to be specified as a string-array to allow providing 
> multiple names?
Yes. This is string-array.
> 
>> +patternProperties:
>> +  ".*-supply":
>> +    description:
>> +      Specified the phandle for various supplies
>>
>> required:
>>   - compatible
>> -  - vout-supply
>>
>> additionalProperties: false
>>
>>
> 
> I think it would be nice to also update the examples to show what a 
> multi-supply instance would look like.
Ack. Will do that.
> 
> A slightly more descriptive subject line would also be good -- "Add dt 
> property" is a bit vague.
Suggestion ?
How about like 'Allow multiple supplies' or 'Add support for multiple 
supplies'
> 
>> base-commit: c55470f8b0616b0adb758077dbae9b19c5aac005
>> -- 
>> 2.39.1
>>
Regards,
Naresh

Zev Weiss April 20, 2023, 10:41 a.m. UTC | #3

On Thu, Apr 20, 2023 at 01:22:30AM PDT, Naresh Solanki wrote:
>Hi Zev,
>
>On 20-04-2023 05:31 am, Zev Weiss wrote:
>>On Tue, Apr 18, 2023 at 07:50:50AM PDT, Naresh Solanki wrote:
>>>Add DT property regulator-supplies.
>>>This enables us to couple one or more regulator output to gether. This
>>>is use in case of Single connector having 2 or more supplies.
>>>
>>>Signed-off-by: Naresh Solanki <Naresh.Solanki@9elements.com>
>>>---
>>>.../bindings/regulator/regulator-output.yaml         | 12 +++++++++---
>>>1 file changed, 9 insertions(+), 3 deletions(-)
>>>
>>>diff --git 
>>>a/Documentation/devicetree/bindings/regulator/regulator-output.yaml 
>>>b/Documentation/devicetree/bindings/regulator/regulator-output.yaml
>>>index 078b37a1a71a..17f683d3c1f3 100644
>>>--- a/Documentation/devicetree/bindings/regulator/regulator-output.yaml
>>>+++ b/Documentation/devicetree/bindings/regulator/regulator-output.yaml
>>>@@ -21,13 +21,19 @@ properties:
>>>  compatible:
>>>    const: regulator-output
>>>
>>>-  vout-supply:
>>>+  regulator-supplies:
>>>    description:
>>>-      Phandle of the regulator supplying the output.
>>>+      Specifies the name of the output supply provided by the regulator.
>>>+      Defaults to "vout".
>>>+    default: "vout"
>>>+
>>
>>Was this meant to be specified as a string-array to allow providing 
>>multiple names?
>Yes. This is string-array.

Okay -- in that case I think it should include

   $ref: /schemas/types.yaml#/definitions/string-array

>>
>>>+patternProperties:
>>>+  ".*-supply":
>>>+    description:
>>>+      Specified the phandle for various supplies
>>>
>>>required:
>>>  - compatible
>>>-  - vout-supply
>>>
>>>additionalProperties: false
>>>
>>>
>>
>>I think it would be nice to also update the examples to show what a 
>>multi-supply instance would look like.
>Ack. Will do that.
>>
>>A slightly more descriptive subject line would also be good -- "Add 
>>dt property" is a bit vague.
>Suggestion ?
>How about like 'Allow multiple supplies' or 'Add support for multiple 
>supplies'

Sure, both of those sound fine to me.

>>
>>>base-commit: c55470f8b0616b0adb758077dbae9b19c5aac005
>>>-- 
>>>2.39.1
>>>
>Regards,
>Naresh

Naresh Solanki April 20, 2023, 11:32 a.m. UTC | #4

Hi Zev,

On 20-04-2023 04:11 pm, Zev Weiss wrote:
> On Thu, Apr 20, 2023 at 01:22:30AM PDT, Naresh Solanki wrote:
>> Hi Zev,
>>
>> On 20-04-2023 05:31 am, Zev Weiss wrote:
>>> On Tue, Apr 18, 2023 at 07:50:50AM PDT, Naresh Solanki wrote:
>>>> Add DT property regulator-supplies.
>>>> This enables us to couple one or more regulator output to gether. This
>>>> is use in case of Single connector having 2 or more supplies.
>>>>
>>>> Signed-off-by: Naresh Solanki <Naresh.Solanki@9elements.com>
>>>> ---
>>>> .../bindings/regulator/regulator-output.yaml         | 12 +++++++++---
>>>> 1 file changed, 9 insertions(+), 3 deletions(-)
>>>>
>>>> diff --git 
>>>> a/Documentation/devicetree/bindings/regulator/regulator-output.yaml 
>>>> b/Documentation/devicetree/bindings/regulator/regulator-output.yaml
>>>> index 078b37a1a71a..17f683d3c1f3 100644
>>>> --- a/Documentation/devicetree/bindings/regulator/regulator-output.yaml
>>>> +++ b/Documentation/devicetree/bindings/regulator/regulator-output.yaml
>>>> @@ -21,13 +21,19 @@ properties:
>>>>   compatible:
>>>>     const: regulator-output
>>>>
>>>> -  vout-supply:
>>>> +  regulator-supplies:
>>>>     description:
>>>> -      Phandle of the regulator supplying the output.
>>>> +      Specifies the name of the output supply provided by the 
>>>> regulator.
>>>> +      Defaults to "vout".
>>>> +    default: "vout"
>>>> +
>>>
>>> Was this meant to be specified as a string-array to allow providing 
>>> multiple names?
>> Yes. This is string-array.
> 
> Okay -- in that case I think it should include
> 
>    $ref: /schemas/types.yaml#/definitions/string-array
Ack
> 
>>>
>>>> +patternProperties:
>>>> +  ".*-supply":
>>>> +    description:
>>>> +      Specified the phandle for various supplies
>>>>
>>>> required:
>>>>   - compatible
>>>> -  - vout-supply
>>>>
>>>> additionalProperties: false
>>>>
>>>>
>>>
>>> I think it would be nice to also update the examples to show what a 
>>> multi-supply instance would look like.
>> Ack. Will do that.
>>>
>>> A slightly more descriptive subject line would also be good -- "Add 
>>> dt property" is a bit vague.
>> Suggestion ?
>> How about like 'Allow multiple supplies' or 'Add support for multiple 
>> supplies'
> 
> Sure, both of those sound fine to me.
Thanks :)
> 
>>>
>>>> base-commit: c55470f8b0616b0adb758077dbae9b19c5aac005
>>>> -- 
>>>> 2.39.1
>>>>
>> Regards,
>> Naresh
Regards,
Naresh

Rob Herring April 21, 2023, 6:10 p.m. UTC | #5

On Thu, Apr 20, 2023 at 01:52:30PM +0530, Naresh Solanki wrote:
> Hi Zev,
> 
> On 20-04-2023 05:31 am, Zev Weiss wrote:
> > On Tue, Apr 18, 2023 at 07:50:50AM PDT, Naresh Solanki wrote:
> > > Add DT property regulator-supplies.
> > > This enables us to couple one or more regulator output to gether. This
> > > is use in case of Single connector having 2 or more supplies.
> > > 
> > > Signed-off-by: Naresh Solanki <Naresh.Solanki@9elements.com>
> > > ---
> > > .../bindings/regulator/regulator-output.yaml         | 12 +++++++++---
> > > 1 file changed, 9 insertions(+), 3 deletions(-)
> > > 
> > > diff --git
> > > a/Documentation/devicetree/bindings/regulator/regulator-output.yaml
> > > b/Documentation/devicetree/bindings/regulator/regulator-output.yaml
> > > index 078b37a1a71a..17f683d3c1f3 100644
> > > --- a/Documentation/devicetree/bindings/regulator/regulator-output.yaml
> > > +++ b/Documentation/devicetree/bindings/regulator/regulator-output.yaml
> > > @@ -21,13 +21,19 @@ properties:
> > >   compatible:
> > >     const: regulator-output
> > > 
> > > -  vout-supply:
> > > +  regulator-supplies:
> > >     description:
> > > -      Phandle of the regulator supplying the output.
> > > +      Specifies the name of the output supply provided by the regulator.
> > > +      Defaults to "vout".
> > > +    default: "vout"
> > > +
> > 
> > Was this meant to be specified as a string-array to allow providing
> > multiple names?
> Yes. This is string-array.
> > 
> > > +patternProperties:
> > > +  ".*-supply":
> > > +    description:
> > > +      Specified the phandle for various supplies
> > > 
> > > required:
> > >   - compatible
> > > -  - vout-supply
> > > 
> > > additionalProperties: false
> > > 
> > > 
> > 
> > I think it would be nice to also update the examples to show what a
> > multi-supply instance would look like.
> Ack. Will do that.
> > 
> > A slightly more descriptive subject line would also be good -- "Add dt
> > property" is a bit vague.
> Suggestion ?
> How about like 'Allow multiple supplies' or 'Add support for multiple
> supplies'

And indicate this is for regulator-output, As-is looks like it's 
something for all regulators.

Rob

Naresh Solanki April 24, 2023, 7:49 a.m. UTC | #6

Hi Rob,

On 21-04-2023 11:40 pm, Rob Herring wrote:
> On Thu, Apr 20, 2023 at 01:52:30PM +0530, Naresh Solanki wrote:
>> Hi Zev,
>>
>> On 20-04-2023 05:31 am, Zev Weiss wrote:
>>> On Tue, Apr 18, 2023 at 07:50:50AM PDT, Naresh Solanki wrote:
>>>> Add DT property regulator-supplies.
>>>> This enables us to couple one or more regulator output to gether. This
>>>> is use in case of Single connector having 2 or more supplies.
>>>>
>>>> Signed-off-by: Naresh Solanki <Naresh.Solanki@9elements.com>
>>>> ---
>>>> .../bindings/regulator/regulator-output.yaml         | 12 +++++++++---
>>>> 1 file changed, 9 insertions(+), 3 deletions(-)
>>>>
>>>> diff --git
>>>> a/Documentation/devicetree/bindings/regulator/regulator-output.yaml
>>>> b/Documentation/devicetree/bindings/regulator/regulator-output.yaml
>>>> index 078b37a1a71a..17f683d3c1f3 100644
>>>> --- a/Documentation/devicetree/bindings/regulator/regulator-output.yaml
>>>> +++ b/Documentation/devicetree/bindings/regulator/regulator-output.yaml
>>>> @@ -21,13 +21,19 @@ properties:
>>>>    compatible:
>>>>      const: regulator-output
>>>>
>>>> -  vout-supply:
>>>> +  regulator-supplies:
>>>>      description:
>>>> -      Phandle of the regulator supplying the output.
>>>> +      Specifies the name of the output supply provided by the regulator.
>>>> +      Defaults to "vout".
>>>> +    default: "vout"
>>>> +
>>>
>>> Was this meant to be specified as a string-array to allow providing
>>> multiple names?
>> Yes. This is string-array.
>>>
>>>> +patternProperties:
>>>> +  ".*-supply":
>>>> +    description:
>>>> +      Specified the phandle for various supplies
>>>>
>>>> required:
>>>>    - compatible
>>>> -  - vout-supply
>>>>
>>>> additionalProperties: false
>>>>
>>>>
>>>
>>> I think it would be nice to also update the examples to show what a
>>> multi-supply instance would look like.
>> Ack. Will do that.
>>>
>>> A slightly more descriptive subject line would also be good -- "Add dt
>>> property" is a bit vague.
>> Suggestion ?
>> How about like 'Allow multiple supplies' or 'Add support for multiple
>> supplies'
> 
> And indicate this is for regulator-output, As-is looks like it's
> something for all regulators.
Thanks for bringing that to my notice. Will make:
dt-bindings: regulator-output: Add dt property
> 
> Rob
Regards,
Naresh

diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/regulator/regulator-output.yaml b/Documentation/devicetree/bindings/regulator/regulator-output.yaml
index 078b37a1a71a..17f683d3c1f3 100644
--- a/Documentation/devicetree/bindings/regulator/regulator-output.yaml
+++ b/Documentation/devicetree/bindings/regulator/regulator-output.yaml
@@ -21,13 +21,19 @@  properties:
   compatible:
     const: regulator-output
 
-  vout-supply:
+  regulator-supplies:
     description:
-      Phandle of the regulator supplying the output.
+      Specifies the name of the output supply provided by the regulator.
+      Defaults to "vout".
+    default: "vout"
+
+patternProperties:
+  ".*-supply":
+    description:
+      Specified the phandle for various supplies
 
 required:
   - compatible
-  - vout-supply
 
 additionalProperties: false