diff mbox series

[v10,13/14] HP BIOSCFG driver - Makefile

Message ID	20230419151321.6167-14-jorge.lopez2@hp.com
State	New
Headers	Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; From: Jorge Lopez <jorgealtxwork@gmail.com> To: hdegoede@redhat.com, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, thomas@t-8ch.de Subject: [PATCH v10 13/14] HP BIOSCFG driver - Makefile Date: Wed, 19 Apr 2023 10:13:20 -0500 Message-Id: <20230419151321.6167-14-jorge.lopez2@hp.com> In-Reply-To: <20230419151321.6167-1-jorge.lopez2@hp.com> References: <20230419151321.6167-1-jorge.lopez2@hp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk
Series	HP BIOSCFG driver \| [v10,00/14] HP BIOSCFG driver [v10,01/14] HP BIOSCFG driver - Documentation [v10,02/14] HP BIOSCFG driver - biosattr-interface [v10,03/14] HP BIOSCFG driver - bioscfg [v10,04/14] HP BIOSCFG driver - int-attributes [v10,05/14] HP BIOSCFG driver - ordered-attributes [v10,06/14] HP BIOSCFG driver - passwdobj-attributes [v10,07/14] HP BIOSCFG driver - string-attributes [v10,08/14] HP BIOSCFG driver - bioscfg-h [v10,09/14] HP BIOSCFG driver - enum-attributes [v10,10/14] HP BIOSCFG driver - passwdattr-interface [v10,11/14] HP BIOSCFG driver - spmobj-attributes [v10,12/14] HP BIOSCFG driver - surestart-attributes [v10,13/14] HP BIOSCFG driver - Makefile [v10,14/14] HP BIOSCFG driver - MAINTAINERS

Commit Message

Jorge Lopez April 19, 2023, 3:13 p.m. UTC

  HP BIOS Configuration driver purpose is to provide a driver supporting
the latest sysfs class firmware attributes framework allowing the user
to change BIOS settings and security solutions on HP Inc.’s commercial
notebooks.

Many features of HP Commercial notebooks can be managed using Windows
Management Instrumentation (WMI). WMI is an implementation of Web-Based
Enterprise Management (WBEM) that provides a standards-based interface
for changing and monitoring system settings. HP BIOSCFG driver provides
a native Linux solution and the exposed features facilitates the
migration to Linux environments.

The Linux security features to be provided in hp-bioscfg driver enables
managing the BIOS settings and security solutions via sysfs, a virtual
filesystem that can be used by user-mode applications. The new
documentation cover HP-specific firmware sysfs attributes such Secure
Platform Management and Sure Start. Each section provides security
feature description and identifies sysfs directories and files exposed
by the driver.

Many HP Commercial notebooks include a feature called Secure Platform
Management (SPM), which replaces older password-based BIOS settings
management with public key cryptography. PC secure product management
begins when a target system is provisioned with cryptographic keys
that are used to ensure the integrity of communications between system
management utilities and the BIOS.

HP Commercial notebooks have several BIOS settings that control its
behaviour and capabilities, many of which are related to security.
To prevent unauthorized changes to these settings, the system can
be configured to use a cryptographic signature-based authorization
string that the BIOS will use to verify authorization to modify the
setting.

Linux Security components are under development and not published yet.
The only linux component is the driver (hp bioscfg) at this time.
Other published security components are under Windows.

Signed-off-by: Jorge Lopez <jorge.lopez2@hp.com>

---
Based on the latest platform-drivers-x86.git/for-next
---
 drivers/platform/x86/hp/Kconfig             | 16 ++++++++++++++++
 drivers/platform/x86/hp/Makefile            |  1 +
 drivers/platform/x86/hp/hp-bioscfg/Makefile | 13 +++++++++++++
 3 files changed, 30 insertions(+)
 create mode 100644 drivers/platform/x86/hp/hp-bioscfg/Makefile

Comments

kernel test robot April 20, 2023, 1:44 a.m. UTC | #1

Hi Jorge,

kernel test robot noticed the following build warnings:

[auto build test WARNING on linus/master]
[also build test WARNING on v6.3-rc7 next-20230419]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Jorge-Lopez/HP-BIOSCFG-driver-Documentation/20230419-231828
patch link:    https://lore.kernel.org/r/20230419151321.6167-14-jorge.lopez2%40hp.com
patch subject: [PATCH v10 13/14] HP BIOSCFG driver  - Makefile
config: i386-randconfig-a015-20230417 (https://download.01.org/0day-ci/archive/20230420/202304200914.VfJcRutc-lkp@intel.com/config)
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/cfbebfbd4ed15793fab894715bfd74387adcf4f1
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Jorge-Lopez/HP-BIOSCFG-driver-Documentation/20230419-231828
        git checkout cfbebfbd4ed15793fab894715bfd74387adcf4f1
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/platform/x86/hp/hp-bioscfg/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202304200914.VfJcRutc-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c:141:2: warning: variable 'id' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
           if (!buf_cp) {
           ^~~~~~~~~~~~
   include/linux/compiler.h:56:28: note: expanded from macro 'if'
   #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/compiler.h:58:30: note: expanded from macro '__trace_if_var'
   #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
                                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c:169:18: note: uninitialized use occurs here
           clear_passwords(id);
                           ^~
   drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c:141:2: note: remove the 'if' if its condition is always false
           if (!buf_cp) {
           ^~~~~~~~~~~~~~
   include/linux/compiler.h:56:23: note: expanded from macro 'if'
   #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
                         ^
   drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c:138:8: note: initialize the variable 'id' to silence this warning
           int id, ret = -EIO;
                 ^
                  = 0
   1 warning generated.
--
>> drivers/platform/x86/hp/hp-bioscfg/biosattr-interface.c:76:2: warning: variable 'ret' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
           if (!start)
           ^~~~~~~~~~~
   include/linux/compiler.h:56:28: note: expanded from macro 'if'
   #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/compiler.h:58:30: note: expanded from macro '__trace_if_var'
   #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
                                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/platform/x86/hp/hp-bioscfg/biosattr-interface.c:87:9: note: uninitialized use occurs here
           return ret;
                  ^~~
   drivers/platform/x86/hp/hp-bioscfg/biosattr-interface.c:76:2: note: remove the 'if' if its condition is always false
           if (!start)
           ^~~~~~~~~~~
   include/linux/compiler.h:56:23: note: expanded from macro 'if'
   #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
                         ^
   drivers/platform/x86/hp/hp-bioscfg/biosattr-interface.c:72:2: warning: variable 'ret' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
           if (!start)
           ^~~~~~~~~~~
   include/linux/compiler.h:56:28: note: expanded from macro 'if'
   #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/compiler.h:58:30: note: expanded from macro '__trace_if_var'
   #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
                                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/platform/x86/hp/hp-bioscfg/biosattr-interface.c:87:9: note: uninitialized use occurs here
           return ret;
                  ^~~
   drivers/platform/x86/hp/hp-bioscfg/biosattr-interface.c:72:2: note: remove the 'if' if its condition is always false
           if (!start)
           ^~~~~~~~~~~
   include/linux/compiler.h:56:23: note: expanded from macro 'if'
   #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
                         ^
   drivers/platform/x86/hp/hp-bioscfg/biosattr-interface.c:43:2: warning: variable 'ret' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
           if (instance < 0)
           ^~~~~~~~~~~~~~~~~
   include/linux/compiler.h:56:28: note: expanded from macro 'if'
   #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/compiler.h:58:30: note: expanded from macro '__trace_if_var'
   #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
                                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/platform/x86/hp/hp-bioscfg/biosattr-interface.c:87:9: note: uninitialized use occurs here
           return ret;
                  ^~~
   drivers/platform/x86/hp/hp-bioscfg/biosattr-interface.c:43:2: note: remove the 'if' if its condition is always false
           if (instance < 0)
           ^~~~~~~~~~~~~~~~~
   include/linux/compiler.h:56:23: note: expanded from macro 'if'
   #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
                         ^
   drivers/platform/x86/hp/hp-bioscfg/biosattr-interface.c:30:9: note: initialize the variable 'ret' to silence this warning
           int ret;
                  ^
                   = 0
   3 warnings generated.


vim +141 drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c

1780f5eca27fb8 Jorge Lopez 2023-04-19  132  
1780f5eca27fb8 Jorge Lopez 2023-04-19  133  static ssize_t new_password_store(struct kobject *kobj,
1780f5eca27fb8 Jorge Lopez 2023-04-19  134  				  struct kobj_attribute *attr,
1780f5eca27fb8 Jorge Lopez 2023-04-19  135  				  const char *buf, size_t count)
1780f5eca27fb8 Jorge Lopez 2023-04-19  136  {
1780f5eca27fb8 Jorge Lopez 2023-04-19  137  	char *p, *buf_cp = NULL;
1780f5eca27fb8 Jorge Lopez 2023-04-19  138  	int id, ret = -EIO;
1780f5eca27fb8 Jorge Lopez 2023-04-19  139  
1780f5eca27fb8 Jorge Lopez 2023-04-19  140  	buf_cp = kstrdup(buf, GFP_KERNEL);
1780f5eca27fb8 Jorge Lopez 2023-04-19 @141  	if (!buf_cp) {
1780f5eca27fb8 Jorge Lopez 2023-04-19  142  		ret = -ENOMEM;
1780f5eca27fb8 Jorge Lopez 2023-04-19  143  		goto exit_password;
1780f5eca27fb8 Jorge Lopez 2023-04-19  144  	}
1780f5eca27fb8 Jorge Lopez 2023-04-19  145  
1780f5eca27fb8 Jorge Lopez 2023-04-19  146  	p = memchr(buf_cp, '\n', count);
1780f5eca27fb8 Jorge Lopez 2023-04-19  147  
1780f5eca27fb8 Jorge Lopez 2023-04-19  148  	if (p != NULL)
1780f5eca27fb8 Jorge Lopez 2023-04-19  149  		*p = '\0';
1780f5eca27fb8 Jorge Lopez 2023-04-19  150  
1780f5eca27fb8 Jorge Lopez 2023-04-19  151  	id = get_password_instance_id(kobj);
1780f5eca27fb8 Jorge Lopez 2023-04-19  152  
1780f5eca27fb8 Jorge Lopez 2023-04-19  153  	if (id >= 0)
1780f5eca27fb8 Jorge Lopez 2023-04-19  154  		ret = validate_password_input(id, buf_cp);
1780f5eca27fb8 Jorge Lopez 2023-04-19  155  
1780f5eca27fb8 Jorge Lopez 2023-04-19  156  	if (!ret)
1780f5eca27fb8 Jorge Lopez 2023-04-19  157  		strscpy(bioscfg_drv.password_data[id].new_password,
1780f5eca27fb8 Jorge Lopez 2023-04-19  158  			buf_cp,
1780f5eca27fb8 Jorge Lopez 2023-04-19  159  			sizeof(bioscfg_drv.password_data[id].new_password));
1780f5eca27fb8 Jorge Lopez 2023-04-19  160  
1780f5eca27fb8 Jorge Lopez 2023-04-19  161  	if (!ret)
1780f5eca27fb8 Jorge Lopez 2023-04-19  162  		ret = hp_set_attribute(kobj->name, buf_cp);
1780f5eca27fb8 Jorge Lopez 2023-04-19  163  
1780f5eca27fb8 Jorge Lopez 2023-04-19  164  exit_password:
1780f5eca27fb8 Jorge Lopez 2023-04-19  165  	/*
1780f5eca27fb8 Jorge Lopez 2023-04-19  166  	 * Regardless of the results both new and current passwords
1780f5eca27fb8 Jorge Lopez 2023-04-19  167  	 * will be set to zero and avoid security issues
1780f5eca27fb8 Jorge Lopez 2023-04-19  168  	 */
1780f5eca27fb8 Jorge Lopez 2023-04-19  169  	clear_passwords(id);
1780f5eca27fb8 Jorge Lopez 2023-04-19  170  
1780f5eca27fb8 Jorge Lopez 2023-04-19  171  	kfree(buf_cp);
1780f5eca27fb8 Jorge Lopez 2023-04-19  172  	return ret ? ret : count;
1780f5eca27fb8 Jorge Lopez 2023-04-19  173  }
1780f5eca27fb8 Jorge Lopez 2023-04-19  174

kernel test robot April 20, 2023, 3:57 a.m. UTC | #2

Hi Jorge,

kernel test robot noticed the following build warnings:

[auto build test WARNING on linus/master]
[also build test WARNING on v6.3-rc7 next-20230419]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Jorge-Lopez/HP-BIOSCFG-driver-Documentation/20230419-231828
patch link:    https://lore.kernel.org/r/20230419151321.6167-14-jorge.lopez2%40hp.com
patch subject: [PATCH v10 13/14] HP BIOSCFG driver  - Makefile
config: i386-randconfig-s002-20230417 (https://download.01.org/0day-ci/archive/20230420/202304201100.r6QLG0Fc-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.4-39-gce1a6720-dirty
        # https://github.com/intel-lab-lkp/linux/commit/cfbebfbd4ed15793fab894715bfd74387adcf4f1
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Jorge-Lopez/HP-BIOSCFG-driver-Documentation/20230419-231828
        git checkout cfbebfbd4ed15793fab894715bfd74387adcf4f1
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=i386 olddefconfig
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=i386 SHELL=/bin/bash drivers/platform/x86/hp/hp-bioscfg/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202304201100.r6QLG0Fc-lkp@intel.com/

sparse warnings: (new ones prefixed by >>)
>> drivers/platform/x86/hp/hp-bioscfg/surestart-attributes.c:80:23: sparse: sparse: symbol 'sure_start_audit_log_entries' was not declared. Should it be static?
--
>> drivers/platform/x86/hp/hp-bioscfg/spmobj-attributes.c:191:23: sparse: sparse: symbol 'password_spm_status' was not declared. Should it be static?

Jorge Lopez April 20, 2023, 1:28 p.m. UTC | #3

Thank you for the heads up.  I will look  them over.

Regards,

Jorge

On Wed, Apr 19, 2023 at 10:57 PM kernel test robot <lkp@intel.com> wrote:
>
> Hi Jorge,
>
> kernel test robot noticed the following build warnings:
>
> [auto build test WARNING on linus/master]
> [also build test WARNING on v6.3-rc7 next-20230419]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
>
> url:    https://github.com/intel-lab-lkp/linux/commits/Jorge-Lopez/HP-BIOSCFG-driver-Documentation/20230419-231828
> patch link:    https://lore.kernel.org/r/20230419151321.6167-14-jorge.lopez2%40hp.com
> patch subject: [PATCH v10 13/14] HP BIOSCFG driver  - Makefile
> config: i386-randconfig-s002-20230417 (https://download.01.org/0day-ci/archive/20230420/202304201100.r6QLG0Fc-lkp@intel.com/config)
> compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
> reproduce:
>         # apt-get install sparse
>         # sparse version: v0.6.4-39-gce1a6720-dirty
>         # https://github.com/intel-lab-lkp/linux/commit/cfbebfbd4ed15793fab894715bfd74387adcf4f1
>         git remote add linux-review https://github.com/intel-lab-lkp/linux
>         git fetch --no-tags linux-review Jorge-Lopez/HP-BIOSCFG-driver-Documentation/20230419-231828
>         git checkout cfbebfbd4ed15793fab894715bfd74387adcf4f1
>         # save the config file
>         mkdir build_dir && cp config build_dir/.config
>         make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=i386 olddefconfig
>         make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=i386 SHELL=/bin/bash drivers/platform/x86/hp/hp-bioscfg/
>
> If you fix the issue, kindly add following tag where applicable
> | Reported-by: kernel test robot <lkp@intel.com>
> | Link: https://lore.kernel.org/oe-kbuild-all/202304201100.r6QLG0Fc-lkp@intel.com/
>
> sparse warnings: (new ones prefixed by >>)
> >> drivers/platform/x86/hp/hp-bioscfg/surestart-attributes.c:80:23: sparse: sparse: symbol 'sure_start_audit_log_entries' was not declared. Should it be static?
> --
> >> drivers/platform/x86/hp/hp-bioscfg/spmobj-attributes.c:191:23: sparse: sparse: symbol 'password_spm_status' was not declared. Should it be static?
>
> --
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests

Jorge Lopez April 20, 2023, 1:33 p.m. UTC | #4

Thank you.  I will address those issues.

Regards,

Jorge

On Wed, Apr 19, 2023 at 8:45 PM kernel test robot <lkp@intel.com> wrote:
>
> Hi Jorge,
>
> kernel test robot noticed the following build warnings:
>
> [auto build test WARNING on linus/master]
> [also build test WARNING on v6.3-rc7 next-20230419]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
>
> url:    https://github.com/intel-lab-lkp/linux/commits/Jorge-Lopez/HP-BIOSCFG-driver-Documentation/20230419-231828
> patch link:    https://lore.kernel.org/r/20230419151321.6167-14-jorge.lopez2%40hp.com
> patch subject: [PATCH v10 13/14] HP BIOSCFG driver  - Makefile
> config: i386-randconfig-a015-20230417 (https://download.01.org/0day-ci/archive/20230420/202304200914.VfJcRutc-lkp@intel.com/config)
> compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # https://github.com/intel-lab-lkp/linux/commit/cfbebfbd4ed15793fab894715bfd74387adcf4f1
>         git remote add linux-review https://github.com/intel-lab-lkp/linux
>         git fetch --no-tags linux-review Jorge-Lopez/HP-BIOSCFG-driver-Documentation/20230419-231828
>         git checkout cfbebfbd4ed15793fab894715bfd74387adcf4f1
>         # save the config file
>         mkdir build_dir && cp config build_dir/.config
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 olddefconfig
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/platform/x86/hp/hp-bioscfg/
>
> If you fix the issue, kindly add following tag where applicable
> | Reported-by: kernel test robot <lkp@intel.com>
> | Link: https://lore.kernel.org/oe-kbuild-all/202304200914.VfJcRutc-lkp@intel.com/
>
> All warnings (new ones prefixed by >>):
>
> >> drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c:141:2: warning: variable 'id' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
>            if (!buf_cp) {
>            ^~~~~~~~~~~~
>    include/linux/compiler.h:56:28: note: expanded from macro 'if'
>    #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
>                               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>    include/linux/compiler.h:58:30: note: expanded from macro '__trace_if_var'
>    #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
>                                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>    drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c:169:18: note: uninitialized use occurs here
>            clear_passwords(id);
>                            ^~
>    drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c:141:2: note: remove the 'if' if its condition is always false
>            if (!buf_cp) {
>            ^~~~~~~~~~~~~~
>    include/linux/compiler.h:56:23: note: expanded from macro 'if'
>    #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
>                          ^
>    drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c:138:8: note: initialize the variable 'id' to silence this warning
>            int id, ret = -EIO;
>                  ^
>                   = 0
>    1 warning generated.
> --
> >> drivers/platform/x86/hp/hp-bioscfg/biosattr-interface.c:76:2: warning: variable 'ret' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
>            if (!start)
>            ^~~~~~~~~~~
>    include/linux/compiler.h:56:28: note: expanded from macro 'if'
>    #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
>                               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>    include/linux/compiler.h:58:30: note: expanded from macro '__trace_if_var'
>    #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
>                                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>    drivers/platform/x86/hp/hp-bioscfg/biosattr-interface.c:87:9: note: uninitialized use occurs here
>            return ret;
>                   ^~~
>    drivers/platform/x86/hp/hp-bioscfg/biosattr-interface.c:76:2: note: remove the 'if' if its condition is always false
>            if (!start)
>            ^~~~~~~~~~~
>    include/linux/compiler.h:56:23: note: expanded from macro 'if'
>    #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
>                          ^
>    drivers/platform/x86/hp/hp-bioscfg/biosattr-interface.c:72:2: warning: variable 'ret' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
>            if (!start)
>            ^~~~~~~~~~~
>    include/linux/compiler.h:56:28: note: expanded from macro 'if'
>    #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
>                               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>    include/linux/compiler.h:58:30: note: expanded from macro '__trace_if_var'
>    #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
>                                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>    drivers/platform/x86/hp/hp-bioscfg/biosattr-interface.c:87:9: note: uninitialized use occurs here
>            return ret;
>                   ^~~
>    drivers/platform/x86/hp/hp-bioscfg/biosattr-interface.c:72:2: note: remove the 'if' if its condition is always false
>            if (!start)
>            ^~~~~~~~~~~
>    include/linux/compiler.h:56:23: note: expanded from macro 'if'
>    #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
>                          ^
>    drivers/platform/x86/hp/hp-bioscfg/biosattr-interface.c:43:2: warning: variable 'ret' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
>            if (instance < 0)
>            ^~~~~~~~~~~~~~~~~
>    include/linux/compiler.h:56:28: note: expanded from macro 'if'
>    #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
>                               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>    include/linux/compiler.h:58:30: note: expanded from macro '__trace_if_var'
>    #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
>                                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>    drivers/platform/x86/hp/hp-bioscfg/biosattr-interface.c:87:9: note: uninitialized use occurs here
>            return ret;
>                   ^~~
>    drivers/platform/x86/hp/hp-bioscfg/biosattr-interface.c:43:2: note: remove the 'if' if its condition is always false
>            if (instance < 0)
>            ^~~~~~~~~~~~~~~~~
>    include/linux/compiler.h:56:23: note: expanded from macro 'if'
>    #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
>                          ^
>    drivers/platform/x86/hp/hp-bioscfg/biosattr-interface.c:30:9: note: initialize the variable 'ret' to silence this warning
>            int ret;
>                   ^
>                    = 0
>    3 warnings generated.
>
>
> vim +141 drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c
>
> 1780f5eca27fb8 Jorge Lopez 2023-04-19  132
> 1780f5eca27fb8 Jorge Lopez 2023-04-19  133  static ssize_t new_password_store(struct kobject *kobj,
> 1780f5eca27fb8 Jorge Lopez 2023-04-19  134                                struct kobj_attribute *attr,
> 1780f5eca27fb8 Jorge Lopez 2023-04-19  135                                const char *buf, size_t count)
> 1780f5eca27fb8 Jorge Lopez 2023-04-19  136  {
> 1780f5eca27fb8 Jorge Lopez 2023-04-19  137      char *p, *buf_cp = NULL;
> 1780f5eca27fb8 Jorge Lopez 2023-04-19  138      int id, ret = -EIO;
> 1780f5eca27fb8 Jorge Lopez 2023-04-19  139
> 1780f5eca27fb8 Jorge Lopez 2023-04-19  140      buf_cp = kstrdup(buf, GFP_KERNEL);
> 1780f5eca27fb8 Jorge Lopez 2023-04-19 @141      if (!buf_cp) {
> 1780f5eca27fb8 Jorge Lopez 2023-04-19  142              ret = -ENOMEM;
> 1780f5eca27fb8 Jorge Lopez 2023-04-19  143              goto exit_password;
> 1780f5eca27fb8 Jorge Lopez 2023-04-19  144      }
> 1780f5eca27fb8 Jorge Lopez 2023-04-19  145
> 1780f5eca27fb8 Jorge Lopez 2023-04-19  146      p = memchr(buf_cp, '\n', count);
> 1780f5eca27fb8 Jorge Lopez 2023-04-19  147
> 1780f5eca27fb8 Jorge Lopez 2023-04-19  148      if (p != NULL)
> 1780f5eca27fb8 Jorge Lopez 2023-04-19  149              *p = '\0';
> 1780f5eca27fb8 Jorge Lopez 2023-04-19  150
> 1780f5eca27fb8 Jorge Lopez 2023-04-19  151      id = get_password_instance_id(kobj);
> 1780f5eca27fb8 Jorge Lopez 2023-04-19  152
> 1780f5eca27fb8 Jorge Lopez 2023-04-19  153      if (id >= 0)
> 1780f5eca27fb8 Jorge Lopez 2023-04-19  154              ret = validate_password_input(id, buf_cp);
> 1780f5eca27fb8 Jorge Lopez 2023-04-19  155
> 1780f5eca27fb8 Jorge Lopez 2023-04-19  156      if (!ret)
> 1780f5eca27fb8 Jorge Lopez 2023-04-19  157              strscpy(bioscfg_drv.password_data[id].new_password,
> 1780f5eca27fb8 Jorge Lopez 2023-04-19  158                      buf_cp,
> 1780f5eca27fb8 Jorge Lopez 2023-04-19  159                      sizeof(bioscfg_drv.password_data[id].new_password));
> 1780f5eca27fb8 Jorge Lopez 2023-04-19  160
> 1780f5eca27fb8 Jorge Lopez 2023-04-19  161      if (!ret)
> 1780f5eca27fb8 Jorge Lopez 2023-04-19  162              ret = hp_set_attribute(kobj->name, buf_cp);
> 1780f5eca27fb8 Jorge Lopez 2023-04-19  163
> 1780f5eca27fb8 Jorge Lopez 2023-04-19  164  exit_password:
> 1780f5eca27fb8 Jorge Lopez 2023-04-19  165      /*
> 1780f5eca27fb8 Jorge Lopez 2023-04-19  166       * Regardless of the results both new and current passwords
> 1780f5eca27fb8 Jorge Lopez 2023-04-19  167       * will be set to zero and avoid security issues
> 1780f5eca27fb8 Jorge Lopez 2023-04-19  168       */
> 1780f5eca27fb8 Jorge Lopez 2023-04-19  169      clear_passwords(id);
> 1780f5eca27fb8 Jorge Lopez 2023-04-19  170
> 1780f5eca27fb8 Jorge Lopez 2023-04-19  171      kfree(buf_cp);
> 1780f5eca27fb8 Jorge Lopez 2023-04-19  172      return ret ? ret : count;
> 1780f5eca27fb8 Jorge Lopez 2023-04-19  173  }
> 1780f5eca27fb8 Jorge Lopez 2023-04-19  174
>
> --
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests

diff mbox series

Patch

diff --git a/drivers/platform/x86/hp/Kconfig b/drivers/platform/x86/hp/Kconfig
index ae165955311c..7fef4f12e498 100644
--- a/drivers/platform/x86/hp/Kconfig
+++ b/drivers/platform/x86/hp/Kconfig
@@ -60,4 +60,20 @@  config TC1100_WMI
 	  This is a driver for the WMI extensions (wireless and bluetooth power
 	  control) of the HP Compaq TC1100 tablet.
 
+config HP_BIOSCFG
+	tristate "HP BIOS Configuration Driver"
+	default m
+	depends on ACPI_WMI
+	select NLS
+	select FW_ATTR_CLASS
+	help
+	  This driver enables administrators to securely manage BIOS settings
+	  using digital certificates and public-key cryptography that eliminate
+	  the need for passwords for both remote and local management. It supports
+	  changing BIOS settings on many HP machines from 2018 and newer without
+	  the use of any additional software.
+
+	  To compile this driver as a module, choose M here: the module will
+	  be called hp-bioscfg.
+
 endif # X86_PLATFORM_DRIVERS_HP
diff --git a/drivers/platform/x86/hp/Makefile b/drivers/platform/x86/hp/Makefile
index db1eed4cd7c7..e4f908a61acf 100644
--- a/drivers/platform/x86/hp/Makefile
+++ b/drivers/platform/x86/hp/Makefile
@@ -8,3 +8,4 @@ 
 obj-$(CONFIG_HP_ACCEL)		+= hp_accel.o
 obj-$(CONFIG_HP_WMI)		+= hp-wmi.o
 obj-$(CONFIG_TC1100_WMI)	+= tc1100-wmi.o
+obj-$(CONFIG_HP_BIOSCFG)	+= hp-bioscfg/
diff --git a/drivers/platform/x86/hp/hp-bioscfg/Makefile b/drivers/platform/x86/hp/hp-bioscfg/Makefile
new file mode 100644
index 000000000000..529eba6fa47f
--- /dev/null
+++ b/drivers/platform/x86/hp/hp-bioscfg/Makefile
@@ -0,0 +1,13 @@ 
+obj-$(CONFIG_HP_BIOSCFG) := hp-bioscfg.o
+
+hp-bioscfg-objs := bioscfg.o	\
+	enum-attributes.o	\
+	int-attributes.o	\
+	string-attributes.o	\
+	passwdobj-attributes.o	\
+	biosattr-interface.o	\
+	passwdattr-interface.o	\
+	ordered-attributes.o	\
+	surestart-attributes.o	\
+	spmobj-attributes.o
+