Message ID | 20230419-const-partition-v1-1-2d66f2d83873@weissschuh.net |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp198943vqo; Wed, 19 Apr 2023 01:01:35 -0700 (PDT) X-Google-Smtp-Source: AKy350Y7Oxe5j1G6edB2S28XHS50jO2rFHV1SJHmPS62nD6GyrQoe0UO53eFk7yZkusnwDygY2o0 X-Received: by 2002:a05:6870:c1cf:b0:177:ab68:aa9a with SMTP id i15-20020a056870c1cf00b00177ab68aa9amr3031921oad.1.1681891294925; Wed, 19 Apr 2023 01:01:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681891294; cv=none; d=google.com; s=arc-20160816; b=TQ7DVM5FENq/pcxsCEr170shcRL0DbpD+ahGH6A5X3eA6vszG4oxB5hKvY3L2gmCtC jqjiyHN7K7guRCxSSmlKhHPw9BSogjMesij5YqeGW4cc2bT+40ZHcHurhta14MxKqCnR dNm80JDpnOJgb5TdZwS0ZpDs8kXah+32Fpi/tG03Zpo+ZOREjjGm+nPcswRgJ2AqiOKv z87tDP3c+99TOf+uvRmyZjPpixw7j1t80EJ0Nb7oq8pfsIe7CTT+Mg6CTojhLzYJF6DA e1sel2iVeY8s0FNbjc9JwEib1TIvFA65bN4/kD7t3NmK2agLdiIRWhEtuNNqB5X5QgTc NAaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:dkim-signature :from; bh=aVc0DWJRFn7SfpDsP60uvX1ez+3koVzjxEn5Aj3R67E=; b=SjYLre0wzGBmUsKAy87uOeCb3Jc8yq5ZHOJ3etssaCqQAnkHTyUj4Kos39rRYS3sFs zpVeD1XQhvyPVeses3VpPh6Ydy4rmj/DAo1AuDgfH3O0PPyQJpH+Y0Dq/+/Z3WUqI4un RCdyRDGJSpwk/OQwswMXnsk2I44tIcM7WWH340FxWwuV/SUSSiG3a8YbsE6lG+5nL86f wqf4kQBeFjg2bvBai6PhNmeNbF4Okck0OJ/IYRL+0HXJMfzuehOR9JASFcfrcvW47U/p hi8l+GONbxsbGjaILAsmpN6Ui5JxwreXPMlMDFDL06Z1X8uFss85iFr9XgY4XZAlzlZH NvvQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@weissschuh.net header.s=mail header.b=l8DYAJVt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i21-20020a056870891500b001765d22796asi14472994oao.165.2023.04.19.01.01.21; Wed, 19 Apr 2023 01:01:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@weissschuh.net header.s=mail header.b=l8DYAJVt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232471AbjDSHvC (ORCPT <rfc822;peter110.wang@gmail.com> + 99 others); Wed, 19 Apr 2023 03:51:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38536 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232398AbjDSHuj (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Wed, 19 Apr 2023 03:50:39 -0400 Received: from todd.t-8ch.de (todd.t-8ch.de [159.69.126.157]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E1749C175; Wed, 19 Apr 2023 00:50:09 -0700 (PDT) From: =?utf-8?q?Thomas_Wei=C3=9Fschuh?= <linux@weissschuh.net> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=weissschuh.net; s=mail; t=1681890606; bh=kSlTxie2Ksev8vTGCDWHXnNc4gL+EGM1NG1+H1a+m6E=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=l8DYAJVtorw7L4oqC+eL7xArCxF0pNZgDiJh5GTlfkWKPhqU3+9dyZEB5ePCv4+VD Rl0xSBuODwChxCxKuoWOWqxnzlPqZD5y44QD/iH97YYQOfZBaAQCVCMfpwcNpiAzna YgEb+VMGmvp69gQCYdFJMZt8IhD8ozmqO6boHrfw= Date: Wed, 19 Apr 2023 09:50:01 +0200 Subject: [PATCH 1/4] block: constify partition prober array MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Message-Id: <20230419-const-partition-v1-1-2d66f2d83873@weissschuh.net> References: <20230419-const-partition-v1-0-2d66f2d83873@weissschuh.net> In-Reply-To: <20230419-const-partition-v1-0-2d66f2d83873@weissschuh.net> To: Jens Axboe <axboe@kernel.dk> Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, =?utf-8?q?Tho?= =?utf-8?q?mas_Wei=C3=9Fschuh?= <linux@weissschuh.net> X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1681890605; l=698; i=linux@weissschuh.net; s=20221212; h=from:subject:message-id; bh=kSlTxie2Ksev8vTGCDWHXnNc4gL+EGM1NG1+H1a+m6E=; b=DjdLzIs3C9Vi612gPssij7yXcJOt4k/kQJmuexW0wQ7fSreII52rD8l2eI00RFP7uk3Udg0Tq joRXaGTK8QDAKCsrAasX3qd78urpEuX/9fQCfnv/27kCSKmCm7m3uym X-Developer-Key: i=linux@weissschuh.net; a=ed25519; pk=KcycQgFPX2wGR5azS7RhpBqedglOZVgRPfdFSPB1LNw= X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1763590846648371443?= X-GMAIL-MSGID: =?utf-8?q?1763590846648371443?= |
Series | block: constify some structures of partitions/core.c | |
Commit Message
Thomas Weißschuh
April 19, 2023, 7:50 a.m. UTC
The array is never modified so it can be const.
Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
block/partitions/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
Hi Thomas, kernel test robot noticed the following build warnings: [auto build test WARNING on af67688dca57999fd848f051eeea1d375ba546b2] url: https://github.com/intel-lab-lkp/linux/commits/Thomas-Wei-schuh/block-constify-partition-prober-array/20230419-155356 base: af67688dca57999fd848f051eeea1d375ba546b2 patch link: https://lore.kernel.org/r/20230419-const-partition-v1-1-2d66f2d83873%40weissschuh.net patch subject: [PATCH 1/4] block: constify partition prober array config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20230419/202304191640.SkNk7kVN-lkp@intel.com/config) compiler: m68k-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/9bc1f4308c10322c327c9e86ede6bb9e862440aa git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Thomas-Wei-schuh/block-constify-partition-prober-array/20230419-155356 git checkout 9bc1f4308c10322c327c9e86ede6bb9e862440aa # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash block/partitions/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp@intel.com> | Link: https://lore.kernel.org/oe-kbuild-all/202304191640.SkNk7kVN-lkp@intel.com/ All warnings (new ones prefixed by >>): >> block/partitions/core.c:15:8: warning: type qualifiers ignored on function return type [-Wignored-qualifiers] 15 | static const int (*check_part[])(struct parsed_partitions *) = { | ^~~~~ vim +15 block/partitions/core.c 14 > 15 static const int (*check_part[])(struct parsed_partitions *) = { 16 /* 17 * Probe partition formats with tables at disk address 0 18 * that also have an ADFS boot block at 0xdc0. 19 */ 20 #ifdef CONFIG_ACORN_PARTITION_ICS 21 adfspart_check_ICS, 22 #endif 23 #ifdef CONFIG_ACORN_PARTITION_POWERTEC 24 adfspart_check_POWERTEC, 25 #endif 26 #ifdef CONFIG_ACORN_PARTITION_EESOX 27 adfspart_check_EESOX, 28 #endif 29 30 /* 31 * Now move on to formats that only have partition info at 32 * disk address 0xdc0. Since these may also have stale 33 * PC/BIOS partition tables, they need to come before 34 * the msdos entry. 35 */ 36 #ifdef CONFIG_ACORN_PARTITION_CUMANA 37 adfspart_check_CUMANA, 38 #endif 39 #ifdef CONFIG_ACORN_PARTITION_ADFS 40 adfspart_check_ADFS, 41 #endif 42
Hi Thomas, kernel test robot noticed the following build warnings: [auto build test WARNING on af67688dca57999fd848f051eeea1d375ba546b2] url: https://github.com/intel-lab-lkp/linux/commits/Thomas-Wei-schuh/block-constify-partition-prober-array/20230419-155356 base: af67688dca57999fd848f051eeea1d375ba546b2 patch link: https://lore.kernel.org/r/20230419-const-partition-v1-1-2d66f2d83873%40weissschuh.net patch subject: [PATCH 1/4] block: constify partition prober array config: arm64-randconfig-r001-20230416 (https://download.01.org/0day-ci/archive/20230419/202304192132.a6MR0cFR-lkp@intel.com/config) compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project 437b7602e4a998220871de78afcb020b9c14a661) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install arm64 cross compiling tool for clang build # apt-get install binutils-aarch64-linux-gnu # https://github.com/intel-lab-lkp/linux/commit/9bc1f4308c10322c327c9e86ede6bb9e862440aa git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Thomas-Wei-schuh/block-constify-partition-prober-array/20230419-155356 git checkout 9bc1f4308c10322c327c9e86ede6bb9e862440aa # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash block/partitions/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp@intel.com> | Link: https://lore.kernel.org/oe-kbuild-all/202304192132.a6MR0cFR-lkp@intel.com/ All warnings (new ones prefixed by >>): >> block/partitions/core.c:15:8: warning: 'const' type qualifier on return type has no effect [-Wignored-qualifiers] static const int (*check_part[])(struct parsed_partitions *) = { ^~~~~~ block/partitions/core.c:47:2: error: incompatible function pointer types initializing 'const int (*)(struct parsed_partitions *)' with an expression of type 'int (struct parsed_partitions *)' [-Wincompatible-function-pointer-types] efi_partition, /* this must come before msdos */ ^~~~~~~~~~~~~ block/partitions/core.c:50:2: error: incompatible function pointer types initializing 'const int (*)(struct parsed_partitions *)' with an expression of type 'int (struct parsed_partitions *)' [-Wincompatible-function-pointer-types] sgi_partition, ^~~~~~~~~~~~~ block/partitions/core.c:56:2: error: incompatible function pointer types initializing 'const int (*)(struct parsed_partitions *)' with an expression of type 'int (struct parsed_partitions *)' [-Wincompatible-function-pointer-types] msdos_partition, ^~~~~~~~~~~~~~~ block/partitions/core.c:59:2: error: incompatible function pointer types initializing 'const int (*)(struct parsed_partitions *)' with an expression of type 'int (struct parsed_partitions *)' [-Wincompatible-function-pointer-types] osf_partition, ^~~~~~~~~~~~~ block/partitions/core.c:62:2: error: incompatible function pointer types initializing 'const int (*)(struct parsed_partitions *)' with an expression of type 'int (struct parsed_partitions *)' [-Wincompatible-function-pointer-types] sun_partition, ^~~~~~~~~~~~~ block/partitions/core.c:65:2: error: incompatible function pointer types initializing 'const int (*)(struct parsed_partitions *)' with an expression of type 'int (struct parsed_partitions *)' [-Wincompatible-function-pointer-types] amiga_partition, ^~~~~~~~~~~~~~~ block/partitions/core.c:71:2: error: incompatible function pointer types initializing 'const int (*)(struct parsed_partitions *)' with an expression of type 'int (struct parsed_partitions *)' [-Wincompatible-function-pointer-types] mac_partition, ^~~~~~~~~~~~~ 1 warning and 7 errors generated. vim +/const +15 block/partitions/core.c 14 > 15 static const int (*check_part[])(struct parsed_partitions *) = { 16 /* 17 * Probe partition formats with tables at disk address 0 18 * that also have an ADFS boot block at 0xdc0. 19 */ 20 #ifdef CONFIG_ACORN_PARTITION_ICS 21 adfspart_check_ICS, 22 #endif 23 #ifdef CONFIG_ACORN_PARTITION_POWERTEC 24 adfspart_check_POWERTEC, 25 #endif 26 #ifdef CONFIG_ACORN_PARTITION_EESOX 27 adfspart_check_EESOX, 28 #endif 29 30 /* 31 * Now move on to formats that only have partition info at 32 * disk address 0xdc0. Since these may also have stale 33 * PC/BIOS partition tables, they need to come before 34 * the msdos entry. 35 */ 36 #ifdef CONFIG_ACORN_PARTITION_CUMANA 37 adfspart_check_CUMANA, 38 #endif 39 #ifdef CONFIG_ACORN_PARTITION_ADFS 40 adfspart_check_ADFS, 41 #endif 42
Hi Thomas,
kernel test robot noticed the following build errors:
[auto build test ERROR on af67688dca57999fd848f051eeea1d375ba546b2]
url: https://github.com/intel-lab-lkp/linux/commits/Thomas-Wei-schuh/block-constify-partition-prober-array/20230419-155356
base: af67688dca57999fd848f051eeea1d375ba546b2
patch link: https://lore.kernel.org/r/20230419-const-partition-v1-1-2d66f2d83873%40weissschuh.net
patch subject: [PATCH 1/4] block: constify partition prober array
config: arm64-randconfig-r001-20230416 (https://download.01.org/0day-ci/archive/20230420/202304200014.y79VnmJo-lkp@intel.com/config)
compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project 437b7602e4a998220871de78afcb020b9c14a661)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
# https://github.com/intel-lab-lkp/linux/commit/9bc1f4308c10322c327c9e86ede6bb9e862440aa
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Thomas-Wei-schuh/block-constify-partition-prober-array/20230419-155356
git checkout 9bc1f4308c10322c327c9e86ede6bb9e862440aa
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash block/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202304200014.y79VnmJo-lkp@intel.com/
All errors (new ones prefixed by >>):
block/partitions/core.c:15:8: warning: 'const' type qualifier on return type has no effect [-Wignored-qualifiers]
static const int (*check_part[])(struct parsed_partitions *) = {
^~~~~~
>> block/partitions/core.c:47:2: error: incompatible function pointer types initializing 'const int (*)(struct parsed_partitions *)' with an expression of type 'int (struct parsed_partitions *)' [-Wincompatible-function-pointer-types]
efi_partition, /* this must come before msdos */
^~~~~~~~~~~~~
block/partitions/core.c:50:2: error: incompatible function pointer types initializing 'const int (*)(struct parsed_partitions *)' with an expression of type 'int (struct parsed_partitions *)' [-Wincompatible-function-pointer-types]
sgi_partition,
^~~~~~~~~~~~~
block/partitions/core.c:56:2: error: incompatible function pointer types initializing 'const int (*)(struct parsed_partitions *)' with an expression of type 'int (struct parsed_partitions *)' [-Wincompatible-function-pointer-types]
msdos_partition,
^~~~~~~~~~~~~~~
block/partitions/core.c:59:2: error: incompatible function pointer types initializing 'const int (*)(struct parsed_partitions *)' with an expression of type 'int (struct parsed_partitions *)' [-Wincompatible-function-pointer-types]
osf_partition,
^~~~~~~~~~~~~
block/partitions/core.c:62:2: error: incompatible function pointer types initializing 'const int (*)(struct parsed_partitions *)' with an expression of type 'int (struct parsed_partitions *)' [-Wincompatible-function-pointer-types]
sun_partition,
^~~~~~~~~~~~~
block/partitions/core.c:65:2: error: incompatible function pointer types initializing 'const int (*)(struct parsed_partitions *)' with an expression of type 'int (struct parsed_partitions *)' [-Wincompatible-function-pointer-types]
amiga_partition,
^~~~~~~~~~~~~~~
block/partitions/core.c:71:2: error: incompatible function pointer types initializing 'const int (*)(struct parsed_partitions *)' with an expression of type 'int (struct parsed_partitions *)' [-Wincompatible-function-pointer-types]
mac_partition,
^~~~~~~~~~~~~
1 warning and 7 errors generated.
vim +47 block/partitions/core.c
387048bf67eeff Christoph Hellwig 2020-03-24 42
387048bf67eeff Christoph Hellwig 2020-03-24 43 #ifdef CONFIG_CMDLINE_PARTITION
387048bf67eeff Christoph Hellwig 2020-03-24 44 cmdline_partition,
387048bf67eeff Christoph Hellwig 2020-03-24 45 #endif
387048bf67eeff Christoph Hellwig 2020-03-24 46 #ifdef CONFIG_EFI_PARTITION
387048bf67eeff Christoph Hellwig 2020-03-24 @47 efi_partition, /* this must come before msdos */
387048bf67eeff Christoph Hellwig 2020-03-24 48 #endif
387048bf67eeff Christoph Hellwig 2020-03-24 49 #ifdef CONFIG_SGI_PARTITION
387048bf67eeff Christoph Hellwig 2020-03-24 50 sgi_partition,
387048bf67eeff Christoph Hellwig 2020-03-24 51 #endif
387048bf67eeff Christoph Hellwig 2020-03-24 52 #ifdef CONFIG_LDM_PARTITION
387048bf67eeff Christoph Hellwig 2020-03-24 53 ldm_partition, /* this must come before msdos */
387048bf67eeff Christoph Hellwig 2020-03-24 54 #endif
387048bf67eeff Christoph Hellwig 2020-03-24 55 #ifdef CONFIG_MSDOS_PARTITION
387048bf67eeff Christoph Hellwig 2020-03-24 56 msdos_partition,
387048bf67eeff Christoph Hellwig 2020-03-24 57 #endif
387048bf67eeff Christoph Hellwig 2020-03-24 58 #ifdef CONFIG_OSF_PARTITION
387048bf67eeff Christoph Hellwig 2020-03-24 59 osf_partition,
387048bf67eeff Christoph Hellwig 2020-03-24 60 #endif
387048bf67eeff Christoph Hellwig 2020-03-24 61 #ifdef CONFIG_SUN_PARTITION
387048bf67eeff Christoph Hellwig 2020-03-24 62 sun_partition,
387048bf67eeff Christoph Hellwig 2020-03-24 63 #endif
387048bf67eeff Christoph Hellwig 2020-03-24 64 #ifdef CONFIG_AMIGA_PARTITION
387048bf67eeff Christoph Hellwig 2020-03-24 65 amiga_partition,
387048bf67eeff Christoph Hellwig 2020-03-24 66 #endif
387048bf67eeff Christoph Hellwig 2020-03-24 67 #ifdef CONFIG_ATARI_PARTITION
387048bf67eeff Christoph Hellwig 2020-03-24 68 atari_partition,
387048bf67eeff Christoph Hellwig 2020-03-24 69 #endif
387048bf67eeff Christoph Hellwig 2020-03-24 70 #ifdef CONFIG_MAC_PARTITION
387048bf67eeff Christoph Hellwig 2020-03-24 71 mac_partition,
387048bf67eeff Christoph Hellwig 2020-03-24 72 #endif
387048bf67eeff Christoph Hellwig 2020-03-24 73 #ifdef CONFIG_ULTRIX_PARTITION
387048bf67eeff Christoph Hellwig 2020-03-24 74 ultrix_partition,
387048bf67eeff Christoph Hellwig 2020-03-24 75 #endif
387048bf67eeff Christoph Hellwig 2020-03-24 76 #ifdef CONFIG_IBM_PARTITION
387048bf67eeff Christoph Hellwig 2020-03-24 77 ibm_partition,
387048bf67eeff Christoph Hellwig 2020-03-24 78 #endif
387048bf67eeff Christoph Hellwig 2020-03-24 79 #ifdef CONFIG_KARMA_PARTITION
387048bf67eeff Christoph Hellwig 2020-03-24 80 karma_partition,
387048bf67eeff Christoph Hellwig 2020-03-24 81 #endif
387048bf67eeff Christoph Hellwig 2020-03-24 82 #ifdef CONFIG_SYSV68_PARTITION
387048bf67eeff Christoph Hellwig 2020-03-24 83 sysv68_partition,
387048bf67eeff Christoph Hellwig 2020-03-24 84 #endif
387048bf67eeff Christoph Hellwig 2020-03-24 85 NULL
387048bf67eeff Christoph Hellwig 2020-03-24 86 };
387048bf67eeff Christoph Hellwig 2020-03-24 87
Hi Thomas,
kernel test robot noticed the following build warnings:
[auto build test WARNING on af67688dca57999fd848f051eeea1d375ba546b2]
url: https://github.com/intel-lab-lkp/linux/commits/Thomas-Wei-schuh/block-constify-partition-prober-array/20230419-155356
base: af67688dca57999fd848f051eeea1d375ba546b2
patch link: https://lore.kernel.org/r/20230419-const-partition-v1-1-2d66f2d83873%40weissschuh.net
patch subject: [PATCH 1/4] block: constify partition prober array
config: x86_64-randconfig-s023 (https://download.01.org/0day-ci/archive/20230420/202304200454.r3d73iaw-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.4-39-gce1a6720-dirty
# https://github.com/intel-lab-lkp/linux/commit/9bc1f4308c10322c327c9e86ede6bb9e862440aa
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Thomas-Wei-schuh/block-constify-partition-prober-array/20230419-155356
git checkout 9bc1f4308c10322c327c9e86ede6bb9e862440aa
# save the config file
mkdir build_dir && cp config build_dir/.config
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=x86_64 olddefconfig
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=x86_64 SHELL=/bin/bash
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202304200454.r3d73iaw-lkp@intel.com/
sparse warnings: (new ones prefixed by >>)
>> block/partitions/core.c:24:9: sparse: sparse: incorrect type in initializer (different modifiers) @@ expected int ( const * )( ... ) @@ got int ( * )( ... ) @@
block/partitions/core.c:24:9: sparse: expected int ( const * )( ... )
block/partitions/core.c:24:9: sparse: got int ( * )( ... )
block/partitions/core.c:47:9: sparse: sparse: incorrect type in initializer (different modifiers) @@ expected int ( const * )( ... ) @@ got int ( * )( ... ) @@
block/partitions/core.c:47:9: sparse: expected int ( const * )( ... )
block/partitions/core.c:47:9: sparse: got int ( * )( ... )
block/partitions/core.c:53:9: sparse: sparse: incorrect type in initializer (different modifiers) @@ expected int ( const * )( ... ) @@ got int ( * )( ... ) @@
block/partitions/core.c:53:9: sparse: expected int ( const * )( ... )
block/partitions/core.c:53:9: sparse: got int ( * )( ... )
block/partitions/core.c:56:9: sparse: sparse: incorrect type in initializer (different modifiers) @@ expected int ( const * )( ... ) @@ got int ( * )( ... ) @@
block/partitions/core.c:56:9: sparse: expected int ( const * )( ... )
block/partitions/core.c:56:9: sparse: got int ( * )( ... )
block/partitions/core.c:68:9: sparse: sparse: incorrect type in initializer (different modifiers) @@ expected int ( const * )( ... ) @@ got int ( * )( ... ) @@
block/partitions/core.c:68:9: sparse: expected int ( const * )( ... )
block/partitions/core.c:68:9: sparse: got int ( * )( ... )
block/partitions/core.c:71:9: sparse: sparse: incorrect type in initializer (different modifiers) @@ expected int ( const * )( ... ) @@ got int ( * )( ... ) @@
block/partitions/core.c:71:9: sparse: expected int ( const * )( ... )
block/partitions/core.c:71:9: sparse: got int ( * )( ... )
vim +24 block/partitions/core.c
387048bf67eeff Christoph Hellwig 2020-03-24 14
9bc1f4308c1032 Thomas Weißschuh 2023-04-19 15 static const int (*check_part[])(struct parsed_partitions *) = {
387048bf67eeff Christoph Hellwig 2020-03-24 16 /*
387048bf67eeff Christoph Hellwig 2020-03-24 17 * Probe partition formats with tables at disk address 0
387048bf67eeff Christoph Hellwig 2020-03-24 18 * that also have an ADFS boot block at 0xdc0.
387048bf67eeff Christoph Hellwig 2020-03-24 19 */
387048bf67eeff Christoph Hellwig 2020-03-24 20 #ifdef CONFIG_ACORN_PARTITION_ICS
387048bf67eeff Christoph Hellwig 2020-03-24 21 adfspart_check_ICS,
387048bf67eeff Christoph Hellwig 2020-03-24 22 #endif
387048bf67eeff Christoph Hellwig 2020-03-24 23 #ifdef CONFIG_ACORN_PARTITION_POWERTEC
387048bf67eeff Christoph Hellwig 2020-03-24 @24 adfspart_check_POWERTEC,
387048bf67eeff Christoph Hellwig 2020-03-24 25 #endif
387048bf67eeff Christoph Hellwig 2020-03-24 26 #ifdef CONFIG_ACORN_PARTITION_EESOX
387048bf67eeff Christoph Hellwig 2020-03-24 27 adfspart_check_EESOX,
387048bf67eeff Christoph Hellwig 2020-03-24 28 #endif
387048bf67eeff Christoph Hellwig 2020-03-24 29
387048bf67eeff Christoph Hellwig 2020-03-24 30 /*
387048bf67eeff Christoph Hellwig 2020-03-24 31 * Now move on to formats that only have partition info at
387048bf67eeff Christoph Hellwig 2020-03-24 32 * disk address 0xdc0. Since these may also have stale
387048bf67eeff Christoph Hellwig 2020-03-24 33 * PC/BIOS partition tables, they need to come before
387048bf67eeff Christoph Hellwig 2020-03-24 34 * the msdos entry.
387048bf67eeff Christoph Hellwig 2020-03-24 35 */
387048bf67eeff Christoph Hellwig 2020-03-24 36 #ifdef CONFIG_ACORN_PARTITION_CUMANA
387048bf67eeff Christoph Hellwig 2020-03-24 37 adfspart_check_CUMANA,
387048bf67eeff Christoph Hellwig 2020-03-24 38 #endif
387048bf67eeff Christoph Hellwig 2020-03-24 39 #ifdef CONFIG_ACORN_PARTITION_ADFS
387048bf67eeff Christoph Hellwig 2020-03-24 40 adfspart_check_ADFS,
387048bf67eeff Christoph Hellwig 2020-03-24 41 #endif
387048bf67eeff Christoph Hellwig 2020-03-24 42
diff --git a/block/partitions/core.c b/block/partitions/core.c index 7b8ef6296abd..667f3dcebd59 100644 --- a/block/partitions/core.c +++ b/block/partitions/core.c @@ -12,7 +12,7 @@ #include <linux/raid/detect.h> #include "check.h" -static int (*check_part[])(struct parsed_partitions *) = { +static const int (*check_part[])(struct parsed_partitions *) = { /* * Probe partition formats with tables at disk address 0 * that also have an ADFS boot block at 0xdc0.