diff mbox series

[2/2] vfs: clean up d_backing_inode() function

Message ID 20230419072736.172593-2-haifeng.xu@shopee.com
State New
Headers
Series [1/2] vfs: remove unused d_backing_dentry() function |

Commit Message

Haifeng Xu April 19, 2023, 7:27 a.m. UTC 
  Using an extra variable to record the inode is unnecessary, return it
directly.

Signed-off-by: Haifeng Xu <haifeng.xu@shopee.com>
---
 include/linux/dcache.h | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Miklos Szeredi April 19, 2023, 8:05 a.m. UTC | #1 
If we are touching that function, I'd just get rid of it completely
(s/d_backing_inode/d_inode/).

Thanks,
Miklos

On Wed, Apr 19, 2023 at 9:27 AM Haifeng Xu <haifeng.xu@shopee.com> wrote:
>
> Using an extra variable to record the inode is unnecessary, return it
> directly.
>
> Signed-off-by: Haifeng Xu <haifeng.xu@shopee.com>
> ---
>  include/linux/dcache.h | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/include/linux/dcache.h b/include/linux/dcache.h
> index 13023c7211d6..97324b6434e5 100644
> --- a/include/linux/dcache.h
> +++ b/include/linux/dcache.h
> @@ -540,9 +540,7 @@ static inline struct inode *d_inode_rcu(const struct dentry *dentry)
>   */
>  static inline struct inode *d_backing_inode(const struct dentry *upper)
>  {
> -       struct inode *inode = upper->d_inode;
> -
> -       return inode;
> +       return upper->d_inode;
>  }
>
>  /**
> --
> 2.25.1
>
Haifeng Xu April 19, 2023, 9:32 a.m. UTC | #2 
On 2023/4/19 16:05, Miklos Szeredi wrote:
> If we are touching that function, I'd just get rid of it completely
> (s/d_backing_inode/d_inode/).
> 
> Thanks,
> Miklos
> 
> On Wed, Apr 19, 2023 at 9:27 AM Haifeng Xu <haifeng.xu@shopee.com> wrote:
>>
>> Using an extra variable to record the inode is unnecessary, return it
>> directly.
>>
>> Signed-off-by: Haifeng Xu <haifeng.xu@shopee.com>
>> ---
>>  include/linux/dcache.h | 4 +---
>>  1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/include/linux/dcache.h b/include/linux/dcache.h
>> index 13023c7211d6..97324b6434e5 100644
>> --- a/include/linux/dcache.h
>> +++ b/include/linux/dcache.h
>> @@ -540,9 +540,7 @@ static inline struct inode *d_inode_rcu(const struct dentry *dentry)
>>   */
>>  static inline struct inode *d_backing_inode(const struct dentry *upper)
>>  {
>> -       struct inode *inode = upper->d_inode;
>> -
>> -       return inode;
>> +       return upper->d_inode;
>>  }
>>
>>  /**
>> --
>> 2.25.1
>>
> 

Yes, d_backing_inode() does the same thing with d_inode(). Thanks for your suggestion.
diff mbox series

Patch

diff --git a/include/linux/dcache.h b/include/linux/dcache.h
index 13023c7211d6..97324b6434e5 100644
--- a/include/linux/dcache.h
+++ b/include/linux/dcache.h
@@ -540,9 +540,7 @@  static inline struct inode *d_inode_rcu(const struct dentry *dentry)
  */
 static inline struct inode *d_backing_inode(const struct dentry *upper)
 {
-	struct inode *inode = upper->d_inode;
-
-	return inode;
+	return upper->d_inode;
 }
 
 /**