Message ID | 20230418113217.781524-1-Naresh.Solanki@9elements.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp2777372vqo; Tue, 18 Apr 2023 04:42:47 -0700 (PDT) X-Google-Smtp-Source: AKy350atZJY8eNIq6+9kRkTMoa5YMvW2C8RRt0sUJFreOrXoq0rbUefwoXvU8J1o1wwADo1Psxkb X-Received: by 2002:a17:902:f693:b0:1a2:8924:224a with SMTP id l19-20020a170902f69300b001a28924224amr2510962plg.25.1681818167561; Tue, 18 Apr 2023 04:42:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681818167; cv=none; d=google.com; s=arc-20160816; b=QqW7NEXDpUoatXCtyTSnVnRd0jgFg7+xKaNcG0R7q7ROLxXzq8sBRalSM/J8ug0STZ w+K/BaZwHprVBQIE5T9U88Y3KF61XE5n/ltnYMF5FB+MZnST1L+Fidi8doLCvgyCCY1O LNiy7rqvQ6C/aeYUQnc0vivwGuYLQJZ2uuIkPiGGB7htL10Qs0SNxyDY5kyVhlh54nW7 JCLIsgqKHBAQuCk0u0703nAamrqbSoApLQHJbJkmVNQKVnrpvIHDGOdlio1L/iJamcfx VczAco9uc9VKwUPbXu2MahSI6ajmvdtjFjENzf3NU+0LR+VzF93xvGC0Uv/EpvuzGUqN CX1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=D2PeO5e/Aox7QzhHkYSjxJqeqgTXFUOLxZJv9Qdfgrk=; b=A/uiuuNzUT55Pfz5wRdr3IVkG3NM5vmO9jSEwT/iA3Af1c7n0a6niSCtFWs7bFCVKb aIgrBITs0El18UgP+D/KakSpvOQ2yPvhCdR+SLpwctFN3YY6WtLlFmWD9PLJiAXOx987 J63OUop9/ydiz3DQAOhAxsgYb4tk2L/LZmVYtcz6L1Gtg1kvmG4JJ4xvMRy4ZuQGu9ZE JexVbNeB0WbHtVIN+aFcXIM9F5wl9Y6IlW/oaf+x83nErX1sxGM22KS6nypK5x6A46U8 zU3V5TJLh7g1bDO23SaYRZAHHGstEiQSxp3xWTjZHE1dj0vgICU4CCiYTgHcWP7OQibT LcsA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@9elements.com header.s=google header.b=RH+YGD10; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=9elements.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ij29-20020a170902ab5d00b001a1abc91952si13600469plb.194.2023.04.18.04.42.33; Tue, 18 Apr 2023 04:42:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@9elements.com header.s=google header.b=RH+YGD10; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=9elements.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231216AbjDRLcb (ORCPT <rfc822;leviz.kernel.dev@gmail.com> + 99 others); Tue, 18 Apr 2023 07:32:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42968 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229456AbjDRLc3 (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 18 Apr 2023 07:32:29 -0400 Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 120F440D5 for <linux-kernel@vger.kernel.org>; Tue, 18 Apr 2023 04:32:28 -0700 (PDT) Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-3f09b9ac51dso64972805e9.0 for <linux-kernel@vger.kernel.org>; Tue, 18 Apr 2023 04:32:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=9elements.com; s=google; t=1681817546; x=1684409546; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=D2PeO5e/Aox7QzhHkYSjxJqeqgTXFUOLxZJv9Qdfgrk=; b=RH+YGD10Qb+PdrpuxWIl9buclhbzz5Ju3+49P2MB/c7gpU4g2hk4+mSyz85yBYRsRu aKITw2+IQkCfCQ/0uSPr2JODdW+xMEbyEzwguAaWzn6UUjHGkfwYH84T18/xtv7AC7jI ed/gaTsAM/tl4cLmjAk9YYppNvDUMC8Uw4APXW+BrcTD2/sK8IlrdkN76zlQ97u0vuJY 3V45h3AjW5ApD/uJ+zlRSGfolS1unFBNSLN4N87sx0Y4HZ9/rRiqxtDciIpXTH23zZVl NxiQgMQrushL1wTMbAMIKmFqzSuFFh0brDJ1t5z+YFLoEbXOW3zUtl8XM/e18Upje8Yt bJEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681817546; x=1684409546; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=D2PeO5e/Aox7QzhHkYSjxJqeqgTXFUOLxZJv9Qdfgrk=; b=hOpkm5sxkdegRF8TPID86BgePE0KwQ+wAJ7JVBRNqKAAvEmNuANjQfe4/V7QVELCpm UVA2fGruafWK7y1qHs8YwKYUpqTSRyXBiL2S/nfENruc0vDaVrcpbZWLcGVXg6hG1faK u12fU8pdTJwCI36qiLxrvYSzIrC3Tl9I7Wqzna8u87pXpWR6GuoFeGIMti54D4+LW4Qv oA/+U8UPlhnBcVLr25rS+nFu44qtwOVm94L3X5dE1CDtzHQdIeoSnVd/8g35ykbHq8Dp pGBhId6Y9QzlnET2jhtrIc8oaHOaHAE3Fm9SBxjNLPVTxo2uWoppkRlcP/CFOnTM6Nok vHlQ== X-Gm-Message-State: AAQBX9fXxIPmYxTDa1+UQ1XonQqQLjSduaXMNEnaFwYNs1hnoXppjSg7 fkoxom0FgWwCmZxH/2bEoWQdNQ== X-Received: by 2002:adf:f7c5:0:b0:2fb:a0eb:feaa with SMTP id a5-20020adff7c5000000b002fba0ebfeaamr1619941wrq.17.1681817546464; Tue, 18 Apr 2023 04:32:26 -0700 (PDT) Received: from stroh80.sec.9e.network (ip-078-094-000-051.um19.pools.vodafone-ip.de. [78.94.0.51]) by smtp.gmail.com with ESMTPSA id z18-20020adfd0d2000000b002da75c5e143sm12901633wrh.29.2023.04.18.04.32.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Apr 2023 04:32:26 -0700 (PDT) From: Naresh Solanki <naresh.solanki@9elements.com> X-Google-Original-From: Naresh Solanki <Naresh.Solanki@9elements.com> To: Jean Delvare <jdelvare@suse.com>, Guenter Roeck <linux@roeck-us.net>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Naresh Solanki <Naresh.Solanki@9elements.com> Cc: linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/2] dt-bindings: hwmon: Add binding for max6639 Date: Tue, 18 Apr 2023 13:32:16 +0200 Message-Id: <20230418113217.781524-1-Naresh.Solanki@9elements.com> X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1763514167079668947?= X-GMAIL-MSGID: =?utf-8?q?1763514167079668947?= |
Series |
[1/2] dt-bindings: hwmon: Add binding for max6639
|
|
Commit Message
Naresh Solanki
April 18, 2023, 11:32 a.m. UTC
Add Devicetree binding documentation for Maxim MAX6639 temperature
monitor with PWM fan-speed controller.
Signed-off-by: Naresh Solanki <Naresh.Solanki@9elements.com>
---
.../bindings/hwmon/maxim,max6639.yaml | 55 +++++++++++++++++++
1 file changed, 55 insertions(+)
create mode 100644 Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml
base-commit: b8610e0fe08f1476895f141be60f8dd842f0adac
Comments
On 18/04/2023 13:32, Naresh Solanki wrote: > Add Devicetree binding documentation for Maxim MAX6639 temperature > monitor with PWM fan-speed controller. Subject: drop second/last, redundant "binding for". The "dt-bindings" prefix is already stating that these are bindings. > > Signed-off-by: Naresh Solanki <Naresh.Solanki@9elements.com> > --- > .../bindings/hwmon/maxim,max6639.yaml | 55 +++++++++++++++++++ > 1 file changed, 55 insertions(+) > create mode 100644 Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml > > diff --git a/Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml b/Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml > new file mode 100644 > index 000000000000..20b28cd36555 > --- /dev/null > +++ b/Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml > @@ -0,0 +1,55 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > + Drop blank line This is v9. Where is the changelog? Where is previous authorship? At least some parts of it? Why this has less properties than old one? Why this has more mistakes than the old one? Go to previous patch... or fix everything which was already fixed. Best regards, Krzysztof
Hi Krysztof, On 18-04-2023 09:47 pm, Krzysztof Kozlowski wrote: > On 18/04/2023 13:32, Naresh Solanki wrote: >> Add Devicetree binding documentation for Maxim MAX6639 temperature >> monitor with PWM fan-speed controller. > > Subject: drop second/last, redundant "binding for". The "dt-bindings" > prefix is already stating that these are bindings. Ack > >> >> Signed-off-by: Naresh Solanki <Naresh.Solanki@9elements.com> >> --- >> .../bindings/hwmon/maxim,max6639.yaml | 55 +++++++++++++++++++ >> 1 file changed, 55 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml >> >> diff --git a/Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml b/Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml >> new file mode 100644 >> index 000000000000..20b28cd36555 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml >> @@ -0,0 +1,55 @@ >> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> + > > Drop blank line Ack > > This is v9. Where is the changelog? Where is previous authorship? At > least some parts of it? Why this has less properties than old one? Why > this has more mistakes than the old one? Go to previous patch... or fix > everything which was already fixed. This patch is to add basic dt support only hence no additional properties. > > Best regards, > Krzysztof > Regards, Naresh
On 19/04/2023 11:00, Naresh Solanki wrote: > Hi Krysztof, > > On 18-04-2023 09:47 pm, Krzysztof Kozlowski wrote: >> On 18/04/2023 13:32, Naresh Solanki wrote: >>> Add Devicetree binding documentation for Maxim MAX6639 temperature >>> monitor with PWM fan-speed controller. >> >> Subject: drop second/last, redundant "binding for". The "dt-bindings" >> prefix is already stating that these are bindings. > Ack >> >>> >>> Signed-off-by: Naresh Solanki <Naresh.Solanki@9elements.com> >>> --- >>> .../bindings/hwmon/maxim,max6639.yaml | 55 +++++++++++++++++++ >>> 1 file changed, 55 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml >>> >>> diff --git a/Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml b/Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml >>> new file mode 100644 >>> index 000000000000..20b28cd36555 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml >>> @@ -0,0 +1,55 @@ >>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >>> +%YAML 1.2 >>> +--- >>> + >> >> Drop blank line > Ack >> >> This is v9. Where is the changelog? Where is previous authorship? At >> least some parts of it? Why this has less properties than old one? Why >> this has more mistakes than the old one? Go to previous patch... or fix >> everything which was already fixed. > This patch is to add basic dt support only hence no additional properties. How does that answer my questions? Best regards, Krzysztof
Hi On 19-04-2023 02:34 pm, Krzysztof Kozlowski wrote: > On 19/04/2023 11:00, Naresh Solanki wrote: >> Hi Krysztof, >> >> On 18-04-2023 09:47 pm, Krzysztof Kozlowski wrote: >>> On 18/04/2023 13:32, Naresh Solanki wrote: >>>> Add Devicetree binding documentation for Maxim MAX6639 temperature >>>> monitor with PWM fan-speed controller. >>> >>> Subject: drop second/last, redundant "binding for". The "dt-bindings" >>> prefix is already stating that these are bindings. >> Ack >>> >>>> >>>> Signed-off-by: Naresh Solanki <Naresh.Solanki@9elements.com> >>>> --- >>>> .../bindings/hwmon/maxim,max6639.yaml | 55 +++++++++++++++++++ >>>> 1 file changed, 55 insertions(+) >>>> create mode 100644 Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml >>>> >>>> diff --git a/Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml b/Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml >>>> new file mode 100644 >>>> index 000000000000..20b28cd36555 >>>> --- /dev/null >>>> +++ b/Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml >>>> @@ -0,0 +1,55 @@ >>>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >>>> +%YAML 1.2 >>>> +--- >>>> + >>> >>> Drop blank line >> Ack >>> >>> This is v9. Where is the changelog? Where is previous authorship? At >>> least some parts of it? Why this has less properties than old one? Why >>> this has more mistakes than the old one? Go to previous patch... or fix >>> everything which was already fixed. >> This patch is to add basic dt support only hence no additional properties. > > How does that answer my questions? This patch is intended to add dt support for the max6639 driver, and I did not take it from previous patches. As this is a basic dt binding, it has fewer properties compared to the old one. I have used v8 as a reference for this patch, and I will review it again to make sure I have not missed anything. Will ensure to fix them in the next patch. Although I cannot go back to the previous patch, I will address and fix any issues in this patchset. > > Best regards, > Krzysztof > Regards, Naresh
diff --git a/Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml b/Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml new file mode 100644 index 000000000000..20b28cd36555 --- /dev/null +++ b/Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml @@ -0,0 +1,55 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- + +$id: http://devicetree.org/schemas/hwmon/maxim,max6639.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Maxim max6639 Dual fan controller + +maintainers: + - Naresh Solanki <Naresh.Solanki@9elements.com> + +description: | + The MAX6639 is a 2-channel temperature monitor with dual, automatic, PWM + fan-speed controller. It monitors its own temperature and one external + diode-connected transistor or the temperatures of two external diode-connected + transistors, typically available in CPUs, FPGAs, or GPUs. + + Datasheets: + https://datasheets.maximintegrated.com/en/ds/MAX6639-MAX6639F.pdf + +properties: + compatible: + enum: + - maxim,max6639 + + reg: + maxItems: 1 + + '#address-cells': + const: 1 + + '#size-cells': + const: 0 + +required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + i2c { + #address-cells = <1>; + #size-cells = <0>; + + max6639@10 { + compatible = "maxim,max6639"; + reg = <0x10>; + #address-cells = <1>; + #size-cells = <0>; + }; + }; +...