[PATCH-1,rs6000] xfail float128 comparison test case that fails on powerpc64 [PR108728]
Message ID | b7d4dad9-e410-c4f0-62f7-c3b6acdd7d70@linux.ibm.com |
---|---|
State | Accepted |
Headers |
Return-Path: <gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp2551063vqo; Mon, 17 Apr 2023 20:15:07 -0700 (PDT) X-Google-Smtp-Source: AKy350Zd9n75qoaNl9hp4xLZZ3FL6nzIPRneaJZP5pljbeynXEuILWV2aBuMzk70gUDVRcV2Wcsx X-Received: by 2002:a05:6402:b06:b0:506:77e9:7ee4 with SMTP id bm6-20020a0564020b0600b0050677e97ee4mr832981edb.33.1681787707595; Mon, 17 Apr 2023 20:15:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681787707; cv=none; d=google.com; s=arc-20160816; b=eBLUMwami0xrJ2ZrzZDA2iWJiLlewPiCcpKItIxrQ9mCDpHVVRDUC8n0ep77Z27hJD eJ6nvuEpo80p+Y3qbb85eyxX8p8xxBEXZzLi5zpwShqva9aFStk+nGi/DyaRbj9dXIx4 2zixSPWvNOQ6wfdt3mehDiuqWGkpR5IegrHlN0jEdgA2IFKOqiQpzYwreVQHjAhgrasy refB4jan2OHoqe+R5wZ1M2f1aNNI/y6a+6iNwt8LqRKPknBYAYuBTQMF8Psqr5gcODv0 IXjYsadoJFMaFtsd6VyXwLzaVkV3TZbHejbQUVBE98bhZsDlhPR/khG3k7IuM3uGf/Jk RPzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:mime-version :content-transfer-encoding:subject:cc:to:content-language:user-agent :date:message-id:dmarc-filter:delivered-to:dkim-signature :dkim-filter; bh=326teLAlg5WF5p/fFLIewAm2LXqep2tzehcQc6bPz1s=; b=cNuBiKAswJGpMZlJa3aZFrQs2mDc8rNuowrE0AnmdR80KYZ2hn3CqHpUwcj2KNgv3t 25JOC5o6TXyjxICAQY6H6kHHwW3Q8LLl0XqRDt+y/3c0neQvKEcw2jtaZu3gc/fO0uT7 73HQseNXaf3Op67CS43vRFK+jkhot7SM3VRcHD8rpEGeJGmo4G9H7+Y7mqP09r5J2cJ9 brClAoD0j/Eh9GxxOWBcl5pPz9v407/QD8Ifg+4jdrwCYROJB//x8/vfN7xtF8UA//Ya mrBKswqNgH51usCboAIe/j/rxcx5m4D6MABpGxx77S8pYw35Vw1Pk6Kf2MduZGk7YnrN OW/g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=kr6bc3xm; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id v20-20020a056402185400b00506985655f0si5335639edy.355.2023.04.17.20.15.07 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Apr 2023 20:15:07 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=kr6bc3xm; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 13775385771A for <ouuuleilei@gmail.com>; Tue, 18 Apr 2023 03:14:59 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 13775385771A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1681787699; bh=326teLAlg5WF5p/fFLIewAm2LXqep2tzehcQc6bPz1s=; h=Date:To:Cc:Subject:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=kr6bc3xm48ZnEIbp98sNlwrNuoyfiZ876pQh31Zwot7XINDrJfZUxEqvydFvA3a6U OYtQBTor8IsoyHHhrLjsNLVfe5Ovvdh0JR/+179johwJLALzBs01ZQguSSM1R0VcMA nfRqm0Yo86d3ieyKO/FRJloSsWQNfguMNlZK+kcc= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 453A13858D32 for <gcc-patches@gcc.gnu.org>; Tue, 18 Apr 2023 03:14:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 453A13858D32 Received: from pps.filterd (m0353727.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 33I3BjSP019871; Tue, 18 Apr 2023 03:14:07 GMT Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3q1k3ar0yn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 18 Apr 2023 03:14:07 +0000 Received: from m0353727.ppops.net (m0353727.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 33I3CVxu023297; Tue, 18 Apr 2023 03:14:06 GMT Received: from ppma03fra.de.ibm.com (6b.4a.5195.ip4.static.sl-reverse.com [149.81.74.107]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3q1k3ar0xu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 18 Apr 2023 03:14:06 +0000 Received: from pps.filterd (ppma03fra.de.ibm.com [127.0.0.1]) by ppma03fra.de.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 33H5K4wU017234; Tue, 18 Apr 2023 03:14:04 GMT Received: from smtprelay05.fra02v.mail.ibm.com ([9.218.2.225]) by ppma03fra.de.ibm.com (PPS) with ESMTPS id 3pykj69dpg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 18 Apr 2023 03:14:04 +0000 Received: from smtpav05.fra02v.mail.ibm.com (smtpav05.fra02v.mail.ibm.com [10.20.54.104]) by smtprelay05.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 33I3DtOv8192558 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 18 Apr 2023 03:13:55 GMT Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A374120049; Tue, 18 Apr 2023 03:13:55 +0000 (GMT) Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 26A2320043; Tue, 18 Apr 2023 03:13:54 +0000 (GMT) Received: from [9.200.145.81] (unknown [9.200.145.81]) by smtpav05.fra02v.mail.ibm.com (Postfix) with ESMTP; Tue, 18 Apr 2023 03:13:53 +0000 (GMT) Message-ID: <b7d4dad9-e410-c4f0-62f7-c3b6acdd7d70@linux.ibm.com> Date: Tue, 18 Apr 2023 11:13:52 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Content-Language: en-US To: gcc-patches <gcc-patches@gcc.gnu.org> Cc: Segher Boessenkool <segher@kernel.crashing.org>, David <dje.gcc@gmail.com>, "Kewen.Lin" <linkw@linux.ibm.com>, Peter Bergner <bergner@linux.ibm.com> Subject: [PATCH-1, rs6000] xfail float128 comparison test case that fails on powerpc64 [PR108728] Content-Type: text/plain; charset=UTF-8 X-TM-AS-GCONF: 00 X-Proofpoint-GUID: SovM9Up-W7YdHJ1C4P0GIpqNMxRT62pd X-Proofpoint-ORIG-GUID: 0hx_74YhufdlE0WdLWt2s2u14XH_kKru Content-Transfer-Encoding: 7bit X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-04-17_14,2023-04-17_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 bulkscore=0 malwarescore=0 suspectscore=0 adultscore=0 clxscore=1015 mlxlogscore=999 spamscore=0 mlxscore=0 impostorscore=0 priorityscore=1501 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000 definitions=main-2304180027 X-Spam-Status: No, score=-12.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org> List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe> List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/> List-Post: <mailto:gcc-patches@gcc.gnu.org> List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help> List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe> From: HAO CHEN GUI via Gcc-patches <gcc-patches@gcc.gnu.org> Reply-To: HAO CHEN GUI <guihaoc@linux.ibm.com> Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" <gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org> X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1763482227490214029?= X-GMAIL-MSGID: =?utf-8?q?1763482227490214029?= |
Series |
[PATCH-1,rs6000] xfail float128 comparison test case that fails on powerpc64 [PR108728]
|
|
Checks
Context | Check | Description |
---|---|---|
snail/gcc-patch-check | success | Github commit url |
Commit Message
HAO CHEN GUI
April 18, 2023, 3:13 a.m. UTC
Hi, This patch xfails a float128 comparison test case on powerpc64 that fails due to a longstanding issue with floating-point compares. See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58684 for more information. The case is xfailed when instructions of float128 hardware are generated. When software simulation is used, the case should pass. The patch passed regression test on Power Linux platforms. Thanks Gui Haochen ChangeLog rs6000: xfail float128 comparison test case that fails on powerpc64. This patch xfails a float128 comparison test cases on powerpc64 that fails due to a longstanding issue with floating-point compares. See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58684 for more information. gcc/testsuite/ PR target/108728 * gcc.dg/torture/float128-cmp-invalid.c: Add xfail. patch.diff
Comments
Hi Haochen, on 2023/4/18 11:13, HAO CHEN GUI wrote: > Hi, > This patch xfails a float128 comparison test case on powerpc64 > that fails due to a longstanding issue with floating-point > compares. > > See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58684 for more > information. > > The case is xfailed when instructions of float128 hardware are > generated. When software simulation is used, the case should pass. IMHO we should make the comments here (commit log) clearer, like: when float128 hardware gets supported (-mfloat128-hardware takes effect), xscmpuqp is generated for comparison which is unexpected. "When software simulation is used, the case should pass" is not so right, I would interpret the use of __lekf2 as software simulation, we have to xfail this too when the _hw version is used during runtime, please make it clearer. > > The patch passed regression test on Power Linux platforms. > > Thanks > Gui Haochen > > ChangeLog > rs6000: xfail float128 comparison test case that fails on powerpc64. > > This patch xfails a float128 comparison test cases on powerpc64 that > fails due to a longstanding issue with floating-point compares. > > See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58684 for more information. > > gcc/testsuite/ > PR target/108728 > * gcc.dg/torture/float128-cmp-invalid.c: Add xfail. > > patch.diff > diff --git a/gcc/testsuite/gcc.dg/torture/float128-cmp-invalid.c b/gcc/testsuite/gcc.dg/torture/float128-cmp-invalid.c > index 1f675efdd61..7b520d1f9f1 100644 > --- a/gcc/testsuite/gcc.dg/torture/float128-cmp-invalid.c > +++ b/gcc/testsuite/gcc.dg/torture/float128-cmp-invalid.c > @@ -1,5 +1,5 @@ > /* Test for "invalid" exceptions from __float128 comparisons. */ > -/* { dg-do run } */ > +/* { dg-do run { xfail { ppc_float128_hw || { ppc_cpu_supports_hw && p9vector_hw } } } } */ This change looks good to me, though personally I prefer dg-xfail-run-if as we can specify one associated comment with it. :) BR, Kewen > /* { dg-options "" } */ > /* { dg-require-effective-target __float128 } */ > /* { dg-require-effective-target base_quadfloat_support } */
diff --git a/gcc/testsuite/gcc.dg/torture/float128-cmp-invalid.c b/gcc/testsuite/gcc.dg/torture/float128-cmp-invalid.c index 1f675efdd61..7b520d1f9f1 100644 --- a/gcc/testsuite/gcc.dg/torture/float128-cmp-invalid.c +++ b/gcc/testsuite/gcc.dg/torture/float128-cmp-invalid.c @@ -1,5 +1,5 @@ /* Test for "invalid" exceptions from __float128 comparisons. */ -/* { dg-do run } */ +/* { dg-do run { xfail { ppc_float128_hw || { ppc_cpu_supports_hw && p9vector_hw } } } } */ /* { dg-options "" } */ /* { dg-require-effective-target __float128 } */ /* { dg-require-effective-target base_quadfloat_support } */