diff mbox series

[v1,4/9] dt-bindings: hwmon: Modify hpe,gxp-fan-ctrl

Message ID 20230418152824.110823-5-nick.hawkins@hpe.com
State New
Headers
Series ARM: Add GPIO and PSU Support |

Commit Message

Hawkins, Nick April 18, 2023, 3:28 p.m. UTC 
  From: Nick Hawkins <nick.hawkins@hpe.com>

Remove the fn2 register reference as GPIO will
be using it.

Signed-off-by: Nick Hawkins <nick.hawkins@hpe.com>
---
 .../devicetree/bindings/hwmon/hpe,gxp-fan-ctrl.yaml         | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

Comments

Krzysztof Kozlowski April 18, 2023, 5:03 p.m. UTC | #1 
On 18/04/2023 17:28, nick.hawkins@hpe.com wrote:
> From: Nick Hawkins <nick.hawkins@hpe.com>
> 
> Remove the fn2 register reference as GPIO will
> be using it.

Please wrap commit message according to Linux coding style / submission
process (neither too early nor over the limit):
https://elixir.bootlin.com/linux/v5.18-rc4/source/Documentation/process/submitting-patches.rst#L586

Subject: everything is modify/update. Be a bit more descriptive what you
are doing here.

> 
> Signed-off-by: Nick Hawkins <nick.hawkins@hpe.com>
> ---
>  .../devicetree/bindings/hwmon/hpe,gxp-fan-ctrl.yaml         | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)

BTW, bindings go before drivers using them.

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/hwmon/hpe,gxp-fan-ctrl.yaml b/Documentation/devicetree/bindings/hwmon/hpe,gxp-fan-ctrl.yaml
index 4a52aac6be72..ee70f06787f6 100644
--- a/Documentation/devicetree/bindings/hwmon/hpe,gxp-fan-ctrl.yaml
+++ b/Documentation/devicetree/bindings/hwmon/hpe,gxp-fan-ctrl.yaml
@@ -21,13 +21,11 @@  properties:
     items:
       - description: Fan controller PWM
       - description: Programmable logic
-      - description: Function 2
 
   reg-names:
     items:
       - const: base
       - const: pl
-      - const: fn2
 
 required:
   - compatible
@@ -40,6 +38,6 @@  examples:
   - |
     fan-controller@1000c00 {
       compatible = "hpe,gxp-fan-ctrl";
-      reg = <0x1000c00 0x200>, <0xd1000000 0xff>, <0x80200000 0x100000>;
-      reg-names = "base", "pl", "fn2";
+      reg = <0x1000c00 0x200>, <0xd1000000 0xff>;
+      reg-names = "base", "pl";
     };