Message ID | 20220928-mdm9615-dt-schema-fixes-v4-8-dac2dfaac703@linaro.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4242:0:0:0:0:0 with SMTP id s2csp580568wrr; Fri, 21 Oct 2022 02:13:30 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7wCj6HJq3im1sgaoNFHoCKCNdxzm2jdTxVt1yrmpw+GKeYGWE8jFatGFawnqx378auzEKE X-Received: by 2002:a05:6a00:2291:b0:563:9d0d:62ae with SMTP id f17-20020a056a00229100b005639d0d62aemr18660275pfe.17.1666343610449; Fri, 21 Oct 2022 02:13:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666343610; cv=none; d=google.com; s=arc-20160816; b=pOMkdSQxqMcbNeg1qPnB5Y0Y1BnEMr6+D2Ph9h5gxQ3Qp1auJOn84mzqCRypqOiV0R NrbyhzMBLIbMmo70sv9vCta9+QWBJpvnBEFrmfN9ZGAyr7pTNJIQNaovSgTvhRDIzfGf d1AqOQtEJ9Q8Lzky1wsChH2o1NcyavVpvAg4wm/qMJUjvQNmGbDxDVG8xgNCz0/GEMB4 OA78it1i4KHbu8XI6BXgKHI1gBHHBrFOm9XJs9PXpEzgAgCQGLQFuufQlLcRGvmQ/TeV 8m+KYdmYft6iJZEFOIvU2egaUfbbLgft1AQsjba/LTV9tbhiygZkfx6gHEJL8qE8YL16 /qtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:from :dkim-signature; bh=s2dHjCbjXW/wRyX5RnrOPDvSbncypen+BqayjwLtgH0=; b=scXwt6k6CKZY63ai6FRiWTs6ziiWKtr9Vp8RzM+82/4Ph9q51OyiG3KLccRV5q/b4k qit4oHrxgBwTIiZEekAQoBWrMN8pmu2EREvQ9bF8ah4kQ+lp8GBtHAYtSKWbidahGiEI eVazQIlUthTSDLE4kRyP8jOu2tuNuOKZaict85pYnR7XQewMr59SVat+vS+wzXwMIPM3 6/1cZvOLoW7/K9/SdAWw2Gg2sjesol6PUBXbKt75SyeUckFczHQsvpzL/1ywF3v+TQKe fU3uLag02V0mdh9Y0EyZxNJy1HRFBktK8LoTrvSshm7hD8X43nKoIbigI27nikjyx8Ox BV8Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=BU5GmauM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id il10-20020a17090b164a00b001f335a72172si7008395pjb.62.2022.10.21.02.13.17; Fri, 21 Oct 2022 02:13:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=BU5GmauM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231226AbiJUJJj (ORCPT <rfc822;pwkd43@gmail.com> + 99 others); Fri, 21 Oct 2022 05:09:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35588 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231168AbiJUJJB (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 21 Oct 2022 05:09:01 -0400 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E1CF01A3E07 for <linux-kernel@vger.kernel.org>; Fri, 21 Oct 2022 02:08:58 -0700 (PDT) Received: by mail-wr1-x435.google.com with SMTP id a10so3342911wrm.12 for <linux-kernel@vger.kernel.org>; Fri, 21 Oct 2022 02:08:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=s2dHjCbjXW/wRyX5RnrOPDvSbncypen+BqayjwLtgH0=; b=BU5GmauMtsJbxzoW3M8HF62Q7USBINYhrQ/egAo+/CMIP61fhSf3FXUMjyVSa2WBHf /Z4PSiX8Xd2LX1WvsFq28WsS4NeInp94H8nMYbEoyqo3CsGilMXyp0BLuG67ON5Yl6jA BXpRk5f8ERR64ZlctzLNkyf15csMfMS4E/axdBE5wsr5RGg7VB1k0v15MSHJIX1vFcBH 8MYKuet44iMzdgqvU1gXl/i4wqanCCuXQ9v768QOOS8s2/pHu99rk9B5HhHPoZeDExx2 ubfnNxhGHUTrAs82eDdt13qz+lkgGzmspxCUMQ8gWpJ2tb1lUvX0zPvuiHw4oNdT3chn oXQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=s2dHjCbjXW/wRyX5RnrOPDvSbncypen+BqayjwLtgH0=; b=H10OlYZgvTmt2MMfjQ1LLPOH6ALlY/0xRTpYHPi+t2o9ADJO2/FXLmb0RqCdgVVUO6 HT//+2cwE4zfcCrHVK4Ecye0+MF4FMMm/zcVz2E0yrSRw4fX63+at4NM9HueC4sbdFTq xYJ+kcPDAF5sCldRyNF3Jmm1EmWy8HIPL6teA+U9MY2jBGMlizXYE5NWXIsrFyzE51pX gtmAvrK0/EEq5Hrr27WDbKnQaabQc/rOf82VDagyHfZv9EDAWw+viphAnudLfAL6+EPN VqNhc02dNMrrSvSTuM9Hle5Ib07LcdkzWmztYbNt4XEsoBSIARHRdCiYO81sd6AFzdES O8xw== X-Gm-Message-State: ACrzQf3E8U5S8rSJpwz8jGTGL8dhZ6M6f4CM/bv/HF9tbImIuFlcP4se Pn53HIAwMaImZHMJEGz9YZ42+A== X-Received: by 2002:a5d:63d1:0:b0:235:9aeb:e365 with SMTP id c17-20020a5d63d1000000b002359aebe365mr5572793wrw.77.1666343336475; Fri, 21 Oct 2022 02:08:56 -0700 (PDT) Received: from arrakeen.starnux.net ([2a01:e0a:982:cbb0:8261:5fff:fe11:bdda]) by smtp.gmail.com with ESMTPSA id v10-20020a05600c444a00b003c6f27d275dsm2230286wmn.33.2022.10.21.02.08.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Oct 2022 02:08:56 -0700 (PDT) From: Neil Armstrong <neil.armstrong@linaro.org> Date: Fri, 21 Oct 2022 11:06:44 +0200 Subject: [PATCH v4 08/11] mfd: qcom-pm8xxx: drop unused PM8018 compatible MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Message-Id: <20220928-mdm9615-dt-schema-fixes-v4-8-dac2dfaac703@linaro.org> References: <20220928-mdm9615-dt-schema-fixes-v4-0-dac2dfaac703@linaro.org> In-Reply-To: <20220928-mdm9615-dt-schema-fixes-v4-0-dac2dfaac703@linaro.org> To: Bjorn Andersson <andersson@kernel.org>, Satya Priya <quic_c_skakit@quicinc.com>, Lee Jones <lee@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Rob Herring <robh+dt@kernel.org>, Konrad Dybcio <konrad.dybcio@somainline.org>, Dmitry Torokhov <dmitry.torokhov@gmail.com>, Alexandre Belloni <alexandre.belloni@bootlin.com>, Andy Gross <agross@kernel.org>, Alessandro Zummo <a.zummo@towertech.it> Cc: Bjorn Andersson <andersson@kernel.org>, linux-input@vger.kernel.org, linux-arm-msm@vger.kernel.org, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, devicetree@vger.kernel.org, Neil Armstrong <neil.armstrong@linaro.org>, Rob Herring <robh@kernel.org>, linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.10.1 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747287918075845173?= X-GMAIL-MSGID: =?utf-8?q?1747287918075845173?= |
Series |
arm: qcom: mdm9615: first round of bindings and DT fixes
|
|
Commit Message
Neil Armstrong
Oct. 21, 2022, 9:06 a.m. UTC
The PM8018 compatible is always used with PM8921 fallback, so PM8018 compatible can be safely removed from device ID table Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> --- drivers/mfd/qcom-pm8xxx.c | 1 - 1 file changed, 1 deletion(-)
Comments
On Fri, 21 Oct 2022, Neil Armstrong wrote: > The PM8018 compatible is always used with PM8921 fallback, so PM8018 > compatible can be safely removed from device ID table > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> Tags should appear chronologically. I've fixed this up and applied the patch, thanks. > --- > drivers/mfd/qcom-pm8xxx.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/mfd/qcom-pm8xxx.c b/drivers/mfd/qcom-pm8xxx.c > index 2f2734ba5273..601106580e2e 100644 > --- a/drivers/mfd/qcom-pm8xxx.c > +++ b/drivers/mfd/qcom-pm8xxx.c > @@ -497,7 +497,6 @@ static const struct pm_irq_data pm8821_data = { > }; > > static const struct of_device_id pm8xxx_id_table[] = { > - { .compatible = "qcom,pm8018", .data = &pm8xxx_data}, > { .compatible = "qcom,pm8058", .data = &pm8xxx_data}, > { .compatible = "qcom,pm8821", .data = &pm8821_data}, > { .compatible = "qcom,pm8921", .data = &pm8xxx_data}, >
Hi, On 31/10/2022 16:32, Lee Jones wrote: > On Fri, 21 Oct 2022, Neil Armstrong wrote: > >> The PM8018 compatible is always used with PM8921 fallback, so PM8018 >> compatible can be safely removed from device ID table >> >> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> > > Tags should appear chronologically. Indeed, they were added by b4, I'll report this. Thanks, Neil > > I've fixed this up and applied the patch, thanks. > >> --- >> drivers/mfd/qcom-pm8xxx.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/drivers/mfd/qcom-pm8xxx.c b/drivers/mfd/qcom-pm8xxx.c >> index 2f2734ba5273..601106580e2e 100644 >> --- a/drivers/mfd/qcom-pm8xxx.c >> +++ b/drivers/mfd/qcom-pm8xxx.c >> @@ -497,7 +497,6 @@ static const struct pm_irq_data pm8821_data = { >> }; >> >> static const struct of_device_id pm8xxx_id_table[] = { >> - { .compatible = "qcom,pm8018", .data = &pm8xxx_data}, >> { .compatible = "qcom,pm8058", .data = &pm8xxx_data}, >> { .compatible = "qcom,pm8821", .data = &pm8821_data}, >> { .compatible = "qcom,pm8921", .data = &pm8xxx_data}, >> >
On 31/10/2022 11:32, Lee Jones wrote: > On Fri, 21 Oct 2022, Neil Armstrong wrote: > >> The PM8018 compatible is always used with PM8921 fallback, so PM8018 >> compatible can be safely removed from device ID table >> >> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> > > Tags should appear chronologically. > I would assume that as well, but `b4 trailers` disagrees. It documents even this behavior (the chain of custody) here: https://b4.docs.kernel.org/en/latest/config.html So while I agree with you, I also prefer the tools to make the decision instead of humans (to follow the process, assuming the tool implements the process). Either the tool should be fixed or the tool's decision is correct. Best regards, Krzysztof
On Wed, 02 Nov 2022, Krzysztof Kozlowski wrote: > On 31/10/2022 11:32, Lee Jones wrote: > > On Fri, 21 Oct 2022, Neil Armstrong wrote: > > > >> The PM8018 compatible is always used with PM8921 fallback, so PM8018 > >> compatible can be safely removed from device ID table > >> > >> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > >> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> > > > > Tags should appear chronologically. > > > > I would assume that as well, but `b4 trailers` disagrees. It documents > even this behavior (the chain of custody) here: > https://b4.docs.kernel.org/en/latest/config.html > > So while I agree with you, I also prefer the tools to make the decision > instead of humans (to follow the process, assuming the tool implements > the process). Either the tool should be fixed or the tool's decision is > correct. Take a look further down the thread, since this has already been heavily debated. Not sure if there has been a clear winner or any kind of agreement yet (if there ever will be), but until there is or I until I am convinced otherwise, I'm going to continue on with the chronological method. Also, as far as I'm aware, tools like `b4` and the-like haven't been mandated (yet?), so using its rules to dictate our actions probably isn't the correct approach.
diff --git a/drivers/mfd/qcom-pm8xxx.c b/drivers/mfd/qcom-pm8xxx.c index 2f2734ba5273..601106580e2e 100644 --- a/drivers/mfd/qcom-pm8xxx.c +++ b/drivers/mfd/qcom-pm8xxx.c @@ -497,7 +497,6 @@ static const struct pm_irq_data pm8821_data = { }; static const struct of_device_id pm8xxx_id_table[] = { - { .compatible = "qcom,pm8018", .data = &pm8xxx_data}, { .compatible = "qcom,pm8058", .data = &pm8xxx_data}, { .compatible = "qcom,pm8821", .data = &pm8821_data}, { .compatible = "qcom,pm8921", .data = &pm8xxx_data},