diff mbox series

[v2] docs: f2fs: specify extent cache for read explicitly

Message ID 20230417044100.56409-1-frank.li@vivo.com
State New
Headers
Series [v2] docs: f2fs: specify extent cache for read explicitly |

Commit Message

李扬韬 April 17, 2023, 4:41 a.m. UTC 
  Let's descrbie it's read extent cache.

Signed-off-by: Yangtao Li <frank.li@vivo.com>
---
v2:
-s/an/a
 Documentation/filesystems/f2fs.rst | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Bagas Sanjaya April 18, 2023, 2:10 a.m. UTC | #1 
On 4/17/23 11:41, Yangtao Li wrote:
> Let's descrbie it's read extent cache.

"Clarify the fact that extent_cache and noextent_cache toggle read
extent cache on or off."

> -extent_cache		 Enable an extent cache based on rb-tree, it can cache
> -			 as many as extent which map between contiguous logical
> +extent_cache		 Enable a read extent cache based on rb-tree, it can cache
"... . It can cache ..."

>  noinline_data		 Disable the inline data feature, inline data feature is
>  			 enabled by default.

"Disable inline data feature, for which the feature is enabled by
default." (submit as separate patch).

Thanks.
Jonathan Corbet April 18, 2023, 1:47 p.m. UTC | #2 
Bagas Sanjaya <bagasdotme@gmail.com> writes:

> On 4/17/23 11:41, Yangtao Li wrote:
>> Let's descrbie it's read extent cache.
>
> "Clarify the fact that extent_cache and noextent_cache toggle read
> extent cache on or off."

Please stop nit-picking patches.  This is good enough, though I might
fix the "describe" typo on the way in.

>> -extent_cache		 Enable an extent cache based on rb-tree, it can cache
>> -			 as many as extent which map between contiguous logical
>> +extent_cache		 Enable a read extent cache based on rb-tree, it can cache
> "... . It can cache ..."

Bagas.  Enough.  Seriously.

>>  noinline_data		 Disable the inline data feature, inline data feature is
>>  			 enabled by default.
>
> "Disable inline data feature, for which the feature is enabled by
> default." (submit as separate patch).

And please stop trying to make additional work for others.  If you want
to improve something, submit a patch yourself.

jon
diff mbox series

Patch

diff --git a/Documentation/filesystems/f2fs.rst b/Documentation/filesystems/f2fs.rst
index c57745375edb..84911b7aff25 100644
--- a/Documentation/filesystems/f2fs.rst
+++ b/Documentation/filesystems/f2fs.rst
@@ -163,11 +163,11 @@  barrier			 If this option is set, cache_flush commands are allowed to be
 fastboot		 This option is used when a system wants to reduce mount
 			 time as much as possible, even though normal performance
 			 can be sacrificed.
-extent_cache		 Enable an extent cache based on rb-tree, it can cache
-			 as many as extent which map between contiguous logical
+extent_cache		 Enable a read extent cache based on rb-tree, it can cache
+			 many extents which map between contiguous logical
 			 address and physical address per inode, resulting in
 			 increasing the cache hit ratio. Set by default.
-noextent_cache		 Disable an extent cache based on rb-tree explicitly, see
+noextent_cache		 Disable a read extent cache based on rb-tree explicitly, see
 			 the above extent_cache mount option.
 noinline_data		 Disable the inline data feature, inline data feature is
 			 enabled by default.