diff mbox series

driver core: auxiliary bus: No need to get auxdev->dev again

Message ID 20230418122406.1338-1-angus.chen@jaguarmicro.com
State New
Headers
Series driver core: auxiliary bus: No need to get auxdev->dev again |

Commit Message

Angus Chen April 18, 2023, 12:24 p.m. UTC 
  Use dev variable directly.
No functional change intended.

Signed-off-by: Angus Chen <angus.chen@jaguarmicro.com>
---
 drivers/base/auxiliary.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Greg KH April 18, 2023, 12:32 p.m. UTC | #1 
On Tue, Apr 18, 2023 at 08:24:06PM +0800, Angus Chen wrote:
> Use dev variable directly.
> No functional change intended.

Not intended, but is it really intended?  What does this line mean?

> 
> Signed-off-by: Angus Chen <angus.chen@jaguarmicro.com>
> ---
>  drivers/base/auxiliary.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/base/auxiliary.c b/drivers/base/auxiliary.c
> index 4d4c2c8d26c4..ca1d044ff738 100644
> --- a/drivers/base/auxiliary.c
> +++ b/drivers/base/auxiliary.c
> @@ -286,7 +286,7 @@ int auxiliary_device_init(struct auxiliary_device *auxdev)
>  	}
>  
>  	dev->bus = &auxiliary_bus_type;
> -	device_initialize(&auxdev->dev);
> +	device_initialize(dev);

While an interesting change, is it needed?  Why make it?

thanks,

greg k-h
Angus Chen April 19, 2023, 1:02 a.m. UTC | #2 
> -----Original Message-----
> From: Greg KH <gregkh@linuxfoundation.org>
> Sent: Tuesday, April 18, 2023 8:32 PM
> To: Angus Chen <angus.chen@jaguarmicro.com>
> Cc: rafael@kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH] driver core: auxiliary bus: No need to get auxdev->dev
> again
> 
> On Tue, Apr 18, 2023 at 08:24:06PM +0800, Angus Chen wrote:
> > Use dev variable directly.
> > No functional change intended.
> 
> Not intended, but is it really intended?  What does this line mean?
> 
> >
> > Signed-off-by: Angus Chen <angus.chen@jaguarmicro.com>
> > ---
> >  drivers/base/auxiliary.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/base/auxiliary.c b/drivers/base/auxiliary.c
> > index 4d4c2c8d26c4..ca1d044ff738 100644
> > --- a/drivers/base/auxiliary.c
> > +++ b/drivers/base/auxiliary.c
> > @@ -286,7 +286,7 @@ int auxiliary_device_init(struct auxiliary_device
> *auxdev)
> >  	}
> >
> >  	dev->bus = &auxiliary_bus_type;
> > -	device_initialize(&auxdev->dev);
> > +	device_initialize(dev);
> 
> While an interesting change, is it needed?  Why make it?
I mean it just a clean up.beacuse
struct device *dev = &auxdev->dev;
thanks.

> 
> thanks,
> 
> greg k-h
diff mbox series

Patch

diff --git a/drivers/base/auxiliary.c b/drivers/base/auxiliary.c
index 4d4c2c8d26c4..ca1d044ff738 100644
--- a/drivers/base/auxiliary.c
+++ b/drivers/base/auxiliary.c
@@ -286,7 +286,7 @@  int auxiliary_device_init(struct auxiliary_device *auxdev)
 	}
 
 	dev->bus = &auxiliary_bus_type;
-	device_initialize(&auxdev->dev);
+	device_initialize(dev);
 	return 0;
 }
 EXPORT_SYMBOL_GPL(auxiliary_device_init);