Message ID | 20221028023711.4196-1-slark_xiao@163.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp576667wru; Thu, 27 Oct 2022 19:38:59 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6eDpTk68wBcjy1KeLz9TV4BrNU4I551RFjX/uvEdvsRuFSvkM/p/rOMqyP74+KlE1RX5oZ X-Received: by 2002:a17:907:948f:b0:7a8:6861:819a with SMTP id dm15-20020a170907948f00b007a86861819amr21633042ejc.30.1666924739079; Thu, 27 Oct 2022 19:38:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666924739; cv=none; d=google.com; s=arc-20160816; b=WCZImpkbheii2dnlOG7PpkzmTc6kXFKSN5PXqCZ5E+C1gOU81O17Cx92teZ7zhEIAm VTKBjQ6EfUw6A7CnBA75SzNLv4/YfMT7Y+LEqOBcnsKltxiJci7sorXdvdUw93fRp5Lk SYvJ+XaLVVA5/u5koc9dnqTjqO/zMelah5G3QqP+p3oj1a02A6C01Lsr2glkC1nH9i++ CMWiN4O2PR3zA5qSplyKw1JQPjQJWuExlJasKjYxMWaRMaUfm6iJeYo4req6vwSjp1YU m2Ac0pr/lH+gjUwnxRFVrKbbKYX/AIVsxy6V0t1CIzbe7TyWQGEwLYu7b+fe2+DWWlhV ZQyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=zqkmr0wA7VhQA95CKLsLqZlQw5p80Szn0PM+lT5Es9U=; b=J9ZrYfQbX3ObQsvKf0VNgy/d6Z6s7C8eBd+6qfsq6Y/nt9uVdjP83f3Pgf6lxi5Xfk T3pt4ryVzDBwKqxcCAZaqMb1pHq2rSoiELL2TZ4PfYi/++js3VQMGRApT32zOnPE3ye2 Vn08jbV8oEtBWSzFiG2DlW1N1xjpP19s+KGbMNPMsl/o8NSiSnTDAneThuOQL0PtmM65 Ln6lQY0HRqSe8N6YbInofb4DBYYnVdxq2c0PTU8ZQlTSYSHtbbBSff41rAo/ehddJQ/7 zDFFDrV5D/UQgWeQyQXoDtW2lmr3izF+9NGZ07yXvbOwM6j1LJNMG9U2aW0TFp8SklKV GOmA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b=Jn2N7yUu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=163.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id sg9-20020a170907a40900b0078dd12d0a9bsi520125ejc.875.2022.10.27.19.38.35; Thu, 27 Oct 2022 19:38:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b=Jn2N7yUu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=163.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236217AbiJ1CiC (ORCPT <rfc822;chrisfriedt@gmail.com> + 99 others); Thu, 27 Oct 2022 22:38:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49558 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236185AbiJ1Ch3 (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Thu, 27 Oct 2022 22:37:29 -0400 Received: from m12-11.163.com (m12-11.163.com [220.181.12.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 766E0A474; Thu, 27 Oct 2022 19:37:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=zqkmr 0wA7VhQA95CKLsLqZlQw5p80Szn0PM+lT5Es9U=; b=Jn2N7yUuCkWpV+D6wJUsq QlXBH73ICQNd2e74cmEbhfANjsZaNAsAHPGP5ff8cZbmlkBkHEuCFfII5/RQJr8B LAlsKha++y6hz6lIJFpa3rfu11Cwji7Ag7TDFuigYIgPAiqCk5n5qgFrqM1p3F5A US09HfBkKlFJ2IM4MrZPpY= Received: from jbd-ThinkPad-X1-Nano-Gen-1.. (unknown [223.104.77.214]) by smtp7 (Coremail) with SMTP id C8CowADXe9VaQFtjLOfMOQ--.4894S2; Fri, 28 Oct 2022 10:37:16 +0800 (CST) From: Slark Xiao <slark_xiao@163.com> To: bhelgaas@google.com Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Slark Xiao <slark_xiao@163.com> Subject: [PATCH v2] PCI: Add vendor ID for Quectel and Cinterion Date: Fri, 28 Oct 2022 10:37:11 +0800 Message-Id: <20221028023711.4196-1-slark_xiao@163.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID: C8CowADXe9VaQFtjLOfMOQ--.4894S2 X-Coremail-Antispam: 1Uf129KBjvJXoW7ZF1UWw47tFy5CF4DZF4rAFb_yoW8GryfpF s8CrWktr48JFW7Gw1vyr1DWF9FvFs0kFn8AF1agw4F9F47Xw48XryUArs0kryagFs2qrW5 XF1DCws0ga4DXw7anT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x0pioUDkUUUUU= X-Originating-IP: [223.104.77.214] X-CM-SenderInfo: xvod2y5b0lt0i6rwjhhfrp/1tbiRxyoZFc7ZFzyLAAAsd X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747897274786653969?= X-GMAIL-MSGID: =?utf-8?q?1747897274786653969?= |
Series |
[v2] PCI: Add vendor ID for Quectel and Cinterion
|
|
Commit Message
Slark Xiao
Oct. 28, 2022, 2:37 a.m. UTC
In MHI driver, there are some companies product still do not have their
own PCI vendor macro. So we add it here to make the code neat. Ref ID
could be found in link https://pcisig.com/membership/member-companies
and https://pciids.sourceforge.net/pci.ids . Thales use Cinterion as
their IOT modem card's trademark. So you will find 0x1269 belongs to
Thales. Actually, Cinterion belongs to Gemalto, and Gemalto belongs to
Thales.
Signed-off-by: Slark Xiao <slark_xiao@163.com>
---
include/linux/pci_ids.h | 4 ++++
1 file changed, 4 insertions(+)
Comments
On Fri, Oct 28, 2022 at 10:37:11AM +0800, Slark Xiao wrote: > In MHI driver, there are some companies product still do not have their > own PCI vendor macro. So we add it here to make the code neat. Ref ID > could be found in link https://pcisig.com/membership/member-companies > and https://pciids.sourceforge.net/pci.ids . Thales use Cinterion as > their IOT modem card's trademark. So you will find 0x1269 belongs to > Thales. Actually, Cinterion belongs to Gemalto, and Gemalto belongs to > Thales. > The patch description is confusing me. What about below instead? ``` Add missing vendor ID for Cinterion (which is 0x1269). ``` > Signed-off-by: Slark Xiao <slark_xiao@163.com> > --- > include/linux/pci_ids.h | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h > index b362d90eb9b0..9e2b6286f53f 100644 > --- a/include/linux/pci_ids.h > +++ b/include/linux/pci_ids.h > @@ -1765,6 +1765,8 @@ > #define PCI_VENDOR_ID_SATSAGEM 0x1267 > #define PCI_DEVICE_ID_SATSAGEM_NICCY 0x1016 > > +#define PCI_VENDOR_ID_CINTERION 0x1269 /* Celluar Modules*/ > + > #define PCI_VENDOR_ID_ENSONIQ 0x1274 > #define PCI_DEVICE_ID_ENSONIQ_CT5880 0x5880 > #define PCI_DEVICE_ID_ENSONIQ_ES1370 0x5000 > @@ -2585,6 +2587,8 @@ > #define PCI_VENDOR_ID_TEKRAM 0x1de1 > #define PCI_DEVICE_ID_TEKRAM_DC290 0xdc29 > > +#define PCI_VENDOR_ID_QUECTEL 0x1eac > + Why pourring in Quectel ID while this patch is about Cinterion? Thanks.
At 2022-10-28 11:51:23, "Bagas Sanjaya" <bagasdotme@gmail.com> wrote: >On Fri, Oct 28, 2022 at 10:37:11AM +0800, Slark Xiao wrote: >> In MHI driver, there are some companies product still do not have their >> own PCI vendor macro. So we add it here to make the code neat. Ref ID >> could be found in link https://pcisig.com/membership/member-companies >> and https://pciids.sourceforge.net/pci.ids . Thales use Cinterion as >> their IOT modem card's trademark. So you will find 0x1269 belongs to >> Thales. Actually, Cinterion belongs to Gemalto, and Gemalto belongs to >> Thales. >> > >The patch description is confusing me. > >What about below instead? > >``` >Add missing vendor ID for Cinterion (which is 0x1269). >``` > As you said 0x1269 belongs to Thales (not Cinterion), So I write it about the details. >> Signed-off-by: Slark Xiao <slark_xiao@163.com> >> --- >> include/linux/pci_ids.h | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h >> index b362d90eb9b0..9e2b6286f53f 100644 >> --- a/include/linux/pci_ids.h >> +++ b/include/linux/pci_ids.h >> @@ -1765,6 +1765,8 @@ >> #define PCI_VENDOR_ID_SATSAGEM 0x1267 >> #define PCI_DEVICE_ID_SATSAGEM_NICCY 0x1016 >> >> +#define PCI_VENDOR_ID_CINTERION 0x1269 /* Celluar Modules*/ >> + >> #define PCI_VENDOR_ID_ENSONIQ 0x1274 >> #define PCI_DEVICE_ID_ENSONIQ_CT5880 0x5880 >> #define PCI_DEVICE_ID_ENSONIQ_ES1370 0x5000 >> @@ -2585,6 +2587,8 @@ >> #define PCI_VENDOR_ID_TEKRAM 0x1de1 >> #define PCI_DEVICE_ID_TEKRAM_DC290 0xdc29 >> >> +#define PCI_VENDOR_ID_QUECTEL 0x1eac >> + > >Why pourring in Quectel ID while this patch is about Cinterion? > >Thanks. > Patch title is for 2 vendors, Quectel and Cinterion. May I add 2 different VID at the same time? >-- >An old man doll... just what I always wanted! - Clara
On 10/28/22 10:57, Slark Xiao wrote: > At 2022-10-28 11:51:23, "Bagas Sanjaya" <bagasdotme@gmail.com> wrote: >> On Fri, Oct 28, 2022 at 10:37:11AM +0800, Slark Xiao wrote: >>> In MHI driver, there are some companies product still do not have their >>> own PCI vendor macro. So we add it here to make the code neat. Ref ID >>> could be found in link https://pcisig.com/membership/member-companies >>> and https://pciids.sourceforge.net/pci.ids . Thales use Cinterion as >>> their IOT modem card's trademark. So you will find 0x1269 belongs to >>> Thales. Actually, Cinterion belongs to Gemalto, and Gemalto belongs to >>> Thales. >>> >> >> The patch description is confusing me. >> >> What about below instead? >> >> ``` >> Add missing vendor ID for Cinterion (which is 0x1269). >> ``` Oops, I mean also for Quectel (0x1eac). >> > As you said 0x1269 belongs to Thales (not Cinterion), So I write it about the details. > >>> Signed-off-by: Slark Xiao <slark_xiao@163.com> >>> --- >>> include/linux/pci_ids.h | 4 ++++ >>> 1 file changed, 4 insertions(+) >>> >>> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h >>> index b362d90eb9b0..9e2b6286f53f 100644 >>> --- a/include/linux/pci_ids.h >>> +++ b/include/linux/pci_ids.h >>> @@ -1765,6 +1765,8 @@ >>> #define PCI_VENDOR_ID_SATSAGEM 0x1267 >>> #define PCI_DEVICE_ID_SATSAGEM_NICCY 0x1016 >>> >>> +#define PCI_VENDOR_ID_CINTERION 0x1269 /* Celluar Modules*/ >>> + >>> #define PCI_VENDOR_ID_ENSONIQ 0x1274 >>> #define PCI_DEVICE_ID_ENSONIQ_CT5880 0x5880 >>> #define PCI_DEVICE_ID_ENSONIQ_ES1370 0x5000 >>> @@ -2585,6 +2587,8 @@ >>> #define PCI_VENDOR_ID_TEKRAM 0x1de1 >>> #define PCI_DEVICE_ID_TEKRAM_DC290 0xdc29 >>> >>> +#define PCI_VENDOR_ID_QUECTEL 0x1eac >>> + >> >> Why pourring in Quectel ID while this patch is about Cinterion? >> >> Thanks. >> > Patch title is for 2 vendors, Quectel and Cinterion. May I add 2 different VID at the > same time? Ah! I don't see the patch subject. Next time, please just send plain-text email, not HTML. Thanks.
On Fri, Oct 28, 2022 at 10:37:11AM +0800, Slark Xiao wrote: > In MHI driver, there are some companies product still do not have their > own PCI vendor macro. So we add it here to make the code neat. Ref ID > could be found in link https://pcisig.com/membership/member-companies > and https://pciids.sourceforge.net/pci.ids . Thales use Cinterion as > their IOT modem card's trademark. So you will find 0x1269 belongs to > Thales. Actually, Cinterion belongs to Gemalto, and Gemalto belongs to > Thales. There should not be spaces at the beginning of these lines. Don't bother with the sourceforge URL; I don't think that's really useful here. > Signed-off-by: Slark Xiao <slark_xiao@163.com> > --- > include/linux/pci_ids.h | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h > index b362d90eb9b0..9e2b6286f53f 100644 > --- a/include/linux/pci_ids.h > +++ b/include/linux/pci_ids.h > @@ -1765,6 +1765,8 @@ > #define PCI_VENDOR_ID_SATSAGEM 0x1267 > #define PCI_DEVICE_ID_SATSAGEM_NICCY 0x1016 > > +#define PCI_VENDOR_ID_CINTERION 0x1269 /* Celluar Modules*/ This should identify the *vendor*, not a trademark for a specific product line. And it should correspond somehow with the PCI-SIG registration. So I think PCI_VENDOR_ID_THALES would be more appropriate here. I think the best thing here would be two patches. One patch would add PCI_VENDOR_ID_THALES to pci_ids.h and also add a use of it in the MHI driver. The second patch would do the same for PCI_VENDOR_ID_QUECTEL. Then each one is logically self-contained. > #define PCI_VENDOR_ID_ENSONIQ 0x1274 > #define PCI_DEVICE_ID_ENSONIQ_CT5880 0x5880 > #define PCI_DEVICE_ID_ENSONIQ_ES1370 0x5000 > @@ -2585,6 +2587,8 @@ > #define PCI_VENDOR_ID_TEKRAM 0x1de1 > #define PCI_DEVICE_ID_TEKRAM_DC290 0xdc29 > > +#define PCI_VENDOR_ID_QUECTEL 0x1eac > + > #define PCI_VENDOR_ID_TEHUTI 0x1fc9 > #define PCI_DEVICE_ID_TEHUTI_3009 0x3009 > #define PCI_DEVICE_ID_TEHUTI_3010 0x3010 > -- > 2.34.1 >
At 2022-10-29 00:06:21, "Bjorn Helgaas" <helgaas@kernel.org> wrote: >On Fri, Oct 28, 2022 at 10:37:11AM +0800, Slark Xiao wrote: >> In MHI driver, there are some companies product still do not have their >> own PCI vendor macro. So we add it here to make the code neat. Ref ID >> could be found in link https://pcisig.com/membership/member-companies >> and https://pciids.sourceforge.net/pci.ids . Thales use Cinterion as >> their IOT modem card's trademark. So you will find 0x1269 belongs to >> Thales. Actually, Cinterion belongs to Gemalto, and Gemalto belongs to >> Thales. > >There should not be spaces at the beginning of these lines. > >Don't bother with the sourceforge URL; I don't think that's really >useful here. The space issue will be fixed in next patch. > >> Signed-off-by: Slark Xiao <slark_xiao@163.com> >> --- >> include/linux/pci_ids.h | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h >> index b362d90eb9b0..9e2b6286f53f 100644 >> --- a/include/linux/pci_ids.h >> +++ b/include/linux/pci_ids.h >> @@ -1765,6 +1765,8 @@ >> #define PCI_VENDOR_ID_SATSAGEM 0x1267 >> #define PCI_DEVICE_ID_SATSAGEM_NICCY 0x1016 >> >> +#define PCI_VENDOR_ID_CINTERION 0x1269 /* Celluar Modules*/ > >This should identify the *vendor*, not a trademark for a specific >product line. And it should correspond somehow with the PCI-SIG >registration. So I think PCI_VENDOR_ID_THALES would be more >appropriate here. > Yeah, currently it's used by IOT modules which support PCIE. But we can't know if they will use this VID for other non-IOT modules product. Thales would be better. >I think the best thing here would be two patches. One patch would add >PCI_VENDOR_ID_THALES to pci_ids.h and also add a use of it in the MHI >driver. The second patch would do the same for PCI_VENDOR_ID_QUECTEL. > >Then each one is logically self-contained. I must make sure these ids are applied, then I could commit the changes in MHI driver side. Otherwise it will cause build error. So I combine QUECTEL with THALES as a single patch. Shall I separate it from each other? 1 for PCI IDs, and another for MHI change. It would be better, I think. > >> #define PCI_VENDOR_ID_ENSONIQ 0x1274 >> #define PCI_DEVICE_ID_ENSONIQ_CT5880 0x5880 >> #define PCI_DEVICE_ID_ENSONIQ_ES1370 0x5000 >> @@ -2585,6 +2587,8 @@ >> #define PCI_VENDOR_ID_TEKRAM 0x1de1 >> #define PCI_DEVICE_ID_TEKRAM_DC290 0xdc29 >> >> +#define PCI_VENDOR_ID_QUECTEL 0x1eac >> + >> #define PCI_VENDOR_ID_TEHUTI 0x1fc9 >> #define PCI_DEVICE_ID_TEHUTI_3009 0x3009 >> #define PCI_DEVICE_ID_TEHUTI_3010 0x3010 >> -- >> 2.34.1 >>
On Mon, Oct 31, 2022 at 05:08:18PM +0800, Slark Xiao wrote: > At 2022-10-29 00:06:21, "Bjorn Helgaas" <helgaas@kernel.org> wrote: > >I think the best thing here would be two patches. One patch would add > >PCI_VENDOR_ID_THALES to pci_ids.h and also add a use of it in the MHI > >driver. The second patch would do the same for PCI_VENDOR_ID_QUECTEL. > > > >Then each one is logically self-contained. > > I must make sure these ids are applied, then I could commit the > changes in MHI driver side. Otherwise it will cause build error. > > So I combine QUECTEL with THALES as a single patch. Shall I separate > it from each other? 1 for PCI IDs, and another for MHI change. It > would be better, I think. Make two patches: - A single patch that adds PCI_VENDOR_ID_THALES to pci_ids.h and also adds a use of it in the MHI driver. - A single patch that adds PCI_VENDOR_ID_QUECTEL to pci_ids.h and also adds a use of it in the MHI driver. That way there's no possibility of build error and no need to coordinate patches. Similar previous work: https://git.kernel.org/linus/fae74feacd2d ("hisi_acc_qm: Move VF PCI device IDs to common header") https://git.kernel.org/linus/d3826a95222c ("nfp: add support for NFP3800/NFP3803 PCIe devices") https://git.kernel.org/linus/4fb0abfee424 ("x86/amd_nb: Add AMD Family 19h Models (10h-1Fh) and (A0h-AFh) PCI IDs")
diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h index b362d90eb9b0..9e2b6286f53f 100644 --- a/include/linux/pci_ids.h +++ b/include/linux/pci_ids.h @@ -1765,6 +1765,8 @@ #define PCI_VENDOR_ID_SATSAGEM 0x1267 #define PCI_DEVICE_ID_SATSAGEM_NICCY 0x1016 +#define PCI_VENDOR_ID_CINTERION 0x1269 /* Celluar Modules*/ + #define PCI_VENDOR_ID_ENSONIQ 0x1274 #define PCI_DEVICE_ID_ENSONIQ_CT5880 0x5880 #define PCI_DEVICE_ID_ENSONIQ_ES1370 0x5000 @@ -2585,6 +2587,8 @@ #define PCI_VENDOR_ID_TEKRAM 0x1de1 #define PCI_DEVICE_ID_TEKRAM_DC290 0xdc29 +#define PCI_VENDOR_ID_QUECTEL 0x1eac + #define PCI_VENDOR_ID_TEHUTI 0x1fc9 #define PCI_DEVICE_ID_TEHUTI_3009 0x3009 #define PCI_DEVICE_ID_TEHUTI_3010 0x3010