LoongArch: Remove the definition of the macro LOGICAL_OP_NON_SHORT_CIRCUIT under the architecture and use the default definition instead.
| Message ID | 20230413115126.1568212-1-chenglulu@loongson.cn |
|---|---|
| State | Accepted |
| Headers |
Return-Path: <gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp971802vqo;
Thu, 13 Apr 2023 04:52:09 -0700 (PDT)
X-Google-Smtp-Source:
AKy350ZtBz642sQAJcPxkX1xVLxwO58zDLrBNKDX0vAlF4tL6q1iXnNPPvB3rNayiFiX4g3fvloY
X-Received: by 2002:a17:906:24d7:b0:94e:c8c5:37c2 with SMTP id
f23-20020a17090624d700b0094ec8c537c2mr27490ejb.25.1681386729345;
Thu, 13 Apr 2023 04:52:09 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1681386729; cv=none;
d=google.com; s=arc-20160816;
b=ErCYbNRx9kckkKcJGsNT0SxEWAmruPVj0AW8W9eKMOCTDWP3SEn4Iz1L/w62TDiwUi
RvuO/CFVnsdxiD0UyPKMLHKheuKimu+xIOL6wy+ZDSXyxjlSaU1s0ndBtMjO6KDNzmQd
bqsXz9qJhXzx/7ynyg2WKZremyImJ+Xr2srCdhgZoj+syg8ufHM8++rA9Uce1k3KEF/z
RRchTC8+Stxs7N+X3sz84boCPjQwqTDsPovNyFG6mxDGyYoqEg0s07QuJO9fEgayirJ+
/HBLsTmqFjrKXBZ4PgZIf6VjlJPAGWMScd6I3tFx61JZqqdiamw1Nr0xnfTGyZ1E0/Ih
R7dw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=sender:errors-to:list-subscribe:list-help:list-post:list-archive
:list-unsubscribe:list-id:precedence:content-transfer-encoding
:mime-version:message-id:date:subject:cc:to:from:dmarc-filter
:delivered-to;
bh=JRtkzV0sqA/HJ+mKOlT+9v83mvDwsJzoGU5zOFNJJGU=;
b=QgZnOYbOg/MM3/anjKqT+I4wFqbMnK3MNiI+CldEGMyGsfTdu2rHxfpfrKSwU2azFk
bn6JMmc3bmavvbH1bz1NaW5Yad2NGOGxw8DDUE9aYV0Nd3aLDBf1RyT1CBmhGwAJWcI+
lYXChRXmj9GUnKfVkZTvOOmurXMBvI6dkgpXmrkuKi3OfTaXfBPyrlAYHfo+lyKlHhdT
FFa+JHr+CKAZu8casXD3GnQlMEbrQEnqstSHiyr7fYXi45xovE33wCodhFLGCxmk8eZW
3LIYbusRwM2C38quO52q4HzjwaVenVqcgJBf4HSTBdu9gtHc41GGzIqMq+8NOEIsN/UC
jErw==
ARC-Authentication-Results: i=1; mx.google.com;
spf=pass (google.com: domain of
gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates
2620:52:3:1:0:246e:9693:128c as permitted sender)
smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"
Received: from sourceware.org (server2.sourceware.org.
[2620:52:3:1:0:246e:9693:128c])
by mx.google.com with ESMTPS id
wc16-20020a170907125000b0094a7c65bf32si1535531ejb.1002.2023.04.13.04.52.09
for <ouuuleilei@gmail.com>
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Thu, 13 Apr 2023 04:52:09 -0700 (PDT)
Received-SPF: pass (google.com: domain of
gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates
2620:52:3:1:0:246e:9693:128c as permitted sender)
client-ip=2620:52:3:1:0:246e:9693:128c;
Authentication-Results: mx.google.com;
spf=pass (google.com: domain of
gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates
2620:52:3:1:0:246e:9693:128c as permitted sender)
smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"
Received: from server2.sourceware.org (localhost [IPv6:::1])
by sourceware.org (Postfix) with ESMTP id 61AB23858C60
for <ouuuleilei@gmail.com>; Thu, 13 Apr 2023 11:52:02 +0000 (GMT)
X-Original-To: gcc-patches@gcc.gnu.org
Delivered-To: gcc-patches@gcc.gnu.org
Received: from loongson.cn (mail.loongson.cn [114.242.206.163])
by sourceware.org (Postfix) with ESMTP id 57E9D3858D32
for <gcc-patches@gcc.gnu.org>; Thu, 13 Apr 2023 11:51:38 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 57E9D3858D32
Authentication-Results: sourceware.org;
dmarc=none (p=none dis=none) header.from=loongson.cn
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=loongson.cn
Received: from loongson.cn (unknown [10.2.5.5])
by gateway (Coremail) with SMTP id _____8BxednG7Ddk1+IbAA--.43253S3;
Thu, 13 Apr 2023 19:51:34 +0800 (CST)
Received: from 5.5.5 (unknown [10.2.5.5])
by localhost.localdomain (Coremail) with SMTP id
AQAAf8Cx97zB7DdkEFoiAA--.36629S2;
Thu, 13 Apr 2023 19:51:34 +0800 (CST)
From: Lulu Cheng <chenglulu@loongson.cn>
To: gcc-patches@gcc.gnu.org
Cc: xry111@xry111.site, i@xen0n.name, xuchenghua@loongson.cn,
Lulu Cheng <chenglulu@loongson.cn>
Subject: [PATCH] LoongArch: Remove the definition of the macro
LOGICAL_OP_NON_SHORT_CIRCUIT under the architecture and use the default
definition instead.
Date: Thu, 13 Apr 2023 19:51:26 +0800
Message-Id: <20230413115126.1568212-1-chenglulu@loongson.cn>
X-Mailer: git-send-email 2.31.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-CM-TRANSID: AQAAf8Cx97zB7DdkEFoiAA--.36629S2
X-CM-SenderInfo: xfkh0wpoxo3qxorr0wxvrqhubq/
X-Coremail-Antispam: 1Uk129KBjvdXoWrZr4xur4UZF17tryxWF47XFb_yoWfArX_X3
W3t3WDGw48Jay8Jwn0qayrKayUZ3WkJFnYyF9xAr4Ikr1fXrnxArWkWay5Ar15KrWkZ3Zx
JrZ5KrnIkr1UtjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8wcxFpf9Il3svdxBIdaVrn0
xqx4xG64xvF2IEw4CE5I8CrVC2j2Jv73VFW2AGmfu7bjvjm3AaLaJ3UjIYCTnIWjp_UUUY
j7kC6x804xWl14x267AKxVWUJVW8JwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0rVWrJVCq3w
AFIxvE14AKwVWUXVWUAwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK021l84ACjcxK
6xIIjxv20xvE14v26r1I6r4UM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26r1j6r4UM28EF7
xvwVC2z280aVAFwI0_Cr1j6rxdM28EF7xvwVC2z280aVCY1x0267AKxVWxJr0_GcWle2I2
62IYc4CY6c8Ij28IcVAaY2xG8wAqjxCEc2xF0cIa020Ex4CE44I27wAqx4xG64xvF2IEw4
CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_JrI_JrylYx0Ex4A2jsIE14v26r1j6r4UMcvj
eVCFs4IE7xkEbVWUJVW8JwACjcxG0xvY0x0EwIxGrwCF04k20xvY0x0EwIxGrwCFx2IqxV
CFs4IE7xkEbVWUJVW8JwC20s026c02F40E14v26r1j6r18MI8I3I0E7480Y4vE14v26r10
6r1rMI8E67AF67kF1VAFwI0_JF0_Jw1lIxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxV
WUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Jr0_Gr1lIxAIcVCF04k26cxKx2IYs7xG
6r1j6r1xMIIF0xvEx4A2jsIE14v26r1j6r4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Jr0_Gr
UvcSsGvfC2KfnxnUUI43ZEXa7IU8j-e5UUUUU==
X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00, GIT_PATCH_0,
KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS,
TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
server2.sourceware.org
X-BeenThere: gcc-patches@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>,
<mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>,
<mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>
Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org
Sender: "Gcc-patches" <gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org>
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1763061771221512305?=
X-GMAIL-MSGID: =?utf-8?q?1763061771221512305?=
|
| Series |
LoongArch: Remove the definition of the macro LOGICAL_OP_NON_SHORT_CIRCUIT under the architecture and use the default definition instead.
|
|
Checks
| Context | Check | Description |
|---|---|---|
| snail/gcc-patch-check | success | Github commit url |
Commit Message
chenglulu
April 13, 2023, 11:51 a.m. UTC
In some cases, setting this macro as the default can reduce the number of conditional branch instructions. gcc/ChangeLog: * config/loongarch/loongarch.h (LOGICAL_OP_NON_SHORT_CIRCUIT): Remove the macro definition. --- gcc/config/loongarch/loongarch.h | 1 - 1 file changed, 1 deletion(-)
Comments
On Thu, 2023-04-13 at 19:51 +0800, Lulu Cheng wrote: > In some cases, setting this macro as the default can reduce the number of conditional > branch instructions. > > gcc/ChangeLog: > > * config/loongarch/loongarch.h (LOGICAL_OP_NON_SHORT_CIRCUIT): Remove the macro > definition. I think it's OK for GCC 13. At least the result is better for simple cases like "x >= a && x < b". > --- > gcc/config/loongarch/loongarch.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/gcc/config/loongarch/loongarch.h b/gcc/config/loongarch/loongarch.h > index f8167875646..6b7dbecd3ff 100644 > --- a/gcc/config/loongarch/loongarch.h > +++ b/gcc/config/loongarch/loongarch.h > @@ -836,7 +836,6 @@ typedef struct { > 1 is the default; other values are interpreted relative to that. */ > > #define BRANCH_COST(speed_p, predictable_p) loongarch_branch_cost > -#define LOGICAL_OP_NON_SHORT_CIRCUIT 0 > > /* Return the asm template for a conditional branch instruction. > OPCODE is the opcode's mnemonic and OPERANDS is the asm template for
在 2023/4/13 下午8:24, Xi Ruoyao 写道: > On Thu, 2023-04-13 at 19:51 +0800, Lulu Cheng wrote: >> In some cases, setting this macro as the default can reduce the number of conditional >> branch instructions. >> >> gcc/ChangeLog: >> >> * config/loongarch/loongarch.h (LOGICAL_OP_NON_SHORT_CIRCUIT): Remove the macro >> definition. > I think it's OK for GCC 13. At least the result is better for simple > cases like "x >= a && x < b". I also want to merge to GCC13.:-D > >> --- >> gcc/config/loongarch/loongarch.h | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/gcc/config/loongarch/loongarch.h b/gcc/config/loongarch/loongarch.h >> index f8167875646..6b7dbecd3ff 100644 >> --- a/gcc/config/loongarch/loongarch.h >> +++ b/gcc/config/loongarch/loongarch.h >> @@ -836,7 +836,6 @@ typedef struct { >> 1 is the default; other values are interpreted relative to that. */ >> >> #define BRANCH_COST(speed_p, predictable_p) loongarch_branch_cost >> -#define LOGICAL_OP_NON_SHORT_CIRCUIT 0 >> >> /* Return the asm template for a conditional branch instruction. >> OPCODE is the opcode's mnemonic and OPERANDS is the asm template for
Pushed to r14-15. Due to my reasons, this modification did not catch up with the creation of the releases/gcc-13 branch, can I still submit this modification to releases/gcc-13?:-( 在 2023/4/13 下午8:24, Xi Ruoyao 写道: > On Thu, 2023-04-13 at 19:51 +0800, Lulu Cheng wrote: >> In some cases, setting this macro as the default can reduce the number of conditional >> branch instructions. >> >> gcc/ChangeLog: >> >> * config/loongarch/loongarch.h (LOGICAL_OP_NON_SHORT_CIRCUIT): Remove the macro >> definition. > I think it's OK for GCC 13. At least the result is better for simple > cases like "x >= a && x < b". > >> --- >> gcc/config/loongarch/loongarch.h | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/gcc/config/loongarch/loongarch.h b/gcc/config/loongarch/loongarch.h >> index f8167875646..6b7dbecd3ff 100644 >> --- a/gcc/config/loongarch/loongarch.h >> +++ b/gcc/config/loongarch/loongarch.h >> @@ -836,7 +836,6 @@ typedef struct { >> 1 is the default; other values are interpreted relative to that. */ >> >> #define BRANCH_COST(speed_p, predictable_p) loongarch_branch_cost >> -#define LOGICAL_OP_NON_SHORT_CIRCUIT 0 >> >> /* Return the asm template for a conditional branch instruction. >> OPCODE is the opcode's mnemonic and OPERANDS is the asm template for
On Tue, 2023-04-18 at 09:54 +0800, Lulu Cheng wrote: > Pushed to r14-15. > > Due to my reasons, this modification did not catch up with the creation > of the releases/gcc-13 branch, > > can I still submit this modification to releases/gcc-13?:-( I guess we need a decision from Jakub.
diff --git a/gcc/config/loongarch/loongarch.h b/gcc/config/loongarch/loongarch.h index f8167875646..6b7dbecd3ff 100644 --- a/gcc/config/loongarch/loongarch.h +++ b/gcc/config/loongarch/loongarch.h @@ -836,7 +836,6 @@ typedef struct { 1 is the default; other values are interpreted relative to that. */ #define BRANCH_COST(speed_p, predictable_p) loongarch_branch_cost -#define LOGICAL_OP_NON_SHORT_CIRCUIT 0 /* Return the asm template for a conditional branch instruction. OPCODE is the opcode's mnemonic and OPERANDS is the asm template for