diff mbox series

[1/2] PHIOPT: small cleanup in match_simplify_replacement

Message ID 20230417221740.251864-1-apinski@marvell.com
State Accepted
Headers
Series [1/2] PHIOPT: small cleanup in match_simplify_replacement |

Checks

Context Check Description
snail/gcc-patch-check success Github commit url

Commit Message

Andrew Pinski April 17, 2023, 10:17 p.m. UTC 
  We know that the statement we are moving is already
have a SSA_NAME on the lhs so we don't need to
check that and can also just call reset_flow_sensitive_info
with the name we already got.

OK? Bootstrapped and tested on x86_64-linux-gnu with no regressions.

gcc/ChangeLog:

	* tree-ssa-phiopt.cc (match_simplify_replacement):
	Simplify code that does the movement slightly.
---
 gcc/tree-ssa-phiopt.cc | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

Comments

Richard Biener April 18, 2023, 6:24 a.m. UTC | #1 
On Tue, Apr 18, 2023 at 12:18 AM Andrew Pinski via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
> We know that the statement we are moving is already
> have a SSA_NAME on the lhs so we don't need to
> check that and can also just call reset_flow_sensitive_info
> with the name we already got.
>
> OK? Bootstrapped and tested on x86_64-linux-gnu with no regressions.

OK.

> gcc/ChangeLog:
>
>         * tree-ssa-phiopt.cc (match_simplify_replacement):
>         Simplify code that does the movement slightly.
> ---
>  gcc/tree-ssa-phiopt.cc | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/gcc/tree-ssa-phiopt.cc b/gcc/tree-ssa-phiopt.cc
> index 16acd2f1894..4ddb4d5db90 100644
> --- a/gcc/tree-ssa-phiopt.cc
> +++ b/gcc/tree-ssa-phiopt.cc
> @@ -1094,11 +1094,10 @@ match_simplify_replacement (basic_block cond_bb, basic_block middle_bb,
>
>        tree name = gimple_get_lhs (stmt_to_move);
>        // Mark the name to be renamed if there is one.
> -      if (name && TREE_CODE (name) == SSA_NAME)
> -       bitmap_set_bit (inserted_exprs, SSA_NAME_VERSION (name));
> +      bitmap_set_bit (inserted_exprs, SSA_NAME_VERSION (name));
>        gimple_stmt_iterator gsi1 = gsi_for_stmt (stmt_to_move);
>        gsi_move_before (&gsi1, &gsi);
> -      reset_flow_sensitive_info (gimple_assign_lhs (stmt_to_move));
> +      reset_flow_sensitive_info (name);
>      }
>
>    replace_phi_edge_with_variable (cond_bb, e1, phi, result, inserted_exprs);
> --
> 2.31.1
>
diff mbox series

Patch

diff --git a/gcc/tree-ssa-phiopt.cc b/gcc/tree-ssa-phiopt.cc
index 16acd2f1894..4ddb4d5db90 100644
--- a/gcc/tree-ssa-phiopt.cc
+++ b/gcc/tree-ssa-phiopt.cc
@@ -1094,11 +1094,10 @@  match_simplify_replacement (basic_block cond_bb, basic_block middle_bb,
 
       tree name = gimple_get_lhs (stmt_to_move);
       // Mark the name to be renamed if there is one.
-      if (name && TREE_CODE (name) == SSA_NAME)
-	bitmap_set_bit (inserted_exprs, SSA_NAME_VERSION (name));
+      bitmap_set_bit (inserted_exprs, SSA_NAME_VERSION (name));
       gimple_stmt_iterator gsi1 = gsi_for_stmt (stmt_to_move);
       gsi_move_before (&gsi1, &gsi);
-      reset_flow_sensitive_info (gimple_assign_lhs (stmt_to_move));
+      reset_flow_sensitive_info (name);
     }
 
   replace_phi_edge_with_variable (cond_bb, e1, phi, result, inserted_exprs);