diff mbox series

soc: qcom: ramp_controller: Fix an error handling path in qcom_ramp_controller_probe()

Message ID 84727a79d0261b4112411aec23b553504015c02c.1681684138.git.christophe.jaillet@wanadoo.fr
State New
Headers
Series soc: qcom: ramp_controller: Fix an error handling path in qcom_ramp_controller_probe() |

Commit Message

Christophe JAILLET April 16, 2023, 10:29 p.m. UTC 
  'qrc' is known to be non-NULL at this point.
Checking for 'qrc->desc' was expected instead, so use it.

Fixes: a723c95fa137 ("soc: qcom: Add Qualcomm Ramp Controller driver")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
 drivers/soc/qcom/ramp_controller.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

AngeloGioacchino Del Regno April 17, 2023, 10:33 a.m. UTC | #1 
Il 17/04/23 00:29, Christophe JAILLET ha scritto:
> 'qrc' is known to be non-NULL at this point.
> Checking for 'qrc->desc' was expected instead, so use it.
> 
> Fixes: a723c95fa137 ("soc: qcom: Add Qualcomm Ramp Controller driver")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Bjorn Andersson May 25, 2023, 4:53 a.m. UTC | #2 
On Mon, 17 Apr 2023 00:29:35 +0200, Christophe JAILLET wrote:
> 'qrc' is known to be non-NULL at this point.
> Checking for 'qrc->desc' was expected instead, so use it.
> 
> 

Applied, thanks!

[1/1] soc: qcom: ramp_controller: Fix an error handling path in qcom_ramp_controller_probe()
      commit: b3d0dcc8e359cf5d57fb6308bc9750af5da574b3

Best regards,
diff mbox series

Patch

diff --git a/drivers/soc/qcom/ramp_controller.c b/drivers/soc/qcom/ramp_controller.c
index dc74d2a19de2..5e3ba0be0903 100644
--- a/drivers/soc/qcom/ramp_controller.c
+++ b/drivers/soc/qcom/ramp_controller.c
@@ -296,7 +296,7 @@  static int qcom_ramp_controller_probe(struct platform_device *pdev)
 		return -ENOMEM;
 
 	qrc->desc = device_get_match_data(&pdev->dev);
-	if (!qrc)
+	if (!qrc->desc)
 		return -EINVAL;
 
 	qrc->regmap = devm_regmap_init_mmio(&pdev->dev, base, &qrc_regmap_config);