[v1,1/2] clk: starfive: Fix RESET_STARFIVE_JH7110 can't be selected in a specified case
Message ID | 20230417074115.30786-2-hal.feng@starfivetech.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1948198vqo; Mon, 17 Apr 2023 00:49:56 -0700 (PDT) X-Google-Smtp-Source: AKy350ZBdhsrBT+fl40ZmF4XfDoo6YnMT8vDOy+dxDiHoKQRr7kZz+UTeK/j7UE4Gv7mEN5EOYVc X-Received: by 2002:a17:90b:17c7:b0:246:f9f1:ad17 with SMTP id me7-20020a17090b17c700b00246f9f1ad17mr12995129pjb.40.1681717796334; Mon, 17 Apr 2023 00:49:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681717796; cv=none; d=google.com; s=arc-20160816; b=qzalcJ/lpbHifPU4S76VgiqLRUcJK7VcyMqL0habTOjJKyKqgLwoqTh1Mnjaa7/D4y Vgm8PLbhTfkRva/cBy9tYDdWNAOjspM1WM/aEPeXq5Zb58z6vwkZUfeJ78zdmCW8VDsM Qi08fi1e3oCC2CtEZf4puXYsGR6SOBqKo7U7aqHVunVocmQxj/a0vT+GQlRt683A7Kj9 gYNqiJ15jKcKdE/MUqHA1G2IpcRrhoOz1ZOcsww8GIhhD8xJfIFHYS21JIjXi0hPnWJd QHuXSBf0qbyLMAPtRZatFC2QJXhNM+1YiFG7GK+A0/dN1yg7ca/jawIM3UWmT6mGnHfA Strw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=js2Kib3HZPNcYauuxDIu5NUOHL5TmEzjyK8+ySOU7bA=; b=aeGkAUDyMitNlHG6XR4Y65cUYHfPDbCozAUP7n0Y8VqdM2y4xE0lOE7hkxQlkXSPam KjfZtzCCuPEVO1Ps3Njij3EnfkP4H2gcIKu5b0VfKt9aL6g8yIekRrp5rm5MNsOkyDv2 RnIL9JpalQ1Cs9LMTH20LcTmU9RU2Nqrjvc77t8BFVxakkl6Vx2zouqEP0V0en247NcC 46dxxZkbPYz6u9WJ1I21uGfzu8FnMcAE/uF71ZtuDtAV0c7QXph/j1dRJF8MD0qQ6pyZ paDSRhh5uLCEPq2WvN0OkLXuaLJN4IogoLI1XzAhEEWVU2f9abK+2jsqm/BmIYnTP8Mv 7yXg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v10-20020a63f20a000000b0050be7b93e73si6468733pgh.694.2023.04.17.00.49.42; Mon, 17 Apr 2023 00:49:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230493AbjDQHmX convert rfc822-to-8bit (ORCPT <rfc822;leviz.kernel.dev@gmail.com> + 99 others); Mon, 17 Apr 2023 03:42:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59614 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229754AbjDQHmT (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Mon, 17 Apr 2023 03:42:19 -0400 Received: from fd01.gateway.ufhost.com (fd01.gateway.ufhost.com [61.152.239.71]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0A3C340D5; Mon, 17 Apr 2023 00:41:42 -0700 (PDT) Received: from EXMBX166.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX166", Issuer "EXMBX166" (not verified)) by fd01.gateway.ufhost.com (Postfix) with ESMTP id 7BB3F24E2AB; Mon, 17 Apr 2023 15:41:17 +0800 (CST) Received: from EXMBX172.cuchost.com (172.16.6.92) by EXMBX166.cuchost.com (172.16.6.76) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Mon, 17 Apr 2023 15:41:17 +0800 Received: from ubuntu.localdomain (183.27.97.249) by EXMBX172.cuchost.com (172.16.6.92) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Mon, 17 Apr 2023 15:41:16 +0800 From: Hal Feng <hal.feng@starfivetech.com> To: <linux-clk@vger.kernel.org>, <oe-kbuild-all@lists.linux.dev>, <linux-mm@kvack.org> CC: Stephen Boyd <sboyd@kernel.org>, Michael Turquette <mturquette@baylibre.com>, Conor Dooley <conor.dooley@microchip.com>, "Paul Gazzillo" <paul@pgazz.com>, Necip Fazil Yildiran <fazilyildiran@gmail.com>, Emil Renner Berthing <emil.renner.berthing@canonical.com>, Hal Feng <hal.feng@starfivetech.com>, Xingyu Wu <xingyu.wu@starfivetech.com>, <linux-kernel@vger.kernel.org> Subject: [PATCH v1 1/2] clk: starfive: Fix RESET_STARFIVE_JH7110 can't be selected in a specified case Date: Mon, 17 Apr 2023 15:41:14 +0800 Message-ID: <20230417074115.30786-2-hal.feng@starfivetech.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20230417074115.30786-1-hal.feng@starfivetech.com> References: <20230417074115.30786-1-hal.feng@starfivetech.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [183.27.97.249] X-ClientProxiedBy: EXCAS062.cuchost.com (172.16.6.22) To EXMBX172.cuchost.com (172.16.6.92) X-YovoleRuleAgent: yovoleflag Content-Transfer-Encoding: 8BIT X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_MSPIKE_H2, SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1763408919764450431?= X-GMAIL-MSGID: =?utf-8?q?1763408919764450431?= |
Series |
A fix for StarFive JH7110 clock drivers
|
|
Commit Message
Hal Feng
April 17, 2023, 7:41 a.m. UTC
When (ARCH_STARFIVE [=n] && COMPILE_TEST [=y] && RESET_CONTROLLER [=n]),
RESET_STARFIVE_JH7110 can't be selected by CLK_STARFIVE_JH7110_SYS
and CLK_STARFIVE_JH7110_AON.
Considering RESET_STARFIVE_JH7110 is not a necessary option for compilation
test, we should select it only if ARCH_STARFIVE=y. Also, delete redundant
selected options of CLK_STARFIVE_JH7110_AON because these options are
already selected by the dependency.
Fixes: edab7204afe5 ("clk: starfive: Add StarFive JH7110 system clock driver")
Fixes: b2ab3c94f41f ("clk: starfive: Add StarFive JH7110 always-on clock driver")
Signed-off-by: Hal Feng <hal.feng@starfivetech.com>
---
drivers/clk/starfive/Kconfig | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
Comments
On Mon, Apr 17, 2023 at 03:41:14PM +0800, Hal Feng wrote: > When (ARCH_STARFIVE [=n] && COMPILE_TEST [=y] && RESET_CONTROLLER [=n]), > RESET_STARFIVE_JH7110 can't be selected by CLK_STARFIVE_JH7110_SYS > and CLK_STARFIVE_JH7110_AON. > > Considering RESET_STARFIVE_JH7110 is not a necessary option for compilation > test, we should select it only if ARCH_STARFIVE=y. Also, delete redundant > selected options of CLK_STARFIVE_JH7110_AON because these options are > already selected by the dependency. > > Fixes: edab7204afe5 ("clk: starfive: Add StarFive JH7110 system clock driver") > Fixes: b2ab3c94f41f ("clk: starfive: Add StarFive JH7110 always-on clock driver") > Signed-off-by: Hal Feng <hal.feng@starfivetech.com> > --- > drivers/clk/starfive/Kconfig | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/clk/starfive/Kconfig b/drivers/clk/starfive/Kconfig > index 71c1148ee5f6..3fad4adee841 100644 > --- a/drivers/clk/starfive/Kconfig > +++ b/drivers/clk/starfive/Kconfig > @@ -26,7 +26,7 @@ config CLK_STARFIVE_JH7110_SYS > depends on ARCH_STARFIVE || COMPILE_TEST > select AUXILIARY_BUS > select CLK_STARFIVE_JH71X0 > - select RESET_STARFIVE_JH7110 > + select RESET_STARFIVE_JH7110 if ARCH_STARFIVE Hmm, I don't really follow the logic above. Why not just make the if be `if RESET_CONTROLLER` rather than ARCH_STARFIVE? I'm probably missing some obvious reason why not. Cheers, Conor. > default ARCH_STARFIVE > help > Say yes here to support the system clock controller on the > @@ -35,9 +35,6 @@ config CLK_STARFIVE_JH7110_SYS > config CLK_STARFIVE_JH7110_AON > tristate "StarFive JH7110 always-on clock support" > depends on CLK_STARFIVE_JH7110_SYS > - select AUXILIARY_BUS > - select CLK_STARFIVE_JH71X0 > - select RESET_STARFIVE_JH7110 > default m if ARCH_STARFIVE > help > Say yes here to support the always-on clock controller on the > -- > 2.38.1 >
On Mon, 17 Apr 2023 10:54:09 +0100, Conor Dooley wrote: > On Mon, Apr 17, 2023 at 03:41:14PM +0800, Hal Feng wrote: >> When (ARCH_STARFIVE [=n] && COMPILE_TEST [=y] && RESET_CONTROLLER [=n]), >> RESET_STARFIVE_JH7110 can't be selected by CLK_STARFIVE_JH7110_SYS >> and CLK_STARFIVE_JH7110_AON. >> >> Considering RESET_STARFIVE_JH7110 is not a necessary option for compilation >> test, we should select it only if ARCH_STARFIVE=y. Also, delete redundant >> selected options of CLK_STARFIVE_JH7110_AON because these options are >> already selected by the dependency. >> >> Fixes: edab7204afe5 ("clk: starfive: Add StarFive JH7110 system clock driver") >> Fixes: b2ab3c94f41f ("clk: starfive: Add StarFive JH7110 always-on clock driver") >> Signed-off-by: Hal Feng <hal.feng@starfivetech.com> >> --- >> drivers/clk/starfive/Kconfig | 5 +---- >> 1 file changed, 1 insertion(+), 4 deletions(-) >> >> diff --git a/drivers/clk/starfive/Kconfig b/drivers/clk/starfive/Kconfig >> index 71c1148ee5f6..3fad4adee841 100644 >> --- a/drivers/clk/starfive/Kconfig >> +++ b/drivers/clk/starfive/Kconfig >> @@ -26,7 +26,7 @@ config CLK_STARFIVE_JH7110_SYS >> depends on ARCH_STARFIVE || COMPILE_TEST >> select AUXILIARY_BUS >> select CLK_STARFIVE_JH71X0 >> - select RESET_STARFIVE_JH7110 >> + select RESET_STARFIVE_JH7110 if ARCH_STARFIVE > > Hmm, I don't really follow the logic above. > Why not just make the if be `if RESET_CONTROLLER` rather than > ARCH_STARFIVE? > I'm probably missing some obvious reason why not. Note that RESET_CONTROLLER is selected by ARCH_STARFIVE. Thanks. Best regards, Hal
On Mon, Apr 17, 2023 at 06:06:29PM +0800, Hal Feng wrote: > On Mon, 17 Apr 2023 10:54:09 +0100, Conor Dooley wrote: > > On Mon, Apr 17, 2023 at 03:41:14PM +0800, Hal Feng wrote: > >> When (ARCH_STARFIVE [=n] && COMPILE_TEST [=y] && RESET_CONTROLLER [=n]), > >> RESET_STARFIVE_JH7110 can't be selected by CLK_STARFIVE_JH7110_SYS > >> and CLK_STARFIVE_JH7110_AON. > >> > >> Considering RESET_STARFIVE_JH7110 is not a necessary option for compilation > >> test, we should select it only if ARCH_STARFIVE=y. Also, delete redundant > >> selected options of CLK_STARFIVE_JH7110_AON because these options are > >> already selected by the dependency. > >> > >> Fixes: edab7204afe5 ("clk: starfive: Add StarFive JH7110 system clock driver") > >> Fixes: b2ab3c94f41f ("clk: starfive: Add StarFive JH7110 always-on clock driver") > >> Signed-off-by: Hal Feng <hal.feng@starfivetech.com> > >> --- > >> drivers/clk/starfive/Kconfig | 5 +---- > >> 1 file changed, 1 insertion(+), 4 deletions(-) > >> > >> diff --git a/drivers/clk/starfive/Kconfig b/drivers/clk/starfive/Kconfig > >> index 71c1148ee5f6..3fad4adee841 100644 > >> --- a/drivers/clk/starfive/Kconfig > >> +++ b/drivers/clk/starfive/Kconfig > >> @@ -26,7 +26,7 @@ config CLK_STARFIVE_JH7110_SYS > >> depends on ARCH_STARFIVE || COMPILE_TEST > >> select AUXILIARY_BUS > >> select CLK_STARFIVE_JH71X0 > >> - select RESET_STARFIVE_JH7110 > >> + select RESET_STARFIVE_JH7110 if ARCH_STARFIVE > > > > Hmm, I don't really follow the logic above. > > Why not just make the if be `if RESET_CONTROLLER` rather than > > ARCH_STARFIVE? > > I'm probably missing some obvious reason why not. > > Note that RESET_CONTROLLER is selected by ARCH_STARFIVE. Thanks. Aye, just the explicit dependency seems like it'd be less fragile and more obvious in the future.
Quoting Conor Dooley (2023-04-17 03:18:35) > On Mon, Apr 17, 2023 at 06:06:29PM +0800, Hal Feng wrote: > > On Mon, 17 Apr 2023 10:54:09 +0100, Conor Dooley wrote: > > > On Mon, Apr 17, 2023 at 03:41:14PM +0800, Hal Feng wrote: > > >> When (ARCH_STARFIVE [=n] && COMPILE_TEST [=y] && RESET_CONTROLLER [=n]), > > >> RESET_STARFIVE_JH7110 can't be selected by CLK_STARFIVE_JH7110_SYS > > >> and CLK_STARFIVE_JH7110_AON. > > >> > > >> Considering RESET_STARFIVE_JH7110 is not a necessary option for compilation > > >> test, we should select it only if ARCH_STARFIVE=y. Also, delete redundant > > >> selected options of CLK_STARFIVE_JH7110_AON because these options are > > >> already selected by the dependency. > > >> > > >> Fixes: edab7204afe5 ("clk: starfive: Add StarFive JH7110 system clock driver") > > >> Fixes: b2ab3c94f41f ("clk: starfive: Add StarFive JH7110 always-on clock driver") > > >> Signed-off-by: Hal Feng <hal.feng@starfivetech.com> > > >> --- > > >> drivers/clk/starfive/Kconfig | 5 +---- > > >> 1 file changed, 1 insertion(+), 4 deletions(-) > > >> > > >> diff --git a/drivers/clk/starfive/Kconfig b/drivers/clk/starfive/Kconfig > > >> index 71c1148ee5f6..3fad4adee841 100644 > > >> --- a/drivers/clk/starfive/Kconfig > > >> +++ b/drivers/clk/starfive/Kconfig > > >> @@ -26,7 +26,7 @@ config CLK_STARFIVE_JH7110_SYS > > >> depends on ARCH_STARFIVE || COMPILE_TEST > > >> select AUXILIARY_BUS > > >> select CLK_STARFIVE_JH71X0 > > >> - select RESET_STARFIVE_JH7110 > > >> + select RESET_STARFIVE_JH7110 if ARCH_STARFIVE > > > > > > Hmm, I don't really follow the logic above. > > > Why not just make the if be `if RESET_CONTROLLER` rather than > > > ARCH_STARFIVE? > > > I'm probably missing some obvious reason why not. > > > > Note that RESET_CONTROLLER is selected by ARCH_STARFIVE. Thanks. > > Aye, just the explicit dependency seems like it'd be less fragile and > more obvious in the future. Agreed. Be explicit so we don't have to hunt down select dependencies.
On Mon, 17 Apr 2023 17:22:01 -0700, Stephen Boyd wrote: > Quoting Conor Dooley (2023-04-17 03:18:35) >> On Mon, Apr 17, 2023 at 06:06:29PM +0800, Hal Feng wrote: >> > On Mon, 17 Apr 2023 10:54:09 +0100, Conor Dooley wrote: >> > > On Mon, Apr 17, 2023 at 03:41:14PM +0800, Hal Feng wrote: >> > >> When (ARCH_STARFIVE [=n] && COMPILE_TEST [=y] && RESET_CONTROLLER [=n]), >> > >> RESET_STARFIVE_JH7110 can't be selected by CLK_STARFIVE_JH7110_SYS >> > >> and CLK_STARFIVE_JH7110_AON. >> > >> >> > >> Considering RESET_STARFIVE_JH7110 is not a necessary option for compilation >> > >> test, we should select it only if ARCH_STARFIVE=y. Also, delete redundant >> > >> selected options of CLK_STARFIVE_JH7110_AON because these options are >> > >> already selected by the dependency. >> > >> >> > >> Fixes: edab7204afe5 ("clk: starfive: Add StarFive JH7110 system clock driver") >> > >> Fixes: b2ab3c94f41f ("clk: starfive: Add StarFive JH7110 always-on clock driver") >> > >> Signed-off-by: Hal Feng <hal.feng@starfivetech.com> >> > >> --- >> > >> drivers/clk/starfive/Kconfig | 5 +---- >> > >> 1 file changed, 1 insertion(+), 4 deletions(-) >> > >> >> > >> diff --git a/drivers/clk/starfive/Kconfig b/drivers/clk/starfive/Kconfig >> > >> index 71c1148ee5f6..3fad4adee841 100644 >> > >> --- a/drivers/clk/starfive/Kconfig >> > >> +++ b/drivers/clk/starfive/Kconfig >> > >> @@ -26,7 +26,7 @@ config CLK_STARFIVE_JH7110_SYS >> > >> depends on ARCH_STARFIVE || COMPILE_TEST >> > >> select AUXILIARY_BUS >> > >> select CLK_STARFIVE_JH71X0 >> > >> - select RESET_STARFIVE_JH7110 >> > >> + select RESET_STARFIVE_JH7110 if ARCH_STARFIVE >> > > >> > > Hmm, I don't really follow the logic above. >> > > Why not just make the if be `if RESET_CONTROLLER` rather than >> > > ARCH_STARFIVE? >> > > I'm probably missing some obvious reason why not. >> > >> > Note that RESET_CONTROLLER is selected by ARCH_STARFIVE. Thanks. >> >> Aye, just the explicit dependency seems like it'd be less fragile and >> more obvious in the future. > > Agreed. Be explicit so we don't have to hunt down select dependencies. With further consideration, on the other hand, if we set `if ARCH_STARFIVE` here, it can point out that we need the reset driver to boot up JH7110 besides the clock drivers, and the reset driver is not a necessary option for compilation test. So the reset driver is independent to the clock drivers when you doing a compilation test. If we set `if RESET_CONTROLLER` here, the reset driver will be compiled automatically when (ARCH_STARFIVE [=n] && COMPILE_TEST [=y] && RESET_CONTROLLER [=y] && CLK_STARFIVE_JH7110_SYS [=y]). Best regards, Hal
On Tue, Apr 18, 2023 at 10:14:06AM +0800, Hal Feng wrote: > On Mon, 17 Apr 2023 17:22:01 -0700, Stephen Boyd wrote: > > Quoting Conor Dooley (2023-04-17 03:18:35) > >> Aye, just the explicit dependency seems like it'd be less fragile and > >> more obvious in the future. > > > > Agreed. Be explicit so we don't have to hunt down select dependencies. > > With further consideration, on the other hand, if we set `if ARCH_STARFIVE` > here, it can point out that we need the reset driver to boot up JH7110 > besides the clock drivers, and the reset driver is not a necessary option > for compilation test. So the reset driver is independent to the clock > drivers when you doing a compilation test. If ARCH_STARFIVE is enabled, both options (RESET_CONTROLLER & RESET_STARFIVE_JH7110) will be selected & you don't need to worry about people not realising this. Try it out & look at the option in menuconfig. > If we set `if RESET_CONTROLLER` here, the reset driver will be compiled > automatically when (ARCH_STARFIVE [=n] && COMPILE_TEST [=y] && > RESET_CONTROLLER [=y] && CLK_STARFIVE_JH7110_SYS [=y]). This is what we want, right? The more often it gets built by randconfig etc the better, especially for archs that are not RISC-V. Cheers, Conor.
On Tue, 18 Apr 2023 07:31:47 +0100, Conor Dooley wrote: > On Tue, Apr 18, 2023 at 10:14:06AM +0800, Hal Feng wrote: >> On Mon, 17 Apr 2023 17:22:01 -0700, Stephen Boyd wrote: >> > Quoting Conor Dooley (2023-04-17 03:18:35) > >> >> Aye, just the explicit dependency seems like it'd be less fragile and >> >> more obvious in the future. >> > >> > Agreed. Be explicit so we don't have to hunt down select dependencies. >> >> With further consideration, on the other hand, if we set `if ARCH_STARFIVE` >> here, it can point out that we need the reset driver to boot up JH7110 >> besides the clock drivers, and the reset driver is not a necessary option >> for compilation test. So the reset driver is independent to the clock >> drivers when you doing a compilation test. > > If ARCH_STARFIVE is enabled, both options (RESET_CONTROLLER & > RESET_STARFIVE_JH7110) will be selected & you don't need to worry about > people not realising this. Try it out & look at the option in > menuconfig. > >> If we set `if RESET_CONTROLLER` here, the reset driver will be compiled >> automatically when (ARCH_STARFIVE [=n] && COMPILE_TEST [=y] && >> RESET_CONTROLLER [=y] && CLK_STARFIVE_JH7110_SYS [=y]). > > This is what we want, right? The more often it gets built by randconfig > etc the better, especially for archs that are not RISC-V. OK, will fix it in v2. Best regards, Hal
diff --git a/drivers/clk/starfive/Kconfig b/drivers/clk/starfive/Kconfig index 71c1148ee5f6..3fad4adee841 100644 --- a/drivers/clk/starfive/Kconfig +++ b/drivers/clk/starfive/Kconfig @@ -26,7 +26,7 @@ config CLK_STARFIVE_JH7110_SYS depends on ARCH_STARFIVE || COMPILE_TEST select AUXILIARY_BUS select CLK_STARFIVE_JH71X0 - select RESET_STARFIVE_JH7110 + select RESET_STARFIVE_JH7110 if ARCH_STARFIVE default ARCH_STARFIVE help Say yes here to support the system clock controller on the @@ -35,9 +35,6 @@ config CLK_STARFIVE_JH7110_SYS config CLK_STARFIVE_JH7110_AON tristate "StarFive JH7110 always-on clock support" depends on CLK_STARFIVE_JH7110_SYS - select AUXILIARY_BUS - select CLK_STARFIVE_JH71X0 - select RESET_STARFIVE_JH7110 default m if ARCH_STARFIVE help Say yes here to support the always-on clock controller on the