diff mbox series

pwm: clk: Use the devm_clk_get_prepared() helper function

Message ID 9281571825c365c1591fcf31527d45ec576c19b4.1681635694.git.christophe.jaillet@wanadoo.fr
State New
Headers
Series pwm: clk: Use the devm_clk_get_prepared() helper function |

Commit Message

Christophe JAILLET April 16, 2023, 9:02 a.m. UTC 
  Use the devm_clk_get_prepared() helper function instead of hand-writing it.
It saves some line of codes.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
 drivers/pwm/pwm-clk.c | 12 ++----------
 1 file changed, 2 insertions(+), 10 deletions(-)

Comments

Uwe Kleine-König April 16, 2023, 5:05 p.m. UTC | #1 
Hello,

On Sun, Apr 16, 2023 at 11:02:13AM +0200, Christophe JAILLET wrote:
> Use the devm_clk_get_prepared() helper function instead of hand-writing it.
> It saves some line of codes.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Thanks
Uwe
Thierry Reding June 23, 2023, 2:51 p.m. UTC | #2 
On Sun, 16 Apr 2023 11:02:13 +0200, Christophe JAILLET wrote:
> Use the devm_clk_get_prepared() helper function instead of hand-writing it.
> It saves some line of codes.
> 
> 

Applied, thanks!

[1/1] pwm: clk: Use the devm_clk_get_prepared() helper function
      commit: 2b8e30b1bd500df67554f1c183caf333de82f8d2

Best regards,
diff mbox series

Patch

diff --git a/drivers/pwm/pwm-clk.c b/drivers/pwm/pwm-clk.c
index f1da99881adf..0ee4d2aee4df 100644
--- a/drivers/pwm/pwm-clk.c
+++ b/drivers/pwm/pwm-clk.c
@@ -89,7 +89,7 @@  static int pwm_clk_probe(struct platform_device *pdev)
 	if (!pcchip)
 		return -ENOMEM;
 
-	pcchip->clk = devm_clk_get(&pdev->dev, NULL);
+	pcchip->clk = devm_clk_get_prepared(&pdev->dev, NULL);
 	if (IS_ERR(pcchip->clk))
 		return dev_err_probe(&pdev->dev, PTR_ERR(pcchip->clk),
 				     "Failed to get clock\n");
@@ -98,15 +98,9 @@  static int pwm_clk_probe(struct platform_device *pdev)
 	pcchip->chip.ops = &pwm_clk_ops;
 	pcchip->chip.npwm = 1;
 
-	ret = clk_prepare(pcchip->clk);
-	if (ret < 0)
-		return dev_err_probe(&pdev->dev, ret, "Failed to prepare clock\n");
-
 	ret = pwmchip_add(&pcchip->chip);
-	if (ret < 0) {
-		clk_unprepare(pcchip->clk);
+	if (ret < 0)
 		return dev_err_probe(&pdev->dev, ret, "Failed to add pwm chip\n");
-	}
 
 	platform_set_drvdata(pdev, pcchip);
 	return 0;
@@ -120,8 +114,6 @@  static void pwm_clk_remove(struct platform_device *pdev)
 
 	if (pcchip->clk_enabled)
 		clk_disable(pcchip->clk);
-
-	clk_unprepare(pcchip->clk);
 }
 
 static const struct of_device_id pwm_clk_dt_ids[] = {