diff mbox series

[v2,1/5] dt-bindings: display: panel: nt36523: Allow 'port' instead of 'ports'

Message ID 20230412-topic-lenovopanel-v2-1-055c3649788e@linaro.org
State New
Headers
Series Lenovo Tab P11 panel |

Commit Message

Konrad Dybcio April 13, 2023, 10:09 a.m. UTC 
  Using 'port' instead of 'ports' for single-DSI usecases allows for saving
a couple of DTS LoC, including a level of indentation. Allow that.

Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
 .../bindings/display/panel/novatek,nt36523.yaml           | 15 +++++++++++++--
 1 file changed, 13 insertions(+), 2 deletions(-)

Comments

Krzysztof Kozlowski April 16, 2023, 3:25 p.m. UTC | #1 
On 13/04/2023 12:09, Konrad Dybcio wrote:
> Using 'port' instead of 'ports' for single-DSI usecases allows for saving
> a couple of DTS LoC, including a level of indentation. Allow that.
> 
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
>  .../bindings/display/panel/novatek,nt36523.yaml           | 15 +++++++++++++--
>  1 file changed, 13 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/display/panel/novatek,nt36523.yaml b/Documentation/devicetree/bindings/display/panel/novatek,nt36523.yaml
> index 0039561ef04c..38f4f986aef1 100644
> --- a/Documentation/devicetree/bindings/display/panel/novatek,nt36523.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/novatek,nt36523.yaml
> @@ -33,15 +33,26 @@ properties:
>      description: regulator that supplies the I/O voltage
>  
>    reg: true
> -  ports: true
>    backlight: true
>  
> +oneOf:
> +  - allOf:
> +      - properties:
> +          ports: true
> +      - required:
> +          - ports
> +
> +  - allOf:
> +      - properties:
> +          port: true
> +      - required:
> +          - port

If one is not connected, I still would prefer to have ports node as this
device in general supports two ports.

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/display/panel/novatek,nt36523.yaml b/Documentation/devicetree/bindings/display/panel/novatek,nt36523.yaml
index 0039561ef04c..38f4f986aef1 100644
--- a/Documentation/devicetree/bindings/display/panel/novatek,nt36523.yaml
+++ b/Documentation/devicetree/bindings/display/panel/novatek,nt36523.yaml
@@ -33,15 +33,26 @@  properties:
     description: regulator that supplies the I/O voltage
 
   reg: true
-  ports: true
   backlight: true
 
+oneOf:
+  - allOf:
+      - properties:
+          ports: true
+      - required:
+          - ports
+
+  - allOf:
+      - properties:
+          port: true
+      - required:
+          - port
+
 required:
   - compatible
   - reg
   - vddio-supply
   - reset-gpios
-  - ports
 
 unevaluatedProperties: false