Commit Message
Isaku Yamahata
Oct. 30, 2022, 6:22 a.m. UTC
From: Sean Christopherson <sean.j.christopherson@intel.com> Add error codes for the TDX SEAMCALLs both for TDX VMM side for TDH SEAMCALL and TDX guest side for TDG.VP.VMCALL. KVM issues the TDX SEAMCALLs and checks its error code. KVM handles hypercall from the TDX guest and may return an error. So error code for the TDX guest is also needed. TDX SEAMCALL uses bits 31:0 to return more information, so these error codes will only exactly match RAX[63:32]. Error codes for TDG.VP.VMCALL is defined by TDX Guest-Host-Communication interface spec. Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com> Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com> --- arch/x86/kvm/vmx/tdx_errno.h | 38 ++++++++++++++++++++++++++++++++++++ 1 file changed, 38 insertions(+) create mode 100644 arch/x86/kvm/vmx/tdx_errno.h
Comments
On 2022/10/30 14:22, isaku.yamahata@intel.com wrote: > From: Sean Christopherson <sean.j.christopherson@intel.com> > > Add error codes for the TDX SEAMCALLs both for TDX VMM side for TDH > SEAMCALL and TDX guest side for TDG.VP.VMCALL. KVM issues the TDX > SEAMCALLs and checks its error code. KVM handles hypercall from the TDX > guest and may return an error. So error code for the TDX guest is also > needed. > > TDX SEAMCALL uses bits 31:0 to return more information, so these error > codes will only exactly match RAX[63:32]. Error codes for TDG.VP.VMCALL is > defined by TDX Guest-Host-Communication interface spec. > > Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com> > Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com> > Reviewed-by: Paolo Bonzini <pbonzini@redhat.com> > --- > arch/x86/kvm/vmx/tdx_errno.h | 38 ++++++++++++++++++++++++++++++++++++ > 1 file changed, 38 insertions(+) > create mode 100644 arch/x86/kvm/vmx/tdx_errno.h > > diff --git a/arch/x86/kvm/vmx/tdx_errno.h b/arch/x86/kvm/vmx/tdx_errno.h > new file mode 100644 > index 000000000000..ce246ba62454 > --- /dev/null > +++ b/arch/x86/kvm/vmx/tdx_errno.h > @@ -0,0 +1,38 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +/* architectural status code for SEAMCALL */ > + > +#ifndef __KVM_X86_TDX_ERRNO_H > +#define __KVM_X86_TDX_ERRNO_H > + > +#define TDX_SEAMCALL_STATUS_MASK 0xFFFFFFFF00000000ULL > + > +/* > + * TDX SEAMCALL Status Codes (returned in RAX) > + */ > +#define TDX_SUCCESS 0x0000000000000000ULL > +#define TDX_NON_RECOVERABLE_VCPU 0x4000000100000000ULL > +#define TDX_INTERRUPTED_RESUMABLE 0x8000000300000000ULL > +#define TDX_OPERAND_BUSY 0x8000020000000000ULL one minor format issue, spaces are used instread of tabs this line. > +#define TDX_VCPU_NOT_ASSOCIATED 0x8000070200000000ULL > +#define TDX_KEY_GENERATION_FAILED 0x8000080000000000ULL > +#define TDX_KEY_STATE_INCORRECT 0xC000081100000000ULL > +#define TDX_KEY_CONFIGURED 0x0000081500000000ULL > +#define TDX_NO_HKID_READY_TO_WBCACHE 0x0000082100000000ULL > +#define TDX_EPT_WALK_FAILED 0xC0000B0000000000ULL > + > +/* > + * TDG.VP.VMCALL Status Codes (returned in R10) > + */ > +#define TDG_VP_VMCALL_SUCCESS 0x0000000000000000ULL > +#define TDG_VP_VMCALL_RETRY 0x0000000000000001ULL > +#define TDG_VP_VMCALL_INVALID_OPERAND 0x8000000000000000ULL > +#define TDG_VP_VMCALL_TDREPORT_FAILED 0x8000000000000001ULL > + > +/* > + * TDX module operand ID, appears in 31:0 part of error code as > + * detail information > + */ > +#define TDX_OPERAND_ID_RCX 0x01 > +#define TDX_OPERAND_ID_SEPT 0x92 > + > +#endif /* __KVM_X86_TDX_ERRNO_H */
On Mon, Oct 31, 2022 at 05:22:13PM +0800, Binbin Wu <binbin.wu@linux.intel.com> wrote: > > On 2022/10/30 14:22, isaku.yamahata@intel.com wrote: > > From: Sean Christopherson <sean.j.christopherson@intel.com> > > > > Add error codes for the TDX SEAMCALLs both for TDX VMM side for TDH > > SEAMCALL and TDX guest side for TDG.VP.VMCALL. KVM issues the TDX > > SEAMCALLs and checks its error code. KVM handles hypercall from the TDX > > guest and may return an error. So error code for the TDX guest is also > > needed. > > > > TDX SEAMCALL uses bits 31:0 to return more information, so these error > > codes will only exactly match RAX[63:32]. Error codes for TDG.VP.VMCALL is > > defined by TDX Guest-Host-Communication interface spec. > > > > Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com> > > Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com> > > Reviewed-by: Paolo Bonzini <pbonzini@redhat.com> > > --- > > arch/x86/kvm/vmx/tdx_errno.h | 38 ++++++++++++++++++++++++++++++++++++ > > 1 file changed, 38 insertions(+) > > create mode 100644 arch/x86/kvm/vmx/tdx_errno.h > > > > diff --git a/arch/x86/kvm/vmx/tdx_errno.h b/arch/x86/kvm/vmx/tdx_errno.h > > new file mode 100644 > > index 000000000000..ce246ba62454 > > --- /dev/null > > +++ b/arch/x86/kvm/vmx/tdx_errno.h > > @@ -0,0 +1,38 @@ > > +/* SPDX-License-Identifier: GPL-2.0 */ > > +/* architectural status code for SEAMCALL */ > > + > > +#ifndef __KVM_X86_TDX_ERRNO_H > > +#define __KVM_X86_TDX_ERRNO_H > > + > > +#define TDX_SEAMCALL_STATUS_MASK 0xFFFFFFFF00000000ULL > > + > > +/* > > + * TDX SEAMCALL Status Codes (returned in RAX) > > + */ > > +#define TDX_SUCCESS 0x0000000000000000ULL > > +#define TDX_NON_RECOVERABLE_VCPU 0x4000000100000000ULL > > +#define TDX_INTERRUPTED_RESUMABLE 0x8000000300000000ULL > > +#define TDX_OPERAND_BUSY 0x8000020000000000ULL > > one minor format issue, spaces are used instread of tabs this line. Thanks, fixed it locally. It will be include in the next respin.
diff --git a/arch/x86/kvm/vmx/tdx_errno.h b/arch/x86/kvm/vmx/tdx_errno.h new file mode 100644 index 000000000000..ce246ba62454 --- /dev/null +++ b/arch/x86/kvm/vmx/tdx_errno.h @@ -0,0 +1,38 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* architectural status code for SEAMCALL */ + +#ifndef __KVM_X86_TDX_ERRNO_H +#define __KVM_X86_TDX_ERRNO_H + +#define TDX_SEAMCALL_STATUS_MASK 0xFFFFFFFF00000000ULL + +/* + * TDX SEAMCALL Status Codes (returned in RAX) + */ +#define TDX_SUCCESS 0x0000000000000000ULL +#define TDX_NON_RECOVERABLE_VCPU 0x4000000100000000ULL +#define TDX_INTERRUPTED_RESUMABLE 0x8000000300000000ULL +#define TDX_OPERAND_BUSY 0x8000020000000000ULL +#define TDX_VCPU_NOT_ASSOCIATED 0x8000070200000000ULL +#define TDX_KEY_GENERATION_FAILED 0x8000080000000000ULL +#define TDX_KEY_STATE_INCORRECT 0xC000081100000000ULL +#define TDX_KEY_CONFIGURED 0x0000081500000000ULL +#define TDX_NO_HKID_READY_TO_WBCACHE 0x0000082100000000ULL +#define TDX_EPT_WALK_FAILED 0xC0000B0000000000ULL + +/* + * TDG.VP.VMCALL Status Codes (returned in R10) + */ +#define TDG_VP_VMCALL_SUCCESS 0x0000000000000000ULL +#define TDG_VP_VMCALL_RETRY 0x0000000000000001ULL +#define TDG_VP_VMCALL_INVALID_OPERAND 0x8000000000000000ULL +#define TDG_VP_VMCALL_TDREPORT_FAILED 0x8000000000000001ULL + +/* + * TDX module operand ID, appears in 31:0 part of error code as + * detail information + */ +#define TDX_OPERAND_ID_RCX 0x01 +#define TDX_OPERAND_ID_SEPT 0x92 + +#endif /* __KVM_X86_TDX_ERRNO_H */