| Message ID | 20230414093411.113787-3-cristian.ciocaltea@collabora.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp264883vqo;
Fri, 14 Apr 2023 03:11:15 -0700 (PDT)
X-Google-Smtp-Source:
AKy350Y2dFQItOTxjswE6kwBKmX/EnUQnipdmqG4ZmYn/paX1ggvIv/yxr1LV9FlSLS3GWldF7Zy
X-Received: by 2002:a05:6a20:42a6:b0:ee:74d9:52ec with SMTP id
o38-20020a056a2042a600b000ee74d952ecmr720765pzj.8.1681467075655;
Fri, 14 Apr 2023 03:11:15 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1681467075; cv=none;
d=google.com; s=arc-20160816;
b=OLbVGDc5jrOHnuujGd7CiQb8QP/1u50ATW6y80cA0dospcRrE4Pm2CUH4mGm58yZVE
U68ccZ6IDPUhSPtRZIQcC1RTJ43Q1e5g9+kREwn2kcVOQreYBFWH8i4fq9DgGCUQ5aCq
E7J5bSDdSaGfIFfFJ2PAajOCC1qujpU29O6kOxEGfkdbgbUf4M/D7tW6c1W4tMDAB8Y5
lSCU4krB8GOtf5oxw2Tfv/L/aOWVD7iuYpXcRkkx6rmbhbw7FpQzOYX6s11bTfbYK3ty
S6LaWCEo2zEtl7pBlRtB3TwtmojoEkVmQO1A+ecLnu0CZluGUyQZ5hVNUSPJJVzSBtob
RSkA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:references:in-reply-to:message-id:date:subject:cc:to:from
:dkim-signature;
bh=NTvsl3dE3rtkTi+1ykJfXsNTNAlqqgfyg5NNjQHFOIs=;
b=hWOBsM5QOtfkUQVFjxwItOr1nIvS8mdoZu6RqRgdMsPb9CNW7e4CakH9Gcw9blAefG
izrptWOye4JmRWp8Te/kjFrzvYHSA8RncjK2yQLtTrAWzHLoHTSSHr0nyfx5/y2uh8El
Zi2szo+fNUc1sy6KfdoDlq6Wb2XYMRYNJTMTdHRiJBWdIYY8Vys5yoiE0tEo5pseJWB/
0cWBzim3rJA13hQwidyJ5pSmU+Zwxsq9cU5rE3xOKscaZA6Wl1sB8+88S78BkrY4txgH
IzidoTV1khJxgC4p/83pu3E2vL4iRlsGnNyJrhvCoTg7g8E2M0D528LsNXWhuCa+Kr8e
Jkzw==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@collabora.com header.s=mail header.b=UofXJW8d;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE)
header.from=collabora.com
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
t14-20020aa7946e000000b006321d3921bfsi3873438pfq.381.2023.04.14.03.11.01;
Fri, 14 Apr 2023 03:11:15 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=pass header.i=@collabora.com header.s=mail header.b=UofXJW8d;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE)
header.from=collabora.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S230034AbjDNJfQ (ORCPT <rfc822;leviz.kernel.dev@gmail.com>
+ 99 others); Fri, 14 Apr 2023 05:35:16 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52640 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S230028AbjDNJfM (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Fri, 14 Apr 2023 05:35:12 -0400
Received: from madras.collabora.co.uk (madras.collabora.co.uk
[46.235.227.172])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3F62C83CF;
Fri, 14 Apr 2023 02:34:48 -0700 (PDT)
Received: from localhost (unknown [188.27.34.213])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits)
server-digest SHA256)
(No client certificate requested)
(Authenticated sender: cristicc)
by madras.collabora.co.uk (Postfix) with ESMTPSA id DD467660320A;
Fri, 14 Apr 2023 10:34:21 +0100 (BST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com;
s=mail; t=1681464862;
bh=0pJdxIJkVJSQqKBTxSYqm8uKUIxBe37vCYuK7W6XaLo=;
h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
b=UofXJW8dvLsF4YLVoEdLhw33+WIoxvTTiUglwVfH0K9csK9WtuiwKT4OoJixDaX3k
hv6YZvrK1Ri0ISZ/jReXdX/pfzK2hPStHZBNeNUchHnCedA+YX/EzVLhUvVqWttyi8
tNrvYnIuYETJOQSBhx60/s6+By5xrfjaSnXOa1mT2ul+dPxrCV6S6ksASz2lkIl5xF
JNJUAhLpw9/XTYjZjoHFw9jDC9cyoHER+9Mv2qOeoLr+yEqjlpxMoucVbQ+7FWPFoP
3Wc5b/5Cnghz46JzcgM23LvTy1YAWJBam8tXlAycLAfHwpEF6a8AF9k2Y4+kwygLgP
dU+cr9A/V14mA==
From: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
To: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Heiko Stuebner <heiko@sntech.de>,
Christopher Obbard <chris.obbard@collabora.com>,
Michael Riesch <michael.riesch@wolfvision.net>,
Sebastian Reichel <sebastian.reichel@collabora.com>,
Shreeya Patel <shreeya.patel@collabora.com>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
kernel@collabora.com
Subject: [PATCH 2/3] arm64: dts: rockchip: Use generic name for es8316 on
rk3588-rock-5b
Date: Fri, 14 Apr 2023 12:34:10 +0300
Message-Id: <20230414093411.113787-3-cristian.ciocaltea@collabora.com>
X-Mailer: git-send-email 2.40.0
In-Reply-To: <20230414093411.113787-1-cristian.ciocaltea@collabora.com>
References: <20230414093411.113787-1-cristian.ciocaltea@collabora.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,
T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1763146020279014253?=
X-GMAIL-MSGID: =?utf-8?q?1763146020279014253?=
|
| Series |
Add regulators to Rock 5B's CPU big cores
|
|
Commit Message
Cristian Ciocaltea
April 14, 2023, 9:34 a.m. UTC
Use generic 'audio-codec' name for es8316 node on Rock 5B board.
Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
---
arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On 14/04/2023 11:34, Cristian Ciocaltea wrote: > Use generic 'audio-codec' name for es8316 node on Rock 5B board. > > Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com> > --- > arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts > index 62750beb12aa..8cc97d146a73 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts > @@ -72,7 +72,7 @@ hym8563: rtc@51 { > &i2c7 { > status = "okay"; > > - es8316: es8316@11 { > + es8316: audio-codec@11 { This is a trivial change. Fix all instances in all subarch/platform DTS. Not board-per-board. Best regards, Krzysztof
On 4/14/23 13:26, Krzysztof Kozlowski wrote: > On 14/04/2023 11:34, Cristian Ciocaltea wrote: >> Use generic 'audio-codec' name for es8316 node on Rock 5B board. >> >> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com> >> --- >> arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts >> index 62750beb12aa..8cc97d146a73 100644 >> --- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts >> +++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts >> @@ -72,7 +72,7 @@ hym8563: rtc@51 { >> &i2c7 { >> status = "okay"; >> >> - es8316: es8316@11 { >> + es8316: audio-codec@11 { > > This is a trivial change. Fix all instances in all subarch/platform DTS. > Not board-per-board. Looks like only the rockchip DTS are affected, but not quite sure how to proceed in the case of 'es8316: codec@', should I change them to 'es8316: audio-codec@' as well? arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts: es8316: es8316@11 { arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi: es8316: codec@11 { arch/arm64/boot/dts/rockchip/rk3399-rockpro64-v2.dts: es8316: codec@10 { arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts: es8316: codec@11 {
On 14/04/2023 12:53, Cristian Ciocaltea wrote: > On 4/14/23 13:26, Krzysztof Kozlowski wrote: >> On 14/04/2023 11:34, Cristian Ciocaltea wrote: >>> Use generic 'audio-codec' name for es8316 node on Rock 5B board. >>> >>> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com> >>> --- >>> arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts >>> index 62750beb12aa..8cc97d146a73 100644 >>> --- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts >>> +++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts >>> @@ -72,7 +72,7 @@ hym8563: rtc@51 { >>> &i2c7 { >>> status = "okay"; >>> >>> - es8316: es8316@11 { >>> + es8316: audio-codec@11 { >> >> This is a trivial change. Fix all instances in all subarch/platform DTS. >> Not board-per-board. > > Looks like only the rockchip DTS are affected, but not quite sure how to > proceed in the case of 'es8316: codec@', should I change them to > 'es8316: audio-codec@' as well? > > arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts: es8316: es8316@11 { No, fix only this. Best regards, Krzysztof
diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts index 62750beb12aa..8cc97d146a73 100644 --- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts +++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts @@ -72,7 +72,7 @@ hym8563: rtc@51 { &i2c7 { status = "okay"; - es8316: es8316@11 { + es8316: audio-codec@11 { compatible = "everest,es8316"; reg = <0x11>; clocks = <&cru I2S0_8CH_MCLKOUT>;