diff mbox series

Mips: Fix _CONST64_(x) as unsigned

Message ID 20230411063144.3119-1-zhangqing@loongson.cn
State New
Headers
Series Mips: Fix _CONST64_(x) as unsigned |

Commit Message

Qing Zhang April 11, 2023, 6:31 a.m. UTC 
  Addresses should all be of unsigned type to avoid unnecessary conversions.

Signed-off-by: Qing Zhang <zhangqing@loongson.cn>
---
 arch/mips/include/asm/addrspace.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Jiaxun Yang April 14, 2023, 8:13 a.m. UTC | #1 
> 2023年4月11日 07:31，Qing Zhang <zhangqing@loongson.cn> 写道：
> 
> Addresses should all be of unsigned type to avoid unnecessary conversions.

It’s defined as signed for a reason. To keep consistent with 32-bit address, which
Is sign-extended on 64bit systems.

Thanks
Jiaxun

> 
> Signed-off-by: Qing Zhang <zhangqing@loongson.cn>
> ---
> arch/mips/include/asm/addrspace.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/mips/include/asm/addrspace.h b/arch/mips/include/asm/addrspace.h
> index 59a48c60a065..75d36115a25e 100644
> --- a/arch/mips/include/asm/addrspace.h
> +++ b/arch/mips/include/asm/addrspace.h
> @@ -25,9 +25,9 @@
> #define _ATYPE32_ int
> #define _ATYPE64_ __s64
> #ifdef CONFIG_64BIT
> -#define _CONST64_(x) x ## L
> +#define _CONST64_(x) x ## UL
> #else
> -#define _CONST64_(x) x ## LL
> +#define _CONST64_(x) x ## ULL
> #endif
> #endif
> 
> -- 
> 2.20.1
>
diff mbox series

Patch

diff --git a/arch/mips/include/asm/addrspace.h b/arch/mips/include/asm/addrspace.h
index 59a48c60a065..75d36115a25e 100644
--- a/arch/mips/include/asm/addrspace.h
+++ b/arch/mips/include/asm/addrspace.h
@@ -25,9 +25,9 @@ 
 #define _ATYPE32_	int
 #define _ATYPE64_	__s64
 #ifdef CONFIG_64BIT
-#define _CONST64_(x)	x ## L
+#define _CONST64_(x)	x ## UL
 #else
-#define _CONST64_(x)	x ## LL
+#define _CONST64_(x)	x ## ULL
 #endif
 #endif