Message ID | 20230413085351.26808-1-stanley_chang@realtek.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp889236vqo; Thu, 13 Apr 2023 02:02:06 -0700 (PDT) X-Google-Smtp-Source: AKy350YSK7Cj62qCTg/vmOK8yz77+5/hai3dyhTl+/Ll31CtpAacxzaa3WVqIZphutyy0dwlRJBC X-Received: by 2002:a17:903:1205:b0:1a1:d70f:7114 with SMTP id l5-20020a170903120500b001a1d70f7114mr1730675plh.14.1681376525895; Thu, 13 Apr 2023 02:02:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681376525; cv=none; d=google.com; s=arc-20160816; b=vKGB/YFTZR3qqcH4KOj0CgCcTpuLx3XZTmVcVjyQ+lDCvX+U+wjt0JpQvGiByyFW6W lVeSqBMnN3LU8AgAjnjUvEUJWJnDIwcbCgi/EGq8xJxUtMyNihWsbdKj2r2EqszZJu8R LlBe7sNnNBeUvm8/0GalNYmYfe+ZMbVsIhh6ohLvsiAeHZxJNdX2g8K/NOsR1A7CME3H kTyclIyMEYP5ws+2Ddn5sAMx12iIblNGKpjj4PMW/d7hfdyE/lVlqDqTVcY2m5I0UNNE tW6wafUTC7lxL8ubxbZCMO6b2mz57JRWLJw7ZEgAn9/kMfbpEzfdDIA5kI25eDbRQjs1 AulA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:authenticated-by; bh=AIa0OEUv9vsqbwBmFVrWkl8v4D5z/w15/6vrnovkEbM=; b=d6dqt/EjO7QURN3XtwmuXFabP0MRlIU2/nxa4vDSpI/gwA5oBd0433exi1sGUJqpb/ UW7Op2vEl7vwcqu3vDd+TloglZNg9McD8aAroQ0uDblVhybL+ugBoruY5bC78E3v4LaZ 6Iav8A99EUfRwwBxnko4BFvG0rcOw6kG8Wmiz1QAXATMCDLzXBJEz9UPLsEK2tCmhI8k 9dPjf4HHhHX8F6cytJlVES+HVfnnC52vW1F4doV9vJlFDUxcC4IkPWXDI4IuClZQ68oB s5eLkoiz0PmmvE7MvHrStZ559RJa4BLsCHj8pnhcE6g8X1aTAxEAJgUSNHFRTz6h+zXF /bnQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u11-20020a6540cb000000b0051393805cd1si987910pgp.461.2023.04.13.02.01.54; Thu, 13 Apr 2023 02:02:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230116AbjDMI4I (ORCPT <rfc822;peter110.wang@gmail.com> + 99 others); Thu, 13 Apr 2023 04:56:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49014 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229746AbjDMIzf (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Thu, 13 Apr 2023 04:55:35 -0400 Received: from rtits2.realtek.com.tw (rtits2.realtek.com [211.75.126.72]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 129C09750; Thu, 13 Apr 2023 01:54:32 -0700 (PDT) Authenticated-By: X-SpamFilter-By: ArmorX SpamTrap 5.77 with qID 33D8rThtD028776, This message is accepted by code: ctloc85258 Received: from mail.realtek.com (rtexh36505.realtek.com.tw[172.21.6.25]) by rtits2.realtek.com.tw (8.15.2/2.81/5.90) with ESMTPS id 33D8rThtD028776 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=OK); Thu, 13 Apr 2023 16:53:29 +0800 Received: from RTEXMBS03.realtek.com.tw (172.21.6.96) by RTEXH36505.realtek.com.tw (172.21.6.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.32; Thu, 13 Apr 2023 16:53:51 +0800 Received: from RTEXH36506.realtek.com.tw (172.21.6.27) by RTEXMBS03.realtek.com.tw (172.21.6.96) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.7; Thu, 13 Apr 2023 16:53:51 +0800 Received: from localhost.localdomain (172.21.252.101) by RTEXH36506.realtek.com.tw (172.21.6.27) with Microsoft SMTP Server id 15.1.2507.17 via Frontend Transport; Thu, 13 Apr 2023 16:53:51 +0800 From: Stanley Chang <stanley_chang@realtek.com> To: Thinh Nguyen <Thinh.Nguyen@synopsys.com> CC: Stanley Chang <stanley_chang@realtek.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Rob Herring <robh+dt@kernel.org>, "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>, Felipe Balbi <balbi@kernel.org>, <linux-usb@vger.kernel.org>, <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org> Subject: [PATCH v3 2/2] dt-bindings: usb: snps,dwc3: Add 'snps,parkmode-disable-hs-quirk' quirk Date: Thu, 13 Apr 2023 16:53:50 +0800 Message-ID: <20230413085351.26808-1-stanley_chang@realtek.com> X-Mailer: git-send-email 2.40.0 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-KSE-ServerInfo: RTEXMBS03.realtek.com.tw, 9 X-KSE-AntiSpam-Interceptor-Info: scan successful X-KSE-AntiSpam-Version: 5.9.59, Database issued on: 04/13/2023 08:33:39 X-KSE-AntiSpam-Status: KAS_STATUS_NOT_DETECTED X-KSE-AntiSpam-Method: none X-KSE-AntiSpam-Rate: 0 X-KSE-AntiSpam-Info: Lua profiles 176677 [Apr 13 2023] X-KSE-AntiSpam-Info: Version: 5.9.59.0 X-KSE-AntiSpam-Info: Envelope from: stanley_chang@realtek.com X-KSE-AntiSpam-Info: LuaCore: 509 509 b12bcaa7ba85624b485f2b6b92324b70964a1c65 X-KSE-AntiSpam-Info: {Tracking_from_domain_doesnt_match_to} X-KSE-AntiSpam-Info: 127.0.0.199:7.1.2;realtek.com:7.1.1;d41d8cd98f00b204e9800998ecf8427e.com:7.1.1 X-KSE-AntiSpam-Info: Rate: 0 X-KSE-AntiSpam-Info: Status: not_detected X-KSE-AntiSpam-Info: Method: none X-KSE-AntiSpam-Info: Auth:dkim=none X-KSE-Antiphishing-Info: Clean X-KSE-Antiphishing-ScanningType: Heuristic X-KSE-Antiphishing-Method: None X-KSE-Antiphishing-Bases: 04/13/2023 08:36:00 X-KSE-AttachmentFiltering-Interceptor-Info: no applicable attachment filtering rules found X-KSE-Antivirus-Interceptor-Info: scan successful X-KSE-Antivirus-Info: =?big5_tw?b?Q2xlYW4sIGJhc2VzOiAyMDIzLzQvMTMgpFekyCAwNjoz?= =?big5_tw?b?ODowMA==?= X-KSE-BulkMessagesFiltering-Scan-Result: protection disabled X-KSE-ServerInfo: RTEXH36505.realtek.com.tw, 9 X-KSE-AntiSpam-Interceptor-Info: fallback X-KSE-Antivirus-Interceptor-Info: fallback X-KSE-AntiSpam-Interceptor-Info: fallback X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1762968704037878271?= X-GMAIL-MSGID: =?utf-8?q?1763051072314282821?= |
Series |
[v3,1/2] usb: dwc3: core: add support for disabling High-speed park mode
|
|
Commit Message
Stanley Chang[昌育德]
April 13, 2023, 8:53 a.m. UTC
Add a new 'snps,parkmode-disable-hs-quirk' DT quirk to dwc3 core for
disable the high-speed parkmode.
For some USB wifi devices, if enable this feature it will reduce the
performance. Therefore, add an option for disabling HS park mode by
device-tree.
In Synopsys's dwc3 data book:
In a few high speed devices when an IN request is sent within 900ns of the
ACK of the previous packet, these devices send a NAK. When connected to
these devices, if required, the software can disable the park mode if you
see performance drop in your system. When park mode is disabled,
pipelining of multiple packet is disabled and instead one packet at a time
is requested by the scheduler. This allows up to 12 NAKs in a micro-frame
and improves performance of these slow devices.
Signed-off-by: Stanley Chang <stanley_chang@realtek.com>
---
v2 to v3 change:
1. Add the comment message.
2. cc the right maintainers.
---
Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 5 +++++
1 file changed, 5 insertions(+)
Comments
On Thu, Apr 13, 2023 at 04:53:50PM +0800, Stanley Chang wrote: > Add a new 'snps,parkmode-disable-hs-quirk' DT quirk to dwc3 core for > disable the high-speed parkmode. > > For some USB wifi devices, if enable this feature it will reduce the > performance. Therefore, add an option for disabling HS park mode by > device-tree. > > In Synopsys's dwc3 data book: > In a few high speed devices when an IN request is sent within 900ns of the > ACK of the previous packet, these devices send a NAK. When connected to > these devices, if required, the software can disable the park mode if you > see performance drop in your system. When park mode is disabled, > pipelining of multiple packet is disabled and instead one packet at a time > is requested by the scheduler. This allows up to 12 NAKs in a micro-frame > and improves performance of these slow devices. > > Signed-off-by: Stanley Chang <stanley_chang@realtek.com> > --- > v2 to v3 change: > 1. Add the comment message. > 2. cc the right maintainers. This is not properly threaded with patch 1/2 for some reason, so our tools can not pick up the whole thread at once. Please fix up your sending script, or just use git send-email directly. thanks, greg k-h
> This is not properly threaded with patch 1/2 for some reason, so our tools can > not pick up the whole thread at once. Please fix up your sending script, or > just use git send-email directly. > > thanks, > > greg k-h > I send the patch by git send-email. git send-email --cc="Stanley Chang <stanley_chang@realtek.com>" --to="Thinh Nguyen <Thinh.Nguyen@synopsys.com>" --cc-cmd='./scripts/get_maintainer.pl -norolestats v3-0001-usb-dwc3-core-add-support-for-disabling-High-spee.patch' --annotate v3-0001-usb-dwc3-core-add-support-for-disabling-High-spee.patch git send-email --cc="Stanley Chang <stanley_chang@realtek.com>" --to="Thinh Nguyen <Thinh.Nguyen@synopsys.com>" --cc-cmd='./scripts/get_maintainer.pl -norolesats v3-0002-dt-bindings-usb-snps-dwc3-Add-snps-parkmode-disab.patch' --annotate v3-0002-dt-bindings-usb-snps-dwc3-Add-snps-parkmode-disab.patch I don't know why it can't thread with 2 patches? Do I need to resend v4 patch? Or how can I to resolve this problem?
On 13/04/2023 11:36, Stanley Chang[昌育德] wrote: >> This is not properly threaded with patch 1/2 for some reason, so our tools can >> not pick up the whole thread at once. Please fix up your sending script, or >> just use git send-email directly. >> >> thanks, >> >> greg k-h >> > > I send the patch by git send-email. > > git send-email --cc="Stanley Chang <stanley_chang@realtek.com>" --to="Thinh Nguyen <Thinh.Nguyen@synopsys.com>" --cc-cmd='./scripts/get_maintainer.pl -norolestats v3-0001-usb-dwc3-core-add-support-for-disabling-High-spee.patch' --annotate v3-0001-usb-dwc3-core-add-support-for-disabling-High-spee.patch > > git send-email --cc="Stanley Chang <stanley_chang@realtek.com>" --to="Thinh Nguyen <Thinh.Nguyen@synopsys.com>" --cc-cmd='./scripts/get_maintainer.pl -norolesats v3-0002-dt-bindings-usb-snps-dwc3-Add-snps-parkmode-disab.patch' --annotate v3-0002-dt-bindings-usb-snps-dwc3-Add-snps-parkmode-disab.patch > > I don't know why it can't thread with 2 patches? You can - git help send-email Easiest way is to: git send-email .... v3* Best regards, Krzysztof
On Thu, Apr 13, 2023 at 09:36:58AM +0000, Stanley Chang[昌育德] wrote: > > This is not properly threaded with patch 1/2 for some reason, so our tools can > > not pick up the whole thread at once. Please fix up your sending script, or > > just use git send-email directly. > > > > thanks, > > > > greg k-h > > > > I send the patch by git send-email. > > git send-email --cc="Stanley Chang <stanley_chang@realtek.com>" --to="Thinh Nguyen <Thinh.Nguyen@synopsys.com>" --cc-cmd='./scripts/get_maintainer.pl -norolestats v3-0001-usb-dwc3-core-add-support-for-disabling-High-spee.patch' --annotate v3-0001-usb-dwc3-core-add-support-for-disabling-High-spee.patch > > git send-email --cc="Stanley Chang <stanley_chang@realtek.com>" --to="Thinh Nguyen <Thinh.Nguyen@synopsys.com>" --cc-cmd='./scripts/get_maintainer.pl -norolesats v3-0002-dt-bindings-usb-snps-dwc3-Add-snps-parkmode-disab.patch' --annotate v3-0002-dt-bindings-usb-snps-dwc3-Add-snps-parkmode-disab.patch > > I don't know why it can't thread with 2 patches? Because the second invocation of git send-email knows nothing about the first. As Krzysztof said, send both patches on the same command line. > Do I need to resend v4 patch? Yes, I can not take these as-is for this reason. thanks, greg k-h
diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml index be36956af53b..45ca967b8d14 100644 --- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml +++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml @@ -232,6 +232,11 @@ properties: When set, all SuperSpeed bus instances in park mode are disabled. type: boolean + snps,parkmode-disable-hs-quirk: + description: + When set, all HighSpeed bus instances in park mode are disabled. + type: boolean + snps,dis_metastability_quirk: description: When set, disable metastability workaround. CAUTION! Use only if you are