[04/11] dmaengine: dw-axi-dmac: remove redudant axi_dma_disable() calling

Message ID 20230313170450.897-5-jszhang@kernel.org
State New
Headers
Series dmaengine: dw-axi_dmac: bug fix clean up and more features |

Commit Message

Jisheng Zhang March 13, 2023, 5:04 p.m. UTC
  axi_dma_suspend() will soon call axi_dma_disable(), remove the redudant
axi_dma_disable() callin.

Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
---
 drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c | 1 -
 1 file changed, 1 deletion(-)
  

Comments

Vinod Koul April 12, 2023, 5:36 p.m. UTC | #1
On 14-03-23, 01:04, Jisheng Zhang wrote:
> axi_dma_suspend() will soon call axi_dma_disable(), remove the redudant

s/redudant/redundant

> axi_dma_disable() callin.
> 
> Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
> ---
>  drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c
> index 891776528619..410222e7224c 100644
> --- a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c
> +++ b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c
> @@ -1535,7 +1535,6 @@ static int dw_remove(struct platform_device *pdev)
>  		axi_chan_disable(&chip->dw->chan[i]);
>  		axi_chan_irq_disable(&chip->dw->chan[i], DWAXIDMAC_IRQ_ALL);
>  	}
> -	axi_dma_disable(chip);
>  
>  	pm_runtime_disable(chip->dev);
>  	axi_dma_suspend(chip);
> -- 
> 2.39.2
  

Patch

diff --git a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c
index 891776528619..410222e7224c 100644
--- a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c
+++ b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c
@@ -1535,7 +1535,6 @@  static int dw_remove(struct platform_device *pdev)
 		axi_chan_disable(&chip->dw->chan[i]);
 		axi_chan_irq_disable(&chip->dw->chan[i], DWAXIDMAC_IRQ_ALL);
 	}
-	axi_dma_disable(chip);
 
 	pm_runtime_disable(chip->dev);
 	axi_dma_suspend(chip);