diff mbox series

arm64: dts: qcom: sc8280xp-lenovo-thinkpad: correct pin drive-strength

Message ID 20230407180710.128815-1-krzysztof.kozlowski@linaro.org
State New
Headers
Series arm64: dts: qcom: sc8280xp-lenovo-thinkpad: correct pin drive-strength |

Commit Message

Krzysztof Kozlowski April 7, 2023, 6:07 p.m. UTC 
  Fix typo in drive-strength property name.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Bjorn Andersson April 7, 2023, 6:57 p.m. UTC | #1 
On Fri, 7 Apr 2023 20:07:10 +0200, Krzysztof Kozlowski wrote:
> Fix typo in drive-strength property name.
> 
> 

Applied, thanks!

[1/1] arm64: dts: qcom: sc8280xp-lenovo-thinkpad: correct pin drive-strength
      commit: 47ce7e168486de0a581f5903e72ba2cbc68123ec

Best regards,
Johan Hovold April 11, 2023, 2:23 p.m. UTC | #2 
On Fri, Apr 07, 2023 at 08:07:10PM +0200, Krzysztof Kozlowski wrote:
> Fix typo in drive-strength property name.

In the future, please try to use the established commit-summary prefix.
In this case:

	arm64: dts: qcom: sc8280xp-x13s:

Johan
Krzysztof Kozlowski April 11, 2023, 4:58 p.m. UTC | #3 
On 11/04/2023 16:23, Johan Hovold wrote:
> On Fri, Apr 07, 2023 at 08:07:10PM +0200, Krzysztof Kozlowski wrote:
>> Fix typo in drive-strength property name.
> 
> In the future, please try to use the established commit-summary prefix.
> In this case:
> 
> 	arm64: dts: qcom: sc8280xp-x13s:

Sure.

commit ca1ce7207e53cfe69aee5002eb3795069668da53
Author: Johan Hovold <johan+linaro@kernel.org>
Date:   Fri Aug 5 11:23:17 2022 +0200

    arm64: dts: qcom: sc8280xp-lenovo-thinkpad-x13s: add alternate touchpad


Best regards,
Krzysztof
Johan Hovold April 12, 2023, 6:49 a.m. UTC | #4 
On Tue, Apr 11, 2023 at 06:58:33PM +0200, Krzysztof Kozlowski wrote:
> On 11/04/2023 16:23, Johan Hovold wrote:
> > On Fri, Apr 07, 2023 at 08:07:10PM +0200, Krzysztof Kozlowski wrote:
> >> Fix typo in drive-strength property name.
> > 
> > In the future, please try to use the established commit-summary prefix.
> > In this case:
> > 
> > 	arm64: dts: qcom: sc8280xp-x13s:
> 
> Sure.
> 
> commit ca1ce7207e53cfe69aee5002eb3795069668da53
> Author: Johan Hovold <johan+linaro@kernel.org>
> Date:   Fri Aug 5 11:23:17 2022 +0200
> 
>     arm64: dts: qcom: sc8280xp-lenovo-thinkpad-x13s: add alternate touchpad

Yeah, we initially used a longer prefix (including "x13s" which was
missing in the Subject of this patch), but quite soon decided on using
the shorter

	arm64: dts: qcom: sc8280xp-x13s:

instead.

Johan
Krzysztof Kozlowski April 12, 2023, 7:03 a.m. UTC | #5 
On 12/04/2023 08:49, Johan Hovold wrote:
> On Tue, Apr 11, 2023 at 06:58:33PM +0200, Krzysztof Kozlowski wrote:
>> On 11/04/2023 16:23, Johan Hovold wrote:
>>> On Fri, Apr 07, 2023 at 08:07:10PM +0200, Krzysztof Kozlowski wrote:
>>>> Fix typo in drive-strength property name.
>>>
>>> In the future, please try to use the established commit-summary prefix.
>>> In this case:
>>>
>>> 	arm64: dts: qcom: sc8280xp-x13s:
>>
>> Sure.
>>
>> commit ca1ce7207e53cfe69aee5002eb3795069668da53
>> Author: Johan Hovold <johan+linaro@kernel.org>
>> Date:   Fri Aug 5 11:23:17 2022 +0200
>>
>>     arm64: dts: qcom: sc8280xp-lenovo-thinkpad-x13s: add alternate touchpad
> 
> Yeah, we initially used a longer prefix (including "x13s" which was
> missing in the Subject of this patch), but quite soon decided on using
> the shorter
> 
> 	arm64: dts: qcom: sc8280xp-x13s:
> 
> instead.

Thanks. Do you know if this rule applies to other long-names? I was
usually keeping full name or shortening them by cutting end, but maybe I
should cut the middle?

sm8250-sony-xperia-edo-pdx206
sm8250-sony-xperia-edo
sm8250-pdx206

Best regards,
Krzysztof
Johan Hovold April 12, 2023, 7:19 a.m. UTC | #6 
On Wed, Apr 12, 2023 at 09:03:31AM +0200, Krzysztof Kozlowski wrote:
> On 12/04/2023 08:49, Johan Hovold wrote:
> > On Tue, Apr 11, 2023 at 06:58:33PM +0200, Krzysztof Kozlowski wrote:
> >> On 11/04/2023 16:23, Johan Hovold wrote:
> >>> On Fri, Apr 07, 2023 at 08:07:10PM +0200, Krzysztof Kozlowski wrote:
> >>>> Fix typo in drive-strength property name.
> >>>
> >>> In the future, please try to use the established commit-summary prefix.
> >>> In this case:
> >>>
> >>> 	arm64: dts: qcom: sc8280xp-x13s:
> >>
> >> Sure.
> >>
> >> commit ca1ce7207e53cfe69aee5002eb3795069668da53
> >> Author: Johan Hovold <johan+linaro@kernel.org>
> >> Date:   Fri Aug 5 11:23:17 2022 +0200
> >>
> >>     arm64: dts: qcom: sc8280xp-lenovo-thinkpad-x13s: add alternate touchpad
> > 
> > Yeah, we initially used a longer prefix (including "x13s" which was
> > missing in the Subject of this patch), but quite soon decided on using
> > the shorter
> > 
> > 	arm64: dts: qcom: sc8280xp-x13s:
> > 
> > instead.
> 
> Thanks. Do you know if this rule applies to other long-names? I was
> usually keeping full name or shortening them by cutting end, but maybe I
> should cut the middle?
> 
> sm8250-sony-xperia-edo-pdx206
> sm8250-sony-xperia-edo
> sm8250-pdx206

I would not call it a rule just yet, but I guess there are further cases
were this could have been used. Perhaps you can all decide to use it for
the other Qualcomm dts as well.

For the X13s the, 'sc8280xp-x13s' is enough to uniquely define the
board and it mirrors 'sc8280xp-crd' (and using a shorter prefix makes
the commit logs easier to read).

The general suggestion is still to check 'git log --oneline' for the
files in question and use what appears to be the (recent) common prefix.

Johan
Konrad Dybcio April 12, 2023, 7:22 a.m. UTC | #7 
On 12.04.2023 09:19, Johan Hovold wrote:
> On Wed, Apr 12, 2023 at 09:03:31AM +0200, Krzysztof Kozlowski wrote:
>> On 12/04/2023 08:49, Johan Hovold wrote:
>>> On Tue, Apr 11, 2023 at 06:58:33PM +0200, Krzysztof Kozlowski wrote:
>>>> On 11/04/2023 16:23, Johan Hovold wrote:
>>>>> On Fri, Apr 07, 2023 at 08:07:10PM +0200, Krzysztof Kozlowski wrote:
>>>>>> Fix typo in drive-strength property name.
>>>>>
>>>>> In the future, please try to use the established commit-summary prefix.
>>>>> In this case:
>>>>>
>>>>> 	arm64: dts: qcom: sc8280xp-x13s:
>>>>
>>>> Sure.
>>>>
>>>> commit ca1ce7207e53cfe69aee5002eb3795069668da53
>>>> Author: Johan Hovold <johan+linaro@kernel.org>
>>>> Date:   Fri Aug 5 11:23:17 2022 +0200
>>>>
>>>>     arm64: dts: qcom: sc8280xp-lenovo-thinkpad-x13s: add alternate touchpad
>>>
>>> Yeah, we initially used a longer prefix (including "x13s" which was
>>> missing in the Subject of this patch), but quite soon decided on using
>>> the shorter
>>>
>>> 	arm64: dts: qcom: sc8280xp-x13s:
>>>
>>> instead.
>>
>> Thanks. Do you know if this rule applies to other long-names? I was
>> usually keeping full name or shortening them by cutting end, but maybe I
>> should cut the middle?
>>
>> sm8250-sony-xperia-edo-pdx206
>> sm8250-sony-xperia-edo
>> sm8250-pdx206
I do sm8250-pdx206 or sm8250-edo for common dtsi changes

Generally anything that contains the SoC name and isn't ambiguous
works, IMO. And the more concise, the better.

Konrad
> 
> I would not call it a rule just yet, but I guess there are further cases
> were this could have been used. Perhaps you can all decide to use it for
> the other Qualcomm dts as well.
> 
> For the X13s the, 'sc8280xp-x13s' is enough to uniquely define the
> board and it mirrors 'sc8280xp-crd' (and using a shorter prefix makes
> the commit logs easier to read).
> 
> The general suggestion is still to check 'git log --oneline' for the
> files in question and use what appears to be the (recent) common prefix.
> 
> Johan
Krzysztof Kozlowski April 13, 2023, 8:53 a.m. UTC | #8 
On 12/04/2023 09:19, Johan Hovold wrote:
> On Wed, Apr 12, 2023 at 09:03:31AM +0200, Krzysztof Kozlowski wrote:
>> On 12/04/2023 08:49, Johan Hovold wrote:
>>> On Tue, Apr 11, 2023 at 06:58:33PM +0200, Krzysztof Kozlowski wrote:
>>>> On 11/04/2023 16:23, Johan Hovold wrote:
>>>>> On Fri, Apr 07, 2023 at 08:07:10PM +0200, Krzysztof Kozlowski wrote:
>>>>>> Fix typo in drive-strength property name.
>>>>>
>>>>> In the future, please try to use the established commit-summary prefix.
>>>>> In this case:
>>>>>
>>>>> 	arm64: dts: qcom: sc8280xp-x13s:
>>>>
>>>> Sure.
>>>>
>>>> commit ca1ce7207e53cfe69aee5002eb3795069668da53
>>>> Author: Johan Hovold <johan+linaro@kernel.org>
>>>> Date:   Fri Aug 5 11:23:17 2022 +0200
>>>>
>>>>     arm64: dts: qcom: sc8280xp-lenovo-thinkpad-x13s: add alternate touchpad
>>>
>>> Yeah, we initially used a longer prefix (including "x13s" which was
>>> missing in the Subject of this patch), but quite soon decided on using
>>> the shorter
>>>
>>> 	arm64: dts: qcom: sc8280xp-x13s:
>>>
>>> instead.
>>
>> Thanks. Do you know if this rule applies to other long-names? I was
>> usually keeping full name or shortening them by cutting end, but maybe I
>> should cut the middle?
>>
>> sm8250-sony-xperia-edo-pdx206
>> sm8250-sony-xperia-edo
>> sm8250-pdx206
> 
> I would not call it a rule just yet, but I guess there are further cases
> were this could have been used. Perhaps you can all decide to use it for
> the other Qualcomm dts as well.
> 
> For the X13s the, 'sc8280xp-x13s' is enough to uniquely define the
> board and it mirrors 'sc8280xp-crd' (and using a shorter prefix makes
> the commit logs easier to read).
> 
> The general suggestion is still to check 'git log --oneline' for the
> files in question and use what appears to be the (recent) common prefix.

I do it for subsystems, but I am not going to do it per file. Sorry, I
am sending way too many of them to keep also customizing them per each
file. If you wanted x13s prefix, then you would name the file like that.
If you named file differently, then apparently that's how you want it to
look.

Best regards,
Krzysztof
Krzysztof Kozlowski April 13, 2023, 8:53 a.m. UTC | #9 
On 12/04/2023 09:22, Konrad Dybcio wrote:
>>>
>>> Thanks. Do you know if this rule applies to other long-names? I was
>>> usually keeping full name or shortening them by cutting end, but maybe I
>>> should cut the middle?
>>>
>>> sm8250-sony-xperia-edo-pdx206
>>> sm8250-sony-xperia-edo
>>> sm8250-pdx206
> I do sm8250-pdx206 or sm8250-edo for common dtsi changes
> 
> Generally anything that contains the SoC name and isn't ambiguous
> works, IMO. And the more concise, the better.

You should have named the files like this...

Best regards,
Krzysztof
Johan Hovold April 13, 2023, 9:11 a.m. UTC | #10 
On Thu, Apr 13, 2023 at 10:53:07AM +0200, Krzysztof Kozlowski wrote:
> On 12/04/2023 09:19, Johan Hovold wrote:

> > The general suggestion is still to check 'git log --oneline' for the
> > files in question and use what appears to be the (recent) common prefix.
> 
> I do it for subsystems, but I am not going to do it per file. Sorry, I
> am sending way too many of them to keep also customizing them per each
> file.

Perhaps you should start grouping your patch bombs of identical changes
rather than send them per file if this is such a burden.

Either way, that is no excuse when changing a single file.

> If you wanted x13s prefix, then you would name the file like that.
> If you named file differently, then apparently that's how you want it to
> look.

No, that is not what we want. The git log tells you what we expect. And
the x13s prefix is there, you just randomly decided to drop it.

Johan
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
index a1db3cf80c47..bdcba719fc38 100644
--- a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
+++ b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
@@ -1428,7 +1428,7 @@  oe-n-pins {
 			pins = "gpio101";
 			function = "gpio";
 			bias-disable;
-			drive-strengh = <16>;
+			drive-strength = <16>;
 			output-high;
 		};
 
@@ -1445,7 +1445,7 @@  oe-n-pins {
 			pins = "gpio48";
 			function = "gpio";
 			bias-disable;
-			drive-strengh = <16>;
+			drive-strength = <16>;
 			output-high;
 		};