diff mbox series

scsi: target: core: remove unused prod_len variable

Message ID 20230329132421.1809362-1-trix@redhat.com
State New
Headers
Series scsi: target: core: remove unused prod_len variable |

Commit Message

Tom Rix March 29, 2023, 1:24 p.m. UTC 
  clang with W=1 reports
drivers/target/target_core_spc.c:229:6: error: variable
  'prod_len' set but not used [-Werror,-Wunused-but-set-variable]
        u32 prod_len;
            ^
This variable is not used so remove it.

Signed-off-by: Tom Rix <trix@redhat.com>
---
 drivers/target/target_core_spc.c | 5 -----
 1 file changed, 5 deletions(-)

Comments

Chaitanya Kulkarni March 29, 2023, 9:07 p.m. UTC | #1 
On 3/29/23 06:24, Tom Rix wrote:
> clang with W=1 reports
> drivers/target/target_core_spc.c:229:6: error: variable
>    'prod_len' set but not used [-Werror,-Wunused-but-set-variable]
>          u32 prod_len;
>              ^
> This variable is not used so remove it.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
>


Looks good.

Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>

-ck
Martin K. Petersen April 12, 2023, 2:04 a.m. UTC | #2 
On Wed, 29 Mar 2023 09:24:21 -0400, Tom Rix wrote:

> clang with W=1 reports
> drivers/target/target_core_spc.c:229:6: error: variable
>   'prod_len' set but not used [-Werror,-Wunused-but-set-variable]
>         u32 prod_len;
>             ^
> This variable is not used so remove it.
> 
> [...]

Applied to 6.4/scsi-queue, thanks!

[1/1] scsi: target: core: remove unused prod_len variable
      https://git.kernel.org/mkp/scsi/c/aa4d7812cf2c
diff mbox series

Patch

diff --git a/drivers/target/target_core_spc.c b/drivers/target/target_core_spc.c
index 5bae45c3fb65..89c0d56294cc 100644
--- a/drivers/target/target_core_spc.c
+++ b/drivers/target/target_core_spc.c
@@ -226,7 +226,6 @@  spc_emulate_evpd_83(struct se_cmd *cmd, unsigned char *buf)
 	struct t10_alua_lu_gp_member *lu_gp_mem;
 	struct t10_alua_tg_pt_gp *tg_pt_gp;
 	unsigned char *prod = &dev->t10_wwn.model[0];
-	u32 prod_len;
 	u32 off = 0;
 	u16 len = 0, id_len;
 
@@ -267,10 +266,6 @@  spc_emulate_evpd_83(struct se_cmd *cmd, unsigned char *buf)
 	 * T10 Vendor Identifier Page, see spc4r17 section 7.7.3.4
 	 */
 	id_len = 8; /* For Vendor field */
-	prod_len = 4; /* For VPD Header */
-	prod_len += 8; /* For Vendor field */
-	prod_len += strlen(prod);
-	prod_len++; /* For : */
 
 	if (dev->dev_flags & DF_EMULATED_VPD_UNIT_SERIAL)
 		id_len += sprintf(&buf[off+12], "%s:%s", prod,