Message ID | 20230407180710.128815-1-krzysztof.kozlowski@linaro.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp464459vqo; Fri, 7 Apr 2023 11:36:08 -0700 (PDT) X-Google-Smtp-Source: AKy350Y7Kpj85nHd85hXOz/QHTVwqtiAwXCF4rERUgYvlMvgNMteNPbLgTvXTuwcEG3vScQFuciw X-Received: by 2002:a17:906:381b:b0:931:df8d:113 with SMTP id v27-20020a170906381b00b00931df8d0113mr424729ejc.26.1680892567989; Fri, 07 Apr 2023 11:36:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680892567; cv=none; d=google.com; s=arc-20160816; b=WNF7+WtHPAZ43ggeXArLPh3N8RLebXpH0fBcy5X4eLdjFmYLDmG4vTu2rEICUXJcY8 FGuuZ+eFPTDaI6J3byXN6H8mny0p/cHW2tnH9qA5eqfJdRCwx9xf4H1asiEbqX158dqJ bG6COLAQpLGrTavFnCQn0GxfX5/xS8T0Urwx63jCKlnCOi0Uk3svQKz70HLsG/0fiTzj PZ9fYJbkRaS5vuT3DkFGeX8fNodaJ6TNjpk3i58sHwTt2LevcEj7+raHUQyapnqV8CZl adSAabmCr3XcJX1q/lrdLFLNBuXqejpDbjx+PnyJcATe8OSO/zfHAojQhRQeMh7+X+B+ GlQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=RKfLN+6s4FW/10OI4gYJAvtaj06v2WhYDh5LXV0gQxc=; b=0klSQ8Xah17X9Fa1ZhbLdZ0CXALIqkNr3ZhkGAhbU1+iL6dG5byYCFQvNNZysphwqg XSsT1jwQilNkbixP6LcvT4i5WUOEZAnWv2+4XVLVTA9Qi18XaIas9U+MhINr/JXHIfSX MCTXwLthSq8foux5ZNelvH8pjkJnZCaY/RsJILxAeL5mJXxZNMxkEwA0/UqhfQnHPtEN mtXxLx1xTTxItxDkzcVHCnuNz5oEFCBpPIiCY8fLMafTHXU7h0g0nwKwmJr0mQH/c/um Wrje5lZvzY5TE9kJfu9dJAGGWosJJ/SFWC0bl1lOzpECrG/s/lUXH++TeTh+7gici3zP TrJw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z27-20020a170906241b00b0093124e501c5si909987eja.688.2023.04.07.11.35.44; Fri, 07 Apr 2023 11:36:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231696AbjDGSHW (ORCPT <rfc822;a1648639935@gmail.com> + 99 others); Fri, 7 Apr 2023 14:07:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52066 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229908AbjDGSHV (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 7 Apr 2023 14:07:21 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BF029AF0D; Fri, 7 Apr 2023 11:07:16 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 283316123B; Fri, 7 Apr 2023 18:07:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6DD0AC433EF; Fri, 7 Apr 2023 18:07:13 +0000 (UTC) From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> To: Andy Gross <agross@kernel.org>, Bjorn Andersson <andersson@kernel.org>, Konrad Dybcio <konrad.dybcio@linaro.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Subject: [PATCH] arm64: dts: qcom: sc8280xp-lenovo-thinkpad: correct pin drive-strength Date: Fri, 7 Apr 2023 20:07:10 +0200 Message-Id: <20230407180710.128815-1-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1762543605339762487?= X-GMAIL-MSGID: =?utf-8?q?1762543605339762487?= |
Series |
arm64: dts: qcom: sc8280xp-lenovo-thinkpad: correct pin drive-strength
|
|
Commit Message
Krzysztof Kozlowski
April 7, 2023, 6:07 p.m. UTC
Fix typo in drive-strength property name.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Comments
On Fri, 7 Apr 2023 20:07:10 +0200, Krzysztof Kozlowski wrote: > Fix typo in drive-strength property name. > > Applied, thanks! [1/1] arm64: dts: qcom: sc8280xp-lenovo-thinkpad: correct pin drive-strength commit: 47ce7e168486de0a581f5903e72ba2cbc68123ec Best regards,
On Fri, Apr 07, 2023 at 08:07:10PM +0200, Krzysztof Kozlowski wrote:
> Fix typo in drive-strength property name.
In the future, please try to use the established commit-summary prefix.
In this case:
arm64: dts: qcom: sc8280xp-x13s:
Johan
On 11/04/2023 16:23, Johan Hovold wrote: > On Fri, Apr 07, 2023 at 08:07:10PM +0200, Krzysztof Kozlowski wrote: >> Fix typo in drive-strength property name. > > In the future, please try to use the established commit-summary prefix. > In this case: > > arm64: dts: qcom: sc8280xp-x13s: Sure. commit ca1ce7207e53cfe69aee5002eb3795069668da53 Author: Johan Hovold <johan+linaro@kernel.org> Date: Fri Aug 5 11:23:17 2022 +0200 arm64: dts: qcom: sc8280xp-lenovo-thinkpad-x13s: add alternate touchpad Best regards, Krzysztof
On Tue, Apr 11, 2023 at 06:58:33PM +0200, Krzysztof Kozlowski wrote: > On 11/04/2023 16:23, Johan Hovold wrote: > > On Fri, Apr 07, 2023 at 08:07:10PM +0200, Krzysztof Kozlowski wrote: > >> Fix typo in drive-strength property name. > > > > In the future, please try to use the established commit-summary prefix. > > In this case: > > > > arm64: dts: qcom: sc8280xp-x13s: > > Sure. > > commit ca1ce7207e53cfe69aee5002eb3795069668da53 > Author: Johan Hovold <johan+linaro@kernel.org> > Date: Fri Aug 5 11:23:17 2022 +0200 > > arm64: dts: qcom: sc8280xp-lenovo-thinkpad-x13s: add alternate touchpad Yeah, we initially used a longer prefix (including "x13s" which was missing in the Subject of this patch), but quite soon decided on using the shorter arm64: dts: qcom: sc8280xp-x13s: instead. Johan
On 12/04/2023 08:49, Johan Hovold wrote: > On Tue, Apr 11, 2023 at 06:58:33PM +0200, Krzysztof Kozlowski wrote: >> On 11/04/2023 16:23, Johan Hovold wrote: >>> On Fri, Apr 07, 2023 at 08:07:10PM +0200, Krzysztof Kozlowski wrote: >>>> Fix typo in drive-strength property name. >>> >>> In the future, please try to use the established commit-summary prefix. >>> In this case: >>> >>> arm64: dts: qcom: sc8280xp-x13s: >> >> Sure. >> >> commit ca1ce7207e53cfe69aee5002eb3795069668da53 >> Author: Johan Hovold <johan+linaro@kernel.org> >> Date: Fri Aug 5 11:23:17 2022 +0200 >> >> arm64: dts: qcom: sc8280xp-lenovo-thinkpad-x13s: add alternate touchpad > > Yeah, we initially used a longer prefix (including "x13s" which was > missing in the Subject of this patch), but quite soon decided on using > the shorter > > arm64: dts: qcom: sc8280xp-x13s: > > instead. Thanks. Do you know if this rule applies to other long-names? I was usually keeping full name or shortening them by cutting end, but maybe I should cut the middle? sm8250-sony-xperia-edo-pdx206 sm8250-sony-xperia-edo sm8250-pdx206 Best regards, Krzysztof
On Wed, Apr 12, 2023 at 09:03:31AM +0200, Krzysztof Kozlowski wrote: > On 12/04/2023 08:49, Johan Hovold wrote: > > On Tue, Apr 11, 2023 at 06:58:33PM +0200, Krzysztof Kozlowski wrote: > >> On 11/04/2023 16:23, Johan Hovold wrote: > >>> On Fri, Apr 07, 2023 at 08:07:10PM +0200, Krzysztof Kozlowski wrote: > >>>> Fix typo in drive-strength property name. > >>> > >>> In the future, please try to use the established commit-summary prefix. > >>> In this case: > >>> > >>> arm64: dts: qcom: sc8280xp-x13s: > >> > >> Sure. > >> > >> commit ca1ce7207e53cfe69aee5002eb3795069668da53 > >> Author: Johan Hovold <johan+linaro@kernel.org> > >> Date: Fri Aug 5 11:23:17 2022 +0200 > >> > >> arm64: dts: qcom: sc8280xp-lenovo-thinkpad-x13s: add alternate touchpad > > > > Yeah, we initially used a longer prefix (including "x13s" which was > > missing in the Subject of this patch), but quite soon decided on using > > the shorter > > > > arm64: dts: qcom: sc8280xp-x13s: > > > > instead. > > Thanks. Do you know if this rule applies to other long-names? I was > usually keeping full name or shortening them by cutting end, but maybe I > should cut the middle? > > sm8250-sony-xperia-edo-pdx206 > sm8250-sony-xperia-edo > sm8250-pdx206 I would not call it a rule just yet, but I guess there are further cases were this could have been used. Perhaps you can all decide to use it for the other Qualcomm dts as well. For the X13s the, 'sc8280xp-x13s' is enough to uniquely define the board and it mirrors 'sc8280xp-crd' (and using a shorter prefix makes the commit logs easier to read). The general suggestion is still to check 'git log --oneline' for the files in question and use what appears to be the (recent) common prefix. Johan
On 12.04.2023 09:19, Johan Hovold wrote: > On Wed, Apr 12, 2023 at 09:03:31AM +0200, Krzysztof Kozlowski wrote: >> On 12/04/2023 08:49, Johan Hovold wrote: >>> On Tue, Apr 11, 2023 at 06:58:33PM +0200, Krzysztof Kozlowski wrote: >>>> On 11/04/2023 16:23, Johan Hovold wrote: >>>>> On Fri, Apr 07, 2023 at 08:07:10PM +0200, Krzysztof Kozlowski wrote: >>>>>> Fix typo in drive-strength property name. >>>>> >>>>> In the future, please try to use the established commit-summary prefix. >>>>> In this case: >>>>> >>>>> arm64: dts: qcom: sc8280xp-x13s: >>>> >>>> Sure. >>>> >>>> commit ca1ce7207e53cfe69aee5002eb3795069668da53 >>>> Author: Johan Hovold <johan+linaro@kernel.org> >>>> Date: Fri Aug 5 11:23:17 2022 +0200 >>>> >>>> arm64: dts: qcom: sc8280xp-lenovo-thinkpad-x13s: add alternate touchpad >>> >>> Yeah, we initially used a longer prefix (including "x13s" which was >>> missing in the Subject of this patch), but quite soon decided on using >>> the shorter >>> >>> arm64: dts: qcom: sc8280xp-x13s: >>> >>> instead. >> >> Thanks. Do you know if this rule applies to other long-names? I was >> usually keeping full name or shortening them by cutting end, but maybe I >> should cut the middle? >> >> sm8250-sony-xperia-edo-pdx206 >> sm8250-sony-xperia-edo >> sm8250-pdx206 I do sm8250-pdx206 or sm8250-edo for common dtsi changes Generally anything that contains the SoC name and isn't ambiguous works, IMO. And the more concise, the better. Konrad > > I would not call it a rule just yet, but I guess there are further cases > were this could have been used. Perhaps you can all decide to use it for > the other Qualcomm dts as well. > > For the X13s the, 'sc8280xp-x13s' is enough to uniquely define the > board and it mirrors 'sc8280xp-crd' (and using a shorter prefix makes > the commit logs easier to read). > > The general suggestion is still to check 'git log --oneline' for the > files in question and use what appears to be the (recent) common prefix. > > Johan
On 12/04/2023 09:19, Johan Hovold wrote: > On Wed, Apr 12, 2023 at 09:03:31AM +0200, Krzysztof Kozlowski wrote: >> On 12/04/2023 08:49, Johan Hovold wrote: >>> On Tue, Apr 11, 2023 at 06:58:33PM +0200, Krzysztof Kozlowski wrote: >>>> On 11/04/2023 16:23, Johan Hovold wrote: >>>>> On Fri, Apr 07, 2023 at 08:07:10PM +0200, Krzysztof Kozlowski wrote: >>>>>> Fix typo in drive-strength property name. >>>>> >>>>> In the future, please try to use the established commit-summary prefix. >>>>> In this case: >>>>> >>>>> arm64: dts: qcom: sc8280xp-x13s: >>>> >>>> Sure. >>>> >>>> commit ca1ce7207e53cfe69aee5002eb3795069668da53 >>>> Author: Johan Hovold <johan+linaro@kernel.org> >>>> Date: Fri Aug 5 11:23:17 2022 +0200 >>>> >>>> arm64: dts: qcom: sc8280xp-lenovo-thinkpad-x13s: add alternate touchpad >>> >>> Yeah, we initially used a longer prefix (including "x13s" which was >>> missing in the Subject of this patch), but quite soon decided on using >>> the shorter >>> >>> arm64: dts: qcom: sc8280xp-x13s: >>> >>> instead. >> >> Thanks. Do you know if this rule applies to other long-names? I was >> usually keeping full name or shortening them by cutting end, but maybe I >> should cut the middle? >> >> sm8250-sony-xperia-edo-pdx206 >> sm8250-sony-xperia-edo >> sm8250-pdx206 > > I would not call it a rule just yet, but I guess there are further cases > were this could have been used. Perhaps you can all decide to use it for > the other Qualcomm dts as well. > > For the X13s the, 'sc8280xp-x13s' is enough to uniquely define the > board and it mirrors 'sc8280xp-crd' (and using a shorter prefix makes > the commit logs easier to read). > > The general suggestion is still to check 'git log --oneline' for the > files in question and use what appears to be the (recent) common prefix. I do it for subsystems, but I am not going to do it per file. Sorry, I am sending way too many of them to keep also customizing them per each file. If you wanted x13s prefix, then you would name the file like that. If you named file differently, then apparently that's how you want it to look. Best regards, Krzysztof
On 12/04/2023 09:22, Konrad Dybcio wrote: >>> >>> Thanks. Do you know if this rule applies to other long-names? I was >>> usually keeping full name or shortening them by cutting end, but maybe I >>> should cut the middle? >>> >>> sm8250-sony-xperia-edo-pdx206 >>> sm8250-sony-xperia-edo >>> sm8250-pdx206 > I do sm8250-pdx206 or sm8250-edo for common dtsi changes > > Generally anything that contains the SoC name and isn't ambiguous > works, IMO. And the more concise, the better. You should have named the files like this... Best regards, Krzysztof
On Thu, Apr 13, 2023 at 10:53:07AM +0200, Krzysztof Kozlowski wrote: > On 12/04/2023 09:19, Johan Hovold wrote: > > The general suggestion is still to check 'git log --oneline' for the > > files in question and use what appears to be the (recent) common prefix. > > I do it for subsystems, but I am not going to do it per file. Sorry, I > am sending way too many of them to keep also customizing them per each > file. Perhaps you should start grouping your patch bombs of identical changes rather than send them per file if this is such a burden. Either way, that is no excuse when changing a single file. > If you wanted x13s prefix, then you would name the file like that. > If you named file differently, then apparently that's how you want it to > look. No, that is not what we want. The git log tells you what we expect. And the x13s prefix is there, you just randomly decided to drop it. Johan
diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts index a1db3cf80c47..bdcba719fc38 100644 --- a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts +++ b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts @@ -1428,7 +1428,7 @@ oe-n-pins { pins = "gpio101"; function = "gpio"; bias-disable; - drive-strengh = <16>; + drive-strength = <16>; output-high; }; @@ -1445,7 +1445,7 @@ oe-n-pins { pins = "gpio48"; function = "gpio"; bias-disable; - drive-strengh = <16>; + drive-strength = <16>; output-high; };