| Message ID | 20230405080152.6732-2-ilpo.jarvinen@linux.intel.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp137502vqo;
Wed, 5 Apr 2023 01:21:38 -0700 (PDT)
X-Google-Smtp-Source:
AKy350ZvwnmM2LxGfjzdKLTj/7dMae0GxfZTZxR7gWULPDEHCUXAd1bHoBDTa0DK4/KscI3TjAMJ
X-Received: by 2002:a17:906:d149:b0:930:4eba:1640 with SMTP id
br9-20020a170906d14900b009304eba1640mr1357839ejb.38.1680682898421;
Wed, 05 Apr 2023 01:21:38 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1680682898; cv=none;
d=google.com; s=arc-20160816;
b=H8vezaDLnrDxLbFQXypSA5949GdiYqoWBMIRkxMvn0EV2xanhLe4Bbv4yCbhWUTIFp
B7shu47NUJgyGUgFZ+5O/DHguYIwjQW130FCXhyCy+Ey1TTmixNr3eFkKkzOprRXL2An
uMCcmSo413Nj/IWrha0Cr8cE2Ezht1zyDnkzqMvi+Rt1un6RhFPnvqr8sz0mpQcAHbTw
d5Z8q7UQylMYef9WORq/+seuePf38YNzkqWjMTW5OtZjXpuI+ZOYjrsoBjQTRlnQWQQZ
ttSE29pECW8C7NFwa666RQ3aYri6F4y/fH4aPCr7yCdyf/XHhGANoaF6oaR5kvyy1Ai9
troQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:references:in-reply-to:message-id:date:subject:cc:to:from
:dkim-signature;
bh=VW68XYq+Grdnnex0s2P4fbzPqqwAQH/LqdiGLYfMLTQ=;
b=De7wJqq4fXa27il4ya54WY82GaDBbcVI6JNDNtkUKDSw8mcCoV82smgApSLqJah9Qq
f+DuhBGgIIR/mtewcXXn1Crg/ULqQ+qA8knG/pi1HGThz3X07mrTo1DrhzCSy4jJOAmP
zz9cxwQvXhniUiVAdn11uyYoERqU788+yV/pF1vx9Xopvllwc+QnOWLW+udGC2OwQf5r
cHoba122Ub3ncg2kksrPZ236ZboL671Nw7UDp4PGzENlDVh8FcW9vuhE99LnSUe9eAaU
T+hchJ1Q3k0q5aY4FmWdur+eZAwz47BRmfalzm+PHlJOEFccpvcw1q34s/hZIZW5fopv
qlIA==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@intel.com header.s=Intel header.b=kJ4zBewq;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
g9-20020a17090604c900b00930625d6a34si724eja.972.2023.04.05.01.21.14;
Wed, 05 Apr 2023 01:21:38 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=pass header.i=@intel.com header.s=Intel header.b=kJ4zBewq;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S237241AbjDEICU (ORCPT <rfc822;lkml4gm@gmail.com> + 99 others);
Wed, 5 Apr 2023 04:02:20 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40858 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S237228AbjDEICS (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Wed, 5 Apr 2023 04:02:18 -0400
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2FCA83C32;
Wed, 5 Apr 2023 01:02:17 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
t=1680681737; x=1712217737;
h=from:to:cc:subject:date:message-id:in-reply-to:
references:mime-version:content-transfer-encoding;
bh=BbQrm2hVJXugEoU9akTq2r86Vq3neTtzZG3wnmgyjIk=;
b=kJ4zBewqi/LvgzEXndVxR4IjtlgOsd9R9PPjRyCkMHimVkCEIJsQg0Er
1uLG8hkIatGrKrdzyaZJhJ+UpFaAaR7WXlQJl6+tAKQZC1LAC2RVUP5Gg
MOr7izPHjwh8G6uozC7IrtUS7US4KsAO9yKgDew4BW14NGBjBvv2xw9S7
cf5sikeAarVlhXpOh5eHnenrRygfJXqtRqnU1U/WQzWLpA5xjWEbu77t7
HnUJhaG9I4BVDwhn9Wj79Mbsea2NeRqz1Oop5gzWwBfc1iF4yUWaR0j5w
L9KGw86UVIDG+GMgVe0wZc9BySgnyPZNOmtO0LfuMvTA0MNVTsD9yxxhZ
A==;
X-IronPort-AV: E=McAfee;i="6600,9927,10670"; a="428680216"
X-IronPort-AV: E=Sophos;i="5.98,319,1673942400";
d="scan'208";a="428680216"
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
05 Apr 2023 01:02:14 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=McAfee;i="6600,9927,10670"; a="775959622"
X-IronPort-AV: E=Sophos;i="5.98,319,1673942400";
d="scan'208";a="775959622"
Received: from wtedesch-mobl1.ger.corp.intel.com (HELO
ijarvine-MOBL2.ger.corp.intel.com) ([10.252.53.134])
by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
05 Apr 2023 01:02:04 -0700
From: =?utf-8?q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
To: Wu Hao <hao.wu@intel.com>, Tom Rix <trix@redhat.com>,
Moritz Fischer <mdf@kernel.org>, Xu Yilun <yilun.xu@intel.com>,
linux-fpga@vger.kernel.org, Lee Jones <lee@kernel.org>,
Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>,
linux-hwmon@vger.kernel.org,
Russ Weight <russell.h.weight@intel.com>,
linux-kernel@vger.kernel.org
Cc: =?utf-8?q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
Subject: [PATCH 1/4] mfd: intel-m10-bmc: Move core symbols to own namespace
Date: Wed, 5 Apr 2023 11:01:49 +0300
Message-Id: <20230405080152.6732-2-ilpo.jarvinen@linux.intel.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20230405080152.6732-1-ilpo.jarvinen@linux.intel.com>
References: <20230405080152.6732-1-ilpo.jarvinen@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-2.4 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE
autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1762323750816607257?=
X-GMAIL-MSGID: =?utf-8?q?1762323750816607257?=
|
| Series |
Manage register access to control delay during sec update
|
|
Commit Message
Ilpo Järvinen
April 5, 2023, 8:01 a.m. UTC
Create INTEL_M10_BMC_CORE namespace for symbols exported by
intel-m10-bmc-core.
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
---
drivers/mfd/intel-m10-bmc-core.c | 2 +-
drivers/mfd/intel-m10-bmc-pmci.c | 1 +
drivers/mfd/intel-m10-bmc-spi.c | 1 +
3 files changed, 3 insertions(+), 1 deletion(-)
Comments
On 4/5/23 01:01, Ilpo Järvinen wrote: > Create INTEL_M10_BMC_CORE namespace for symbols exported by > intel-m10-bmc-core. Reviewed-by: Russ Weight <russell.h.weight@intel.com> > Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> > --- > drivers/mfd/intel-m10-bmc-core.c | 2 +- > drivers/mfd/intel-m10-bmc-pmci.c | 1 + > drivers/mfd/intel-m10-bmc-spi.c | 1 + > 3 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/mfd/intel-m10-bmc-core.c b/drivers/mfd/intel-m10-bmc-core.c > index dac9cf7bcb4a..b94412813887 100644 > --- a/drivers/mfd/intel-m10-bmc-core.c > +++ b/drivers/mfd/intel-m10-bmc-core.c > @@ -98,7 +98,7 @@ const struct attribute_group *m10bmc_dev_groups[] = { > &m10bmc_group, > NULL, > }; > -EXPORT_SYMBOL_GPL(m10bmc_dev_groups); > +EXPORT_SYMBOL_NS_GPL(m10bmc_dev_groups, INTEL_M10_BMC_CORE); > > int m10bmc_dev_init(struct intel_m10bmc *m10bmc, const struct intel_m10bmc_platform_info *info) > { > diff --git a/drivers/mfd/intel-m10-bmc-pmci.c b/drivers/mfd/intel-m10-bmc-pmci.c > index 8821f1876dd6..0392ef8b57d8 100644 > --- a/drivers/mfd/intel-m10-bmc-pmci.c > +++ b/drivers/mfd/intel-m10-bmc-pmci.c > @@ -453,3 +453,4 @@ module_dfl_driver(m10bmc_pmci_driver); > MODULE_DESCRIPTION("MAX10 BMC PMCI-based interface"); > MODULE_AUTHOR("Intel Corporation"); > MODULE_LICENSE("GPL"); > +MODULE_IMPORT_NS(INTEL_M10_BMC_CORE); > diff --git a/drivers/mfd/intel-m10-bmc-spi.c b/drivers/mfd/intel-m10-bmc-spi.c > index 957200e17fed..edd266557ab9 100644 > --- a/drivers/mfd/intel-m10-bmc-spi.c > +++ b/drivers/mfd/intel-m10-bmc-spi.c > @@ -166,3 +166,4 @@ MODULE_DESCRIPTION("Intel MAX 10 BMC SPI bus interface"); > MODULE_AUTHOR("Intel Corporation"); > MODULE_LICENSE("GPL v2"); > MODULE_ALIAS("spi:intel-m10-bmc"); > +MODULE_IMPORT_NS(INTEL_M10_BMC_CORE);
On 2023-04-05 at 11:01:49 +0300, Ilpo Järvinen wrote: > Create INTEL_M10_BMC_CORE namespace for symbols exported by > intel-m10-bmc-core. Is it necessary for handshake register, or just an independent improvement? > > Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> > --- > drivers/mfd/intel-m10-bmc-core.c | 2 +- > drivers/mfd/intel-m10-bmc-pmci.c | 1 + > drivers/mfd/intel-m10-bmc-spi.c | 1 + > 3 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/mfd/intel-m10-bmc-core.c b/drivers/mfd/intel-m10-bmc-core.c > index dac9cf7bcb4a..b94412813887 100644 > --- a/drivers/mfd/intel-m10-bmc-core.c > +++ b/drivers/mfd/intel-m10-bmc-core.c > @@ -98,7 +98,7 @@ const struct attribute_group *m10bmc_dev_groups[] = { > &m10bmc_group, > NULL, > }; > -EXPORT_SYMBOL_GPL(m10bmc_dev_groups); > +EXPORT_SYMBOL_NS_GPL(m10bmc_dev_groups, INTEL_M10_BMC_CORE); > > int m10bmc_dev_init(struct intel_m10bmc *m10bmc, const struct intel_m10bmc_platform_info *info) Why this function is not included in namespace? Thanks, Yilun > { > diff --git a/drivers/mfd/intel-m10-bmc-pmci.c b/drivers/mfd/intel-m10-bmc-pmci.c > index 8821f1876dd6..0392ef8b57d8 100644 > --- a/drivers/mfd/intel-m10-bmc-pmci.c > +++ b/drivers/mfd/intel-m10-bmc-pmci.c > @@ -453,3 +453,4 @@ module_dfl_driver(m10bmc_pmci_driver); > MODULE_DESCRIPTION("MAX10 BMC PMCI-based interface"); > MODULE_AUTHOR("Intel Corporation"); > MODULE_LICENSE("GPL"); > +MODULE_IMPORT_NS(INTEL_M10_BMC_CORE); > diff --git a/drivers/mfd/intel-m10-bmc-spi.c b/drivers/mfd/intel-m10-bmc-spi.c > index 957200e17fed..edd266557ab9 100644 > --- a/drivers/mfd/intel-m10-bmc-spi.c > +++ b/drivers/mfd/intel-m10-bmc-spi.c > @@ -166,3 +166,4 @@ MODULE_DESCRIPTION("Intel MAX 10 BMC SPI bus interface"); > MODULE_AUTHOR("Intel Corporation"); > MODULE_LICENSE("GPL v2"); > MODULE_ALIAS("spi:intel-m10-bmc"); > +MODULE_IMPORT_NS(INTEL_M10_BMC_CORE); > -- > 2.30.2 >
On Fri, 7 Apr 2023, Xu Yilun wrote: > On 2023-04-05 at 11:01:49 +0300, Ilpo Järvinen wrote: > > Create INTEL_M10_BMC_CORE namespace for symbols exported by > > intel-m10-bmc-core. > > Is it necessary for handshake register, or just an independent > improvement? It's independent improvement. > > Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> > > --- > > drivers/mfd/intel-m10-bmc-core.c | 2 +- > > drivers/mfd/intel-m10-bmc-pmci.c | 1 + > > drivers/mfd/intel-m10-bmc-spi.c | 1 + > > 3 files changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/mfd/intel-m10-bmc-core.c b/drivers/mfd/intel-m10-bmc-core.c > > index dac9cf7bcb4a..b94412813887 100644 > > --- a/drivers/mfd/intel-m10-bmc-core.c > > +++ b/drivers/mfd/intel-m10-bmc-core.c > > @@ -98,7 +98,7 @@ const struct attribute_group *m10bmc_dev_groups[] = { > > &m10bmc_group, > > NULL, > > }; > > -EXPORT_SYMBOL_GPL(m10bmc_dev_groups); > > +EXPORT_SYMBOL_NS_GPL(m10bmc_dev_groups, INTEL_M10_BMC_CORE); > > > > int m10bmc_dev_init(struct intel_m10bmc *m10bmc, const struct intel_m10bmc_platform_info *info) > > Why this function is not included in namespace? It was not left out on purpose, I'll add it there.
diff --git a/drivers/mfd/intel-m10-bmc-core.c b/drivers/mfd/intel-m10-bmc-core.c index dac9cf7bcb4a..b94412813887 100644 --- a/drivers/mfd/intel-m10-bmc-core.c +++ b/drivers/mfd/intel-m10-bmc-core.c @@ -98,7 +98,7 @@ const struct attribute_group *m10bmc_dev_groups[] = { &m10bmc_group, NULL, }; -EXPORT_SYMBOL_GPL(m10bmc_dev_groups); +EXPORT_SYMBOL_NS_GPL(m10bmc_dev_groups, INTEL_M10_BMC_CORE); int m10bmc_dev_init(struct intel_m10bmc *m10bmc, const struct intel_m10bmc_platform_info *info) { diff --git a/drivers/mfd/intel-m10-bmc-pmci.c b/drivers/mfd/intel-m10-bmc-pmci.c index 8821f1876dd6..0392ef8b57d8 100644 --- a/drivers/mfd/intel-m10-bmc-pmci.c +++ b/drivers/mfd/intel-m10-bmc-pmci.c @@ -453,3 +453,4 @@ module_dfl_driver(m10bmc_pmci_driver); MODULE_DESCRIPTION("MAX10 BMC PMCI-based interface"); MODULE_AUTHOR("Intel Corporation"); MODULE_LICENSE("GPL"); +MODULE_IMPORT_NS(INTEL_M10_BMC_CORE); diff --git a/drivers/mfd/intel-m10-bmc-spi.c b/drivers/mfd/intel-m10-bmc-spi.c index 957200e17fed..edd266557ab9 100644 --- a/drivers/mfd/intel-m10-bmc-spi.c +++ b/drivers/mfd/intel-m10-bmc-spi.c @@ -166,3 +166,4 @@ MODULE_DESCRIPTION("Intel MAX 10 BMC SPI bus interface"); MODULE_AUTHOR("Intel Corporation"); MODULE_LICENSE("GPL v2"); MODULE_ALIAS("spi:intel-m10-bmc"); +MODULE_IMPORT_NS(INTEL_M10_BMC_CORE);