diff mbox series

rvmet-fcloop: Remove remote port from list when unlinking

Message ID 20230411092209.12719-1-dwagner@suse.de
State New
Headers
Series rvmet-fcloop: Remove remote port from list when unlinking |

Commit Message

Daniel Wagner April 11, 2023, 9:22 a.m. UTC 
  The remote port is never removed from fcloop_nports list. During module
unloading it's possible to end up an busy loop in fcloop_exit, because
the remote port is found in the list and thus we will never progress.

The kernel log will be spammed with

  nvme_fcloop: fcloop_exit: Failed deleting remote port
  nvme_fcloop: fcloop_exit: Failed deleting target port

Signed-off-by: Daniel Wagner <dwagner@suse.de>
---
 drivers/nvme/target/fcloop.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Daniel Wagner April 11, 2023, 10:09 a.m. UTC | #1 
On Tue, Apr 11, 2023 at 11:22:09AM +0200, Daniel Wagner wrote:
> The remote port is never removed from fcloop_nports list. During module
> unloading it's possible to end up an busy loop in fcloop_exit, because
> the remote port is found in the list and thus we will never progress.
> 
> The kernel log will be spammed with
> 
>   nvme_fcloop: fcloop_exit: Failed deleting remote port
>   nvme_fcloop: fcloop_exit: Failed deleting target port
> 
> Signed-off-by: Daniel Wagner <dwagner@suse.de>
> ---

Found a bunch more problems which need to be addressed. I'll collect all
changes and send them as series.
diff mbox series

Patch

diff --git a/drivers/nvme/target/fcloop.c b/drivers/nvme/target/fcloop.c
index 5c16372f3b53..1e53c8fe4b95 100644
--- a/drivers/nvme/target/fcloop.c
+++ b/drivers/nvme/target/fcloop.c
@@ -1352,6 +1352,8 @@  __unlink_remote_port(struct fcloop_nport *nport)
 		nport->tport->remoteport = NULL;
 	nport->rport = NULL;
 
+	list_del(&nport->nport_list);
+
 	return rport;
 }